https://issues.apache.org/bugzilla/show_bug.cgi?id=56907
Bug ID: 56907
Summary: Threads leak
Product: Tomcat 8
Version: 8.0.11
Hardware: PC
Status: NEW
Severity: normal
Priority: P2
Component: WebSocket
2014-08-30 17:34 GMT+02:00 Mark Thomas :
> The proposed 8.0.12 release is:
> [ ] Broken - do not release
> [X] Stable - go ahead and release as 8.0.12
>
> Rémy
Author: markt
Date: Tue Sep 2 12:58:24 2014
New Revision: 1621972
URL: http://svn.apache.org/r1621972
Log:
Refactor test to make it easier to test multiple cookie parsers
Modified:
tomcat/trunk/test/org/apache/tomcat/util/http/TestCookies.java
Modified: tomcat/trunk/test/org/apache/tomcat/u
Author: violetagg
Date: Tue Sep 2 13:11:20 2014
New Revision: 1621975
URL: http://svn.apache.org/r1621975
Log:
According to JavaDoc javax.servlet.jsp.PageContext.include(String) and
javax.servlet.jsp.PageContext.include(String, boolean) must throw IOException
if I/O error occur during the opera
2014-09-02 15:11 GMT+02:00 :
> Author: violetagg
> Date: Tue Sep 2 13:11:20 2014
> New Revision: 1621975
>
> URL: http://svn.apache.org/r1621975
> Log:
> According to JavaDoc javax.servlet.jsp.PageContext.include(String) and
> javax.servlet.jsp.PageContext.include(String, boolean) must throw
> IO
Author: markt
Date: Tue Sep 2 13:40:43 2014
New Revision: 1621982
URL: http://svn.apache.org/r1621982
Log:
Initial implementation of RFC2109 parser
Modified:
tomcat/trunk/java/org/apache/tomcat/util/http/parser/Cookie.java
Modified: tomcat/trunk/java/org/apache/tomcat/util/http/parser/Cooki
Author: markt
Date: Tue Sep 2 13:40:58 2014
New Revision: 1621984
URL: http://svn.apache.org/r1621984
Log:
Add a performance test for non-RFC2109 cookies (which nearly all will
be)
Added:
tomcat/trunk/test/org/apache/tomcat/util/http/TesterCookiesPerformance.java
(with props)
Added:
tom
Author: markt
Date: Tue Sep 2 13:41:02 2014
New Revision: 1621985
URL: http://svn.apache.org/r1621985
Log:
Expand unit tests to cover old and new implementation
Modified:
tomcat/trunk/test/org/apache/tomcat/util/http/TestCookies.java
Modified: tomcat/trunk/test/org/apache/tomcat/util/http/T
Author: markt
Date: Tue Sep 2 13:41:07 2014
New Revision: 1621986
URL: http://svn.apache.org/r1621986
Log:
Update names
Modified:
tomcat/trunk/test/org/apache/tomcat/util/http/TestCookies.java
Modified: tomcat/trunk/test/org/apache/tomcat/util/http/TestCookies.java
URL:
http://svn.apache.o
Author: markt
Date: Tue Sep 2 13:41:12 2014
New Revision: 1621987
URL: http://svn.apache.org/r1621987
Log:
Name only cookies now always return a zero length value rather than a
null value.
Modified:
tomcat/trunk/test/org/apache/tomcat/util/http/TestCookies.java
Modified: tomcat/trunk/test/o
Author: markt
Date: Tue Sep 2 13:41:16 2014
New Revision: 1621988
URL: http://svn.apache.org/r1621988
Log:
Adjust test as RFC6265/2109 parser only permits $Version=1
Modified:
tomcat/trunk/test/org/apache/tomcat/util/http/TestCookies.java
Modified: tomcat/trunk/test/org/apache/tomcat/util/h
Author: markt
Date: Tue Sep 2 13:41:25 2014
New Revision: 1621990
URL: http://svn.apache.org/r1621990
Log:
RFC2109 parser that passes the tests - still several TODOs.
Modified:
tomcat/trunk/test/org/apache/tomcat/util/http/TestCookies.java
Modified: tomcat/trunk/test/org/apache/tomcat/util/
Author: markt
Date: Tue Sep 2 13:41:20 2014
New Revision: 1621989
URL: http://svn.apache.org/r1621989
Log:
Add parsing for RFC2109 values
Modified:
tomcat/trunk/test/org/apache/tomcat/util/http/TestCookies.java
Modified: tomcat/trunk/test/org/apache/tomcat/util/http/TestCookies.java
URL:
h
Author: markt
Date: Tue Sep 2 13:40:53 2014
New Revision: 1621983
URL: http://svn.apache.org/r1621983
Log:
Add a per context option to select the cookie parser to use and add the
necessary plumbing to pass that choice to the cookie parser.
Modified:
tomcat/trunk/java/org/apache/catalina/Cont
On 30/08/2014 16:34, Mark Thomas wrote:
> The proposed Apache Tomcat 8.0.12 release is now available for voting.
>
> The main changes since 8.0.11 are:
> - Fix a regression in the processing of includes and forwards when
> Contexts had been reloaded.
> - Session ID generation is now extensible
>
Author: violetagg
Date: Tue Sep 2 13:46:45 2014
New Revision: 1621998
URL: http://svn.apache.org/r1621998
Log:
Merged revision 1621975 from tomcat/trunk:
According to JavaDoc javax.servlet.jsp.PageContext.include(String) and
javax.servlet.jsp.PageContext.include(String, boolean) must throw IOExc
On 01/09/2014 13:49, Mark Thomas wrote:
> As previously advertised, I've been working on a new RFC6265 cookie
> parsing. The current status is as follows:
> - parser is working for RFC6265 cookie headers
> - RFC2109 parsing is still TODO
> - new parser is driven by Context level config (no more sys
Hi,
2014-09-02 16:37 GMT+03:00 Rémy Maucherat :
>
> 2014-09-02 15:11 GMT+02:00 :
>
> > Author: violetagg
> > Date: Tue Sep 2 13:11:20 2014
> > New Revision: 1621975
> >
> > URL: http://svn.apache.org/r1621975
> > Log:
> > According to JavaDoc javax.servlet.jsp.PageContext.include(String) and
> >
2014-09-02 15:51 GMT+02:00 Violeta Georgieva :
> Hi,
>
>
> 2014-09-02 16:37 GMT+03:00 Rémy Maucherat :
> >
> > 2014-09-02 15:11 GMT+02:00 :
> >
> > > Author: violetagg
> > > Date: Tue Sep 2 13:11:20 2014
> > > New Revision: 1621975
> > >
> > > URL: http://svn.apache.org/r1621975
> > > Log:
> > >
2014-09-02 15:47 GMT+02:00 Mark Thomas :
> I was able to squeeze out a little more performance without impacting
> readability. The original and the new RFC6265 parser now have as near as
> makes no difference the same performance.
>
> Nice.
Rémy
Author: markt
Date: Tue Sep 2 14:10:51 2014
New Revision: 1622004
URL: http://svn.apache.org/r1622004
Log:
Add a warning to the docs for future developers.
Modified:
tomcat/trunk/java/org/apache/tomcat/util/http/parser/Cookie.java
Modified: tomcat/trunk/java/org/apache/tomcat/util/http/pars
Author: markt
Date: Tue Sep 2 14:12:59 2014
New Revision: 1622008
URL: http://svn.apache.org/r1622008
Log:
Changelog for the RFC6265 cookie parser
Modified:
tomcat/trunk/webapps/docs/changelog.xml
Modified: tomcat/trunk/webapps/docs/changelog.xml
URL:
http://svn.apache.org/viewvc/tomcat/tr
Author: markt
Date: Tue Sep 2 15:10:41 2014
New Revision: 1622031
URL: http://svn.apache.org/r1622031
Log:
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=55917
The new cookie parser correctly handles 8-bit values.
Add the test cases from the proposed patch by Jeremy Boynes.
NOte RFC2616 d
https://issues.apache.org/bugzilla/show_bug.cgi?id=55917
Mark Thomas changed:
What|Removed |Added
Status|NEW |RESOLVED
Resolution|---
https://issues.apache.org/bugzilla/show_bug.cgi?id=55951
Bug 55951 depends on bug 55917, which changed state.
Bug 55917 Summary: Cookie parsing fails hard with ISO-8859-1 values
https://issues.apache.org/bugzilla/show_bug.cgi?id=55917
What|Removed |Added
---
Author: markt
Date: Tue Sep 2 15:23:24 2014
New Revision: 1622033
URL: http://svn.apache.org/r1622033
Log:
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=55918
The new cookie parser correctly handles control characters in quoted V1 values
Modified:
tomcat/trunk/test/org/apache/tomcat
https://issues.apache.org/bugzilla/show_bug.cgi?id=55918
Mark Thomas changed:
What|Removed |Added
Status|NEW |RESOLVED
Resolution|---
Author: markt
Date: Tue Sep 2 15:25:34 2014
New Revision: 1622034
URL: http://svn.apache.org/r1622034
Log:
More docs
Modified:
tomcat/trunk/java/org/apache/tomcat/util/http/parser/Cookie.java
Modified: tomcat/trunk/java/org/apache/tomcat/util/http/parser/Cookie.java
URL:
http://svn.apache.
Author: markt
Date: Tue Sep 2 15:38:58 2014
New Revision: 1622036
URL: http://svn.apache.org/r1622036
Log:
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=55921
The new cookie parser correctly handles unescaped JSON in cookie values
Modified:
tomcat/trunk/test/org/apache/tomcat/util/h
https://issues.apache.org/bugzilla/show_bug.cgi?id=55921
Mark Thomas changed:
What|Removed |Added
Status|NEW |RESOLVED
Resolution|---
Author: markt
Date: Tue Sep 2 15:47:56 2014
New Revision: 1622037
URL: http://svn.apache.org/r1622037
Log:
Refactor to reduce code duplication
Modified:
tomcat/trunk/java/org/apache/tomcat/util/http/parser/Cookie.java
Modified: tomcat/trunk/java/org/apache/tomcat/util/http/parser/Cookie.jav
Author: markt
Date: Tue Sep 2 15:55:59 2014
New Revision: 1622040
URL: http://svn.apache.org/r1622040
Log:
Fix the remaining TODO in the new cookie parser
Modified:
tomcat/trunk/java/org/apache/tomcat/util/http/parser/Cookie.java
tomcat/trunk/test/org/apache/tomcat/util/http/TestCookies.
Author: kkolinko
Date: Tue Sep 2 16:31:26 2014
New Revision: 1622061
URL: http://svn.apache.org/r1622061
Log:
svn:eol-style = native
Modified:
tomcat/trunk/test/webapp/jsp/pageContext1.jsp (contents, props changed)
tomcat/trunk/test/webapp/jsp/pageContext2.jsp (contents, props change
Author: kkolinko
Date: Tue Sep 2 16:32:17 2014
New Revision: 1622062
URL: http://svn.apache.org/r1622062
Log:
svn:eol-style = native
Modified:
tomcat/tc7.0.x/trunk/test/webapp-3.0/jsp/pageContext1.jsp (contents,
props changed)
tomcat/tc7.0.x/trunk/test/webapp-3.0/jsp/pageContext2.jsp
I've been looking at this again (anything to get a break from writing
parsers for cookies) and chatting with some of the infra folks that look
after the ASF's git repos.
There are a couple of things we need to do:
a) decide how we want to organise development in git
b) decide if we want to move to
Author: markt
Date: Tue Sep 2 16:44:28 2014
New Revision: 1622066
URL: http://svn.apache.org/r1622066
Log:
Trivial whitespace
Modified:
tomcat/trunk/java/org/apache/tomcat/util/http/parser/Cookie.java
Modified: tomcat/trunk/java/org/apache/tomcat/util/http/parser/Cookie.java
URL:
http://sv
On 2014-08-30, 11:34 AM, Mark Thomas wrote:
The proposed 8.0.12 release is:
[ ] Broken - do not release
[X] Stable - go ahead and release as 8.0.12
-- Jeanfrancois
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
2014-09-02 18:41 GMT+02:00 Mark Thomas :
> I'm leaning towards A myself.
>
Oh wow, does this mean I can resurrect my thread on Maven too ? (ideally,
we should also move to it first, then think about how to use it later,
otherwise people will never vote in favor)
:)
Rémy
Regarding question b), I vote yes, whatever the organization of the development
Regarding a), for my part I rather see something between A and B. I think of
the following questions that should be answered first :
- will there be 1 repo per major version like the current SVN setup ? or only
branc
Maven Strike back ?
That would be a very good new and our friend Olivier Lamy will be more than
happy :)
2014-09-02 18:52 GMT+02:00 Rémy Maucherat :
> 2014-09-02 18:41 GMT+02:00 Mark Thomas :
>
> > I'm leaning towards A myself.
> >
>
> Oh wow, does this mean I can resurrect my thread on Maven t
About git workflow.
Github popularized fork/pull-request mode and it helped enrolled tons of
new developpers in many Git projects, in Github but not only.
Would it be something possible with current Git infra in ASF ?
Side note, did infra folks plans to use a new git hosting ?
Using Stash, Gitlab
https://issues.apache.org/bugzilla/show_bug.cgi?id=56857
--- Comment #3 from Volker Kleinschmidt ---
Thanks for the quick follow-up. Any chance this could get backported to 7.x?
--
You are receiving this mail because:
You are the assignee for the bug.
--
On 02/09/2014 19:24, Sylvain Laurent wrote:
> Regarding question b), I vote yes, whatever the organization of the
> development
>
> Regarding a), for my part I rather see something between A and B. I think of
> the following questions that should be answered first :
> - will there be 1 repo per
On 02/09/2014 19:31, Henri Gomez wrote:
> About git workflow.
>
> Github popularized fork/pull-request mode and it helped enrolled tons of
> new developpers in many Git projects, in Github but not only.
> Would it be something possible with current Git infra in ASF ?
The git repo would be mirrore
>The git repo would be mirrored at github. Folks can open pull requests
>at gitbuh now and we can close them when we commit the changes. That
>won't change if we switch to git.
There is mecansims to merge pull-requests for GitHub in Git ASF ?
How is documented somewhere ?
> > Side note, did infr
On Tue, Sep 2, 2014 at 10:52 AM, Rémy Maucherat wrote:
> 2014-09-02 18:41 GMT+02:00 Mark Thomas :
>
> > I'm leaning towards A myself.
>
The move to git clears a huge hurdle, and that is managing contributions.
The patch system is very difficult, and impossible to maintain. A pull
request stays
2014-09-02 20:41 GMT+04:00 Mark Thomas :
> I've been looking at this again (anything to get a break from writing
> parsers for cookies) and chatting with some of the infra folks that look
> after the ASF's git repos.
>
> There are a couple of things we need to do:
> a) decide how we want to organis
On 2 September 2014 20:25, Filip Hanik wrote:
> On Tue, Sep 2, 2014 at 10:52 AM, Rémy Maucherat wrote:
>
>> 2014-09-02 18:41 GMT+02:00 Mark Thomas :
>>
>> > I'm leaning towards A myself.
>>
>
>
> The move to git clears a huge hurdle, and that is managing contributions.
> The patch system is very
> Let's skip Maven and move straight to Gradle, it has the benefit of not
> needing a build system installed on the developers machine, as it gets
> downloaded by the wrapper checked into the repo. This is yet one less
> version that is required by the contributor.
> It's built on top of Ant, and s
Hi,
2014-09-02 22:15 GMT+03:00 Mark Thomas :
>
> ...
> It is up to us.
>
>
> The current svn setup is a single repo.
>
>
> My preference is for a single git repo with branches for 7.0.x and 6.0.x
+1 one repo with many branches
master is the latest development in our case 8.0.x at the moment
>
2014-09-02 23:22 GMT+03:00 Violeta Georgieva :
>
> Hi,
>
>
> 2014-09-02 22:15 GMT+03:00 Mark Thomas :
> >
> > ...
>
> > It is up to us.
> >
> >
> > The current svn setup is a single repo.
> >
> >
> > My preference is for a single git repo with branches for 7.0.x and 6.0.x
>
> +1 one repo with man
2014-09-02 22:49 GMT+02:00 Violeta Georgieva :
> One more thing - in github you can make inline comments for a given
> commit/pull request.
> This is very convenient for a review purposes.
>
Well, I guess since it is mirrored in github, you can comment there.
About the patching process, I would
Author: violetagg
Date: Wed Sep 3 05:36:04 2014
New Revision: 1622163
URL: http://svn.apache.org/r1622163
Log:
Fixed the multipart elements merge operation performed during web application
deployment. Identified by Coverity Scan.
Modified:
tomcat/trunk/java/org/apache/tomcat/util/descriptor
Author: violetagg
Date: Wed Sep 3 05:42:53 2014
New Revision: 1622164
URL: http://svn.apache.org/r1622164
Log:
Merged revision 1622163 from tomcat/trunk:
Fixed the multipart elements merge operation performed during web application
deployment. Identified by Coverity Scan.
Modified:
tomcat/t
Author: violetagg
Date: Wed Sep 3 06:05:58 2014
New Revision: 1622166
URL: http://svn.apache.org/r1622166
Log:
Merged revision 1621731 from tomcat/trunk:
Correct the return value for StandardContext.getResourceOnlyServlets()
so that multiple names are separated by commas. Identified by Coverity
S
On 3. September 2014 08:05:59 MESZ, violet...@apache.org wrote:
>Author: violetagg
>Date: Wed Sep 3 06:05:58 2014
>New Revision: 1622166
>
>URL: http://svn.apache.org/r1622166
>Log:
>Merged revision 1621731 from tomcat/trunk:
>Correct the return value for StandardContext.getResourceOnlyServlets(
56 matches
Mail list logo
