Re: RFC6265, cookie parsing and UTF-8

2014-08-27 Thread Rainer Jung
Am 26.08.2014 um 23:52 schrieb Filip Hanik: ​but our cookies, JSESSIONID, doesn't have to be UTF-8, does it? this goes hand in hand with the SessionIdGenerator that Rainer just did, can that return UTF-8 values? We currently only bundle one impl of that and that impl hasn't changed, so it sti

svn commit: r1620814 - /tomcat/trunk/java/org/apache/catalina/startup/CatalinaProperties.java

2014-08-27 Thread markt
Author: markt Date: Wed Aug 27 08:42:58 2014 New Revision: 1620814 URL: http://svn.apache.org/r1620814 Log: Clean-up Modified: tomcat/trunk/java/org/apache/catalina/startup/CatalinaProperties.java Modified: tomcat/trunk/java/org/apache/catalina/startup/CatalinaProperties.java URL: http://sv

svn commit: r1620815 - /tomcat/trunk/java/org/apache/catalina/startup/CatalinaProperties.java

2014-08-27 Thread markt
Author: markt Date: Wed Aug 27 08:44:41 2014 New Revision: 1620815 URL: http://svn.apache.org/r1620815 Log: Simplify Modified: tomcat/trunk/java/org/apache/catalina/startup/CatalinaProperties.java Modified: tomcat/trunk/java/org/apache/catalina/startup/CatalinaProperties.java URL: http://sv

Re: Coverity static analysis scanning

2014-08-27 Thread Mark Thomas
On 26/08/2014 22:26, Christopher Schultz wrote: > Mark, > > On 8/26/14, 5:20 AM, Mark Thomas wrote: >> I have been pinged off-list by Coverity to say that they have set up >> Tomcat with a free account with their static code analysis service. >> >> I think I have the ability to send invitations so

svn commit: r1620822 - /tomcat/trunk/java/org/apache/jasper/compiler/Compiler.java

2014-08-27 Thread markt
Author: markt Date: Wed Aug 27 09:05:21 2014 New Revision: 1620822 URL: http://svn.apache.org/r1620822 Log: Avoid NPE when using JspC Modified: tomcat/trunk/java/org/apache/jasper/compiler/Compiler.java Modified: tomcat/trunk/java/org/apache/jasper/compiler/Compiler.java URL: http://svn.apa

Re: svn commit: r1620596 - in /tomcat/trunk: java/org/apache/jasper/compiler/ java/org/apache/jasper/servlet/ test/org/apache/jasper/servlet/ test/webapp/jsp/ webapps/docs/

2014-08-27 Thread Mark Thomas
On 26/08/2014 23:16, Konstantin Kolinko wrote: > 2014-08-26 17:32 GMT+04:00 : >> Author: markt >> Date: Tue Aug 26 13:32:45 2014 >> New Revision: 1620596 >> >> URL: http://svn.apache.org/r1620596 >> Log: >> Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=56568 >> Enable any HTTP method to b

svn commit: r1620827 - in /tomcat/tc7.0.x/trunk: ./ test/org/apache/tomcat/util/net/TestCustomSsl.java

2014-08-27 Thread markt
Author: markt Date: Wed Aug 27 09:15:18 2014 New Revision: 1620827 URL: http://svn.apache.org/r1620827 Log: Update expected value after changes in r1617447 Modified: tomcat/tc7.0.x/trunk/ (props changed) tomcat/tc7.0.x/trunk/test/org/apache/tomcat/util/net/TestCustomSsl.java Propchange

Re: svn commit: r1620596 - in /tomcat/trunk: java/org/apache/jasper/compiler/ java/org/apache/jasper/servlet/ test/org/apache/jasper/servlet/ test/webapp/jsp/ webapps/docs/

2014-08-27 Thread Rémy Maucherat
2014-08-27 11:06 GMT+02:00 Mark Thomas : > I've started to ignore the CI failures due to the false positive rate. > That is probably a sign some time needs to be spent looking at the CI > failures and fixing them. > > I'm not a fan of gump and am mostly looking at CI instead for testsuite runs. Ho

Re: RFC6265, cookie parsing and UTF-8

2014-08-27 Thread Mark Thomas
On 26/08/2014 22:52, Filip Hanik wrote: > On Tue, Aug 26, 2014 at 12:53 PM, Mark Thomas wrote: > >> One of the aims of the proposed cookie changes [1] was to deal with the >> HTML 5 changes that mean UTF-8 can appear in cookie headers. >> >> This has some potentially large implications for Tomcat

Re: RFC6265, cookie parsing and UTF-8

2014-08-27 Thread Mark Thomas
On 26/08/2014 23:09, Rémy Maucherat wrote: > 2014-08-26 21:53 GMT+02:00 Mark Thomas : > >> One of the aims of the proposed cookie changes [1] was to deal with the >> HTML 5 changes that mean UTF-8 can appear in cookie headers. >> >> This has some potentially large implications for Tomcat. >> >> Cu

Re: RFC6265, cookie parsing and UTF-8

2014-08-27 Thread Konstantin Kolinko
2014-08-27 13:29 GMT+04:00 Mark Thomas : >> > > Bad news: The issue is that if there is a chance of UTF-8 in the header > then you can't simply split the header into individual cookies based on > the separator byte since you can't tell (without decoding to characters) > if a byte represents the sep

Re: Coverity static analysis scanning

2014-08-27 Thread Mark Thomas
On 26/08/2014 22:52, Henri Gomez wrote: > Hi all > > Are you aware SonarQube is analysing Tomcat in Nemo for years ? > > > http://nemo.sonarqube.org/dashboard/index/50544 > > 310 Blocker issues, 121 Critical issues. I took a quick look. The first 60 or so blocker issues I looked at were all fa

Re: RFC6265, cookie parsing and UTF-8

2014-08-27 Thread Mark Thomas
On 27/08/2014 10:38, Konstantin Kolinko wrote: > 2014-08-27 13:29 GMT+04:00 Mark Thomas : >>> >> >> Bad news: The issue is that if there is a chance of UTF-8 in the header >> then you can't simply split the header into individual cookies based on >> the separator byte since you can't tell (without

Re: Coverity static analysis scanning

2014-08-27 Thread Henri Gomez
Fabrice Belingard, ASFer is working for Sonar. I add him in loop so he could give us more informations 2014-08-27 11:45 GMT+02:00 Mark Thomas : > On 26/08/2014 22:52, Henri Gomez wrote: >> Hi all >> >> Are you aware SonarQube is analysing Tomcat in Nemo for years ? >> >> >> http://nemo.sonarqube.o

svn commit: r1620848 - /tomcat/trunk/java/org/apache/tomcat/util/net/Nio2Endpoint.java

2014-08-27 Thread remm
Author: remm Date: Wed Aug 27 10:08:32 2014 New Revision: 1620848 URL: http://svn.apache.org/r1620848 Log: Drop leftover useless null checks. (now joining the club of people doing pointless commits ...) Modified: tomcat/trunk/java/org/apache/tomcat/util/net/Nio2Endpoint.java Modified: tomca

svn commit: r1620849 - /tomcat/trunk/java/org/apache/tomcat/util/net/Nio2Endpoint.java

2014-08-27 Thread remm
Author: remm Date: Wed Aug 27 10:09:42 2014 New Revision: 1620849 URL: http://svn.apache.org/r1620849 Log: Simplify. Modified: tomcat/trunk/java/org/apache/tomcat/util/net/Nio2Endpoint.java Modified: tomcat/trunk/java/org/apache/tomcat/util/net/Nio2Endpoint.java URL: http://svn.apache.org/v

svn commit: r1620854 - in /tomcat/site/trunk: docs/whoweare.html xdocs/whoweare.xml

2014-08-27 Thread markt
Author: markt Date: Wed Aug 27 10:16:12 2014 New Revision: 1620854 URL: http://svn.apache.org/r1620854 Log: Alphabetical order by surname Modified: tomcat/site/trunk/docs/whoweare.html tomcat/site/trunk/xdocs/whoweare.xml Modified: tomcat/site/trunk/docs/whoweare.html URL: http://svn.ap

svn commit: r1620855 - in /tomcat/site/trunk: docs/whoweare.html xdocs/whoweare.xml

2014-08-27 Thread markt
Author: markt Date: Wed Aug 27 10:20:31 2014 New Revision: 1620855 URL: http://svn.apache.org/r1620855 Log: Move Ian Darwin to emeritus at his request Modified: tomcat/site/trunk/docs/whoweare.html tomcat/site/trunk/xdocs/whoweare.xml Modified: tomcat/site/trunk/docs/whoweare.html URL:

Re: RFC6265, cookie parsing and UTF-8

2014-08-27 Thread Mark Thomas
On 27/08/2014 10:58, Mark Thomas wrote: > On 27/08/2014 10:38, Konstantin Kolinko wrote: >> 2014-08-27 13:29 GMT+04:00 Mark Thomas : >>> >>> Bad news: The issue is that if there is a chance of UTF-8 in the header >>> then you can't simply split the header into individual cookies based on >>> t

Re: svn commit: r1620596 - in /tomcat/trunk: java/org/apache/jasper/compiler/ java/org/apache/jasper/servlet/ test/org/apache/jasper/servlet/ test/webapp/jsp/ webapps/docs/

2014-08-27 Thread Konstantin Kolinko
2014-08-27 13:06 GMT+04:00 Mark Thomas : > On 26/08/2014 23:16, Konstantin Kolinko wrote: >> 2014-08-26 17:32 GMT+04:00 : >>> Author: markt >>> Date: Tue Aug 26 13:32:45 2014 >>> New Revision: 1620596 >>> >>> URL: http://svn.apache.org/r1620596 >>> Log: >>> Fix https://issues.apache.org/bugzilla/s

[Bug 56890] getRealPath returns null

2014-08-27 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=56890 --- Comment #1 from Konstantin Kolinko --- Resource paths are expected to start with a "/" (per javadoc of ServletContext.getResource()). [1] The behaviour in Tomcat 8 is caused by a more strict underlying Resources implementation. That s

[Bug 56890] getRealPath returns null

2014-08-27 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=56890 --- Comment #2 from Mark Thomas --- I'm leaning towards resolving this as invalid. While the spec and the Javadoc could be clearer, it seems pretty obvious that a 'virtual path' is 'servletPath + pathInfo' along the lines of section 3.5 of

Re: svn commit: r1620596 - in /tomcat/trunk: java/org/apache/jasper/compiler/ java/org/apache/jasper/servlet/ test/org/apache/jasper/servlet/ test/webapp/jsp/ webapps/docs/

2014-08-27 Thread Mark Thomas
On 27/08/2014 13:34, Konstantin Kolinko wrote: > 2014-08-27 13:06 GMT+04:00 Mark Thomas : >> On 26/08/2014 23:16, Konstantin Kolinko wrote: >>> 2014-08-26 17:32 GMT+04:00 : Author: markt Date: Tue Aug 26 13:32:45 2014 New Revision: 1620596 URL: http://svn.apache.org/r16205

[Bug 56825] AuthenticatorBase not looking for Coyote Request certificate

2014-08-27 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=56825 Konstantin Kolinko changed: What|Removed |Added Status|RESOLVED|REOPENED Resolution|F

Re: Coverity static analysis scanning

2014-08-27 Thread Rémy Maucherat
2014-08-26 11:20 GMT+02:00 Mark Thomas : > All, > > I have been pinged off-list by Coverity to say that they have set up > Tomcat with a free account with their static code analysis service. > > I think I have the ability to send invitations so if anyone wants to > take a look at the results, just

svn commit: r1620903 - in /tomcat/trunk: java/org/apache/jasper/compiler/Compiler.java java/org/apache/jasper/compiler/Generator.java java/org/apache/jasper/servlet/JspServletWrapper.java test/org/apa

2014-08-27 Thread markt
Author: markt Date: Wed Aug 27 14:28:14 2014 New Revision: 1620903 URL: http://svn.apache.org/r1620903 Log: Rework fix for https://issues.apache.org/bugzilla/show_bug.cgi?id=56568 Modified: tomcat/trunk/java/org/apache/jasper/compiler/Compiler.java tomcat/trunk/java/org/apache/jasper/comp

svn commit: r1620915 - in /tomcat/trunk/java/org/apache: catalina/tribes/group/ catalina/tribes/tipis/ catalina/tribes/transport/bio/ catalina/tribes/transport/nio/ tomcat/jni/socket/

2014-08-27 Thread schultz
Author: schultz Date: Wed Aug 27 15:42:25 2014 New Revision: 1620915 URL: http://svn.apache.org/r1620915 Log: Add super.finalize to finalizers missing those calls. Modified: tomcat/trunk/java/org/apache/catalina/tribes/group/RpcChannel.java tomcat/trunk/java/org/apache/catalina/tribes/ti

svn commit: r1620916 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/catalina/tribes/group/ java/org/apache/catalina/tribes/tipis/ java/org/apache/catalina/tribes/transport/bio/ java/org/apache/catalin

2014-08-27 Thread schultz
Author: schultz Date: Wed Aug 27 15:49:27 2014 New Revision: 1620916 URL: http://svn.apache.org/r1620916 Log: Back-port 1620915 Add super.finalize to finalize() methods that were missing them. Modified: tomcat/tc7.0.x/trunk/ (props changed) tomcat/tc7.0.x/trunk/java/org/apache/catalina/

svn commit: r1620917 - /tomcat/trunk/java/org/apache/catalina/tribes/tipis/AbstractReplicatedMap.java

2014-08-27 Thread schultz
Author: schultz Date: Wed Aug 27 15:52:07 2014 New Revision: 1620917 URL: http://svn.apache.org/r1620917 Log: Moved resource-freeing code from finalize() to breakdown() Have finalize() call breakdown() instead of vice-versa. Modified: tomcat/trunk/java/org/apache/catalina/tribes/tipis/Abstra

svn commit: r1620918 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/catalina/tribes/tipis/AbstractReplicatedMap.java

2014-08-27 Thread schultz
Author: schultz Date: Wed Aug 27 15:53:36 2014 New Revision: 1620918 URL: http://svn.apache.org/r1620918 Log: Back-ported r1620917 Moved resource-freeing code from finalize() to breakdown() Have finalize() call breakdown() instead of vice-versa. Modified: tomcat/tc7.0.x/trunk/ (props change

svn commit: r1620923 - /tomcat/trunk/java/org/apache/jasper/xmlparser/XMLString.java

2014-08-27 Thread schultz
Author: schultz Date: Wed Aug 27 16:05:38 2014 New Revision: 1620923 URL: http://svn.apache.org/r1620923 Log: Added missing hashCode method. Modified: tomcat/trunk/java/org/apache/jasper/xmlparser/XMLString.java Modified: tomcat/trunk/java/org/apache/jasper/xmlparser/XMLString.java URL: htt

svn commit: r1620924 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/jasper/xmlparser/XMLString.java

2014-08-27 Thread schultz
Author: schultz Date: Wed Aug 27 16:06:41 2014 New Revision: 1620924 URL: http://svn.apache.org/r1620924 Log: Back-ported r1620923 Added missing hashCode method. Modified: tomcat/tc7.0.x/trunk/ (props changed) tomcat/tc7.0.x/trunk/java/org/apache/jasper/xmlparser/XMLString.java Propcha

Re: svn commit: r1620923 - /tomcat/trunk/java/org/apache/jasper/xmlparser/XMLString.java

2014-08-27 Thread Mark Thomas
On 27/08/2014 17:05, schu...@apache.org wrote: > Author: schultz > Date: Wed Aug 27 16:05:38 2014 > New Revision: 1620923 > > URL: http://svn.apache.org/r1620923 > Log: > Added missing hashCode method. Two questions. 1. Why do you think this method is missing? I'm pretty sure (although I'm going

Re: svn commit: r1620923 - /tomcat/trunk/java/org/apache/jasper/xmlparser/XMLString.java

2014-08-27 Thread Christopher Schultz
Mark, On 8/27/14, 12:12 PM, Mark Thomas wrote: > On 27/08/2014 17:05, schu...@apache.org wrote: >> Author: schultz >> Date: Wed Aug 27 16:05:38 2014 >> New Revision: 1620923 >> >> URL: http://svn.apache.org/r1620923 >> Log: >> Added missing hashCode method. > > Two questions. > > 1. Why do you t

Re: svn commit: r1620923 - /tomcat/trunk/java/org/apache/jasper/xmlparser/XMLString.java

2014-08-27 Thread Mark Thomas
On 27/08/2014 18:00, Christopher Schultz wrote: > Mark, > > On 8/27/14, 12:12 PM, Mark Thomas wrote: >> On 27/08/2014 17:05, schu...@apache.org wrote: >>> Author: schultz >>> Date: Wed Aug 27 16:05:38 2014 >>> New Revision: 1620923 >>> >>> URL: http://svn.apache.org/r1620923 >>> Log: >>> Added mis

svn commit: r1620958 - /tomcat/trunk/java/org/apache/jasper/xmlparser/XMLString.java

2014-08-27 Thread schultz
Author: schultz Date: Wed Aug 27 19:00:34 2014 New Revision: 1620958 URL: http://svn.apache.org/r1620958 Log: Reverted r1620923 after review. Modified: tomcat/trunk/java/org/apache/jasper/xmlparser/XMLString.java Modified: tomcat/trunk/java/org/apache/jasper/xmlparser/XMLString.java URL: ht

svn commit: r1620959 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/jasper/xmlparser/XMLString.java

2014-08-27 Thread schultz
Author: schultz Date: Wed Aug 27 19:02:18 2014 New Revision: 1620959 URL: http://svn.apache.org/r1620959 Log: Reverted r1620924 after review. Modified: tomcat/tc7.0.x/trunk/ (props changed) tomcat/tc7.0.x/trunk/java/org/apache/jasper/xmlparser/XMLString.java Propchange: tomcat/tc7.0.x/

Re: svn commit: r1620923 - /tomcat/trunk/java/org/apache/jasper/xmlparser/XMLString.java

2014-08-27 Thread Christopher Schultz
Mark, On 8/27/14, 1:33 PM, Mark Thomas wrote: > On 27/08/2014 18:00, Christopher Schultz wrote: >> Mark, >> >> On 8/27/14, 12:12 PM, Mark Thomas wrote: >>> On 27/08/2014 17:05, schu...@apache.org wrote: Author: schultz Date: Wed Aug 27 16:05:38 2014 New Revision: 1620923 U

[Bug 56895] New: catalina.bat does not properly compose JAVA_OPTS

2014-08-27 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=56895 Bug ID: 56895 Summary: catalina.bat does not properly compose JAVA_OPTS Product: Tomcat 7 Version: 7.0.54 Hardware: PC Status: NEW Severity: normal Priori

[Bug 56896] New: if the url contains %, deploye tomcat servlet cannot enter

2014-08-27 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=56896 Bug ID: 56896 Summary: if the url contains %, deploye tomcat servlet cannot enter Product: Tomcat 8 Version: trunk Hardware: PC Status: NEW Seve

[Bug 56896] if the url contains %, Tomcat connot receive the request.

2014-08-27 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=56896 chdyan <380994...@qq.com> changed: What|Removed |Added Summary|if the url contains %, |if the url contains %,

[GUMP@vmgump]: Project tomcat-trunk-test-apr (in module tomcat-trunk) failed

2014-08-27 Thread Bill Barker
To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at gene...@gump.apache.org. Project tomcat-trunk-test-apr has an issue affecting its community integration. Th