[Bug 56634] New: Using the JSP configuration element removes whitespace between EL expressions

2014-06-17 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=56634 Bug ID: 56634 Summary: Using the JSP configuration element removes whitespace between EL expressions Product: Tomcat 7 Version: 7.0.54 Hardware:

svn commit: r1603152 - /tomcat/tc7.0.x/trunk/java/org/apache/coyote/AbstractProtocol.java

2014-06-17 Thread markt
Author: markt Date: Tue Jun 17 12:45:12 2014 New Revision: 1603152 URL: http://svn.apache.org/r1603152 Log: Follow-up to r1602510 after kkolinko review. Add patch chunk missed in backport Modified: tomcat/tc7.0.x/trunk/java/org/apache/coyote/AbstractProtocol.java Modified: tomcat/tc7.0.x/tru

Re: svn commit: r1602510 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/catalina/connector/ java/org/apache/coyote/ java/org/apache/coyote/ajp/ java/org/apache/coyote/http11/ java/org/apache/coyote/ht

2014-06-17 Thread Mark Thomas
On 17/06/2014 00:50, Konstantin Kolinko wrote: > 2014-06-14 0:21 GMT+04:00 : >> Author: markt >> Date: Fri Jun 13 20:21:32 2014 >> New Revision: 1602510 > I have several questions. > > 1) The AbstractProtocol$AbstractConnectionHandler.process() mentioned > above is from Tomcat 8. The code for

[Bug 56334] Double Backslash Escaping in Attributes

2014-06-17 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=56334 Markus changed: What|Removed |Added Status|RESOLVED|REOPENED Resolution|FIXED

[Bug 56334] Double Backslash Escaping in Attributes

2014-06-17 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=56334 --- Comment #16 from Konstantin Kolinko --- Created attachment 31721 --> https://issues.apache.org/bugzilla/attachment.cgi?id=31721&action=edit test_56334_c15.jspx I have not dug into the NUL character issue yet. A quick testing shows th

buildbot failure in ASF Buildbot on tomcat-7-trunk

2014-06-17 Thread buildbot
The Buildbot has detected a new failure on builder tomcat-7-trunk while building ASF Buildbot. Full details are available at: http://ci.apache.org/builders/tomcat-7-trunk/builds/133 Buildbot URL: http://ci.apache.org/ Buildslave for this Build: bb-vm_ubuntu Build Reason: scheduler Build Source

[Bug 56620] Bogus access log entries with status 503 and date in year 1970 (the epoch) when pausing NIO connector

2014-06-17 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=56620 --- Comment #6 from Konstantin Kolinko --- Looks good. For a record: Processing time for HTTP connectors is now measured starting from when the first byte of the next request is read. (r1602956) The old implementation measured it starting

Re: svn commit: r1602510 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/catalina/connector/ java/org/apache/coyote/ java/org/apache/coyote/ajp/ java/org/apache/coyote/http11/ java/org/apache/coyote/ht

2014-06-17 Thread Konstantin Kolinko
2014-06-17 17:08 GMT+04:00 Mark Thomas : > On 17/06/2014 00:50, Konstantin Kolinko wrote: >> 2014-06-14 0:21 GMT+04:00 : >>> Author: markt >>> Date: Fri Jun 13 20:21:32 2014 >>> New Revision: 1602510 > >> 2) The submission of SocketProcessor to the Executor may end with >> RejectedExecutionExce

Re: svn commit: r1602510 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/catalina/connector/ java/org/apache/coyote/ java/org/apache/coyote/ajp/ java/org/apache/coyote/http11/ java/org/apache/coyote/ht

2014-06-17 Thread Mark Thomas
On 17/06/2014 17:09, Konstantin Kolinko wrote: > In Tomcat 8 there was the following commit as part of fixing this issue: > http://svn.apache.org/viewvc?view=revision&revision=r1594411 > > Are there plans to backport it to Tomcat 7? Not from me. It looks like that patch just changed the timin

svn commit: r1603244 - /tomcat/tc7.0.x/trunk/java/org/apache/catalina/valves/ErrorReportValve.java

2014-06-17 Thread kkolinko
Author: kkolinko Date: Tue Jun 17 18:15:53 2014 New Revision: 1603244 URL: http://svn.apache.org/r1603244 Log: Followup to r1602443: correct code formatting. Modified: tomcat/tc7.0.x/trunk/java/org/apache/catalina/valves/ErrorReportValve.java Modified: tomcat/tc7.0.x/trunk/java/org/apache/c

Re: svn commit: r1601583 - in /tomcat/trunk/java/org/apache/tomcat/util/net: AbstractEndpoint.java AprEndpoint.java JIoEndpoint.java Nio2Endpoint.java

2014-06-17 Thread Konstantin Kolinko
2014-06-10 13:37 GMT+04:00 : > Author: markt > Date: Tue Jun 10 09:37:39 2014 > New Revision: 1601583 > > URL: http://svn.apache.org/r1601583 > Log: > Pull up waitingRequests. > NIO2 used a ConcurrentHashMap whereas BIO and APR/native used a Queue. Switch > to ConcurrentHashMap for all since what

buildbot success in ASF Buildbot on tomcat-7-trunk

2014-06-17 Thread buildbot
The Buildbot has detected a restored build on builder tomcat-7-trunk while building ASF Buildbot. Full details are available at: http://ci.apache.org/builders/tomcat-7-trunk/builds/134 Buildbot URL: http://ci.apache.org/ Buildslave for this Build: bb-vm_ubuntu Build Reason: scheduler Build Sou

svn commit: r1603266 - in /tomcat/trunk/java/org/apache/tomcat/util/net: AbstractEndpoint.java AprEndpoint.java JIoEndpoint.java Nio2Endpoint.java

2014-06-17 Thread kkolinko
Author: kkolinko Date: Tue Jun 17 19:19:20 2014 New Revision: 1603266 URL: http://svn.apache.org/r1603266 Log: Followup to r1601583: Use Collections.newSetFromMap to convert ConcurrentHashMap into a Set. Modified: tomcat/trunk/java/org/apache/tomcat/util/net/AbstractEndpoint.java tomcat/t

[Bug 56636] New: EL defineFunction method signature parser fails to correctly match signatures to methods

2014-06-17 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=56636 Bug ID: 56636 Summary: EL defineFunction method signature parser fails to correctly match signatures to methods Product: Tomcat 8 Version: trunk Hardware: PC

svn commit: r1603271 - in /tomcat/trunk/webapps: docs/changelog.xml examples/websocket/echo.xhtml

2014-06-17 Thread markt
Author: markt Date: Tue Jun 17 19:35:10 2014 New Revision: 1603271 URL: http://svn.apache.org/r1603271 Log: Add the other echo endpoints Modified: tomcat/trunk/webapps/docs/changelog.xml tomcat/trunk/webapps/examples/websocket/echo.xhtml Modified: tomcat/trunk/webapps/docs/changelog.xml

svn commit: r1603274 - /tomcat/trunk/webapps/examples/WEB-INF/classes/websocket/echo/EchoAsyncAnnotation.java

2014-06-17 Thread markt
Author: markt Date: Tue Jun 17 19:39:48 2014 New Revision: 1603274 URL: http://svn.apache.org/r1603274 Log: Enable the async echo endpoint Modified: tomcat/trunk/webapps/examples/WEB-INF/classes/websocket/echo/EchoAsyncAnnotation.java Modified: tomcat/trunk/webapps/examples/WEB-INF/classes

Re: svn commit: r1603274 - /tomcat/trunk/webapps/examples/WEB-INF/classes/websocket/echo/EchoAsyncAnnotation.java

2014-06-17 Thread Konstantin Kolinko
2014-06-17 23:39 GMT+04:00 : > Author: markt > Date: Tue Jun 17 19:39:48 2014 > New Revision: 1603274 > > URL: http://svn.apache.org/r1603274 > Log: > Enable the async echo endpoint > > Modified: > > tomcat/trunk/webapps/examples/WEB-INF/classes/websocket/echo/EchoAsyncAnnotation.java > @@ -

svn commit: r1603287 - in /tomcat/trunk/webapps: docs/changelog.xml examples/WEB-INF/classes/websocket/echo/EchoAsyncAnnotation.java

2014-06-17 Thread markt
Author: markt Date: Tue Jun 17 20:31:05 2014 New Revision: 1603287 URL: http://svn.apache.org/r1603287 Log: Ensure that the asynchronous WebSocket echo endpoint in the examples web application always waits for the previous message to complete before it sends the next. Fixes some failures with th

Re: svn commit: r1603274 - /tomcat/trunk/webapps/examples/WEB-INF/classes/websocket/echo/EchoAsyncAnnotation.java

2014-06-17 Thread Mark Thomas
On 17/06/2014 20:47, Konstantin Kolinko wrote: > 2014-06-17 23:39 GMT+04:00 : >> Author: markt >> Date: Tue Jun 17 19:39:48 2014 >> New Revision: 1603274 >> >> URL: http://svn.apache.org/r1603274 >> Log: >> Enable the async echo endpoint >> >> Modified: >> >> tomcat/trunk/webapps/examples/WEB

svn commit: r1603290 - in /tomcat/trunk/webapps/examples: WEB-INF/classes/websocket/echo/EchoAsyncAnnotation.java websocket/echo.xhtml

2014-06-17 Thread markt
Author: markt Date: Tue Jun 17 20:52:51 2014 New Revision: 1603290 URL: http://svn.apache.org/r1603290 Log: Disable async echo endpoint again until we can put in some configurable limits on message size to buffer. Modified: tomcat/trunk/webapps/examples/WEB-INF/classes/websocket/echo/EchoAs

Re: svn commit: r1603274 - /tomcat/trunk/webapps/examples/WEB-INF/classes/websocket/echo/EchoAsyncAnnotation.java

2014-06-17 Thread Rémy Maucherat
2014-06-17 22:36 GMT+02:00 Mark Thomas : > There are some large messages in the Autobahn tests (multi-MB). > > On reflection I think it will be easier to just disable it again. > > Good job on fixing the example, I couldn't see anything wrong with it ! Besides that IMO it should remain disabled, i

svn commit: r1603311 - /tomcat/trunk/java/org/apache/juli/logging/LogFactory.java

2014-06-17 Thread kkolinko
Author: kkolinko Date: Tue Jun 17 23:03:40 2014 New Revision: 1603311 URL: http://svn.apache.org/r1603311 Log: Review of r1597602: 1) Be satisfied by the first result from ServiceLoader and break the loop. 2) Throw LogConfigurationException, which is a subtype of RuntimeException. Modified: t

[Bug 56637] New: ServletContext.getResourceAsStream("resources/config.xml") should return null instead of throwing exception

2014-06-17 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=56637 Bug ID: 56637 Summary: ServletContext.getResourceAsStream("resources/config.x ml") should return null instead of throwing exception Product: Tomcat 8 Version: 8.0.8 H

[Bug 56637] ServletContext.getResourceAsStream("resources/config.xml") should return null instead of throwing exception

2014-06-17 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=56637 quaff changed: What|Removed |Added CC||zhouyanm...@gmail.com OS|

Exclude scanning of class folders for Servlet 3.0 annotations.

2014-06-17 Thread Vimil Saju
Hi, I am using tomcat 7.0.52 and jdk 1.7.0_45. We have a web application which has its classpath configured in its own context xml file using virtualClasspath attribute of Loader tag. The webapp uses version 3.0 of web.xml,  The classpath contains multiple class folders in addition to

[Bug 56596] OpenSSL 1.0.1g is vulnerable to a man-in-the-middle attack

2014-06-17 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=56596 Brett Randall changed: What|Removed |Added CC||javabr...@gmail.com -- You are re