[Bug 56607] shutdown.bat exits before shutdown

2014-06-10 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=56607 --- Comment #2 from elias.wul...@apptus.com --- I would be happy to test a patch for you but I do not want you to toil with DOS scripts if there is a better solution. All I need is an official interface for doing this, not necessarily a DOS

[Bug 56611] New: No need to call method.isAnnotationPresent() then call method.getAnnotation.

2014-06-10 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=56611 Bug ID: 56611 Summary: No need to call method.isAnnotationPresent() then call method.getAnnotation. Product: Tomcat 7 Version: 7.0.47 Hardware: All OS

[Bug 56611] No need to call method.isAnnotationPresent() then call method.getAnnotation.

2014-06-10 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=56611 Mou, Jian changed: What|Removed |Added Attachment #31702|0 |1 is patch|

[Bug 56518] NIO async servlet limit latch leak

2014-06-10 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=56518 --- Comment #12 from hanyong --- Created attachment 31703 --> https://issues.apache.org/bugzilla/attachment.cgi?id=31703&action=edit fix bug 56518 on TOMCAT_7_0_54 Clear thread interrupted status before write to NIO socket. i.e. Never in

svn commit: r1601583 - in /tomcat/trunk/java/org/apache/tomcat/util/net: AbstractEndpoint.java AprEndpoint.java JIoEndpoint.java Nio2Endpoint.java

2014-06-10 Thread markt
Author: markt Date: Tue Jun 10 09:37:39 2014 New Revision: 1601583 URL: http://svn.apache.org/r1601583 Log: Pull up waitingRequests. NIO2 used a ConcurrentHashMap whereas BIO and APR/native used a Queue. Switch to ConcurrentHashMap for all since what we really want here is a Set (and there isn't

svn commit: r1601590 - in /tomcat/trunk/java/org/apache/tomcat/util/net: AbstractEndpoint.java AprEndpoint.java JIoEndpoint.java Nio2Endpoint.java

2014-06-10 Thread markt
Author: markt Date: Tue Jun 10 09:52:56 2014 New Revision: 1601590 URL: http://svn.apache.org/r1601590 Log: Pull up AsyncTimeout APR/native used a separate flag to stop the thread. This avoided issues where running was set true->false-true in quick succession. This fix is now available to NIO2 a

[Bug 56610] jsp:param empty value error

2014-06-10 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=56610 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

[Bug 56561] NoSuchElementException on empty attribute in Validator$ValidateVisitor.getJspAttribute(Validator.java:1385)

2014-06-10 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=56561 Mark Thomas changed: What|Removed |Added CC||raffaele.trip...@gmail.com --- Comme

svn commit: r1601597 - in /tomcat/trunk: res/tomcat.nsi webapps/docs/changelog.xml webapps/docs/manager-howto.xml webapps/docs/realm-howto.xml

2014-06-10 Thread markt
Author: markt Date: Tue Jun 10 10:15:17 2014 New Revision: 1601597 URL: http://svn.apache.org/r1601597 Log: Ensure that the new attribute name username is used in the tomcat-users.xml examples rather than the old name of user. Modified: tomcat/trunk/res/tomcat.nsi tomcat/trunk/webapps/do

svn commit: r1601598 - in /tomcat/tc7.0.x/trunk: res/tomcat.nsi webapps/docs/changelog.xml webapps/docs/manager-howto.xml

2014-06-10 Thread markt
Author: markt Date: Tue Jun 10 10:16:01 2014 New Revision: 1601598 URL: http://svn.apache.org/r1601598 Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=56606 Ensure that the new attribute name username is used in the tomcat-users.xml examples rather than the old name of user. Modified

svn commit: r1601599 - /tomcat/tc6.0.x/trunk/STATUS.txt

2014-06-10 Thread markt
Author: markt Date: Tue Jun 10 10:18:51 2014 New Revision: 1601599 URL: http://svn.apache.org/r1601599 Log: Proposal Modified: tomcat/tc6.0.x/trunk/STATUS.txt Modified: tomcat/tc6.0.x/trunk/STATUS.txt URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=1601599&r1=1601598&r

[Bug 56606] Tomcat Installer: old attribute generated in tomcat-users.xml instead of the new one

2014-06-10 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=56606 Mark Thomas changed: What|Removed |Added Component|Packaging |Native:Packaging Version|

[Bug 56612] New: Jasper is not able to parse two consecutive escaped single quotes in EL

2014-06-10 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=56612 Bug ID: 56612 Summary: Jasper is not able to parse two consecutive escaped single quotes in EL Product: Tomcat 8 Version: 8.0.5 Hardware: PC OS: Linux

[Bug 56612] Jasper is not able to parse two consecutive escaped single quotes in EL

2014-06-10 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=56612 Pavel Horal changed: What|Removed |Added CC||pavel.ho...@orchitech.cz -- You are

[Bug 56518] NIO async servlet limit latch leak

2014-06-10 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=56518 --- Comment #13 from Mark Thomas --- Thanks for all your work on this. It is much appreciated. Given that it is the application that is triggering the interrupt, shouldn't it be the application's responsibility to clear that interrupt befo

Re: svn commit: r1601590 - in /tomcat/trunk/java/org/apache/tomcat/util/net: AbstractEndpoint.java AprEndpoint.java JIoEndpoint.java Nio2Endpoint.java

2014-06-10 Thread Mark Thomas
On 10/06/2014 10:52, ma...@apache.org wrote: > Author: markt > Date: Tue Jun 10 09:52:56 2014 > New Revision: 1601590 > > URL: http://svn.apache.org/r1601590 > Log: > Pull up AsyncTimeout > APR/native used a separate flag to stop the thread. This avoided issues where > running was set true->false

"Printable" documentation for tomcat-connectors

2014-06-10 Thread Christopher Schultz
All, I noticed a series of typos on the connectors docs and I was going to fix them. Before noticing that, as usual, .xml -> .html, I saw that there are two copies of many parts of the site: "regular" and "printer". For example: ./tomcat-site/docs/connectors-doc/generic_howto/printer/workers.html

Time for tcnative-1.1.31?

2014-06-10 Thread Christopher Schultz
All, OpenSSL was released last week with a bunch of patches for fun vulnerabilities. We should probably roll a new release that includes it. I would offer to do it myself, but I don't have a win32 build environment, nor are there instructions for building on win32. I believe Mladen posted them a

async error message if not supported

2014-06-10 Thread Romain Manni-Bucau
Hi in /org/apache/catalina/connector/Request.java it would be nice if error message if there is a filter/servlet not supporting async would be more explicit. Here is the code: 1654 @Override 1655 public AsyncContext startAsync(ServletRequest request, 1656 ServletResponse respo

svn commit: r1601761 - /tomcat/trunk/java/org/apache/tomcat/util/net/AbstractEndpoint.java

2014-06-10 Thread markt
Author: markt Date: Tue Jun 10 20:01:05 2014 New Revision: 1601761 URL: http://svn.apache.org/r1601761 Log: Fix failures to timeout async requests after refactoring. The removed condition was added to the APR connector (by me) some time ago but reviewing the current code I can see no reason for

Re: svn commit: r1601590 - in /tomcat/trunk/java/org/apache/tomcat/util/net: AbstractEndpoint.java AprEndpoint.java JIoEndpoint.java Nio2Endpoint.java

2014-06-10 Thread Konstantin Kolinko
2014-06-10 18:06 GMT+04:00 Mark Thomas : > On 10/06/2014 10:52, ma...@apache.org wrote: >> Author: markt >> Date: Tue Jun 10 09:52:56 2014 >> New Revision: 1601590 >> >> URL: http://svn.apache.org/r1601590 >> Log: >> Pull up AsyncTimeout >> APR/native used a separate flag to stop the thread. This a

Re: Time for tcnative-1.1.31?

2014-06-10 Thread Konstantin Kolinko
2014-06-10 18:46 GMT+04:00 Christopher Schultz : > All, > > OpenSSL was released last week with a bunch of patches for fun > vulnerabilities. We should probably roll a new release that includes it. > > I would offer to do it myself, but I don't have a win32 build > environment, nor are there instru

Re: "Printable" documentation for tomcat-connectors

2014-06-10 Thread Konstantin Kolinko
2014-06-10 18:25 GMT+04:00 Christopher Schultz : > All, > > I noticed a series of typos on the connectors docs and I was going to > fix them. Before noticing that, as usual, .xml -> .html, I saw that > there are two copies of many parts of the site: "regular" and "printer". > For example: > > ./tom

Re: svn commit: r1601590 - in /tomcat/trunk/java/org/apache/tomcat/util/net: AbstractEndpoint.java AprEndpoint.java JIoEndpoint.java Nio2Endpoint.java

2014-06-10 Thread Mark Thomas
On 10/06/2014 21:01, Konstantin Kolinko wrote: > 2014-06-10 18:06 GMT+04:00 Mark Thomas : >> On 10/06/2014 10:52, ma...@apache.org wrote: >>> Author: markt >>> Date: Tue Jun 10 09:52:56 2014 >>> New Revision: 1601590 >>> >>> URL: http://svn.apache.org/r1601590 >>> Log: >>> Pull up AsyncTimeout >>>

Re: "Printable" documentation for tomcat-connectors

2014-06-10 Thread Christopher Schultz
Konstantin, On 6/10/14, 4:46 PM, Konstantin Kolinko wrote: > 2014-06-10 18:25 GMT+04:00 Christopher Schultz : >> All, >> >> I noticed a series of typos on the connectors docs and I was going to >> fix them. Before noticing that, as usual, .xml -> .html, I saw that >> there are two copies of many p

Re: Time for tcnative-1.1.31?

2014-06-10 Thread Christopher Schultz
Konstantin, On 6/10/14, 4:09 PM, Konstantin Kolinko wrote: > 2014-06-10 18:46 GMT+04:00 Christopher Schultz : >> All, >> >> OpenSSL was released last week with a bunch of patches for fun >> vulnerabilities. We should probably roll a new release that includes it. >> >> I would offer to do it myself

Re: "Printable" documentation for tomcat-connectors

2014-06-10 Thread Mark Thomas
On 10/06/2014 22:59, Christopher Schultz wrote: > Aah, okay. I didn't realize that .htaccess files were okay to use. > They seem like a huge security hole ;) Infra limits what you can do in a .htaccess file and - by default - we trust committers. That said, infra won't hesitate to lock an account

svn commit: r1601785 - in /tomcat/trunk: java/org/apache/jasper/compiler/ test/org/apache/el/ test/org/apache/jasper/compiler/ test/webapp/bug5nnnn/ webapps/docs/

2014-06-10 Thread markt
Author: markt Date: Tue Jun 10 22:39:22 2014 New Revision: 1601785 URL: http://svn.apache.org/r1601785 Log: Correctly parse two consecutive escaped single quotes when used in UEL expression in a JSP. Includes various unit tests that check the parsing of ${'\'\''} Added: tomcat/trunk/test/web

svn commit: r1601787 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/jasper/compiler/ java/org/apache/tomcat/util/net/ test/org/apache/el/ test/org/apache/jasper/compiler/ test/webapp-3.0/bug5nnnn/ web

2014-06-10 Thread markt
Author: markt Date: Tue Jun 10 22:46:55 2014 New Revision: 1601787 URL: http://svn.apache.org/r1601787 Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=56612 Correctly parse two consecutive escaped single quotes when used in UEL expression in a JSP. Includes various unit tests that che

[Bug 56612] Jasper is not able to parse two consecutive escaped single quotes in EL

2014-06-10 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=56612 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

Re: svn commit: r1601787 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/jasper/compiler/ java/org/apache/tomcat/util/net/ test/org/apache/el/ test/org/apache/jasper/compiler/ test/webapp-3.0/bug5nnnn/

2014-06-10 Thread Konstantin Kolinko
2014-06-11 2:46 GMT+04:00 : > Author: markt > Date: Tue Jun 10 22:46:55 2014 > New Revision: 1601787 > > URL: http://svn.apache.org/r1601787 > Log: > Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=56612 > Correctly parse two consecutive escaped single quotes when used in UEL > expression i

svn commit: r1601788 - /tomcat/tc7.0.x/trunk/java/org/apache/tomcat/util/net/NioChannel.java

2014-06-10 Thread markt
Author: markt Date: Tue Jun 10 22:57:52 2014 New Revision: 1601788 URL: http://svn.apache.org/r1601788 Log: Revert accidental commit. Modified: tomcat/tc7.0.x/trunk/java/org/apache/tomcat/util/net/NioChannel.java Modified: tomcat/tc7.0.x/trunk/java/org/apache/tomcat/util/net/NioChannel.java

RE: Time for tcnative-1.1.31?

2014-06-10 Thread Konstantin Preißer
Hi Christopher, > -Original Message- > From: Christopher Schultz [mailto:ch...@christopherschultz.net] > Sent: Wednesday, June 11, 2014 12:11 AM > I'm trying to fetch Visual Studio Express but I'm in circular-link hell > at http://www.visualstudio.com/en-us/downloads/download-visual-studi

Re: svn commit: r1601787 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/jasper/compiler/ java/org/apache/tomcat/util/net/ test/org/apache/el/ test/org/apache/jasper/compiler/ test/webapp-3.0/bug5nnnn/

2014-06-10 Thread Mark Thomas
On 10/06/2014 23:55, Konstantin Kolinko wrote: > 2014-06-11 2:46 GMT+04:00 : >> Author: markt >> Date: Tue Jun 10 22:46:55 2014 >> New Revision: 1601787 >> >> URL: http://svn.apache.org/r1601787 >> Log: >> Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=56612 >> Correctly parse two consecut

svn commit: r1601790 - /tomcat/tc6.0.x/trunk/STATUS.txt

2014-06-10 Thread markt
Author: markt Date: Tue Jun 10 23:23:59 2014 New Revision: 1601790 URL: http://svn.apache.org/r1601790 Log: Proposal Modified: tomcat/tc6.0.x/trunk/STATUS.txt Modified: tomcat/tc6.0.x/trunk/STATUS.txt URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=1601790&r1=1601789&r

Re: svn commit: r1601787 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/jasper/compiler/ java/org/apache/tomcat/util/net/ test/org/apache/el/ test/org/apache/jasper/compiler/ test/webapp-3.0/bug5nnnn/

2014-06-10 Thread Konstantin Kolinko
2014-06-11 3:18 GMT+04:00 Mark Thomas : > On 10/06/2014 23:55, Konstantin Kolinko wrote: >> 2014-06-11 2:46 GMT+04:00 : >>> Author: markt >>> Date: Tue Jun 10 22:46:55 2014 >>> New Revision: 1601787 >>> >>> URL: http://svn.apache.org/r1601787 >>> Log: >>> Fix https://issues.apache.org/bugzilla/sho

svn commit: r1601796 - in /tomcat/trunk: java/org/apache/catalina/connector/Request.java webapps/docs/changelog.xml

2014-06-10 Thread violetagg
Author: violetagg Date: Wed Jun 11 01:49:21 2014 New Revision: 1601796 URL: http://svn.apache.org/r1601796 Log: Provide a better error message when asynchronous operations are not supported by a filter or servlet. Patch provided by Romain Manni-Bucau. Issue was reported via users at tomcat.a.o.

svn propchange: r1601796 - svn:log

2014-06-10 Thread violetagg
Author: violetagg Revision: 1601796 Modified property: svn:log Modified: svn:log at Wed Jun 11 01:51:39 2014 -- --- svn:log (original) +++ svn:log Wed Jun 11 01:51:39 2014 @@ -1 +1 @@ -Provide a better error message when a

svn commit: r1601797 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/catalina/connector/Request.java webapps/docs/changelog.xml

2014-06-10 Thread violetagg
Author: violetagg Date: Wed Jun 11 01:55:59 2014 New Revision: 1601797 URL: http://svn.apache.org/r1601797 Log: Merged revision 1601796 from tomcat/trunk: Provide a better error message when asynchronous operations are not supported by a filter or servlet. Patch provided by Romain Manni-Bucau. Is

Re: async error message if not supported

2014-06-10 Thread Violeta Georgieva
Hi, 2014-06-10 21:28 GMT+03:00 Romain Manni-Bucau : > > Hi > > in /org/apache/catalina/connector/Request.java it would be nice if error > message if there is a filter/servlet not supporting async would be more > explicit. Here is the code: > > 1654 @Override > 1655 public AsyncContext star

buildbot success in ASF Buildbot on tomcat-trunk

2014-06-10 Thread buildbot
The Buildbot has detected a restored build on builder tomcat-trunk while building ASF Buildbot. Full details are available at: http://ci.apache.org/builders/tomcat-trunk/builds/162 Buildbot URL: http://ci.apache.org/ Buildslave for this Build: bb-vm_ubuntu Build Reason: scheduler Build Source

Re: async error message if not supported

2014-06-10 Thread Romain Manni-Bucau
Thanks! Le 11 juin 2014 02:58, "Violeta Georgieva" a écrit : > Hi, > > 2014-06-10 21:28 GMT+03:00 Romain Manni-Bucau : > > > > Hi > > > > in /org/apache/catalina/connector/Request.java it would be nice if error > > message if there is a filter/servlet not supporting async would be more > > explic