svn commit: r1599099 - /tomcat/trunk/webapps/examples/WEB-INF/classes/websocket/echo/EchoAsyncAnnotation.java

2014-06-02 Thread remm
Author: remm Date: Mon Jun 2 07:03:24 2014 New Revision: 1599099 URL: http://svn.apache.org/r1599099 Log: Avoid having an import. Modified: tomcat/trunk/webapps/examples/WEB-INF/classes/websocket/echo/EchoAsyncAnnotation.java Modified: tomcat/trunk/webapps/examples/WEB-INF/classes/websock

[Bug 56580] el-api.jar memory leak

2014-06-02 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=56580 --- Comment #2 from cos...@prodinf.ro --- There is no Class in ELUtils but there is BeanELResolver(in el-api.jar). The ELUtils is in (JSF MOjarra https://github.com/bleathem/mojarra/blob/master/jsf-ri/src/main/java/com/sun/faces/el/ELUtils

svn commit: r1599183 - in /tomcat/trunk: java/org/apache/coyote/http11/AbstractHttp11Processor.java test/org/apache/coyote/http11/TestAbstractHttp11Processor.java webapps/docs/changelog.xml

2014-06-02 Thread markt
Author: markt Date: Mon Jun 2 12:23:24 2014 New Revision: 1599183 URL: http://svn.apache.org/r1599183 Log: Revert fix for https://issues.apache.org/bugzilla/show_bug.cgi?id=56555 which, after further discussion, was classed as INVALID. Modified: tomcat/trunk/java/org/apache/coyote/http11/Ab

svn commit: r1599184 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/coyote/http11/AbstractHttp11Processor.java test/org/apache/coyote/http11/TestAbstractHttp11Processor.java webapps/docs/changelog.xml

2014-06-02 Thread markt
Author: markt Date: Mon Jun 2 12:23:49 2014 New Revision: 1599184 URL: http://svn.apache.org/r1599184 Log: Revert fix for https://issues.apache.org/bugzilla/show_bug.cgi?id=56555 which, after further discussion, was classed as INVALID. Modified: tomcat/tc7.0.x/trunk/ (props changed)

[Bug 56555] Multiple connection headers for status 400 when "keep-alive" is specified

2014-06-02 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=56555 Mark Thomas changed: What|Removed |Added Status|REOPENED|RESOLVED Resolution|---

buildbot exception in ASF Buildbot on tomcat-7-trunk

2014-06-02 Thread buildbot
The Buildbot has detected a build exception on builder tomcat-7-trunk while building ASF Buildbot. Full details are available at: http://ci.apache.org/builders/tomcat-7-trunk/builds/90 Buildbot URL: http://ci.apache.org/ Buildslave for this Build: bb-vm_ubuntu Build Reason: scheduler Build Sou

[Bug 56575] [websocket][AsyncContext][Ubuntu] java.lang.IllegalStateException: Not supported. event when async-supported set to true

2014-06-02 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=56575 Jean-Francois Arcand changed: What|Removed |Added Status|NEW |RESOLVED Resolution

[Bug 56580] el-api.jar memory leak

2014-06-02 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=56580 Mark Thomas changed: What|Removed |Added Status|NEEDINFO|NEW --- Comment #3 from Mark Thomas

Re: Error handling

2014-06-02 Thread Mark Thomas
On 31/05/2014 14:57, Konstantin Kolinko wrote: > 2014-05-29 16:31 GMT+04:00 Mark Thomas : >> You've probably noticed I've been poking around the ErrorReportValve, >> the Response objects and other related code. I've been looking into an >> issue that one of the groups at $work has raised around Tom

Re: svn commit: r1598307 - in /tomcat/trunk/java/org/apache/coyote: Response.java http11/AbstractOutputBuffer.java

2014-06-02 Thread Mark Thomas
On 02/06/2014 00:50, Konstantin Kolinko wrote: > Ack, OK. > I re-reviewed with your arguments in mind and see that nothing has changed. > > Several comments. > > First > > One oddity here is, though. The success of this refactoring is based > on fact that ActionCode.RESET is used inte

svn commit: r1599336 - /tomcat/trunk/webapps/examples/WEB-INF/classes/websocket/echo/EchoAsyncAnnotation.java

2014-06-02 Thread markt
Author: markt Date: Mon Jun 2 19:58:40 2014 New Revision: 1599336 URL: http://svn.apache.org/r1599336 Log: Fix IDE warning Modified: tomcat/trunk/webapps/examples/WEB-INF/classes/websocket/echo/EchoAsyncAnnotation.java Modified: tomcat/trunk/webapps/examples/WEB-INF/classes/websocket/echo

[Bug 56586] New: initSQL should be committed if defaultAutoCommit == false

2014-06-02 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=56586 Bug ID: 56586 Summary: initSQL should be committed if defaultAutoCommit == false Product: Tomcat Modules Version: unspecified Hardware: PC OS: Linux

svn commit: r1599385 - /tomcat/trunk/java/org/apache/coyote/spdy/SpdyProcessor.java

2014-06-02 Thread kkolinko
Author: kkolinko Date: Mon Jun 2 22:44:29 2014 New Revision: 1599385 URL: http://svn.apache.org/r1599385 Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=56582 Convert implementations of ActionHook.action(..) to use switch(enum) operator. First, SpdyProcessor. Modified: tomcat/tru

svn commit: r1599393 - in /tomcat/trunk: java/org/apache/coyote/http11/ webapps/docs/

2014-06-02 Thread kkolinko
Author: kkolinko Date: Mon Jun 2 23:40:11 2014 New Revision: 1599393 URL: http://svn.apache.org/r1599393 Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=56582 Convert implementations of ActionHook.action(..) to use switch(enum) operator. Second part: HTTP processors. Modified: to

svn commit: r1599395 - /tomcat/trunk/java/org/apache/coyote/ajp/AbstractAjpProcessor.java

2014-06-02 Thread kkolinko
Author: kkolinko Date: Tue Jun 3 00:15:08 2014 New Revision: 1599395 URL: http://svn.apache.org/r1599395 Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=56582 Convert implementations of ActionHook.action(..) to use switch(enum) operator. Third and the last part: AJP processors. Poten

[Bug 56582] Use switch(enum) in implementations of ActionHook.action(ActionCode, ...)

2014-06-02 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=56582 --- Comment #1 from Konstantin Kolinko --- Done for Tomcat 8 (r1599385 r1599393 r1599395), will be in 8.0.9. I plan to backport this change to Tomcat 7, as I think switch() behaves better for performance. One possible error spotted thanks