On 12/05/2014 21:00, Rémy Maucherat wrote:
> 2014-05-12 16:39 GMT+02:00 Mark Thomas :
>
>> I just got to that. I've answered your immediate question but I want to
>> do a little more digging of my own. I'll respond in more detail on that
>> thread. That said, I'm not expecting NIO2 to be declared
2014-05-13 9:37 GMT+02:00 Mark Thomas :
> I'm running the unit tests now. I want to look at BZ 56516 some more and
> I don't want to hold up a 8.0.x release any longer.
>
There's nothing to look at IMO, the guy is using scriptlets and expects
things to work with the tag variable. Jasper has no id
https://issues.apache.org/bugzilla/show_bug.cgi?id=56518
--- Comment #1 from hanyong ---
Created attachment 31614
--> https://issues.apache.org/bugzilla/attachment.cgi?id=31614&action=edit
source code of the sample webapp
--
You are receiving this mail because:
You are the assignee for the bu
https://issues.apache.org/bugzilla/show_bug.cgi?id=56496
Mark Thomas changed:
What|Removed |Added
Status|NEW |RESOLVED
Resolution|---
Author: markt
Date: Wed May 7 13:56:59 2014
New Revision: 1593018
URL: http://svn.apache.org/r1593018
Log:
Correct vote
Modified:
tomcat/tc6.0.x/trunk/STATUS.txt
Modified: tomcat/tc6.0.x/trunk/STATUS.txt
URL:
http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=1593018&r1=15930
Author: kkolinko
Date: Thu May 8 19:15:25 2014
New Revision: 1593387
URL: http://svn.apache.org/r1593387
Log:
Small optimization: move "getRegistry(null, null)" call out of the loop.
Modified:
tomcat/trunk/java/org/apache/catalina/core/NamingContextListener.java
Modified: tomcat/trunk/java/
Author: markt
Date: Tue May 13 11:25:14 2014
New Revision: 1594198
URL: http://svn.apache.org/r1594198
Log:
Address root cause of ReadPendingException rather than swallowing it.
Modified:
tomcat/trunk/java/org/apache/coyote/AsyncStateMachine.java
tomcat/trunk/java/org/apache/coyote/http11
Author: markt
Date: Tue May 13 11:26:26 2014
New Revision: 1594199
URL: http://svn.apache.org/r1594199
Log:
Give the thread shutting down the existing connections a chance to finish
before forcibly closing them and triggering an exception on each connection
that is forcibly closed.
Modified:
Author: kkolinko
Date: Tue May 13 14:11:11 2014
New Revision: 1594229
URL: http://svn.apache.org/r1594229
Log:
Require RuntimePermission when introducing a new token.
Modified:
tomcat/trunk/java/org/apache/naming/ContextAccessController.java
tomcat/trunk/webapps/docs/changelog.xml
Modifi
Author: kkolinko
Date: Tue May 13 14:17:33 2014
New Revision: 1594232
URL: http://svn.apache.org/r1594232
Log:
proposal
Modified:
tomcat/tc6.0.x/trunk/STATUS.txt
Modified: tomcat/tc6.0.x/trunk/STATUS.txt
URL:
http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=1594232&r1=159423
Author: kkolinko
Date: Tue May 13 14:15:06 2014
New Revision: 1594230
URL: http://svn.apache.org/r1594230
Log:
Merged r1594229 from tomcat/trunk:
Require RuntimePermission when introducing a new token.
Modified:
tomcat/tc7.0.x/trunk/ (props changed)
tomcat/tc7.0.x/trunk/java/org/apache/
https://issues.apache.org/bugzilla/show_bug.cgi?id=56463
Violeta Georgieva changed:
What|Removed |Added
Status|NEW |RESOLVED
Resolution|--
On 12/05/2014 18:32, Rémy Maucherat wrote:
> 2014-05-12 16:25 GMT+02:00 Mark Thomas :
>
>>
>> In terms of whether there is a better place, I didn't look lower down
>> the stack. We probably only want to swallow this if we haven't read any
>> part of the request line.
>>
> Ok, I'll add back the two
Le 12/05/2014 21:24, Christopher Schultz a écrit :
> Could you announce on u...@tomcat.apache.org as well? You have a bigger
> audience over there. Feel free to put [ANN] in the subject which is
> often put into announcement emails to our lists.
Thank you for the hint Christopher. I don't think I
Author: schultz
Date: Tue May 13 14:52:26 2014
New Revision: 1594238
URL: http://svn.apache.org/r1594238
Log:
Replace looped String-concatenation with StringBuilder. No functional change.
Modified:
tomcat/trunk/java/org/apache/jasper/compiler/JDTCompiler.java
Modified: tomcat/trunk/java/org/
https://issues.apache.org/bugzilla/show_bug.cgi?id=56501
--- Comment #6 from Mark Thomas ---
(In reply to Kay from comment #5)
> i think there should be some kind on URL decode on tomcat side.
The problem is the exact opposite. Neither getRequestURI() not getContextPath()
should return decoded
To whom it may engage...
This is an automated request, but not an unsolicited one. For
more information please visit http://gump.apache.org/nagged.html,
and/or contact the folk at gene...@gump.apache.org.
Project taglibs-parent has an issue affecting its community integration.
This issu
https://issues.apache.org/bugzilla/show_bug.cgi?id=56403
--- Comment #5 from Christopher Schultz ---
Created attachment 31615
--> https://issues.apache.org/bugzilla/attachment.cgi?id=31615&action=edit
Example of an interface and implementation of both MessageDigest and PBKDF2
Attaching a self-
https://issues.apache.org/bugzilla/show_bug.cgi?id=56518
Bug ID: 56518
Summary: NIO async servlet limit latch leak
Product: Tomcat 7
Version: 7.0.53
Hardware: PC
OS: Linux
Status: NEW
Severity: normal
The Buildbot has detected a new failure on builder tomcat-trunk while building
ASF Buildbot.
Full details are available at:
http://ci.apache.org/builders/tomcat-trunk/builds/69
Buildbot URL: http://ci.apache.org/
Buildslave for this Build: bb-vm_ubuntu
Build Reason: scheduler
Build Source Stam
Author: markt
Date: Tue May 13 19:39:43 2014
New Revision: 1594346
URL: http://svn.apache.org/r1594346
Log:
Keep Checkstyle happy
Modified:
tomcat/trunk/java/org/apache/jasper/compiler/JDTCompiler.java
Modified: tomcat/trunk/java/org/apache/jasper/compiler/JDTCompiler.java
URL:
http://svn.a
On 13/05/2014 11:43, Rémy Maucherat wrote:
> 2014-05-13 9:37 GMT+02:00 Mark Thomas :
>
>> I'm running the unit tests now. I want to look at BZ 56516 some more and
>> I don't want to hold up a 8.0.x release any longer.
>>
>
> There's nothing to look at IMO, the guy is using scriptlets and expects
https://issues.apache.org/bugzilla/show_bug.cgi?id=56518
hanyong changed:
What|Removed |Added
CC||observer.hany@alibaba-inc.c
The Buildbot has detected a restored build on builder tomcat-trunk while
building ASF Buildbot.
Full details are available at:
http://ci.apache.org/builders/tomcat-trunk/builds/70
Buildbot URL: http://ci.apache.org/
Buildslave for this Build: bb-vm_ubuntu
Build Reason: scheduler
Build Source S
Github user cpbills closed the pull request at:
https://github.com/apache/tomcat/pull/7
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabl
Author: markt
Date: Tue May 13 20:55:24 2014
New Revision: 1594380
URL: http://svn.apache.org/r1594380
Log:
Merge processSocket() and dispatchForEvent()
Modified:
tomcat/trunk/java/org/apache/coyote/http11/Http11NioProcessor.java
tomcat/trunk/java/org/apache/tomcat/util/net/NioEndpoint.ja
Author: markt
Date: Mon May 12 16:56:56 2014
New Revision: 1594028
URL: http://svn.apache.org/r1594028
Log:
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=56501
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=56501
HttpServletRequest.getContextPath() should return the undecoded cont
Author: markt
Date: Tue May 13 21:24:04 2014
New Revision: 1594393
URL: http://svn.apache.org/r1594393
Log:
Remove unused code
Modified:
tomcat/trunk/java/org/apache/tomcat/util/net/NioEndpoint.java
tomcat/trunk/java/org/apache/tomcat/util/net/res/LocalStrings.properties
tomcat/trunk/
Author: markt
Date: Tue May 13 20:50:20 2014
New Revision: 1594377
URL: http://svn.apache.org/r1594377
Log:
Return value is never used (and is hard coded to true anyway) so change return
type to void.
Modified:
tomcat/trunk/java/org/apache/tomcat/util/net/NioEndpoint.java
Modified: tomcat/t
Github user cpbills closed the pull request at:
https://github.com/apache/tomcat/pull/8
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabl
Author: markt
Date: Tue May 13 21:12:36 2014
New Revision: 1594386
URL: http://svn.apache.org/r1594386
Log:
Consistent naming
Modified:
tomcat/trunk/java/org/apache/tomcat/util/net/Nio2Endpoint.java
Modified: tomcat/trunk/java/org/apache/tomcat/util/net/Nio2Endpoint.java
URL:
http://svn.apa
Author: markt
Date: Tue May 13 22:17:21 2014
New Revision: 1594405
URL: http://svn.apache.org/r1594405
Log:
Remove duplicate method
Modified:
tomcat/trunk/java/org/apache/tomcat/util/net/NioBlockingSelector.java
tomcat/trunk/java/org/apache/tomcat/util/net/NioEndpoint.java
Modified: tomc
GitHub user cpbills opened a pull request:
https://github.com/apache/tomcat/pull/8
Fix how a link to $0 is determined
- The test '-L' is true of the file provided is a symbolic link
- 'readlink -f' will print the absolute path to a symbolic link's target
- 'readlink -n' will
Author: markt
Date: Tue May 13 20:59:25 2014
New Revision: 1594381
URL: http://svn.apache.org/r1594381
Log:
Remove unnecessary casts
Modified:
tomcat/trunk/java/org/apache/coyote/http11/Http11AprProcessor.java
tomcat/trunk/java/org/apache/coyote/http11/Http11Processor.java
Modified: tomc
Author: markt
Date: Tue May 13 22:53:21 2014
New Revision: 1594412
URL: http://svn.apache.org/r1594412
Log:
Whitespace police
Modified:
tomcat/trunk/webapps/docs/changelog.xml
Modified: tomcat/trunk/webapps/docs/changelog.xml
URL:
http://svn.apache.org/viewvc/tomcat/trunk/webapps/docs/chang
Emmanuel,
On 5/13/14, 11:16 AM, Emmanuel Bourg wrote:
> Le 12/05/2014 21:24, Christopher Schultz a écrit :
>
>> Could you announce on u...@tomcat.apache.org as well? You have a bigger
>> audience over there. Feel free to put [ANN] in the subject which is
>> often put into announcement emails to o
Rémy,
On 5/7/14, 9:33 AM, Rémy Maucherat wrote:
> 2014-05-06 19:25 GMT+02:00 Christopher Schultz > :
>
>>
>> Since this is not really a "bug" per se, I decided not to create a BZ
>> issue. If it would be easier for everyone if I attached the patch to a
>> BZ issue I'm happy to do that as well.
>>
Github user kkolinko commented on the pull request:
https://github.com/apache/tomcat/pull/7#issuecomment-43018127
http://pubs.opengroup.org/onlinepubs/009695399/mindex.html
http://pubs.opengroup.org/onlinepubs/9699919799/mindex.html
---
If your project is set up for it, you can re
Author: markt
Date: Tue May 13 22:51:19 2014
New Revision: 1594411
URL: http://svn.apache.org/r1594411
Log:
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=56518
Refactor NIO's SocketProcessor to use KeyAtrtachment rather than Socket to
align it with the other implementations. This enables
GitHub user cpbills opened a pull request:
https://github.com/apache/tomcat/pull/7
Fix how a link to $0 is determined
- The test '-L' is true of the file provided is a symbolic link
- 'readlink -f' will print the absolute path to a symbolic link's target
- 'readlink -n' will
Github user cpbills commented on the pull request:
https://github.com/apache/tomcat/pull/7#issuecomment-43012973
Seems like there are other scripts that need fixing; closing for now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Author: markt
Date: Tue May 13 21:07:35 2014
New Revision: 1594383
URL: http://svn.apache.org/r1594383
Log:
Pull up common async code
Modified:
tomcat/trunk/java/org/apache/coyote/http11/AbstractHttp11Processor.java
tomcat/trunk/java/org/apache/coyote/http11/Http11AprProcessor.java
to
https://issues.apache.org/bugzilla/show_bug.cgi?id=56399
--- Comment #1 from Konstantin Kolinko ---
The feature (but not the refactoring it implied) was implemented in Tomcat 8
with r1594436 and will be in 8.0.6.
--
You are receiving this mail because:
You are the assignee for the bug.
---
Author: kkolinko
Date: Wed May 14 00:44:33 2014
New Revision: 1594436
URL: http://svn.apache.org/r1594436
Log:
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=56399
When recycling a Coyote request, ensure that Catalina request have been
recycled.
Modified:
tomcat/trunk/java/org/apache
https://issues.apache.org/bugzilla/show_bug.cgi?id=56512
--- Comment #3 from j...@yahoo.com ---
argh. i was staring at that for ages and kept reading it as
`requestPath.charAt(requestPath.length() - 2)` . must be something wrong with
my testcase then. will go back and see.
--
You are receivin
https://issues.apache.org/bugzilla/show_bug.cgi?id=56516
--- Comment #1 from Konstantin Kolinko ---
Do you expect a variable to be declared each time when
VariableInfo.getDeclare() returns true?
When JSP java code is generated the java scriptlets are treated as opaque. One
does not analyze what c
https://issues.apache.org/bugzilla/show_bug.cgi?id=56518
--- Comment #2 from Mark Thomas ---
Thanks for the sample web application. I am able to reproduce this with NIO but
not with NIO2 or APR/native so it appears that this issue is specific to NIO.
I have started some refactoring that should m
To whom it may engage...
This is an automated request, but not an unsolicited one. For
more information please visit http://gump.apache.org/nagged.html,
and/or contact the folk at gene...@gump.apache.org.
Project taglibs-parent has an issue affecting its community integration.
This issu
Author: markt
Date: Tue May 13 21:05:33 2014
New Revision: 1594382
URL: http://svn.apache.org/r1594382
Log:
Align code across the Processors
Note for NIO that the socketWrapper is the KeyAttachment which allows the NIO
code to be simplified
Modified:
tomcat/trunk/java/org/apache/coyote/http1
https://issues.apache.org/bugzilla/show_bug.cgi?id=56518
--- Comment #3 from Mark Thomas ---
As luck would have it, the next stage of clean-up / refactoring appears to have
fixed this issue. The fix is applied to 8.0.x and the unit tests pass on OSX.
I'm just waiting for the results for Linux and
2014-05-14 2:44 GMT+02:00 :
> Author: kkolinko
> Date: Wed May 14 00:44:33 2014
> New Revision: 1594436
>
> URL: http://svn.apache.org/r1594436
> Log:
> Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=56399
> When recycling a Coyote request, ensure that Catalina request have been
> recycled
51 matches
Mail list logo
