svn commit: r1584270 - in /tomcat/trunk: java/org/apache/catalina/ha/session/ClusterManagerBase.java webapps/docs/changelog.xml

2014-04-03 Thread kfujino
Author: kfujino Date: Thu Apr 3 07:06:09 2014 New Revision: 1584270 URL: http://svn.apache.org/r1584270 Log: Remove the unnecessary cross context check. It does not matter whether the context that is referenced by other context is set to crossContext=true. The context that refers to the differ

svn commit: r1584274 - in /tomcat/trunk: java/org/apache/catalina/ha/session/BackupManager.java java/org/apache/catalina/ha/session/ClusterManagerBase.java java/org/apache/catalina/ha/session/DeltaMan

2014-04-03 Thread kfujino
Author: kfujino Date: Thu Apr 3 07:33:04 2014 New Revision: 1584274 URL: http://svn.apache.org/r1584274 Log: Move to org.apache.catalina.ha.session.ClusterManagerBase common logics of org.apache.catalina.ha.session.BackupManager and org.apache.catalina.ha.session.DeltaManager. Modified: to

[Bug 55483] ELException when object has overloaded methods

2014-04-03 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=55483 Mark Thomas changed: What|Removed |Added Status|RESOLVED|REOPENED Resolution|FIXED

[Tomcat Wiki] Update of "summit-na-2014" by markt

2014-04-03 Thread Apache Wiki
Dear Wiki user, You have subscribed to a wiki page or wiki category on "Tomcat Wiki" for change notification. The "summit-na-2014" page has been changed by markt: https://wiki.apache.org/tomcat/summit-na-2014?action=diff&rev1=2&rev2=3 Comment: Add schedule, catering and some more topics == R

[Bug 56334] Double Backslash Escaping in Attributes

2014-04-03 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=56334 Markus changed: What|Removed |Added OS||All --- Comment #1 from Markus --- Tomca

[Bug 56343] New: NPE in org.apache.tomcat.websocket.WsWebSocketContainer.connectToServer

2014-04-03 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=56343 Bug ID: 56343 Summary: NPE in org.apache.tomcat.websocket.WsWebSocketContainer.conne ctToServer Product: Tomcat 8 Version: 8.0.5 Hardware: PC

svn commit: r1584275 - in /tomcat/tc7.0.x/trunk: java/org/apache/catalina/ha/session/ webapps/docs/

2014-04-03 Thread kfujino
Author: kfujino Date: Thu Apr 3 07:57:38 2014 New Revision: 1584275 URL: http://svn.apache.org/r1584275 Log: Backport r1584267, r1584268, r1584270 and r1584274 Add support for cross context session replication to BackupManager. This fix is included sevral improvement of cluster manager. Modified

svn commit: r1584276 - /tomcat/trunk/java/org/apache/catalina/session/StandardManager.java

2014-04-03 Thread markt
Author: markt Date: Thu Apr 3 07:59:40 2014 New Revision: 1584276 URL: http://svn.apache.org/r1584276 Log: Revert changes from r1581820 as it triggers an IOE Modified: tomcat/trunk/java/org/apache/catalina/session/StandardManager.java Modified: tomcat/trunk/java/org/apache/catalina/session/

svn commit: r1584278 - /tomcat/trunk/java/org/apache/catalina/session/StandardManager.java

2014-04-03 Thread markt
Author: markt Date: Thu Apr 3 08:14:30 2014 New Revision: 1584278 URL: http://svn.apache.org/r1584278 Log: ois is closed in finally block - no need to close it in catch blocks as well. Modified: tomcat/trunk/java/org/apache/catalina/session/StandardManager.java Modified: tomcat/trunk/java/o

buildbot failure in ASF Buildbot on tomcat-7-trunk

2014-04-03 Thread buildbot
The Buildbot has detected a new failure on builder tomcat-7-trunk while building ASF Buildbot. Full details are available at: http://ci.apache.org/builders/tomcat-7-trunk/builds/1844 Buildbot URL: http://ci.apache.org/ Buildslave for this Build: bb-vm_ubuntu Build Reason: scheduler Build Sourc

[Bug 56318] Oracle DB cursors are leaking when using org.apache.tomcat.jdbc.pool.DataSourceFactory

2014-04-03 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=56318 --- Comment #14 from Danila Galimov --- The other changes are: 1) Removed catch of ClassCastException, since it shouldn't occur (And I was not able to get it actually in my tests) 2) Statement is now closed only if Statement.isClosed() retu

buildbot failure in ASF Buildbot on tomcat-trunk

2014-04-03 Thread buildbot
The Buildbot has detected a new failure on builder tomcat-trunk while building ASF Buildbot. Full details are available at: http://ci.apache.org/builders/tomcat-trunk/builds/5654 Buildbot URL: http://ci.apache.org/ Buildslave for this Build: bb-vm_ubuntu Build Reason: scheduler Build Source St

[Bug 56343] NPE in org.apache.tomcat.websocket.WsWebSocketContainer.connectToServer

2014-04-03 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=56343 Remy Maucherat changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

[Bug 56343] NPE in org.apache.tomcat.websocket.WsWebSocketContainer.connectToServer

2014-04-03 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=56343 Przemyslaw Bielicki changed: What|Removed |Added Status|RESOLVED|REOPENED Resolution|

buildbot success in ASF Buildbot on tomcat-trunk

2014-04-03 Thread buildbot
The Buildbot has detected a restored build on builder tomcat-trunk while building ASF Buildbot. Full details are available at: http://ci.apache.org/builders/tomcat-trunk/builds/5655 Buildbot URL: http://ci.apache.org/ Buildslave for this Build: bb-vm_ubuntu Build Reason: scheduler Build Source

[Bug 56336] IndexOutOfBoundsException in the AjpNio2Processor.output() method

2014-04-03 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=56336 Remy Maucherat changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

[Bug 56343] NPE in org.apache.tomcat.websocket.WsWebSocketContainer.connectToServer

2014-04-03 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=56343 --- Comment #3 from Mark Thomas --- Please provide test case (with all source code) for the simplest possible client (I'd strongly suggest the client connects to the Tomcat WebSocket echo example on localhost, port 8080 for easy testing) th

[Bug 56343] NPE in org.apache.tomcat.websocket.WsWebSocketContainer.connectToServer

2014-04-03 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=56343 --- Comment #4 from Przemyslaw Bielicki --- Created attachment 31470 --> https://issues.apache.org/bugzilla/attachment.cgi?id=31470&action=edit WsClient.java main class -- You are receiving this mail because: You are the assignee for th

[Bug 56343] NPE in org.apache.tomcat.websocket.WsWebSocketContainer.connectToServer

2014-04-03 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=56343 --- Comment #5 from Przemyslaw Bielicki --- Created attachment 31471 --> https://issues.apache.org/bugzilla/attachment.cgi?id=31471&action=edit EchoClient.java websocket client endpoint -- You are receiving this mail because: You are th

[Bug 56343] NPE in org.apache.tomcat.websocket.WsWebSocketContainer.connectToServer

2014-04-03 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=56343 --- Comment #6 from Przemyslaw Bielicki --- small tip: I'm not using tomcat-websocket-api.jar - I'm using the official javax.websocket-api-1.0.jar instead -- You are receiving this mail because: You are the assignee for the bug.

[Bug 56343] NPE in org.apache.tomcat.websocket.WsWebSocketContainer.connectToServer

2014-04-03 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=56343 --- Comment #7 from Przemyslaw Bielicki --- and I found that there are some discrepancies in ClientEndpointConfig.java between Tomcat and JSR jars. IMHO you should align Tomcat WebSocket API to match the one from JSR, to avoid such nasty e

@Deprecated setParentClassLoader(ClassLoader pcl)

2014-04-03 Thread Romain Manni-Bucau
Hi guys, just saw setParentClassLoader is deprecated on WebAppClassloader. Comment is "not used in tomcat 8". The question is: how does tomcat handle reloading. With tomcat 7.0.53 impl when reload is hit parent loader is set to null and once restarted the loader is quite broken. Does tomcat 8 ha

Re: @Deprecated setParentClassLoader(ClassLoader pcl)

2014-04-03 Thread Mark Thomas
On 03/04/2014 18:31, Romain Manni-Bucau wrote: > Hi guys, > > just saw setParentClassLoader is deprecated on WebAppClassloader. > Comment is "not used in tomcat 8". > > The question is: how does tomcat handle reloading. With tomcat 7.0.53 > impl when reload is hit parent loader is set to null and

Re: @Deprecated setParentClassLoader(ClassLoader pcl)

2014-04-03 Thread Romain Manni-Bucau
well actually can be a link with cxf. Just trying to see it ATM and just saw the behavior you describe. Will come back if I find something wrong due to tomcat otherwise just assume it was a wrong cxf setup and sorry me to have sent this mail a bit too early. Romain Manni-Bucau Twitter: @rmannibucau

[Bug 56343] NPE in org.apache.tomcat.websocket.WsWebSocketContainer.connectToServer

2014-04-03 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=56343 --- Comment #8 from Mark Thomas --- The public API for the Tomcat implementation of the Java WebSocket 1.0 API and any other implementation (inlcuding the RI) should be identical. I was checking this regularly all the way through developmen

Re: @Deprecated setParentClassLoader(ClassLoader pcl)

2014-04-03 Thread Romain Manni-Bucau
I can confirm it was a side effect of a wrong unregistration of cxf endpoints. We were having a NPE cause parent attribute was null. Would maybe be a nice enhancement to log the classloader is closed. Thanks to have confirmed the normal behavior btw. Romain Manni-Bucau Twitter: @rmannibucau Blog:

svn commit: r1584505 - in /tomcat/trunk: java/org/apache/catalina/ha/tcp/SimpleTcpCluster.java webapps/docs/changelog.xml

2014-04-03 Thread kfujino
Author: kfujino Date: Fri Apr 4 02:27:14 2014 New Revision: 1584505 URL: http://svn.apache.org/r1584505 Log: Simplify the code of o.a.c.ha.tcp.SimpleTcpCluster. In order to add or remove cluster valve to Container, use pipeline instead of IntrospectionUtils. Modified: tomcat/trunk/java/org/

svn commit: r1584507 - /tomcat/trunk/java/org/apache/catalina/ha/tcp/SimpleTcpCluster.java

2014-04-03 Thread kfujino
Author: kfujino Date: Fri Apr 4 02:38:51 2014 New Revision: 1584507 URL: http://svn.apache.org/r1584507 Log: Set null rather than this. Modified: tomcat/trunk/java/org/apache/catalina/ha/tcp/SimpleTcpCluster.java Modified: tomcat/trunk/java/org/apache/catalina/ha/tcp/SimpleTcpCluster.java U

svn commit: r1584511 - /tomcat/trunk/webapps/docs/changelog.xml

2014-04-03 Thread kfujino
Author: kfujino Date: Fri Apr 4 03:11:27 2014 New Revision: 1584511 URL: http://svn.apache.org/r1584511 Log: changelog for r1584507. Modified: tomcat/trunk/webapps/docs/changelog.xml Modified: tomcat/trunk/webapps/docs/changelog.xml URL: http://svn.apache.org/viewvc/tomcat/trunk/webapps/do

svn commit: r1584513 - in /tomcat/tc7.0.x/trunk: java/org/apache/catalina/ha/tcp/SimpleTcpCluster.java webapps/docs/changelog.xml

2014-04-03 Thread kfujino
Author: kfujino Date: Fri Apr 4 04:25:07 2014 New Revision: 1584513 URL: http://svn.apache.org/r1584513 Log: Backport r1584505 and r1584507. -Simplify the code of o.a.c.ha.tcp.SimpleTcpCluster. In order to add or remove cluster valve to Container, use pipeline instead of IntrospectionUtils. -Th

buildbot success in ASF Buildbot on tomcat-7-trunk

2014-04-03 Thread buildbot
The Buildbot has detected a restored build on builder tomcat-7-trunk while building ASF Buildbot. Full details are available at: http://ci.apache.org/builders/tomcat-7-trunk/builds/1845 Buildbot URL: http://ci.apache.org/ Buildslave for this Build: bb-vm_ubuntu Build Reason: scheduler Build So