On 22/01/2014 22:03, Rémy Maucherat wrote:
> 2014/1/22 Mark Thomas
>> I'll see what folks think of the patch so far and maybe explore the
>> entry/exit option as well.
>>
> The first patch however looks more complicated than the "dumb" way IMO.
The variation of the code that needs to be run (ret
On 23/01/2014 09:00, Mark Thomas wrote:
> On 22/01/2014 22:03, Rémy Maucherat wrote:
>> 2014/1/22 Mark Thomas
>
>>> I'll see what folks think of the patch so far and maybe explore the
>>> entry/exit option as well.
>>>
>> The first patch however looks more complicated than the "dumb" way IMO.
>
Author: markt
Date: Thu Jan 23 11:42:10 2014
New Revision: 1560645
URL: http://svn.apache.org/r1560645
Log:
Remove unused code
Modified:
tomcat/trunk/java/org/apache/catalina/ha/session/DeltaManager.java
Modified: tomcat/trunk/java/org/apache/catalina/ha/session/DeltaManager.java
URL:
http:
Author: markt
Date: Thu Jan 23 11:46:30 2014
New Revision: 1560646
URL: http://svn.apache.org/r1560646
Log:
Use try with resoucres
Modified:
tomcat/trunk/java/org/apache/catalina/ha/session/DeltaManager.java
Modified: tomcat/trunk/java/org/apache/catalina/ha/session/DeltaManager.java
URL:
h
Author: markt
Date: Thu Jan 23 12:13:48 2014
New Revision: 1560651
URL: http://svn.apache.org/r1560651
Log:
Clean-up
- Container will always be a Context
- only need one call to Thread.currentThread().getContextClassLoader()
- Fix logic hole if loader.getClassLoader() returns null
- Formatting
Author: markt
Date: Thu Jan 23 12:14:24 2014
New Revision: 1560652
URL: http://svn.apache.org/r1560652
Log:
Code clean-up
- BackupManager is an instance of ClusterManagerBase
- StandardManager is an instance of ManagerBase
Modified:
tomcat/trunk/java/org/apache/catalina/ha/session/DeltaSess
Author: markt
Date: Thu Jan 23 12:15:19 2014
New Revision: 1560653
URL: http://svn.apache.org/r1560653
Log:
Add bind()/unbind() to Context
Modified:
tomcat/trunk/java/org/apache/catalina/Context.java
tomcat/trunk/java/org/apache/catalina/core/StandardContext.java
tomcat/trunk/java/org
Author: markt
Date: Thu Jan 23 12:15:56 2014
New Revision: 1560654
URL: http://svn.apache.org/r1560654
Log:
Migrate AsyncContext to use Context bind()/unbind()
Modified:
tomcat/trunk/java/org/apache/catalina/core/AsyncContextImpl.java
tomcat/trunk/java/org/apache/catalina/security/Securit
Author: markt
Date: Thu Jan 23 12:17:00 2014
New Revision: 1560656
URL: http://svn.apache.org/r1560656
Log:
Migrate StandardHostValve to use Context bind/unbind
Modified:
tomcat/trunk/java/org/apache/catalina/core/StandardHostValve.java
Modified: tomcat/trunk/java/org/apache/catalina/core/St
Author: markt
Date: Thu Jan 23 12:16:28 2014
New Revision: 1560655
URL: http://svn.apache.org/r1560655
Log:
Add new message
Modified:
tomcat/trunk/java/org/apache/catalina/core/LocalStrings.properties
Modified: tomcat/trunk/java/org/apache/catalina/core/LocalStrings.properties
URL:
http://s
Author: markt
Date: Thu Jan 23 12:17:41 2014
New Revision: 1560659
URL: http://svn.apache.org/r1560659
Log:
More migrations to Context bind()/unbind()
Modified:
tomcat/trunk/java/org/apache/catalina/connector/CoyoteAdapter.java
tomcat/trunk/java/org/apache/catalina/core/ApplicationDispatc
Author: markt
Date: Thu Jan 23 12:18:14 2014
New Revision: 1560660
URL: http://svn.apache.org/r1560660
Log:
Migrate to Context bind()/unbind()
Modified:
tomcat/trunk/java/org/apache/catalina/session/StandardSession.java
Modified: tomcat/trunk/java/org/apache/catalina/session/StandardSession.
2014/1/23 Mark Thomas
> http://people.apache.org/~markt/dev/2014-01-23-tccl-tc8-v2.patch
>
> It was easier to write, removes more code and the result is easier to
> read. Unless there are objections I plan to commit this along with some
> additional work to migrate other code that is currently do
On 23/01/2014 12:22, Rémy Maucherat wrote:
> 2014/1/23 Mark Thomas
>
>> http://people.apache.org/~markt/dev/2014-01-23-tccl-tc8-v2.patch
>>
>> It was easier to write, removes more code and the result is easier to
>> read. Unless there are objections I plan to commit this along with some
>> additi
ApacheCon NA will be in Denver 7th to 11th April.
The schedule for ApacheCon NA 2014 has been firmed up. There is an
opportunity for a project summit on either the Thursday or the Friday.
Since the BarCamp has been scheduled for the Thursday the Friday seems
like the better option.
We have comple
Author: remm
Date: Thu Jan 23 14:42:21 2014
New Revision: 1560702
URL: http://svn.apache.org/r1560702
Log:
- Call onClose before actually closing anything (sending a close message closes
the endpoint).
- If onClose throws an exception, call onError.
- After using a blocking send, clear the client
On 23/01/2014 14:42, r...@apache.org wrote:
> Author: remm
> Date: Thu Jan 23 14:42:21 2014
> New Revision: 1560702
>
> URL: http://svn.apache.org/r1560702
> Log:
> - Call onClose before actually closing anything (sending a close message
> closes the endpoint).
-1 (veto) for a specification viol
Author: remm
Date: Thu Jan 23 14:59:45 2014
New Revision: 1560704
URL: http://svn.apache.org/r1560704
Log:
Revert: Call onClose before actually closing anything (sending a close message
closes the endpoint).
Modified:
tomcat/trunk/java/org/apache/tomcat/websocket/WsSession.java
Modified: to
2014/1/23 Mark Thomas
> > - Call onClose before actually closing anything (sending a close message
> closes the endpoint).
>
> -1 (veto) for a specification violation
>
> Section 2.1.5 requires that:
> "the implementation must attempt to send the websocket close frame prior
> to calling the onClo
On 23/01/2014 15:01, Rémy Maucherat wrote:
> 2014/1/23 Mark Thomas
>
>>> - Call onClose before actually closing anything (sending a close message
>> closes the endpoint).
>>
>> -1 (veto) for a specification violation
>>
>> Section 2.1.5 requires that:
>> "the implementation must attempt to send t
The Buildbot has detected a new failure on builder tomcat-trunk while building
ASF Buildbot.
Full details are available at:
http://ci.apache.org/builders/tomcat-trunk/builds/5430
Buildbot URL: http://ci.apache.org/
Buildslave for this Build: bb-vm_ubuntu
Build Reason: scheduler
Build Source St
https://issues.apache.org/bugzilla/show_bug.cgi?id=56056
Bug ID: 56056
Summary: Tomcat fail to redeploy application, when webapps is
on NFS file system
Product: Tomcat 7
Version: 7.0.42
Hardware: All
OS: BeO
2014/1/23 Mark Thomas
> I'd need to go back and check the archives but the I think the
> expectation from the EG was that onClose() would be used to clean up
> resources rather than anything else.
>
> It is always possible that I have misunderstood the intention of the
> spec here but it looks to
Author: markt
Date: Thu Jan 23 15:59:48 2014
New Revision: 1560717
URL: http://svn.apache.org/r1560717
Log:
No need to load classes that have been deleted.
Modified:
tomcat/trunk/java/org/apache/catalina/security/SecurityClassLoad.java
Modified: tomcat/trunk/java/org/apache/catalina/security
Folks,
I'd really like to tag 6.0.x today or tomorrow. The remaining issue in
the status file needs one more vote. If any committer has the time to
review that patch and vote that would be great.
Thanks,
Mark
-
To unsubscribe,
Author: markt
Date: Thu Jan 23 17:33:42 2014
New Revision: 1560764
URL: http://svn.apache.org/r1560764
Log:
Make the HTTP NIO connector tolerant of whitespace in the individual alues used
for the ciphers attribute.
Modified:
tomcat/tc6.0.x/trunk/STATUS.txt
tomcat/tc6.0.x/trunk/java/org/a
Author: remm
Date: Thu Jan 23 17:53:11 2014
New Revision: 1560769
URL: http://svn.apache.org/r1560769
Log:
Vote.
Modified:
tomcat/tc6.0.x/trunk/STATUS.txt
Modified: tomcat/tc6.0.x/trunk/STATUS.txt
URL:
http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=1560769&r1=1560768&r2=15
The Buildbot has detected a restored build on builder tomcat-trunk while
building ASF Buildbot.
Full details are available at:
http://ci.apache.org/builders/tomcat-trunk/builds/5432
Buildbot URL: http://ci.apache.org/
Buildslave for this Build: bb-vm_ubuntu
Build Reason: scheduler
Build Source
https://issues.apache.org/bugzilla/show_bug.cgi?id=56045
--- Comment #1 from Konstantin Kolinko ---
You do not need Jasper, but you need the JSP APIs - the "jsp-api.jar" file.
1. The common XML Schema for the Servlet 3.0 deployment descriptor does depend
on the XML Schema for the JSP 2.2 deploym
Author: markt
Date: Thu Jan 23 18:59:51 2014
New Revision: 1560784
URL: http://svn.apache.org/r1560784
Log:
Remove unused code
Modified:
tomcat/trunk/java/org/apache/tomcat/util/net/AbstractEndpoint.java
Modified: tomcat/trunk/java/org/apache/tomcat/util/net/AbstractEndpoint.java
URL:
http:
Author: markt
Date: Thu Jan 23 19:01:26 2014
New Revision: 1560785
URL: http://svn.apache.org/r1560785
Log:
Remove unused code
Modified:
tomcat/tc7.0.x/trunk/ (props changed)
tomcat/tc7.0.x/trunk/java/org/apache/tomcat/util/net/AbstractEndpoint.java
Propchange: tomcat/tc7.0.x/trunk/
--
2014/1/23 Mark Thomas :
> Folks,
>
> I'd really like to tag 6.0.x today or tomorrow. The remaining issue in
> the status file needs one more vote. If any committer has the time to
> review that patch and vote that would be great.
>
Regarding NPEs in forId().
(An example:
https://issues.apache.org/
https://issues.apache.org/bugzilla/show_bug.cgi?id=56056
Mark Thomas changed:
What|Removed |Added
Status|NEW |RESOLVED
Resolution|---
https://issues.apache.org/bugzilla/show_bug.cgi?id=56045
--- Comment #2 from Dave Syer ---
Good to know that jasper is a sufficient but not necessary dependency, but that
doesn't really help if you don't want anything to do with JSPs.
I did raise this issue specifically against Tomcat 7. It's a
Author: markt
Date: Thu Jan 23 21:22:48 2014
New Revision: 1560810
URL: http://svn.apache.org/r1560810
Log:
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=56039
Enable JmxRemoteLifecycleListener to work with SSL.
Patch by esengstrom.
Modified:
tomcat/trunk/java/org/apache/catalina/mbe
Author: markt
Date: Thu Jan 23 21:25:27 2014
New Revision: 1560812
URL: http://svn.apache.org/r1560812
Log:
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=56039
Enable JmxRemoteLifecycleListener to work with SSL.
Patch by esengstrom.
Modified:
tomcat/tc7.0.x/trunk/ (props changed)
https://issues.apache.org/bugzilla/show_bug.cgi?id=56039
Mark Thomas changed:
What|Removed |Added
Status|NEW |RESOLVED
Resolution|---
Author: remm
Date: Thu Jan 23 21:37:42 2014
New Revision: 1560817
URL: http://svn.apache.org/r1560817
Log:
Fix some arcane introspection errors.
Modified:
tomcat/trunk/java/org/apache/tomcat/websocket/pojo/PojoMessageHandlerBase.java
Modified:
tomcat/trunk/java/org/apache/tomcat/websocket/
On 23/01/2014 21:37, r...@apache.org wrote:
> Author: remm
> Date: Thu Jan 23 21:37:42 2014
> New Revision: 1560817
>
> URL: http://svn.apache.org/r1560817
> Log:
> Fix some arcane introspection errors.
Could you explain what problem this is trying to fix. The method passed
in to this constructor
Author: markt
Date: Thu Jan 23 21:51:15 2014
New Revision: 1560823
URL: http://svn.apache.org/r1560823
Log:
Proposal
Modified:
tomcat/tc6.0.x/trunk/STATUS.txt
Modified: tomcat/tc6.0.x/trunk/STATUS.txt
URL:
http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=1560823&r1=1560822&r
On 23/01/2014 19:05, Konstantin Kolinko wrote:
> I think the following need a fix before tagging:
>
> 1. I think the Maven POM file for the jar that contains
> "org.apache.tomcat.util.descriptor.DigesterFactory" (coyote.jar in
> TC6 maven libs, tomcat-util.jar in Tomcat 7) needs dependency on
>
https://issues.apache.org/bugzilla/show_bug.cgi?id=56029
Mark Thomas changed:
What|Removed |Added
Status|NEW |RESOLVED
Resolution|---
Author: markt
Date: Thu Jan 23 21:52:38 2014
New Revision: 1560824
URL: http://svn.apache.org/r1560824
Log:
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=56029
Regression in fix for BZ55198 broke parsing of some ternary expressions
Align tc6 implementation with that of trunk (diff to trun
Author: kkolinko
Date: Thu Jan 23 22:26:02 2014
New Revision: 1560829
URL: http://svn.apache.org/r1560829
Log:
vote and proposal
Modified:
tomcat/tc6.0.x/trunk/STATUS.txt
Modified: tomcat/tc6.0.x/trunk/STATUS.txt
URL:
http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=1560829&
Author: kkolinko
Date: Thu Jan 23 22:21:51 2014
New Revision: 1560828
URL: http://svn.apache.org/r1560828
Log:
CTR: docs
Correction: The "release" target in dist.xml of Tomcat 6 does not run the tests.
Modified:
tomcat/tc6.0.x/trunk/BUILDING.txt
Modified: tomcat/tc6.0.x/trunk/BUILDING.txt
UR
Author: markt
Date: Thu Jan 23 22:43:27 2014
New Revision: 1560838
URL: http://svn.apache.org/r1560838
Log:
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=56042
If a request in async mode has an error but has already been dispatched don't
generate an error page in the ErrorReportValve so
Author: markt
Date: Thu Jan 23 22:45:19 2014
New Revision: 1560839
URL: http://svn.apache.org/r1560839
Log:
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=56042
If a request in async mode has an error but has already been dispatched don't
generate an error page in the ErrorReportValve so
https://issues.apache.org/bugzilla/show_bug.cgi?id=56042
--- Comment #2 from Mark Thomas ---
Fixed in 8.0.x for 8.0.0 and 7.0.x for 7.0.51.
--
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubsc
https://issues.apache.org/bugzilla/show_bug.cgi?id=56042
Mark Thomas changed:
What|Removed |Added
Status|NEW |RESOLVED
Resolution|---
https://issues.apache.org/bugzilla/show_bug.cgi?id=56058
Bug ID: 56058
Summary: AccessLogValve Local IP/port inconsistent
Product: Tomcat 6
Version: unspecified
Hardware: PC
OS: Linux
Status: NEW
Severity:
Author: markt
Date: Thu Jan 23 23:26:44 2014
New Revision: 1560850
URL: http://svn.apache.org/r1560850
Log:
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=56044
Separate out the EL and WebSocket implementations into separate JARs for
embedded.
Added:
tomcat/trunk/res/maven/tomcat-emb
Author: markt
Date: Thu Jan 23 23:36:14 2014
New Revision: 1560852
URL: http://svn.apache.org/r1560852
Log:
Vote
Modified:
tomcat/tc6.0.x/trunk/STATUS.txt
Modified: tomcat/tc6.0.x/trunk/STATUS.txt
URL:
http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=1560852&r1=1560851&r2=15
https://issues.apache.org/bugzilla/show_bug.cgi?id=56044
--- Comment #1 from Mark Thomas ---
I think I have fixed in this in 8.0.x. I have deployed a new 8.0.0 snapshot. If
you could test that and confirm that the issue is fixed that would be great.
--
You are receiving this mail because:
You a
The Buildbot has detected a new failure on builder tomcat-trunk while building
ASF Buildbot.
Full details are available at:
http://ci.apache.org/builders/tomcat-trunk/builds/5434
Buildbot URL: http://ci.apache.org/
Buildslave for this Build: bb-vm_ubuntu
Build Reason: scheduler
Build Source St
Author: kkolinko
Date: Thu Jan 23 23:46:56 2014
New Revision: 1560855
URL: http://svn.apache.org/r1560855
Log:
proposal
Modified:
tomcat/tc6.0.x/trunk/STATUS.txt
Modified: tomcat/tc6.0.x/trunk/STATUS.txt
URL:
http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=1560855&r1=156085
Author: kkolinko
Date: Fri Jan 24 00:23:47 2014
New Revision: 1560856
URL: http://svn.apache.org/r1560856
Log:
Replace mailing lists links so that they point to the Mailng List page on the
site,
so that people have a chance to read instructions there
Modified:
tomcat/trunk/webapps/ROOT/index
Author: kkolinko
Date: Fri Jan 24 00:33:12 2014
New Revision: 1560857
URL: http://svn.apache.org/r1560857
Log:
Merged r1560856 from tomcat/trunk:
Replace mailing lists links so that they point to the Mailing List page on the
site,
so that people have a chance to read instructions there
Modified:
Author: kkolinko
Date: Fri Jan 24 00:47:01 2014
New Revision: 1560858
URL: http://svn.apache.org/r1560858
Log:
Align EL variables names with trunk
s/tomcat7/tomcat/
This is merge of r1520273 minus s/7/8/ change.
Modified:
tomcat/tc7.0.x/trunk/ (props changed)
tomcat/tc7.0.x/trunk/weba
Author: kkolinko
Date: Fri Jan 24 00:56:49 2014
New Revision: 1560861
URL: http://svn.apache.org/r1560861
Log:
CTR: whitespaces (and duplicate nbsp whitespace) and comment removal,
to align index.jsp and index.html pages.
Modified:
tomcat/tc6.0.x/trunk/webapps/ROOT/index.html
tomcat/tc6.0
https://issues.apache.org/bugzilla/show_bug.cgi?id=56056
--- Comment #2 from Yair Lenga ---
Mark,
Thank for your feedback. I do not believe that the suggested alternatives
address the problem with NFS removals. The issue is not a tomcat problem
problem, it is just the way Nfs works. The temporar
Author: kkolinko
Date: Fri Jan 24 01:05:58 2014
New Revision: 1560865
URL: http://svn.apache.org/r1560865
Log:
CTR: tabs -> spaces
Modified:
tomcat/tc6.0.x/trunk/webapps/ROOT/index.html
tomcat/tc6.0.x/trunk/webapps/ROOT/index.jsp
Modified: tomcat/tc6.0.x/trunk/webapps/ROOT/index.html
URL
https://issues.apache.org/bugzilla/show_bug.cgi?id=56056
--- Comment #3 from Konstantin Kolinko ---
(In reply to Yair Lenga from comment #0)
> This is usually result of some
> process the file open (can be a thread in the application, leaked resources,
> or a user on any machine that can view/ins
The Buildbot has detected a restored build on builder tomcat-trunk while
building ASF Buildbot.
Full details are available at:
http://ci.apache.org/builders/tomcat-trunk/builds/5435
Buildbot URL: http://ci.apache.org/
Buildslave for this Build: bb-vm_ubuntu
Build Reason: scheduler
Build Source
Author: kkolinko
Date: Fri Jan 24 01:42:04 2014
New Revision: 1560878
URL: http://svn.apache.org/r1560878
Log:
proposal
Modified:
tomcat/tc6.0.x/trunk/STATUS.txt
Modified: tomcat/tc6.0.x/trunk/STATUS.txt
URL:
http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=1560878&r1=156087
Hi!
If you run tests with Cobertura 2.0.3 being enabled, it prints a
warning that it cannot parse the source code of ServiceProxy class:
It can be seen in Buildbot logs.
[cobertura-report] WARN getAccumlatedCCNForSource, JavaNCSS got an
error while parsing the java file
/home/buildslave3/slave
Author: kkolinko
Date: Fri Jan 24 02:45:17 2014
New Revision: 1560893
URL: http://svn.apache.org/r1560893
Log:
proposal
Modified:
tomcat/tc6.0.x/trunk/STATUS.txt
Modified: tomcat/tc6.0.x/trunk/STATUS.txt
URL:
http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=1560893&r1=156089
Author: kkolinko
Date: Fri Jan 24 03:23:06 2014
New Revision: 1560895
URL: http://svn.apache.org/r1560895
Log:
CTR: javadoc fix
Modified:
tomcat/tc6.0.x/trunk/java/org/apache/catalina/ant/jmx/JMXAccessorCreateTask.java
Modified:
tomcat/tc6.0.x/trunk/java/org/apache/catalina/ant/jmx/JMXAcce
Author: kkolinko
Date: Fri Jan 24 03:25:48 2014
New Revision: 1560896
URL: http://svn.apache.org/r1560896
Log:
CTR: javadoc fixes
Modified:
tomcat/tc6.0.x/trunk/java/org/apache/catalina/authenticator/FormAuthenticator.java
Modified:
tomcat/tc6.0.x/trunk/java/org/apache/catalina/authenticat
The Buildbot has detected a new failure on builder tomcat-trunk while building
ASF Buildbot.
Full details are available at:
http://ci.apache.org/builders/tomcat-trunk/builds/5436
Buildbot URL: http://ci.apache.org/
Buildslave for this Build: bb-vm_ubuntu
Build Reason: scheduler
Build Source St
Author: kkolinko
Date: Fri Jan 24 03:55:17 2014
New Revision: 1560897
URL: http://svn.apache.org/r1560897
Log:
CTR: javadoc fixes
Modified:
tomcat/tc6.0.x/trunk/java/org/apache/catalina/connector/Request.java
tomcat/tc6.0.x/trunk/java/org/apache/catalina/core/StandardContext.java
tomc
Author: kkolinko
Date: Fri Jan 24 04:13:02 2014
New Revision: 1560898
URL: http://svn.apache.org/r1560898
Log:
CTR: javadoc fixes
Modified:
tomcat/tc6.0.x/trunk/java/org/apache/catalina/ha/session/DeltaRequest.java
tomcat/tc6.0.x/trunk/java/org/apache/catalina/ha/tcp/ReplicationValve.java
https://issues.apache.org/bugzilla/show_bug.cgi?id=56050
Alex Panchenko changed:
What|Removed |Added
Status|NEEDINFO|RESOLVED
Resolution|---
https://issues.apache.org/bugzilla/show_bug.cgi?id=56056
--- Comment #4 from Mark Thomas ---
I'll happily re-open this if you explain how parallel deployment doesn't solve
this problem. If you use parallel deployment:
- you can deploy a new version before deleting the old one
- new users will be
73 matches
Mail list logo
