svn commit: r1537835 - /tomcat/trunk/java/org/apache/catalina/startup/ContextConfig.java

2013-11-01 Thread violetagg
Author: violetagg Date: Fri Nov 1 07:00:56 2013 New Revision: 1537835 URL: http://svn.apache.org/r1537835 Log: Close the stream after using it. Modified: tomcat/trunk/java/org/apache/catalina/startup/ContextConfig.java Modified: tomcat/trunk/java/org/apache/catalina/startup/ContextConfig.ja

svn commit: r1537846 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/catalina/startup/ContextConfig.java webapps/docs/changelog.xml

2013-11-01 Thread violetagg
Author: violetagg Date: Fri Nov 1 07:46:57 2013 New Revision: 1537846 URL: http://svn.apache.org/r1537846 Log: Merged revision 1537835 from tomcat/trunk: Close the stream after using it. Modified: tomcat/tc7.0.x/trunk/ (props changed) tomcat/tc7.0.x/trunk/java/org/apache/catalina/start

[Bug 52323] Cobertura test code coverage support for build.xml and build.properties.default

2013-11-01 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=52323 Mark Thomas changed: What|Removed |Added Attachment #28069|0 |1 is patch|

[Bug 52323] Cobertura test code coverage support for build.xml and build.properties.default

2013-11-01 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=52323 --- Comment #2 from Mark Thomas --- Just tried to enable Cobertura with Tomcat 8 trunk and the tests fail consistently with NPE's in the instrumented code. Absent a working patch for this with Tomncat 8, this issue is eventually going to be

[jira] [Updated] (MTOMCAT-222) No (documented) way to tolerate server cert whose CN doesn't match DNS hostname

2013-11-01 Thread *$^¨%`£
[ https://issues.apache.org/jira/browse/MTOMCAT-222?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Olivier Lamy (*$^¨%`£) updated MTOMCAT-222: --- Fix Version/s: backlog > No (documented) way to tolerate server cert whose C

[jira] [Updated] (MTOMCAT-221) Deploy fails if server requires client-auth

2013-11-01 Thread *$^¨%`£
[ https://issues.apache.org/jira/browse/MTOMCAT-221?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Olivier Lamy (*$^¨%`£) updated MTOMCAT-221: --- Fix Version/s: backlog > Deploy fails if server requires client-auth > -

[jira] [Updated] (MTOMCAT-230) CLONE - Plugin uploads WAR file twice

2013-11-01 Thread *$^¨%`£
[ https://issues.apache.org/jira/browse/MTOMCAT-230?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Olivier Lamy (*$^¨%`£) updated MTOMCAT-230: --- Fix Version/s: backlog > CLONE - Plugin uploads WAR file twice > ---

[jira] [Updated] (MTOMCAT-232) Mapping webapps to "/" does not work

2013-11-01 Thread *$^¨%`£
[ https://issues.apache.org/jira/browse/MTOMCAT-232?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Olivier Lamy (*$^¨%`£) updated MTOMCAT-232: --- Fix Version/s: moreinfo please provide a sample project as I cannot reproduc

[jira] [Updated] (MTOMCAT-177) tomcat7:deploy ignores proxy settings

2013-11-01 Thread *$^¨%`£
[ https://issues.apache.org/jira/browse/MTOMCAT-177?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Olivier Lamy (*$^¨%`£) updated MTOMCAT-177: --- Fix Version/s: moreinfo > tomcat7:deploy ignores proxy settings > --

[jira] [Commented] (MTOMCAT-178) additionalClasspathDirs doesn't seem to be used

2013-11-01 Thread *$^¨%`£
[ https://issues.apache.org/jira/browse/MTOMCAT-178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13811162#comment-13811162 ] Olivier Lamy (*$^¨%`£) commented on MTOMCAT-178: ${project.build.director

[jira] [Updated] (MTOMCAT-178) additionalClasspathDirs doesn't seem to be used

2013-11-01 Thread *$^¨%`£
[ https://issues.apache.org/jira/browse/MTOMCAT-178?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Olivier Lamy (*$^¨%`£) updated MTOMCAT-178: --- Fix Version/s: moreinfo > additionalClasspathDirs doesn't seem to be used >

[jira] [Comment Edited] (MTOMCAT-178) additionalClasspathDirs doesn't seem to be used

2013-11-01 Thread *$^¨%`£
[ https://issues.apache.org/jira/browse/MTOMCAT-178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13811162#comment-13811162 ] Olivier Lamy (*$^¨%`£) edited comment on MTOMCAT-178 at 11/1/13 10:39 AM: -

[jira] [Updated] (MTOMCAT-161) Executable WAR: extraDependencies (JARs) should not be extracted but used directly

2013-11-01 Thread *$^¨%`£
[ https://issues.apache.org/jira/browse/MTOMCAT-161?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Olivier Lamy (*$^¨%`£) updated MTOMCAT-161: --- Fix Version/s: 2.2 > Executable WAR: extraDependencies (JARs) should not be

[jira] [Updated] (MTOMCAT-241) Documentation needed for config element

2013-11-01 Thread *$^¨%`£
[ https://issues.apache.org/jira/browse/MTOMCAT-241?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Olivier Lamy (*$^¨%`£) updated MTOMCAT-241: --- Fix Version/s: 2.2 > Documentation needed for config element >

svn commit: r1537893 - /tomcat/maven-plugin/trunk/tomcat7-maven-plugin/src/main/java/org/apache/tomcat/maven/plugin/tomcat7/run/AbstractRunMojo.java

2013-11-01 Thread olamy
Author: olamy Date: Fri Nov 1 10:46:49 2013 New Revision: 1537893 URL: http://svn.apache.org/r1537893 Log: [MTOMCAT-241] Documentation needed for config element Submitted by Neale Upstone. Modified: tomcat/maven-plugin/trunk/tomcat7-maven-plugin/src/main/java/org/apache/tomcat/maven/plugin

[jira] [Closed] (MTOMCAT-241) Documentation needed for config element

2013-11-01 Thread *$^¨%`£
[ https://issues.apache.org/jira/browse/MTOMCAT-241?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Olivier Lamy (*$^¨%`£) closed MTOMCAT-241. -- Resolution: Fixed > Documentation needed for config element > ---

[jira] [Updated] (MTOMCAT-237) Maven variables not evaluated/resolved inside systemProperties

2013-11-01 Thread *$^¨%`£
[ https://issues.apache.org/jira/browse/MTOMCAT-237?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Olivier Lamy (*$^¨%`£) updated MTOMCAT-237: --- Fix Version/s: moreinfo > Maven variables not evaluated/resolved inside syst

[jira] [Updated] (MTOMCAT-238) Parameter staticContextDocbase cant be used

2013-11-01 Thread *$^¨%`£
[ https://issues.apache.org/jira/browse/MTOMCAT-238?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Olivier Lamy (*$^¨%`£) updated MTOMCAT-238: --- Fix Version/s: moreinfo > Parameter staticContextDocbase cant be used >

[jira] [Commented] (MTOMCAT-238) Parameter staticContextDocbase cant be used

2013-11-01 Thread *$^¨%`£
[ https://issues.apache.org/jira/browse/MTOMCAT-238?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13811169#comment-13811169 ] Olivier Lamy (*$^¨%`£) commented on MTOMCAT-238: test project please. >

[jira] [Updated] (MTOMCAT-235) War file is being uploaded twice - Cookie rejected

2013-11-01 Thread *$^¨%`£
[ https://issues.apache.org/jira/browse/MTOMCAT-235?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Olivier Lamy (*$^¨%`£) updated MTOMCAT-235: --- Labels: moreinfo (was: ) > War file is being uploaded twice - Cookie rejec

[jira] [Commented] (MTOMCAT-235) War file is being uploaded twice - Cookie rejected

2013-11-01 Thread *$^¨%`£
[ https://issues.apache.org/jira/browse/MTOMCAT-235?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13811171#comment-13811171 ] Olivier Lamy (*$^¨%`£) commented on MTOMCAT-235: Because of RewriteRule

[jira] [Updated] (MTOMCAT-235) War file is being uploaded twice - Cookie rejected

2013-11-01 Thread *$^¨%`£
[ https://issues.apache.org/jira/browse/MTOMCAT-235?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Olivier Lamy (*$^¨%`£) updated MTOMCAT-235: --- Fix Version/s: moreinfo > War file is being uploaded twice - Cookie rejecte

[jira] [Updated] (MTOMCAT-233) 404 links at http://tomcat.apache.org/maven-plugin-2.0/modules.html

2013-11-01 Thread *$^¨%`£
[ https://issues.apache.org/jira/browse/MTOMCAT-233?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Olivier Lamy (*$^¨%`£) updated MTOMCAT-233: --- Fix Version/s: 2.2 > 404 links at http://tomcat.apache.org/maven-plugin-2.0/

svn commit: r1537902 - /tomcat/trunk/java/javax/servlet/http/Part.java

2013-11-01 Thread kkolinko
Author: kkolinko Date: Fri Nov 1 11:30:26 2013 New Revision: 1537902 URL: http://svn.apache.org/r1537902 Log: Add @since comment for method Part.getSubmittedFileName() that was added in Servlet 3.1. Modified: tomcat/trunk/java/javax/servlet/http/Part.java Modified: tomcat/trunk/java/javax/

[jira] [Commented] (MTOMCAT-241) Documentation needed for config element

2013-11-01 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/MTOMCAT-241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13811186#comment-13811186 ] Hudson commented on MTOMCAT-241: SUCCESS: Integrated in TomcatMavenPlugin-mvn3.x #262 (Se

Tomcat 8 plans

2013-11-01 Thread Mark Thomas
Now 8.0.0-RC5 is out and the WebSocket implementation seems to be fairly stable, I plan to start work on the next stage of the resources refactoring which will focus on the class loader. The rough outline of what I plan to do is: - Add methods that only return class loader resources (i.e. anything

svn commit: r1537920 - /tomcat/trunk/java/org/apache/catalina/loader/WebappClassLoader.java

2013-11-01 Thread markt
Author: markt Date: Fri Nov 1 12:55:01 2013 New Revision: 1537920 URL: http://svn.apache.org/r1537920 Log: Fix indent Modified: tomcat/trunk/java/org/apache/catalina/loader/WebappClassLoader.java Modified: tomcat/trunk/java/org/apache/catalina/loader/WebappClassLoader.java URL: http://svn.

svn commit: r1537921 - /tomcat/trunk/java/org/apache/catalina/loader/WebappClassLoader.java

2013-11-01 Thread markt
Author: markt Date: Fri Nov 1 12:55:40 2013 New Revision: 1537921 URL: http://svn.apache.org/r1537921 Log: Remove option to set repository path. It will always be /WEB-INF/classes Additional resources can be mapped to /WEB-INF/classes via the new resources implementation. Modified: tomcat/tr

svn commit: r1537923 - in /tomcat/trunk/java/org/apache/catalina/loader: WebappClassLoader.java WebappLoader.java

2013-11-01 Thread markt
Author: markt Date: Fri Nov 1 12:56:13 2013 New Revision: 1537923 URL: http://svn.apache.org/r1537923 Log: Remove the repository Modified: tomcat/trunk/java/org/apache/catalina/loader/WebappClassLoader.java tomcat/trunk/java/org/apache/catalina/loader/WebappLoader.java Modified: tomcat/

Subject: Questions on Jasper's BodyContentImpl, bug #43925, and proposed solution

2013-11-01 Thread Scott Severtson
All, We've noticed that our Tomcat 6.0.37 instances have increasing overhead the longer they stay up. We've captured some heap dumps, expecting to find memory leaks within our code, but found something different instead. Jasper's BodyContentImpl is actually holding most of the non-collectible

[jira] [Commented] (MTOMCAT-161) Executable WAR: extraDependencies (JARs) should not be extracted but used directly

2013-11-01 Thread Tim Astle (JIRA)
[ https://issues.apache.org/jira/browse/MTOMCAT-161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13811290#comment-13811290 ] Tim Astle commented on MTOMCAT-161: --- That sounds similar to something I've observed aft

[Bug 55734] New: Manager using absolute URLs

2013-11-01 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=55734 Bug ID: 55734 Summary: Manager using absolute URLs Product: Tomcat 7 Version: 7.0.42 Hardware: PC OS: Linux Status: NEW Severity: normal P

[Bug 55734] Manager using absolute URLs

2013-11-01 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=55734 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

[Bug 55734] Manager using absolute URLs

2013-11-01 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=55734 --- Comment #2 from Milo Hyson --- Why is it the admin's responsibility? The developer initiated the mess by making a faulty assumption. -- You are receiving this mail because: You are the assignee for the bug. --

[Bug 55734] Manager using absolute URLs

2013-11-01 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=55734 --- Comment #3 from Mark Thomas --- The developer is doing exactly what they should do - using request.getContextPath() to correctly construct the URL. The breakage occurs in the proxy because the proxy is changing the path and the applica

[Bug 55734] Manager using absolute URLs

2013-11-01 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=55734 --- Comment #4 from Milo Hyson --- Having reviewed the source I think I see the problem. As a general rule, developers should NOT be using request.getContextPath() as you suggest. That just binds application content to a deployment-time con

[Bug 55734] Manager using absolute URLs

2013-11-01 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=55734 --- Comment #5 from Mark Thomas --- The Manager app is certainly not a model application in many respects but it does get the handling of the context path right. Consider session cookies. The application is required to set the cookie path.

[Bug 55734] Manager using absolute URLs

2013-11-01 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=55734 --- Comment #6 from Milo Hyson --- Cookies and redirects are easy with the directives provided by mod_proxy. At issue is HTML content. I see no reason why an application should, as a matter of general practice, bake the context-path into in

[Bug 55734] Manager using absolute URLs

2013-11-01 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=55734 --- Comment #7 from Christopher Schultz --- (In reply to Milo Hyson from comment #4) > As a general rule, developers should NOT be using request.getContextPath() as > you suggest. I disagree. Relative links fail in all sorts of bad ways,

[Bug 55734] Manager using absolute URLs

2013-11-01 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=55734 --- Comment #8 from Milo Hyson --- (In reply to Christopher Schultz from comment #7) > Relative links fail in all sorts of bad ways ... Maybe I've just been lucky, but I've been using relative links in applications for years with no issue.

svn commit: r1538084 - /tomcat/trunk/test/org/apache/tomcat/websocket/TesterConnectionLimit.java

2013-11-01 Thread markt
Author: markt Date: Fri Nov 1 23:17:16 2013 New Revision: 1538084 URL: http://svn.apache.org/r1538084 Log: Simple test to see how many outgoing connections can be created on a single machine. Added: tomcat/trunk/test/org/apache/tomcat/websocket/TesterConnectionLimit.java (with props) Ad

[Bug 55734] Manager using absolute URLs

2013-11-01 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=55734 --- Comment #9 from Chuck Caldarale --- (In reply to Milo Hyson from comment #8) > Maybe I've just been lucky, but I've been using relative links in > applications for years with no issue. Can you elaborate on these bad ways? Here's a star

[Bug 55734] Manager using absolute URLs

2013-11-01 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=55734 --- Comment #10 from Milo Hyson --- I came across that same article when I Googled the issue. The problem is it seems to be describing generally bad practices that are not specific to the use of relative URLs. -- You are receiving this ma

[Bug 55735] New: Additional quote entity in html element attribute evaluated in tagx if attribute contains EL expression

2013-11-01 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=55735 Bug ID: 55735 Summary: Additional quote entity in html element attribute evaluated in tagx if attribute contains EL expression Product: Tomcat 7 Version: 7.0.47 Hardw