2013/7/16
>
> Author: markt
> Date: Tue Jul 16 20:01:47 2013
> New Revision: 1503857
>
> URL: http://svn.apache.org/r1503857
> Log:
> Fix handling of nested lambda expressions with method parameters.
>
> Removed:
>
tomcat/trunk/java/org/apache/el/parser/AstLambdaExpressionOrInvocation.java
> Modif
Violeta Georgieva wrote:
>Having the example from the test:
>(x->y->x-y)(2)(1)
>
>We may transform it like this:
>(()->y->2-y)()(1)
>
>So instead of returning right way when formalParameters.isEmpty()
>
>Shouldn't we have something like the one below in order to continue
>evaluation of the nested
On 07/16/2013 11:42 PM, Christopher Schultz wrote:
All,
While doing the trivial fix for
https://issues.apache.org/bugzilla/show_bug.cgi?id=55268, I noticed a
few idioms being used in bin/daemon.sh that struck me as odd. For example:
while [ ".$1" != . ]
do
case "$1" in
--java-home )
Author: markt
Date: Wed Jul 17 13:24:09 2013
New Revision: 1504123
URL: http://svn.apache.org/r1504123
Log:
Further improve handling of nested lambda expressions.
Modified:
tomcat/trunk/java/org/apache/el/Messages.properties
tomcat/trunk/java/org/apache/el/parser/AstLambdaExpression.java
Author: markt
Date: Wed Jul 17 13:24:30 2013
New Revision: 1504124
URL: http://svn.apache.org/r1504124
Log:
Whitespace police
Modified:
tomcat/trunk/webapps/docs/config/systemprops.xml
Modified: tomcat/trunk/webapps/docs/config/systemprops.xml
URL:
http://svn.apache.org/viewvc/tomcat/trunk/
Author: markt
Date: Wed Jul 17 13:28:25 2013
New Revision: 1504127
URL: http://svn.apache.org/r1504127
Log:
Provide messages with exceptions
Modified:
tomcat/trunk/java/org/apache/el/Messages.properties
tomcat/trunk/java/org/apache/el/stream/Optional.java
tomcat/trunk/java/org/apache/
On 17/07/2013 12:43, Mark Thomas wrote:
> Violeta Georgieva wrote:
>
>> Having the example from the test:
>> (x->y->x-y)(2)(1)
>>
>> We may transform it like this:
>> (()->y->2-y)()(1)
>>
>> So instead of returning right way when formalParameters.isEmpty()
>>
>> Shouldn't we have something like t
On 17 July 2013 12:59, Mladen Turk wrote:
> On 07/16/2013 11:42 PM, Christopher Schultz wrote:
>>
>> All,
>>
>> While doing the trivial fix for
>> https://issues.apache.org/bugzilla/show_bug.cgi?id=55268, I noticed a
>> few idioms being used in bin/daemon.sh that struck me as odd. For example:
>>
Author: markt
Date: Wed Jul 17 14:14:28 2013
New Revision: 1504148
URL: http://svn.apache.org/r1504148
Log:
Add the two new resolver types (stream and static) to Jasper in the correct
order and modify JasperELResolver so the correct resolvers are skipped.
Modified:
tomcat/trunk/java/org/apac
On Jul 17, 2013, at 9:21 AM, Caldarale, Charles R wrote:
>> From: ma...@apache.org [mailto:ma...@apache.org]
>> Subject: svn commit: r1504148
>
>> URL: http://svn.apache.org/r1504148
>> Log:
>> Add the two new resolver types (stream and static) to Jasper in the correct
>> order and modify Jasp
On 17/07/2013 15:21, Caldarale, Charles R wrote:
>> From: ma...@apache.org [mailto:ma...@apache.org] Subject: svn
>> commit: r1504148
>
>> URL: http://svn.apache.org/r1504148 Log: Add the two new resolver
>> types (stream and static) to Jasper in the correct order and modify
>> JasperELResolver so
> From: Nick Williams [mailto:nicho...@nicholaswilliams.net]
> Subject: Re: svn commit: r1504148
> I read "so the correct resolvers are skipped" as "so the resolvers
> that should be skipped are skipped."
That interpretation makes much more sense. I think the use of the word
"correct" twice i
Author: markt
Date: Wed Jul 17 14:32:00 2013
New Revision: 1504153
URL: http://svn.apache.org/r1504153
Log:
Add unit tests that check (very basically) that the new EL syntax works in a
JSP. There are single tests for lambda expressions, streams and imports.
TODO: Figure out why the import test cu
> From: ma...@apache.org [mailto:ma...@apache.org]
> Subject: svn commit: r1504148
> URL: http://svn.apache.org/r1504148
> Log:
> Add the two new resolver types (stream and static) to Jasper in the correct
> order and modify JasperELResolver so the correct resolvers are skipped.
Did you really
On 07/17/2013 04:01 PM, sebb wrote:
May I suggest a short comment is added to the script to document why
-z and -n are not used?
Someone else reading the script in the future is going to wonder the same-z and
-n
Some shells do not work well if variable is not set when using -z and -n.
In case
The Buildbot has detected a new failure on builder tomcat-trunk while building
ASF Buildbot.
Full details are available at:
http://ci.apache.org/builders/tomcat-trunk/builds/4707
Buildbot URL: http://ci.apache.org/
Buildslave for this Build: bb-vm_ubuntu
Build Reason: scheduler
Build Source St
On 17 July 2013 15:50, Mladen Turk wrote:
> On 07/17/2013 04:01 PM, sebb wrote:
>>
>> May I suggest a short comment is added to the script to document why
>> -z and -n are not used?
>> Someone else reading the script in the future is going to wonder the
>> same-z and -n
>
>
> Some shells do not wo
On 07/17/2013 06:05 PM, sebb wrote:
Why not use:
if [ "$FOO" != "" ]
Some shells do not allow that (comparing empty strings)
The . is not very obvious in some fonts, and it's more symmetrical to
quote both sides.
Some time its used [ "x$FOO" != x ]
The same way as '[ "x$FOO" = xyes ]',
2013/7/17 Mark Thomas wrote:
>
> On 17/07/2013 12:43, Mark Thomas wrote:
> > Violeta Georgieva wrote:
> >
> >> Having the example from the test:
> >> (x->y->x-y)(2)(1)
> >>
> >> We may transform it like this:
> >> (()->y->2-y)()(1)
> >>
> >> So instead of returning right way when formalParameters.
Author: markt
Date: Wed Jul 17 18:49:31 2013
New Revision: 1504232
URL: http://svn.apache.org/r1504232
Log:
The specification does not appear to allow the use of imports in a JSP page.
EL 3.0 section 1.5.1 states that the ELResolvers process identifiers before the
ImportHandler
JSP 2.3 section
Author: markt
Date: Wed Jul 17 18:58:17 2013
New Revision: 1504234
URL: http://svn.apache.org/r1504234
Log:
Use the correct message key
Modified:
tomcat/trunk/java/javax/el/LambdaExpression.java
Modified: tomcat/trunk/java/javax/el/LambdaExpression.java
URL:
http://svn.apache.org/viewvc/tom
On 17/07/2013 19:17, Violeta Georgieva wrote:
> 2013/7/17 Mark Thomas wrote:
>>
>> On 17/07/2013 12:43, Mark Thomas wrote:
>>> Violeta Georgieva wrote:
>>>
Having the example from the test:
(x->y->x-y)(2)(1)
We may transform it like this:
(()->y->2-y)()(1)
So ins
Mladen,
On 7/17/13 1:07 PM, Mladen Turk wrote:
> On 07/17/2013 06:05 PM, sebb wrote:
>>
>> Why not use:
>>
>> if [ "$FOO" != "" ]
>>
>
> Some shells do not allow that (comparing empty strings)
I don't know of a shell where "$FOO" would be unset and yet expand to
some non-zero-length string in a
Author: markt
Date: Wed Jul 17 20:07:48 2013
New Revision: 1504256
URL: http://svn.apache.org/r1504256
Log:
More nested lambda expression fixes.
Includes another test case and some simple debug code aimed at IDE debuggers.
Modified:
tomcat/trunk/java/org/apache/el/parser/AstLambdaExpression.j
On 17/07/2013 20:12, Mark Thomas wrote:
> On 17/07/2013 19:17, Violeta Georgieva wrote:
>> Why it is expected that (()->y->()->x->x-y)()(1)()(2) should throw
>> ELException? (TestAstLambdaExpression.testNested04())
>> Isn't it a correct one?
>
> That is a copy and paste error that is masking at l
Author: markt
Date: Wed Jul 17 21:12:22 2013
New Revision: 1504281
URL: http://svn.apache.org/r1504281
Log:
More fun and games with nested lambda expressions.
Each invocation of a nested expression consumes a set of method parameters.
Therefore nested lambda expressions that are invoked immediate
On 17/07/2013 21:10, Mark Thomas wrote:
> On 17/07/2013 20:12, Mark Thomas wrote:
>> On 17/07/2013 19:17, Violeta Georgieva wrote:
>
>>> Why it is expected that (()->y->()->x->x-y)()(1)()(2) should throw
>>> ELException? (TestAstLambdaExpression.testNested04())
>>> Isn't it a correct one?
>>
>> Th
Author: markt
Date: Wed Jul 17 21:38:48 2013
New Revision: 1504286
URL: http://svn.apache.org/r1504286
Log:
Add some basic import tests and fix a couple of identified issues.
Added:
tomcat/trunk/test/org/apache/el/parser/TestAstIdentifier.java (with props)
Modified:
tomcat/trunk/java/or
Author: markt
Date: Wed Jul 17 21:40:19 2013
New Revision: 1504287
URL: http://svn.apache.org/r1504287
Log:
Fix failing CI build. Another resolver was added.
Modified:
tomcat/trunk/test/org/apache/jasper/el/TestJasperELResolver.java
Modified: tomcat/trunk/test/org/apache/jasper/el/TestJasper
Author: markt
Date: Wed Jul 17 21:46:15 2013
New Revision: 1504292
URL: http://svn.apache.org/r1504292
Log:
Prep for an 8.0.0-alpha release
Remove section on JNI. Not a frequent enough issue to mentioned in the release
notes.
Clean up the contents list.
Modified:
tomcat/trunk/RELEASE-NOTES
Regardless, please consider documenting the script to explain why it
does not use -n/-z if that is necessary to avoid bugs.
On 17 July 2013 20:26, Christopher Schultz wrote:
> Mladen,
>
> On 7/17/13 1:07 PM, Mladen Turk wrote:
>> On 07/17/2013 06:05 PM, sebb wrote:
>>>
>>> Why not use:
>>>
>>> if
The Buildbot has detected a restored build on builder tomcat-trunk while
building ASF Buildbot.
Full details are available at:
http://ci.apache.org/builders/tomcat-trunk/builds/4713
Buildbot URL: http://ci.apache.org/
Buildslave for this Build: bb-vm_ubuntu
Build Reason: scheduler
Build Source
On 07/17/2013 11:59 PM, sebb wrote:
Regardless, please consider documenting the script to explain why it
does not use -n/-z if that is necessary to avoid bugs.
It would be the same as documenting why one uses a+=1 instead a++ :)
I don't see where its written that one *must* use -n/-z at the fi
33 matches
Mail list logo
