Re: potential problem: CometEvent END is not fired

2013-07-13 Thread Mark Thomas
On 13/07/2013 02:23, stzdzyhs wrote: > Hello, > a basic CometProcessor servlet, I found that the CometEvent END is not > fired.only BEGIN event is fired. There is a unit test that checks this. That suggests that the problem is with your application rather than with Tomcat. The users list is the pl

[Bug 55259] Unnecessary work in JspConfig

2013-07-13 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=55259 --- Comment #2 from Mark Thomas --- Jeremy, Although you were originally granted commit karma due to your taglibs work, you have the necessary karma to commit to any part of the Tomcat tree. You clearly know what you are doing so feel free

Re: potential problem: CometEvent END is not fired

2013-07-13 Thread stzdzyhs
After carefully read the code of test unit: TestCometProcessor.java and the document, it looks like that the CometEvent END is not always fired. for example: a case that will not fire END event: a http GET request, in the BEGIN event, the event.close() is invoked. Please see the attached testcase

[Tomcat Wiki] Update of "FAQ/KnownIssues" by KonstantinKolinko

2013-07-13 Thread Apache Wiki
Dear Wiki user, You have subscribed to a wiki page or wiki category on "Tomcat Wiki" for change notification. The "FAQ/KnownIssues" page has been changed by KonstantinKolinko: https://wiki.apache.org/tomcat/FAQ/KnownIssues?action=diff&rev1=13&rev2=14 Comment: Add OpenJDK logging issue to the li

Committing, was: [Bug 55259] Unnecessary work in JspConfig

2013-07-13 Thread Jeremy Boynes
On Jul 13, 2013, at 2:43 AM, bugzi...@apache.org wrote: > https://issues.apache.org/bugzilla/show_bug.cgi?id=55259 > > --- Comment #2 from Mark Thomas --- > Jeremy, > > Although you were originally granted commit karma due to your taglibs work, > you > have the necessary karma to commit to any

svn commit: r1502847 [1/2] - /tomcat/trunk/java/org/apache/el/parser/

2013-07-13 Thread markt
Author: markt Date: Sat Jul 13 19:28:02 2013 New Revision: 1502847 URL: http://svn.apache.org/r1502847 Log: Add support for defining Sets, Lists and Maps to the parser. The new nodes (the Ast*.java files) are just the auto-generated skeletons and some - if not all - will need some work before th

svn commit: r1502855 - /tomcat/trunk/test/javax/el/TestELProcessor.java

2013-07-13 Thread markt
Author: markt Date: Sat Jul 13 19:33:30 2013 New Revision: 1502855 URL: http://svn.apache.org/r1502855 Log: Prevent possible test failure depending on which method gets selected. Modified: tomcat/trunk/test/javax/el/TestELProcessor.java Modified: tomcat/trunk/test/javax/el/TestELProcessor.ja

svn commit: r1502875 - in /tomcat/trunk/java/org/apache/el/parser: AstListData.java AstMapData.java AstMapEntry.java AstSetData.java

2013-07-13 Thread markt
Author: markt Date: Sat Jul 13 20:36:39 2013 New Revision: 1502875 URL: http://svn.apache.org/r1502875 Log: native line endings Modified: tomcat/trunk/java/org/apache/el/parser/AstListData.java (props changed) tomcat/trunk/java/org/apache/el/parser/AstMapData.java (props changed)

svn commit: r1502876 [2/2] - in /tomcat/trunk/java/org/apache/el/parser: AstAssign.java AstSemicolon.java ELParser.java ELParser.jjt ELParserConstants.java ELParserTokenManager.java ELParserTreeConsta

2013-07-13 Thread markt
Modified: tomcat/trunk/java/org/apache/el/parser/ELParserTokenManager.java URL: http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/el/parser/ELParserTokenManager.java?rev=1502876&r1=1502875&r2=1502876&view=diff == -

svn commit: r1502876 [1/2] - in /tomcat/trunk/java/org/apache/el/parser: AstAssign.java AstSemicolon.java ELParser.java ELParser.jjt ELParserConstants.java ELParserTokenManager.java ELParserTreeConsta

2013-07-13 Thread markt
Author: markt Date: Sat Jul 13 20:40:39 2013 New Revision: 1502876 URL: http://svn.apache.org/r1502876 Log: Add support for the assignment and semicolon operator to the parser. The new nodes (the Ast*.java files) are just the auto-generated skeletons and some - if not all - will need some work b

svn commit: r1502897 - /tomcat/trunk/java/org/apache/jasper/compiler/JspConfig.java

2013-07-13 Thread jboynes
Author: jboynes Date: Sat Jul 13 22:07:49 2013 New Revision: 1502897 URL: http://svn.apache.org/r1502897 Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=55259 JspProperty is the same for all patterns so only create once. Modified: tomcat/trunk/java/org/apache/jasper/compiler/JspCo

[Bug 55259] Unnecessary work in JspConfig

2013-07-13 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=55259 Jeremy Boynes changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

[Bug 55261] New: TestSwallowAbortedUploads fails

2013-07-13 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=55261 Bug ID: 55261 Summary: TestSwallowAbortedUploads fails Product: Tomcat 7 Version: trunk Hardware: Macintosh OS: other Status: NEW Severity: normal

[Bug 55261] TestSwallowAbortedUploads fails

2013-07-13 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=55261 --- Comment #1 from Jeremy Boynes --- Created attachment 30589 --> https://issues.apache.org/bugzilla/attachment.cgi?id=30589&action=edit log from BIO run -- You are receiving this mail because: You are the assignee for the bug. --

buildbot success in ASF Buildbot on tomcat-trunk

2013-07-13 Thread buildbot
The Buildbot has detected a restored build on builder tomcat-trunk while building ASF Buildbot. Full details are available at: http://ci.apache.org/builders/tomcat-trunk/builds/4670 Buildbot URL: http://ci.apache.org/ Buildslave for this Build: bb-vm_ubuntu Build Reason: scheduler Build Source

[Bug 55262] New: Duplicate preludes and codas in same are ignored

2013-07-13 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=55262 Bug ID: 55262 Summary: Duplicate preludes and codas in same are ignored Product: Tomcat 8 Version: trunk Hardware: All OS: All Status: NE

[Bug 55262] Duplicate preludes and codas in same are ignored

2013-07-13 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=55262 --- Comment #1 from Jeremy Boynes --- Created attachment 30590 --> https://issues.apache.org/bugzilla/attachment.cgi?id=30590&action=edit patch with test cases and fix The attachment is all test code apart from the change in JspPropertyG

[Bug 55261] TestSwallowAbortedUploads fails

2013-07-13 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=55261 --- Comment #2 from Rainer Jung --- (In reply to Jeremy Boynes from comment #0) > With a fresh checkout of 7.0.x I am seeing failures with > TestSwallowAbortedUploads under both BIO and NIO. Are there issues with this > test case? > > Mac

svn commit: r1502934 - in /tomcat/trunk/java/org/apache/jasper/compiler: JspConfig.java JspDocumentParser.java PageInfo.java Parser.java

2013-07-13 Thread jboynes
Author: jboynes Date: Sun Jul 14 03:39:18 2013 New Revision: 1502934 URL: http://svn.apache.org/r1502934 Log: Avoid allocating unnecessary Vectors to store preludes and codas by using Collections returned from JspPropertyGroupDescriptor directly. Modified: tomcat/trunk/java/org/apache/jasper/