[Bug 54387] Having servlets with same url should at least cause warning

2013-06-04 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=54387 Loïc Albertin changed: What|Removed |Added CC||loic.alber...@ow2.org --- Comment

svn commit: r1489351 - /tomcat/tc6.0.x/trunk/STATUS.txt

2013-06-04 Thread kkolinko
Author: kkolinko Date: Tue Jun 4 09:11:13 2013 New Revision: 1489351 URL: http://svn.apache.org/r1489351 Log: Propose a patch Modified: tomcat/tc6.0.x/trunk/STATUS.txt Modified: tomcat/tc6.0.x/trunk/STATUS.txt URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=1489351&r1

svn commit: r1489385 [3/3] - in /tomcat/trunk: java/org/apache/catalina/filters/ test/org/apache/catalina/filters/ webapps/docs/config/

2013-06-04 Thread markt
Modified: tomcat/trunk/test/org/apache/catalina/filters/TesterHttpServletResponse.java URL: http://svn.apache.org/viewvc/tomcat/trunk/test/org/apache/catalina/filters/TesterHttpServletResponse.java?rev=1489385&r1=1489384&r2=1489385&view=diff ===

svn commit: r1489385 [1/3] - in /tomcat/trunk: java/org/apache/catalina/filters/ test/org/apache/catalina/filters/ webapps/docs/config/

2013-06-04 Thread markt
Author: markt Date: Tue Jun 4 10:51:31 2013 New Revision: 1489385 URL: http://svn.apache.org/r1489385 Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=55046 Add a Filter that implements CORS (http://www.w3.org/TR/cors/) Based on a patch by Mohit Soni. Added: tomcat/trunk/java/org/

[Tomcat Wiki] Update of "FAQ/Developing" by BrianBurch

2013-06-04 Thread Apache Wiki
Dear Wiki user, You have subscribed to a wiki page or wiki category on "Tomcat Wiki" for change notification. The "FAQ/Developing" page has been changed by BrianBurch: https://wiki.apache.org/tomcat/FAQ/Developing?action=diff&rev1=17&rev2=18 <> How do I remotely debug Tomcat using NetB

[Bug 55046] CORS Filter

2013-06-04 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=55046 --- Comment #5 from Mark Thomas --- Thanks for the updated patch but as I has already started work on the previous patch I have continued with that. The feedback was intended for future patches rather than a list of changes required for thi

[Bug 55035] Deploy ROOT webapp with version through text manager using Ant

2013-06-04 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=55035 --- Comment #3 from Sergey Tcherednichenko --- thanks for including it to trunk :) and sorry for the problem with patch :) though, this is a fix for ant task property "version", but the issue with using "/##someversion" path is not fixed b

[Bug 55035] Deploy ROOT webapp with version through text manager using Ant

2013-06-04 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=55035 --- Comment #4 from Mark Thomas --- I'd say treat using ##version in a path as deprecated / unsupported. -- You are receiving this mail because: You are the assignee for the bug. --

Re: svn commit: r1489385 [1/3] - in /tomcat/trunk: java/org/apache/catalina/filters/ test/org/apache/catalina/filters/ webapps/docs/config/

2013-06-04 Thread Konstantin Kolinko
2013/6/4 : > Author: markt > Date: Tue Jun 4 10:51:31 2013 > New Revision: 1489385 > > URL: http://svn.apache.org/r1489385 > Log: > Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=55046 > Add a Filter that implements CORS (http://www.w3.org/TR/cors/) > Based on a patch by Mohit Soni. > > A

Re: svn commit: r1489385 [1/3] - in /tomcat/trunk: java/org/apache/catalina/filters/ test/org/apache/catalina/filters/ webapps/docs/config/

2013-06-04 Thread Mark Thomas
On 04/06/2013 12:13, Konstantin Kolinko wrote: > The message key casing is inconsistent with the name of the property. > It would be "Preflight". Fixed. > in filter.xml: > > +is rejected with HTTP status code 403 (Forbidden). A > +flowchart that > +demonstrates request processing by

svn commit: r1489390 - in /tomcat/trunk: java/org/apache/catalina/filters/CorsFilter.java java/org/apache/catalina/filters/LocalStrings.properties webapps/docs/images/cors-flowchart.png

2013-06-04 Thread markt
Author: markt Date: Tue Jun 4 11:35:58 2013 New Revision: 1489390 URL: http://svn.apache.org/r1489390 Log: Review comments from kkolinko Added: tomcat/trunk/webapps/docs/images/cors-flowchart.png (with props) Modified: tomcat/trunk/java/org/apache/catalina/filters/CorsFilter.java t

svn commit: r1489405 - /tomcat/trunk/java/org/apache/juli/ClassLoaderLogManager.java

2013-06-04 Thread markt
Author: markt Date: Tue Jun 4 12:19:29 2013 New Revision: 1489405 URL: http://svn.apache.org/r1489405 Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=55052 Fall back to un-prefixed property if a prefixed one is not present Modified: tomcat/trunk/java/org/apache/juli/ClassLoaderLo

svn commit: r1489408 - /tomcat/tc7.0.x/trunk/java/org/apache/juli/FileHandler.java

2013-06-04 Thread markt
Author: markt Date: Tue Jun 4 12:24:41 2013 New Revision: 1489408 URL: http://svn.apache.org/r1489408 Log: Silence some Eclipse warnings Modified: tomcat/tc7.0.x/trunk/java/org/apache/juli/FileHandler.java Modified: tomcat/tc7.0.x/trunk/java/org/apache/juli/FileHandler.java URL: http://svn

svn commit: r1489411 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/juli/ClassLoaderLogManager.java webapps/docs/changelog.xml

2013-06-04 Thread markt
Author: markt Date: Tue Jun 4 12:29:29 2013 New Revision: 1489411 URL: http://svn.apache.org/r1489411 Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=55052 Fall back to un-prefixed property if a prefixed one is not present Modified: tomcat/tc7.0.x/trunk/ (props changed) tom

[Bug 55052] [JULI] Make ClassLoaderLogManager.getProperty() to try unprefixed property if prefixed one does not exist

2013-06-04 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=55052 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

[Bug 55054] public method exitWhenFinished() removed from FileCleaningTracker.

2013-06-04 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=55054 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

svn commit: r1489419 - in /tomcat/trunk/java/org/apache/tomcat/util/http/fileupload: FileCleaningTracker.java FileDeleteStrategy.java disk/DiskFileItem.java disk/DiskFileItemFactory.java

2013-06-04 Thread markt
Author: markt Date: Tue Jun 4 12:48:18 2013 New Revision: 1489419 URL: http://svn.apache.org/r1489419 Log: Some more unused code clean-up. Removed: tomcat/trunk/java/org/apache/tomcat/util/http/fileupload/FileCleaningTracker.java tomcat/trunk/java/org/apache/tomcat/util/http/fileupload

[Bug 54939] No useful logging when maxHeaderCount hit

2013-06-04 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=54939 --- Comment #6 from Mark Thomas --- I'd like to see this issue resolved for the 7.0.41 so I will be fixing it shortly. -- You are receiving this mail because: You are the assignee for the bug.

Re: AsyncContext.dispatch(path) invoked more than once

2013-06-04 Thread Violeta Georgieva
2013/5/31 Violeta Georgieva wrote: > > 2013/5/29 Violeta Georgieva wrote: > > > > 2013/5/28 Konstantin Kolinko wrote: > > > > > > > > > I think that your patch is wrong. > > > > > > Looking at how ActionCode.ASYNC_DISPATCH is handled in different > > > connector implementations in Tomcat 7, the cod

Re: AsyncContext.dispatch(path) invoked more than once

2013-06-04 Thread Mark Thomas
On 04/06/2013 13:55, Violeta Georgieva wrote: > 2013/5/31 Violeta Georgieva wrote: >> Let's put this as plan B for now. >> >> I made a small change in the AsyncContextImpl.doInternalDispatch(). >> >> Can you comment on the patch? >> >> >> Index: C:/tc8.0.x/java/org/apache/catalina/core/AsyncContex

svn commit: r1489437 - in /tomcat/trunk/java/org/apache/coyote/http11: AbstractHttp11Processor.java LocalStrings.properties

2013-06-04 Thread markt
Author: markt Date: Tue Jun 4 13:24:12 2013 New Revision: 1489437 URL: http://svn.apache.org/r1489437 Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=54939 Log errors parsing HTTP request headers. Modified: tomcat/trunk/java/org/apache/coyote/http11/AbstractHttp11Processor.java

svn commit: r1489444 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/coyote/http11/AbstractHttp11Processor.java java/org/apache/coyote/http11/LocalStrings.properties webapps/docs/changelog.xml

2013-06-04 Thread markt
Author: markt Date: Tue Jun 4 13:42:50 2013 New Revision: 1489444 URL: http://svn.apache.org/r1489444 Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=54939 Log errors parsing HTTP request headers using a UserDataHelper Modified: tomcat/tc7.0.x/trunk/ (props changed) tomcat

[Bug 54939] No useful logging when maxHeaderCount hit

2013-06-04 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=54939 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

svn commit: r1489512 - /tomcat/tc7.0.x/trunk/java/org/apache/juli/FileHandler.java

2013-06-04 Thread kkolinko
Author: kkolinko Date: Tue Jun 4 16:47:32 2013 New Revision: 1489512 URL: http://svn.apache.org/r1489512 Log: Wrap line. (Followup to r1489408) Modified: tomcat/tc7.0.x/trunk/java/org/apache/juli/FileHandler.java Modified: tomcat/tc7.0.x/trunk/java/org/apache/juli/FileHandler.java URL: htt

[Bug 55052] [JULI] Make ClassLoaderLogManager.getProperty() to try unprefixed property if prefixed one does not exist

2013-06-04 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=55052 --- Comment #2 from Konstantin Kolinko --- Created attachment 30387 --> https://issues.apache.org/bugzilla/attachment.cgi?id=30387&action=edit 2013-06-04_tc6_55052.patch > Fixed in trunk and 7.0.x and will be included in 7.0.41 onwards.

svn commit: r1489524 - /tomcat/tc6.0.x/trunk/STATUS.txt

2013-06-04 Thread kkolinko
Author: kkolinko Date: Tue Jun 4 17:16:59 2013 New Revision: 1489524 URL: http://svn.apache.org/r1489524 Log: proposal Modified: tomcat/tc6.0.x/trunk/STATUS.txt Modified: tomcat/tc6.0.x/trunk/STATUS.txt URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=1489524&r1=148952

svn commit: r1489525 - /tomcat/tc6.0.x/trunk/STATUS.txt

2013-06-04 Thread kkolinko
Author: kkolinko Date: Tue Jun 4 17:19:35 2013 New Revision: 1489525 URL: http://svn.apache.org/r1489525 Log: Add link to the patch Modified: tomcat/tc6.0.x/trunk/STATUS.txt Modified: tomcat/tc6.0.x/trunk/STATUS.txt URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=1489

svn commit: r1489536 - in /tomcat/trunk: java/org/apache/catalina/core/AsyncContextImpl.java java/org/apache/catalina/core/LocalStrings.properties test/org/apache/catalina/core/TestAsyncContextImpl.ja

2013-06-04 Thread violetagg
Author: violetagg Date: Tue Jun 4 18:03:04 2013 New Revision: 1489536 URL: http://svn.apache.org/r1489536 Log: IllegalStateException will be thrown if more than one asynchronous dispatch operation is started within the same asynchronous cycle. Modified: tomcat/trunk/java/org/apache/catalina

svn commit: r1489546 - /tomcat/trunk/build.properties.default

2013-06-04 Thread kkolinko
Author: kkolinko Date: Tue Jun 4 18:22:29 2013 New Revision: 1489546 URL: http://svn.apache.org/r1489546 Log: Update to Apache Commons Logging 1.1.3 If you svn diff 1_1_2 and 1_1_3 tags of commons-logging, the differences are - Documentation - Manifest and POM files (fix for LOGGING-151), irrele

svn commit: r1489549 - /tomcat/trunk/java/org/apache/catalina/core/StandardHost.java

2013-06-04 Thread markt
Author: markt Date: Tue Jun 4 18:32:13 2013 New Revision: 1489549 URL: http://svn.apache.org/r1489549 Log: Trivial clean-up Modified: tomcat/trunk/java/org/apache/catalina/core/StandardHost.java Modified: tomcat/trunk/java/org/apache/catalina/core/StandardHost.java URL: http://svn.apache.o

svn commit: r1489557 - /tomcat/trunk/java/org/apache/catalina/connector/Response.java

2013-06-04 Thread kkolinko
Author: kkolinko Date: Tue Jun 4 18:46:52 2013 New Revision: 1489557 URL: http://svn.apache.org/r1489557 Log: Restore Javadoc to the getCoyoteResponse() method which has been deprecated, removed (r1188402) and resurrected (r1358055). This method is currently used by RewriteValve. BTW, one place

svn commit: r1489561 - /tomcat/tc7.0.x/trunk/java/org/apache/catalina/connector/Response.java

2013-06-04 Thread kkolinko
Author: kkolinko Date: Tue Jun 4 18:54:24 2013 New Revision: 1489561 URL: http://svn.apache.org/r1489561 Log: Remove @Deprecated marker from getCoyoteResponse() method as it has been resurrected in trunk in r1358055. It is currently used by RewriteValve in trunk and can be useful to valves to al

[Bug 55017] Ability to configure RMI bind address

2013-06-04 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=55017 --- Comment #8 from Christopher Schultz --- (In reply to Mark Thomas from comment #7) > The patch needs to include the associated documentation changes. It would > also be nice if it used StringManager for i18n. Alexey, if you'd care to ma

[Bug 55017] Ability to configure RMI bind address

2013-06-04 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=55017 --- Comment #9 from Alexey Noskov --- Yes, I already found how it's used. I'll make documentation and i18n changes in nearest days. -- You are receiving this mail because: You are the assignee for the bug. --

svn commit: r1489610 - /tomcat/trunk/webapps/docs/config/systemprops.xml

2013-06-04 Thread kkolinko
Author: kkolinko Date: Tue Jun 4 21:15:12 2013 New Revision: 1489610 URL: http://svn.apache.org/r1489610 Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=54939 Follow-up to r1489444: Update description of UserDataHelper uses in documentation. Corrected a typo s/to/too/. Modified:

svn commit: r1489613 - in /tomcat/tc7.0.x/trunk: ./ webapps/docs/config/systemprops.xml

2013-06-04 Thread kkolinko
Author: kkolinko Date: Tue Jun 4 21:20:23 2013 New Revision: 1489613 URL: http://svn.apache.org/r1489613 Log: Merged r1489610 from tomcat/trunk: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=54939 Follow-up to r1489444: Update description of UserDataHelper uses in documentation. Correct

svn commit: r1489633 - /tomcat/trunk/java/org/apache/catalina/startup/HostConfig.java

2013-06-04 Thread markt
Author: markt Date: Tue Jun 4 21:42:12 2013 New Revision: 1489633 URL: http://svn.apache.org/r1489633 Log: Refactor WAR deployment to make a per Context copyXML attribute possible Modified: tomcat/trunk/java/org/apache/catalina/startup/HostConfig.java Modified: tomcat/trunk/java/org/apache/

svn commit: r1489648 - in /tomcat/trunk/java/org/apache/catalina: core/StandardContext.java startup/HostConfig.java

2013-06-04 Thread markt
Author: markt Date: Tue Jun 4 21:54:48 2013 New Revision: 1489648 URL: http://svn.apache.org/r1489648 Log: Add the ability for a context.xml file in a webapp to override the default value of copyXML on the host. There are some 'interesting' edge cases here. Test cases to follow. Modified:

[Bug 55046] CORS Filter

2013-06-04 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=55046 --- Comment #6 from Mohit Soni --- Created attachment 30395 --> https://issues.apache.org/bugzilla/attachment.cgi?id=30395&action=edit Updated documentation filter.xml. I have reviewed the last patch, it looks fine to me functionality wi

[Bug 55046] CORS Filter

2013-06-04 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=55046 Mohit Soni changed: What|Removed |Added Attachment #30395|0 |1 is patch|

svn commit: r1489706 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/catalina/core/AsyncContextImpl.java java/org/apache/catalina/core/LocalStrings.properties test/org/apache/catalina/core/TestAsyncCon

2013-06-04 Thread violetagg
Author: violetagg Date: Wed Jun 5 05:02:38 2013 New Revision: 1489706 URL: http://svn.apache.org/r1489706 Log: Merged revision 1489536 from tomcat/trunk: IllegalStateException will be thrown if more than one asynchronous dispatch operation is started within the same asynchronous cycle. Modified

svn commit: r1489711 - /tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml

2013-06-04 Thread violetagg
Author: violetagg Date: Wed Jun 5 05:44:13 2013 New Revision: 1489711 URL: http://svn.apache.org/r1489711 Log: Fix typos. Modified: tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml Modified: tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml URL: http://svn.apache.org/viewvc/tomcat/tc7.0.x/tru