buildbot success in ASF Buildbot on tomcat-7-trunk

2013-03-17 Thread buildbot
The Buildbot has detected a restored build on builder tomcat-7-trunk while building ASF Buildbot. Full details are available at: http://ci.apache.org/builders/tomcat-7-trunk/builds/1120 Buildbot URL: http://ci.apache.org/ Buildslave for this Build: bb-vm_ubuntu Build Reason: scheduler Build So

buildbot success in ASF Buildbot on tomcat-trunk

2013-03-17 Thread buildbot
The Buildbot has detected a restored build on builder tomcat-trunk while building ASF Buildbot. Full details are available at: http://ci.apache.org/builders/tomcat-trunk/builds/4076 Buildbot URL: http://ci.apache.org/ Buildslave for this Build: bb-vm_ubuntu Build Reason: scheduler Build Source

Bug report for Tomcat 6 [2013/03/17]

2013-03-17 Thread bugzilla
+---+ | Bugzilla Bug ID | | +-+ | | Status: UNC=Unconfirmed NEW=New ASS=Assigned

Bug report for Tomcat 8 [2013/03/17]

2013-03-17 Thread bugzilla
+---+ | Bugzilla Bug ID | | +-+ | | Status: UNC=Unconfirmed NEW=New ASS=Assigned

Bug report for Taglibs [2013/03/17]

2013-03-17 Thread bugzilla
+---+ | Bugzilla Bug ID | | +-+ | | Status: UNC=Unconfirmed NEW=New ASS=Assigned

Bug report for Tomcat 7 [2013/03/17]

2013-03-17 Thread bugzilla
+---+ | Bugzilla Bug ID | | +-+ | | Status: UNC=Unconfirmed NEW=New ASS=Assigned

Bug report for Tomcat Connectors [2013/03/17]

2013-03-17 Thread bugzilla
+---+ | Bugzilla Bug ID | | +-+ | | Status: UNC=Unconfirmed NEW=New ASS=Assigned

Bug report for Tomcat Native [2013/03/17]

2013-03-17 Thread bugzilla
+---+ | Bugzilla Bug ID | | +-+ | | Status: UNC=Unconfirmed NEW=New ASS=Assigned

Bug report for Tomcat Modules [2013/03/17]

2013-03-17 Thread bugzilla
+---+ | Bugzilla Bug ID | | +-+ | | Status: UNC=Unconfirmed NEW=New ASS=Assigned

[Bug 54709] New: Official schemes for WebSocket are "ws"/"wss"; WsWebSocketContainer only allows "http"/"https"

2013-03-17 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=54709 Bug ID: 54709 Summary: Official schemes for WebSocket are "ws"/"wss"; WsWebSocketContainer only allows "http"/"https" Product: Tomcat 8 Version: trunk Hardware: All

[Bug 54709] Official schemes for WebSocket are "ws"/"wss"; WsWebSocketContainer only allows "http"/"https"

2013-03-17 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=54709 Nick Williams changed: What|Removed |Added Attachment #30056|0 |1 is patch|

buildbot failure in ASF Buildbot on tomcat-7-trunk

2013-03-17 Thread buildbot
The Buildbot has detected a new failure on builder tomcat-7-trunk while building ASF Buildbot. Full details are available at: http://ci.apache.org/builders/tomcat-7-trunk/builds/1123 Buildbot URL: http://ci.apache.org/ Buildslave for this Build: bb-vm_ubuntu Build Reason: scheduler Build Sourc

svn commit: r1457402 - /tomcat/trunk/java/org/apache/tomcat/util/http/parser/HttpParser.java

2013-03-17 Thread markt
Author: markt Date: Sun Mar 17 09:22:16 2013 New Revision: 1457402 URL: http://svn.apache.org/r1457402 Log: There was a reason mark/reset was used here. Restore use of mark/reset and add a comment. Modified: tomcat/trunk/java/org/apache/tomcat/util/http/parser/HttpParser.java Modified: tomc

svn commit: r1457403 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/tomcat/util/http/parser/HttpParser.java

2013-03-17 Thread markt
Author: markt Date: Sun Mar 17 09:33:41 2013 New Revision: 1457403 URL: http://svn.apache.org/r1457403 Log: There was a reason mark/reset was used here. Restore use of mark/reset and add a comment. Modified: tomcat/tc7.0.x/trunk/ (props changed) tomcat/tc7.0.x/trunk/java/org/apache/tom

[Bug 52135] Global error page is not handled

2013-03-17 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=52135 --- Comment #17 from Libor Jelinek --- Potential reason to reopen this: Having the following web.xml still end up with showing Tomcat default error page. Is it intended behavior or a bug? ThrowerServlet org.example.ThrowerS

[Bug 54710] New: Java WebSocket specification says @OnMessage methods can have InputStream/Reader parameters; @OnClose can have CloseReason parameters

2013-03-17 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=54710 Bug ID: 54710 Summary: Java WebSocket specification says @OnMessage methods can have InputStream/Reader parameters; @OnClose can have CloseReason parameters Product: T

[Bug 54710] Java WebSocket specification says @OnMessage methods can have InputStream/Reader parameters; @OnClose can have CloseReason parameters

2013-03-17 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=54710 Nick Williams changed: What|Removed |Added Attachment #30057|0 |1 is patch|

[Bug 54710] Java WebSocket specification says @OnMessage methods can have InputStream/Reader parameters; @OnClose can have CloseReason parameters

2013-03-17 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=54710 Nick Williams changed: What|Removed |Added Attachment #30057|0 |1 is obsolete|

buildbot success in ASF Buildbot on tomcat-7-trunk

2013-03-17 Thread buildbot
The Buildbot has detected a restored build on builder tomcat-7-trunk while building ASF Buildbot. Full details are available at: http://ci.apache.org/builders/tomcat-7-trunk/builds/1124 Buildbot URL: http://ci.apache.org/ Buildslave for this Build: bb-vm_ubuntu Build Reason: scheduler Build So

[Bug 54711] New: Strange problem with WsOutputStream; cannot write to it, Session gets closed instead

2013-03-17 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=54711 Bug ID: 54711 Summary: Strange problem with WsOutputStream; cannot write to it, Session gets closed instead Product: Tomcat 8 Version: trunk Hardware: All

[Bug 54711] Strange problem with WsOutputStream; cannot write to it, Session gets closed instead

2013-03-17 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=54711 --- Comment #1 from Nick Williams --- Please note, I pasted the wrong improved method in here. Actual version: @Override public void write(byte[] b, int off, int len) throws IOException { if (buffer.remaining()

[Bug 54711] Strange problem with WsOutputStream; cannot write to it, Session gets closed instead

2013-03-17 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=54711 Nick Williams changed: What|Removed |Added Attachment #30059|application/octet-stream|text/plain mime type|

svn commit: r1457428 - /tomcat/trunk/java/org/apache/tomcat/websocket/pojo/

2013-03-17 Thread markt
Author: markt Date: Sun Mar 17 11:50:36 2013 New Revision: 1457428 URL: http://svn.apache.org/r1457428 Log: Add/improve Javadoc Modified: tomcat/trunk/java/org/apache/tomcat/websocket/pojo/PojoEndpointBase.java tomcat/trunk/java/org/apache/tomcat/websocket/pojo/PojoEndpointClient.java

svn commit: r1457429 - /tomcat/trunk/java/org/apache/tomcat/websocket/pojo/PojoMethodMapping.java

2013-03-17 Thread markt
Author: markt Date: Sun Mar 17 11:59:55 2013 New Revision: 1457429 URL: http://svn.apache.org/r1457429 Log: Renames to make code clearer Fix a bug - only look for a Throwable for onError methods Modified: tomcat/trunk/java/org/apache/tomcat/websocket/pojo/PojoMethodMapping.java Modified: to

[Bug 54712] New: Prefer Locale.ENGLISH over Locale.US for case conversion

2013-03-17 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=54712 Bug ID: 54712 Summary: Prefer Locale.ENGLISH over Locale.US for case conversion Product: Tomcat 7 Version: unspecified Hardware: PC OS: All

svn commit: r1457448 - in /tomcat/trunk/java/org/apache/tomcat/websocket/pojo: LocalStrings.properties PojoMethodMapping.java

2013-03-17 Thread markt
Author: markt Date: Sun Mar 17 13:43:33 2013 New Revision: 1457448 URL: http://svn.apache.org/r1457448 Log: Provide some meaningful error messages for the exceptions Modified: tomcat/trunk/java/org/apache/tomcat/websocket/pojo/LocalStrings.properties tomcat/trunk/java/org/apache/tomcat/we

[Bug 54707] Buggy Perl http clients cause tomcat digest auth to fail due to quoted nc values (e.g. nc="00000001")

2013-03-17 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=54707 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

svn commit: r1457452 - in /tomcat/trunk: java/org/apache/catalina/connector/ java/org/apache/tomcat/util/buf/ java/org/apache/tomcat/util/http/parser/ modules/jdbc-pool/src/main/java/org/apache/tomcat

2013-03-17 Thread markt
Author: markt Date: Sun Mar 17 14:07:25 2013 New Revision: 1457452 URL: http://svn.apache.org/r1457452 Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=54712 Code clean-up. Use Locale.ENGLISH consistently for upper/lower case conversions. Modified: tomcat/trunk/java/org/apache/cata

svn commit: r1457453 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/tomcat/util/buf/ java/org/apache/tomcat/util/http/parser/ modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/ test/org/apac

2013-03-17 Thread markt
Author: markt Date: Sun Mar 17 14:11:35 2013 New Revision: 1457453 URL: http://svn.apache.org/r1457453 Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=54712 Code clean-up. Use Locale.ENGLISH consistently for upper/lower case conversions. Modified: tomcat/tc7.0.x/trunk/ (props ch

[Bug 54712] Prefer Locale.ENGLISH over Locale.US for case conversion

2013-03-17 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=54712 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

svn commit: r1457454 - in /tomcat/trunk: java/org/apache/catalina/core/StandardContext.java java/org/apache/catalina/util/ContextName.java webapps/docs/changelog.xml

2013-03-17 Thread markt
Author: markt Date: Sun Mar 17 14:26:53 2013 New Revision: 1457454 URL: http://svn.apache.org/r1457454 Log: Change the name of the working directory for the ROOT application (located under $CATALINA_BASE/work by default) from _ to ROOT. Modified: tomcat/trunk/java/org/apache/catalina/core/St

[Bug 54708] Use base file name ("ROOT") as the work directory for the default webapp instead of "_"

2013-03-17 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=54708 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

[Bug 52135] Global error page is not handled

2013-03-17 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=52135 --- Comment #18 from balusc --- @Libor: this is behaving as specified. Your servlet is mapped on an overly generic URL pattern of /* which thus also overrides among others the servletcontainer's builtin JspServlet which is listening on *.js

buildbot failure in ASF Buildbot on tomcat-trunk

2013-03-17 Thread buildbot
The Buildbot has detected a new failure on builder tomcat-trunk while building ASF Buildbot. Full details are available at: http://ci.apache.org/builders/tomcat-trunk/builds/4090 Buildbot URL: http://ci.apache.org/ Buildslave for this Build: bb-vm_ubuntu Build Reason: scheduler Build Source St

buildbot success in ASF Buildbot on tomcat-trunk

2013-03-17 Thread buildbot
The Buildbot has detected a restored build on builder tomcat-trunk while building ASF Buildbot. Full details are available at: http://ci.apache.org/builders/tomcat-trunk/builds/4091 Buildbot URL: http://ci.apache.org/ Buildslave for this Build: bb-vm_ubuntu Build Reason: scheduler Build Source

[Bug 54711] Strange problem with WsOutputStream; cannot write to it, Session gets closed instead

2013-03-17 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=54711 --- Comment #2 from Nick Williams --- Created attachment 30061 --> https://issues.apache.org/bugzilla/attachment.cgi?id=30061&action=edit Patch to resolve issue Fixed with attached patch! Woohoo! This was a doozy. There were several pro

[Bug 54711] Strange problem with WsOutputStream; cannot write to it, Session gets closed instead

2013-03-17 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=54711 --- Comment #3 from Nick Williams --- By the way, I'm still getting the following two disconcerting stdout messages when shutting down Tomcat. This is obviously better than it used to be and there are no more errors at all. I'm not sure how

[Bug 54713] New: , @WebServlet(loadOnStartup) do not trigger initialization of Servlet on startup.

2013-03-17 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=54713 Bug ID: 54713 Summary: , @WebServlet(loadOnStartup) do not trigger initialization of Servlet on startup. Product: Tomcat 8 Version: trunk Hardware: All

[Bug 54713] , @WebServlet(loadOnStartup) do not trigger initialization of Servlet on startup.

2013-03-17 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=54713 --- Comment #1 from Nick Williams --- Note that, less than two months ago, this was working fine. -- You are receiving this mail because: You are the assignee for the bug. -

[Bug 54714] New: Examples webapp not starting anymore; NoClassDefFoundError in listener start

2013-03-17 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=54714 Bug ID: 54714 Summary: Examples webapp not starting anymore; NoClassDefFoundError in listener start Product: Tomcat 8 Version: trunk Hardware: All OS:

svn commit: r1457513 - in /tomcat/trunk: java/org/apache/tomcat/websocket/ test/org/apache/tomcat/websocket/ test/org/apache/tomcat/websocket/pojo/

2013-03-17 Thread markt
Author: markt Date: Sun Mar 17 18:49:45 2013 New Revision: 1457513 URL: http://svn.apache.org/r1457513 Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=54709 http -> ws https -> wss Modified: tomcat/trunk/java/org/apache/tomcat/websocket/WsWebSocketContainer.java tomcat/trunk/

[Bug 54709] Official schemes for WebSocket are "ws"/"wss"; WsWebSocketContainer only allows "http"/"https"

2013-03-17 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=54709 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

svn commit: r1457515 - /tomcat/trunk/java/org/apache/tomcat/websocket/WsSession.java

2013-03-17 Thread markt
Author: markt Date: Sun Mar 17 18:51:06 2013 New Revision: 1457515 URL: http://svn.apache.org/r1457515 Log: Don't re-throw exception if we can't send the close message. Use onError. Modified: tomcat/trunk/java/org/apache/tomcat/websocket/WsSession.java Modified: tomcat/trunk/java/org/apache/

[Bug 54709] Official schemes for WebSocket are "ws"/"wss"; WsWebSocketContainer only allows "http"/"https"

2013-03-17 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=54709 --- Comment #2 from Nick Williams --- Note one potential problem: if (port == -1) { if ("ws".equalsIgnoreCase(scheme)) { sa = new InetSocketAddress(host, 80); } else { // TODO

[Bug 54709] Official schemes for WebSocket are "ws"/"wss"; WsWebSocketContainer only allows "http"/"https"

2013-03-17 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=54709 --- Comment #3 from Mark Thomas --- (In reply to comment #2) > Note one potential problem: I must be being blind. What is the problem here? -- You are receiving this mail because: You are the assignee for the bug. --

[Bug 54712] Prefer Locale.ENGLISH over Locale.US for case conversion

2013-03-17 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=54712 --- Comment #2 from Sebb --- (In reply to comment #1) > Note: The provided patch is against trunk rather than 7.0.x/trunk. Oops! Sorry, my IDE project was named when trunk was 7.0.x and I forgot to update it. > This change has been made t

svn commit: r1457528 - /tomcat/trunk/java/org/apache/tomcat/websocket/WsSession.java

2013-03-17 Thread markt
Author: markt Date: Sun Mar 17 19:24:33 2013 New Revision: 1457528 URL: http://svn.apache.org/r1457528 Log: Follow up to r1457515 Modified: tomcat/trunk/java/org/apache/tomcat/websocket/WsSession.java Modified: tomcat/trunk/java/org/apache/tomcat/websocket/WsSession.java URL: http://svn.apa

svn commit: r1457529 - /tomcat/trunk/java/org/apache/tomcat/websocket/WsWebSocketContainer.java

2013-03-17 Thread markt
Author: markt Date: Sun Mar 17 19:25:38 2013 New Revision: 1457529 URL: http://svn.apache.org/r1457529 Log: Fix parsing of HTTP headers. The parser was reading beyond the end of the HTTP response and swallowing and pipe-lined WebSocket messages. Modified: tomcat/trunk/java/org/apache/tomcat/

[Bug 54709] Official schemes for WebSocket are "ws"/"wss"; WsWebSocketContainer only allows "http"/"https"

2013-03-17 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=54709 --- Comment #4 from Nick Williams --- If SSL support is completed by commenting out: sa = new InetSocketAddress(host, 443); Then if someone specifies a URL: wss://localhost:8443/webSocketEndpoint The code will attempt to connect to this

buildbot failure in ASF Buildbot on tomcat-trunk

2013-03-17 Thread buildbot
The Buildbot has detected a new failure on builder tomcat-trunk while building ASF Buildbot. Full details are available at: http://ci.apache.org/builders/tomcat-trunk/builds/4096 Buildbot URL: http://ci.apache.org/ Buildslave for this Build: bb-vm_ubuntu Build Reason: scheduler Build Source St

[Bug 54709] Official schemes for WebSocket are "ws"/"wss"; WsWebSocketContainer only allows "http"/"https"

2013-03-17 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=54709 --- Comment #5 from Nick Williams --- Scratch that previous comment. I was the one that was blind. Your code will work fine. -- You are receiving this mail because: You are the assignee for the bug. --

buildbot success in ASF Buildbot on tomcat-trunk

2013-03-17 Thread buildbot
The Buildbot has detected a restored build on builder tomcat-trunk while building ASF Buildbot. Full details are available at: http://ci.apache.org/builders/tomcat-trunk/builds/4097 Buildbot URL: http://ci.apache.org/ Buildslave for this Build: bb-vm_ubuntu Build Reason: scheduler Build Source

svn commit: r1457554 - /tomcat/trunk/java/org/apache/tomcat/websocket/WsWebSocketContainer.java

2013-03-17 Thread markt
Author: markt Date: Sun Mar 17 20:31:58 2013 New Revision: 1457554 URL: http://svn.apache.org/r1457554 Log: Need to pass query string to server too. Modified: tomcat/trunk/java/org/apache/tomcat/websocket/WsWebSocketContainer.java Modified: tomcat/trunk/java/org/apache/tomcat/websocket/WsWe

svn commit: r1457637 - /tomcat/trunk/java/org/apache/tomcat/websocket/pojo/PojoMethodMapping.java

2013-03-17 Thread kkolinko
Author: kkolinko Date: Mon Mar 18 04:38:05 2013 New Revision: 1457637 URL: http://svn.apache.org/r1457637 Log: Review of r1457429: Make logic more clear. No functional change. Modified: tomcat/trunk/java/org/apache/tomcat/websocket/pojo/PojoMethodMapping.java Modified: tomcat/trunk/java/org

Re: svn commit: r1457403 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/tomcat/util/http/parser/HttpParser.java

2013-03-17 Thread Konstantin Kolinko
2013/3/17 : > Author: markt > Date: Sun Mar 17 09:33:41 2013 > New Revision: 1457403 > > URL: http://svn.apache.org/r1457403 > Log: > There was a reason mark/reset was used here. Restore use of mark/reset and > add a comment. > > Modified: > tomcat/tc7.0.x/trunk/ (props changed) > > to

[Bug 54715] New: WebSocket implementation never calls ServerEndpointConfig.Configurator#modifyHandshake()

2013-03-17 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=54715 Bug ID: 54715 Summary: WebSocket implementation never calls ServerEndpointConfig.Configurator#modifyHandshake() Product: Tomcat 8 Version: trunk Hardware: All

[Bug 54715] WebSocket implementation never calls ServerEndpointConfig.Configurator#modifyHandshake()

2013-03-17 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=54715 Nick Williams changed: What|Removed |Added Attachment #30062|0 |1 is patch|

[Bug 54716] New: WebSocket implementation "freaks out" if Session closed or exception thrown from onOpen method

2013-03-17 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=54716 Bug ID: 54716 Summary: WebSocket implementation "freaks out" if Session closed or exception thrown from onOpen method Product: Tomcat 8 Version: trunk Hardware: All