svn commit: r1447145 - /tomcat/trunk/java/org/apache/catalina/storeconfig/CatalinaClusterSF.java

2013-02-18 Thread kfujino
Author: kfujino Date: Mon Feb 18 08:15:02 2013 New Revision: 1447145 URL: http://svn.apache.org/r1447145 Log: Avoid duplicated store of ClusterDeployer. FarmWarDeployer extends ClusterListener and implements ClusterDeployer. Modified: tomcat/trunk/java/org/apache/catalina/storeconfig/Catalina

Re: svn commit: r1447145 - /tomcat/trunk/java/org/apache/catalina/storeconfig/CatalinaClusterSF.java

2013-02-18 Thread Konstantin Kolinko
2013/2/18 : > Author: kfujino > Date: Mon Feb 18 08:15:02 2013 > New Revision: 1447145 > > URL: http://svn.apache.org/r1447145 > Log: > Avoid duplicated store of ClusterDeployer. > FarmWarDeployer extends ClusterListener and implements ClusterDeployer. > > Modified: > tomcat/trunk/java/org/apa

svn commit: r1447171 - in /tomcat/trunk/java/org/apache/tomcat/jni/socket: AprSocket.java AprSocketContext.java

2013-02-18 Thread markt
Author: markt Date: Mon Feb 18 09:36:08 2013 New Revision: 1447171 URL: http://svn.apache.org/r1447171 Log: Fix checkstyle warnings (sorry new laptop - need to configure it properly) Modified: tomcat/trunk/java/org/apache/tomcat/jni/socket/AprSocket.java tomcat/trunk/java/org/apache/tomca

Re: svn commit: r1447074 - in /tomcat/trunk/java/org/apache/tomcat/jni/socket: AprSocket.java AprSocketContext.java

2013-02-18 Thread Mark Thomas
On 17/02/2013 21:48, Konstantin Kolinko wrote: > Adding "finals" to apparent constant fields is OK (e.g. those > CONNECTING, CONNECTED fields), but generic reducing visibilities here > and there seems wrong. o.a.tomcat.jni.socket is the package added for spdy support. The code is still a work in p

svn commit: r1447173 - in /tomcat/trunk/java/org/apache: catalina/valves/rewrite/ jasper/runtime/ jasper/tagplugins/jstl/ jasper/xmlparser/ tomcat/websocket/

2013-02-18 Thread markt
Author: markt Date: Mon Feb 18 09:50:46 2013 New Revision: 1447173 URL: http://svn.apache.org/r1447173 Log: Fix checkstyle warnings (sorry new laptop) Modified: tomcat/trunk/java/org/apache/catalina/valves/rewrite/RewriteCond.java tomcat/trunk/java/org/apache/jasper/runtime/JspWriterImpl.

svn commit: r1447174 - in /tomcat/trunk/java/org/apache/tomcat/websocket: WsSession.java WsWebSocketContainer.java

2013-02-18 Thread markt
Author: markt Date: Mon Feb 18 09:52:09 2013 New Revision: 1447174 URL: http://svn.apache.org/r1447174 Log: Consistent naming Modified: tomcat/trunk/java/org/apache/tomcat/websocket/WsSession.java tomcat/trunk/java/org/apache/tomcat/websocket/WsWebSocketContainer.java Modified: tomcat/tr

svn commit: r1447175 - /tomcat/trunk/java/org/apache/tomcat/websocket/WsWebSocketContainer.java

2013-02-18 Thread markt
Author: markt Date: Mon Feb 18 09:55:16 2013 New Revision: 1447175 URL: http://svn.apache.org/r1447175 Log: Need to lock on read too Modified: tomcat/trunk/java/org/apache/tomcat/websocket/WsWebSocketContainer.java Modified: tomcat/trunk/java/org/apache/tomcat/websocket/WsWebSocketContainer

Re: svn commit: r1445893 - in /tomcat/trunk: java/javax/websocket/ java/org/apache/tomcat/websocket/ java/org/apache/tomcat/websocket/server/ test/org/apache/tomcat/websocket/

2013-02-18 Thread Mark Thomas
On 18/02/2013 00:02, Konstantin Kolinko wrote: > 2013/2/14 : >> @Override >> public Set getOpenSessions() { >> -// TODO Auto-generated method stub >> -return null; >> +return webSocketContainer.getOpenSession(localEndpoint.getClass()); > > Inconsistent method na

svn commit: r1447178 - /tomcat/trunk/java/javax/servlet/http/Part.java

2013-02-18 Thread markt
Author: markt Date: Mon Feb 18 10:06:16 2013 New Revision: 1447178 URL: http://svn.apache.org/r1447178 Log: Improve Javadoc. Clarify difference between spec minimum behaviour and what Tomcat does. Modified: tomcat/trunk/java/javax/servlet/http/Part.java Modified: tomcat/trunk/java/javax/ser

svn commit: r1447181 - in /tomcat/tc7.0.x/trunk: ./ java/javax/servlet/http/Part.java

2013-02-18 Thread markt
Author: markt Date: Mon Feb 18 10:13:25 2013 New Revision: 1447181 URL: http://svn.apache.org/r1447181 Log: Improve Javadoc. Clarify difference between spec minimum behaviour and what Tomcat does. Modified: tomcat/tc7.0.x/trunk/ (props changed) tomcat/tc7.0.x/trunk/java/javax/servlet/h

[VOTE][RESULT] Release Apache Tomcat 7.0.37

2013-02-18 Thread Mark Thomas
Stable Binding: jfarcand, rjung, yoavs, mturk, kfujino, kkolinko, olamy, markt Non-binding: Arne Franken, violetagg No other votes were cast. This vote therefore passes. I'll start moving the bits to the release locations. I'll update the site once the mirrors have had a chance t

svn commit: r1424 - /release/tomcat/tomcat-7/v7.0.34/

2013-02-18 Thread markt
Author: markt Date: Mon Feb 18 10:48:28 2013 New Revision: 1424 Log: Remove old release Removed: release/tomcat/tomcat-7/v7.0.34/ - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail:

svn commit: r1424 - /release/tomcat/tomcat-7/v7.0.34/

2013-02-18 Thread markt
Author: markt Date: Mon Feb 18 10:48:28 2013 New Revision: 1424 Log: Remove old release Removed: release/tomcat/tomcat-7/v7.0.34/ - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail:

svn commit: r1425 - /dev/tomcat/tomcat-7/v7.0.37/ /release/tomcat/tomcat-7/v7.0.37/

2013-02-18 Thread markt
Author: markt Date: Mon Feb 18 10:50:08 2013 New Revision: 1425 Log: Release v7.0.37 Added: release/tomcat/tomcat-7/v7.0.37/ - copied from r1424, dev/tomcat/tomcat-7/v7.0.37/ Removed: dev/tomcat/tomcat-7/v7.0.37/

svn commit: r1425 - /dev/tomcat/tomcat-7/v7.0.37/ /release/tomcat/tomcat-7/v7.0.37/

2013-02-18 Thread markt
Author: markt Date: Mon Feb 18 10:50:08 2013 New Revision: 1425 Log: Release v7.0.37 Added: release/tomcat/tomcat-7/v7.0.37/ - copied from r1424, dev/tomcat/tomcat-7/v7.0.37/ Removed: dev/tomcat/tomcat-7/v7.0.37/

svn commit: r1447188 - /tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml

2013-02-18 Thread markt
Author: markt Date: Mon Feb 18 11:06:03 2013 New Revision: 1447188 URL: http://svn.apache.org/r1447188 Log: Fix typo Modified: tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml Modified: tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml URL: http://svn.apache.org/viewvc/tomcat/tc7.0.x/trunk/web

svn commit: r1447191 - /tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml

2013-02-18 Thread markt
Author: markt Date: Mon Feb 18 11:08:24 2013 New Revision: 1447191 URL: http://svn.apache.org/r1447191 Log: Another typo Modified: tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml Modified: tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml URL: http://svn.apache.org/viewvc/tomcat/tc7.0.x/trunk

[Bug 54527] Synchronize conf/web.xml mime mapping with Tomcat 7

2013-02-18 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=54527 --- Comment #4 from Mark Thomas --- The proposed patch creates duplicate definitions for: htke, odft, oti, svc, svd, text, tfi, tfm, tga, thmx, s, s3m, saf, sbml, sc, scd, scm, scq, scs, scurl, sda, sdc, sdd, sdkd, sdkm, sdp, sdw, see, seed

[Bug 54527] Synchronize conf/web.xml mime mapping with Tomcat 7

2013-02-18 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=54527 Mark Thomas changed: What|Removed |Added Attachment #29952|0 |1 is obsolete|

svn commit: r1447254 - /tomcat/tc6.0.x/trunk/STATUS.txt

2013-02-18 Thread markt
Author: markt Date: Mon Feb 18 13:42:50 2013 New Revision: 1447254 URL: http://svn.apache.org/r1447254 Log: Proposal Modified: tomcat/tc6.0.x/trunk/STATUS.txt Modified: tomcat/tc6.0.x/trunk/STATUS.txt URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=1447254&r1=1447253&r

[Bug 54527] Synchronize conf/web.xml mime mapping with Tomcat 7

2013-02-18 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=54527 --- Comment #6 from Mark Thomas --- Updated patch proposed for 6.0.x. -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail:

[Tomcat Wiki] Trivial Update of "JerrodPim" by JerrodPim

2013-02-18 Thread Apache Wiki
Dear Wiki user, You have subscribed to a wiki page or wiki category on "Tomcat Wiki" for change notification. The "JerrodPim" page has been changed by JerrodPim: http://wiki.apache.org/tomcat/JerrodPim New page: Nothing to say about myself really.<> Yes! Im a part of this community.<> I just wi

[Tomcat Wiki] Update of "LocalBadContent" by ChuckCaldarale

2013-02-18 Thread Apache Wiki
Dear Wiki user, You have subscribed to a wiki page or wiki category on "Tomcat Wiki" for change notification. The "LocalBadContent" page has been changed by ChuckCaldarale: http://wiki.apache.org/tomcat/LocalBadContent?action=diff&rev1=73&rev2=74 celular-mobile\.com chatsky\.cn cheapestoe

svn commit: r1447296 - /tomcat/maven-plugin/trunk/pom.xml

2013-02-18 Thread olamy
Author: olamy Date: Mon Feb 18 15:08:35 2013 New Revision: 1447296 URL: http://svn.apache.org/r1447296 Log: use 7.0.37 Modified: tomcat/maven-plugin/trunk/pom.xml Modified: tomcat/maven-plugin/trunk/pom.xml URL: http://svn.apache.org/viewvc/tomcat/maven-plugin/trunk/pom.xml?rev=1447296&r1=1

[jira] [Updated] (MTOMCAT-208) JaCoCo instrumentation errors when running StandaloneWarMojo

2013-02-18 Thread Tim Astle (JIRA)
[ https://issues.apache.org/jira/browse/MTOMCAT-208?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tim Astle updated MTOMCAT-208: -- Attachment: StandaloneWarMojo.java.patch > JaCoCo instrumentation errors when running StandaloneWa

[jira] [Created] (MTOMCAT-208) JaCoCo instrumentation errors when running StandaloneWarMojo

2013-02-18 Thread Tim Astle (JIRA)
Tim Astle created MTOMCAT-208: - Summary: JaCoCo instrumentation errors when running StandaloneWarMojo Key: MTOMCAT-208 URL: https://issues.apache.org/jira/browse/MTOMCAT-208 Project: Apache Tomcat Maven P

[jira] [Commented] (MTOMCAT-208) JaCoCo instrumentation errors when running StandaloneWarMojo

2013-02-18 Thread Tim Astle (JIRA)
[ https://issues.apache.org/jira/browse/MTOMCAT-208?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13580736#comment-13580736 ] Tim Astle commented on MTOMCAT-208: --- If anyone has any suggestions on the best way to a

svn commit: r1447458 [50/50] - in /tomcat/site/trunk/docs/tomcat-7.0-doc: ./ api/ api/org/apache/catalina/ api/org/apache/catalina/ant/ api/org/apache/catalina/ant/jmx/ api/org/apache/catalina/authent

2013-02-18 Thread markt
Modified: tomcat/site/trunk/docs/tomcat-7.0-doc/windows-auth-howto.html URL: http://svn.apache.org/viewvc/tomcat/site/trunk/docs/tomcat-7.0-doc/windows-auth-howto.html?rev=1447458&r1=1447457&r2=1447458&view=diff == --- tom

svn commit: r1447463 - in /tomcat/site/trunk: ./ docs/ xdocs/

2013-02-18 Thread markt
Author: markt Date: Mon Feb 18 20:24:01 2013 New Revision: 1447463 URL: http://svn.apache.org/r1447463 Log: Update for 7.0.37 release Modified: tomcat/site/trunk/build.properties.default tomcat/site/trunk/docs/doap_Tomcat.rdf tomcat/site/trunk/docs/download-70.html tomcat/site/tru

[ANN] Apache Tomcat 7.0.37 released

2013-02-18 Thread Mark Thomas
The Apache Tomcat team announces the immediate availability of Apache Tomcat 7.0.37. Apache Tomcat is an open source software implementation of the Java Servlet and JavaServer Pages technologies. This release contains a small number of bug fixes and improvements compared to version 7.0.35. The not

svn commit: r1447471 - in /tomcat/site/trunk: docs/index.html xdocs/index.xml

2013-02-18 Thread markt
Author: markt Date: Mon Feb 18 20:30:05 2013 New Revision: 1447471 URL: http://svn.apache.org/r1447471 Log: Fix typo Modified: tomcat/site/trunk/docs/index.html tomcat/site/trunk/xdocs/index.xml Modified: tomcat/site/trunk/docs/index.html URL: http://svn.apache.org/viewvc/tomcat/site/tr

[jira] [Commented] (MTOMCAT-208) JaCoCo instrumentation errors when running StandaloneWarMojo

2013-02-18 Thread *$^¨%`£
[ https://issues.apache.org/jira/browse/MTOMCAT-208?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13580825#comment-13580825 ] Olivier Lamy (*$^¨%`£) commented on MTOMCAT-208: standalone-war-only soun

[jira] [Updated] (MTOMCAT-208) JaCoCo instrumentation errors when running StandaloneWarMojo

2013-02-18 Thread *$^¨%`£
[ https://issues.apache.org/jira/browse/MTOMCAT-208?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Olivier Lamy (*$^¨%`£) updated MTOMCAT-208: --- Component/s: tomcat6 Fix Version/s: 2.1 > JaCoCo instrumentation e

svn commit: r1447527 - /tomcat/trunk/java/org/apache/tomcat/websocket/WsSession.java

2013-02-18 Thread markt
Author: markt Date: Mon Feb 18 22:51:48 2013 New Revision: 1447527 URL: http://svn.apache.org/r1447527 Log: UCdetector: Add final Modified: tomcat/trunk/java/org/apache/tomcat/websocket/WsSession.java Modified: tomcat/trunk/java/org/apache/tomcat/websocket/WsSession.java URL: http://svn.apa

svn commit: r1447529 - /tomcat/trunk/java/org/apache/tomcat/websocket/WsRemoteEndpointBase.java

2013-02-18 Thread markt
Author: markt Date: Mon Feb 18 22:54:44 2013 New Revision: 1447529 URL: http://svn.apache.org/r1447529 Log: Use final. Use imports. Don't make log static Modified: tomcat/trunk/java/org/apache/tomcat/websocket/WsRemoteEndpointBase.java Modified: tomcat/trunk/java/org/apache/tomcat/websocket

Re: svn commit: r1447074 - in /tomcat/trunk/java/org/apache/tomcat/jni/socket: AprSocket.java AprSocketContext.java

2013-02-18 Thread Konstantin Kolinko
2013/2/18 Mark Thomas : > On 17/02/2013 21:48, Konstantin Kolinko wrote: >> Adding "finals" to apparent constant fields is OK (e.g. those >> CONNECTING, CONNECTED fields), but generic reducing visibilities here >> and there seems wrong. > > o.a.tomcat.jni.socket is the package added for spdy suppor

svn commit: r1447548 - in /tomcat/trunk/java/org/apache/tomcat/websocket: WsSession.java WsWebSocketContainer.java server/WsProtocolHandler.java server/WsServlet.java

2013-02-18 Thread markt
Author: markt Date: Mon Feb 18 23:16:53 2013 New Revision: 1447548 URL: http://svn.apache.org/r1447548 Log: Server side wss support Modified: tomcat/trunk/java/org/apache/tomcat/websocket/WsSession.java tomcat/trunk/java/org/apache/tomcat/websocket/WsWebSocketContainer.java tomcat/tru

Re: svn commit: r1447529 - /tomcat/trunk/java/org/apache/tomcat/websocket/WsRemoteEndpointBase.java

2013-02-18 Thread Konstantin Kolinko
2013/2/19 : > Author: markt > Date: Mon Feb 18 22:54:44 2013 > New Revision: 1447529 > > URL: http://svn.apache.org/r1447529 > Log: > Use final. > Use imports. > Don't make log static Why? "log" is a private field and how it is created it cannot have different values in different threads. I do

Re: svn commit: r1447529 - /tomcat/trunk/java/org/apache/tomcat/websocket/WsRemoteEndpointBase.java

2013-02-18 Thread Mark Thomas
On 18/02/2013 23:24, Konstantin Kolinko wrote: 2013/2/19 : Author: markt Date: Mon Feb 18 22:54:44 2013 New Revision: 1447529 URL: http://svn.apache.org/r1447529 Log: Use final. Use imports. Don't make log static Why? "log" is a private field and how it is created it cannot have different

svn commit: r1447565 - /tomcat/trunk/java/org/apache/catalina/storeconfig/CatalinaClusterSF.java

2013-02-18 Thread kfujino
Author: kfujino Date: Tue Feb 19 01:13:08 2013 New Revision: 1447565 URL: http://svn.apache.org/r1447565 Log: Fix Konstantin's comments. more generic. Modified: tomcat/trunk/java/org/apache/catalina/storeconfig/CatalinaClusterSF.java Modified: tomcat/trunk/java/org/apache/catalina/storeconf

Re: svn commit: r1447145 - /tomcat/trunk/java/org/apache/catalina/storeconfig/CatalinaClusterSF.java

2013-02-18 Thread Keiichi Fujino
2013/2/18 Konstantin Kolinko : > 2013/2/18 : >> Author: kfujino >> Date: Mon Feb 18 08:15:02 2013 >> New Revision: 1447145 >> >> URL: http://svn.apache.org/r1447145 >> Log: >> Avoid duplicated store of ClusterDeployer. >> FarmWarDeployer extends ClusterListener and implements ClusterDeployer. >> >

svn commit: r1447569 - /tomcat/trunk/java/org/apache/catalina/storeconfig/StandardEngineSF.java

2013-02-18 Thread kfujino
Author: kfujino Date: Tue Feb 19 01:48:17 2013 New Revision: 1447569 URL: http://svn.apache.org/r1447569 Log: Improve support for Engine level cluster. Excludes ClusterValve from Engine Valves. Modified: tomcat/trunk/java/org/apache/catalina/storeconfig/StandardEngineSF.java Modified: tomca

[jira] [Updated] (MTOMCAT-208) JaCoCo instrumentation errors when running StandaloneWarMojo

2013-02-18 Thread Tim Astle (JIRA)
[ https://issues.apache.org/jira/browse/MTOMCAT-208?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tim Astle updated MTOMCAT-208: -- Attachment: tomcat-maven-plugin.patch This patch creates a new StandaloneWarOnlyMojo.java class and fi

[jira] [Commented] (MTOMCAT-208) JaCoCo instrumentation errors when running StandaloneWarMojo

2013-02-18 Thread Tim Astle (JIRA)
[ https://issues.apache.org/jira/browse/MTOMCAT-208?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13580956#comment-13580956 ] Tim Astle commented on MTOMCAT-208: --- btw, what has to be updated in the tomcat6-maven-p

svn commit: r1447596 - in /tomcat/trunk/java/org/apache/catalina/storeconfig: InterceptorSF.java server-registry.xml

2013-02-18 Thread kfujino
Author: kfujino Date: Tue Feb 19 05:52:16 2013 New Revision: 1447596 URL: http://svn.apache.org/r1447596 Log: Improvements of InterceptorSF. - Add support for static membership. - Interceptor except StaticMembershipInterceptor has no child elements. Modified: tomcat/trunk/java/org/apache/cata