svn commit: r1345846 - in /tomcat/trunk/java/org/apache: catalina/deploy/NamingResources.java tomcat/util/net/AbstractEndpoint.java

2012-06-04 Thread kkolinko
Author: kkolinko Date: Mon Jun 4 07:24:02 2012 New Revision: 1345846 URL: http://svn.apache.org/viewvc?rev=1345846&view=rev Log: Code formatting (indents). No functional change. Modified: tomcat/trunk/java/org/apache/catalina/deploy/NamingResources.java tomcat/trunk/java/org/apache/tomca

svn commit: r1345848 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/catalina/deploy/NamingResources.java java/org/apache/tomcat/util/net/AbstractEndpoint.java

2012-06-04 Thread kkolinko
Author: kkolinko Date: Mon Jun 4 07:27:46 2012 New Revision: 1345848 URL: http://svn.apache.org/viewvc?rev=1345848&view=rev Log: Merged revision 1345846 from tomcat/trunk: Code formatting (indents). No functional change. Modified: tomcat/tc7.0.x/trunk/ (props changed) tomcat/tc7.0.x/tr

[Bug 38774] try using keyStorePassword property if set

2012-06-04 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=38774 --- Comment #4 from Konstantin Kolinko --- (In reply to comment #3) If you do care, you should open a new bug report and provide enough details to reproduce the issue. Commenting on a 6-year old issue is wrong. A lot has changed. Do not fo

Re: svn commit: r1335700 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/catalina/connector/ java/org/apache/catalina/core/ java/org/apache/catalina/startup/ webapps/docs/

2012-06-04 Thread Mark Thomas
On 04/06/2012 07:55, Konstantin Kolinko wrote: > 2012/5/8 : >> Author: markt >> Date: Tue May 8 19:07:09 2012 >> New Revision: 1335700 >> >> URL: http://svn.apache.org/viewvc?rev=1335700&view=rev >> Log: >> It appears that pausing requests for a Context during reload was relying on >> the mapper

Re: svn commit: r1344253 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/coyote/ajp/AjpAprProcessor.java webapps/docs/changelog.xml

2012-06-04 Thread Mark Thomas
On 04/06/2012 07:41, Konstantin Kolinko wrote: > 2012/5/30 : >> Author: markt >> Date: Wed May 30 13:35:55 2012 >> New Revision: 1344253 >> >> URL: http://svn.apache.org/viewvc?rev=1344253&view=rev >> Log: >> Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=53119 >> Make sure the buffer is c

Re: svn commit: r1335700 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/catalina/connector/ java/org/apache/catalina/core/ java/org/apache/catalina/startup/ webapps/docs/

2012-06-04 Thread Konstantin Kolinko
2012/6/4 Mark Thomas : > On 04/06/2012 07:55, Konstantin Kolinko wrote: >> 2012/5/8  : >>> Author: markt >>> Date: Tue May  8 19:07:09 2012 >>> New Revision: 1335700 >>> >>> URL: http://svn.apache.org/viewvc?rev=1335700&view=rev >>> Log: >>> It appears that pausing requests for a Context during rel

[Bug 52723] An incomplete fix for the resource leak bugs in StandardManager.java

2012-06-04 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=52723 --- Comment #5 from liangg...@sei.pku.edu.cn --- Hi, Konstantin, can you explain more about your new comment (Comment 4)? Does the BufferedOutputStream temp object need to be closed in this code piece? -- You are receiving this mail becau

[GUMP@vmgump]: Project tomcat-tc7.0.x-test (in module tomcat-7.0.x) failed

2012-06-04 Thread Bill Barker
To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at gene...@gump.apache.org. Project tomcat-tc7.0.x-test has an issue affecting its community integration. This

[GUMP@vmgump]: Project tomcat-trunk-test (in module tomcat-trunk) failed

2012-06-04 Thread Bill Barker
To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at gene...@gump.apache.org. Project tomcat-trunk-test has an issue affecting its community integration. This i

RE: svn commit: r1345848 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/catalina/deploy/NamingResources.java java/org/apache/tomcat/util/net/AbstractEndpoint.java

2012-06-04 Thread Filip Hanik (mailing lists)
Ok, this is back to code discipline. At some point, we'd have to expect that more users will adopt v7 in production (I'm still seeing 80%+ being on v6), at that point, commits like this do nothing except pollute the diffs. Servlet 3.1 has released a draft, where I'd expect that trunk is headed.

Re: svn commit: r1345848 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/catalina/deploy/NamingResources.java java/org/apache/tomcat/util/net/AbstractEndpoint.java

2012-06-04 Thread Mark Thomas
On 04/06/2012 17:05, Filip Hanik (mailing lists) wrote: > > Ok, this is back to code discipline. At some point, we'd have to > expect that more users will adopt v7 in production (I'm still seeing > 80%+ being on v6), at that point, commits like this do nothing except > pollute the diffs. It depen

[jira] [Created] (MTOMCAT-159) WAR dependencies extracted every run

2012-06-04 Thread Robert Hollencamp (JIRA)
Robert Hollencamp created MTOMCAT-159: - Summary: WAR dependencies extracted every run Key: MTOMCAT-159 URL: https://issues.apache.org/jira/browse/MTOMCAT-159 Project: Apache Tomcat Maven Plugin

[jira] [Updated] (MTOMCAT-159) WAR dependencies extracted every run

2012-06-04 Thread Robert Hollencamp (JIRA)
[ https://issues.apache.org/jira/browse/MTOMCAT-159?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Hollencamp updated MTOMCAT-159: -- Attachment: MTOMCAT-159-1.diff implementation > WAR dependencies extr

[Bug 53356] New: Mapping a servlet to the applicatio​n's context root results in IAE

2012-06-04 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=53356 Priority: P2 Bug ID: 53356 Assignee: dev@tomcat.apache.org Summary: Mapping a servlet to the applicatio​n's context root results in IAE Severity: normal Classificat

RE: svn commit: r1345848 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/catalina/deploy/NamingResources.java java/org/apache/tomcat/util/net/AbstractEndpoint.java

2012-06-04 Thread Filip Hanik (mailing lists)
> -Original Message- > From: Mark Thomas [mailto:ma...@apache.org] > Sent: Monday, June 04, 2012 12:41 PM > To: Tomcat Developers List > Subject: Re: svn commit: r1345848 - in /tomcat/tc7.0.x/trunk: ./ > java/org/apache/catalina/deploy/NamingResources.java > java/org/apache/tomcat/util/ne

svn commit: r1346107 - /tomcat/trunk/java/org/apache/catalina/deploy/NamingResources.java

2012-06-04 Thread markt
Author: markt Date: Mon Jun 4 19:38:00 2012 New Revision: 1346107 URL: http://svn.apache.org/viewvc?rev=1346107&view=rev Log: Rework fix for https://issues.apache.org/bugzilla/show_bug.cgi?id=5 Modified: tomcat/trunk/java/org/apache/catalina/deploy/NamingResources.java Modified: tomcat/

svn commit: r1346109 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/catalina/deploy/NamingResources.java

2012-06-04 Thread markt
Author: markt Date: Mon Jun 4 19:40:06 2012 New Revision: 1346109 URL: http://svn.apache.org/viewvc?rev=1346109&view=rev Log: Rework fix for https://issues.apache.org/bugzilla/show_bug.cgi?id=5 Modified: tomcat/tc7.0.x/trunk/ (props changed) tomcat/tc7.0.x/trunk/java/org/apache/cat

Re: svn commit: r1345580 - in /tomcat/trunk/java/org/apache/catalina/deploy: LocalStrings.properties NamingResources.java

2012-06-04 Thread Mark Thomas
On 03/06/2012 23:58, Mark Thomas wrote: > Konstantin Kolinko wrote: >> Does something guarantee that there is always common type among >> injection targets? >> >> Can there be two disjoint interfaces A and B, which are both >> implemented by a resource, so assignment to A or B should succeed,

[Bug 53337] IllegalStateException when trying to render a JSP after startAsync

2012-06-04 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=53337 --- Comment #7 from rstoyanc...@yahoo.com --- Thanks for the suggestions, Mark. In the discussion on the servlet-spec user list, even wider implications were mentioned including avoiding reliance on the requestURI or even the session from a

Tomcat 7 code policy (was: Re: svn commit: r1345848)

2012-06-04 Thread Konstantin Kolinko
2012/6/4 Filip Hanik (mailing lists) : > > Ok, this is back to code discipline. At some point, we'd have to expect that > more users will adopt v7 in production (I'm still seeing 80%+ being on v6), > at that point, commits like this do nothing except pollute the diffs. > There were two fixes in

buildbot success in ASF Buildbot on tomcat-7-trunk

2012-06-04 Thread buildbot
The Buildbot has detected a restored build on builder tomcat-7-trunk while building ASF Buildbot. Full details are available at: http://ci.apache.org/builders/tomcat-7-trunk/builds/623 Buildbot URL: http://ci.apache.org/ Buildslave for this Build: bb-vm_ubuntu Build Reason: scheduler Build Sou

[Bug 53356] Mapping a servlet to the applicatio​n's context root results in IAE

2012-06-04 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=53356 --- Comment #1 from Mark Thomas --- Not fixed yet but as an aside you'll need to use not "" -- You are receiving this mail because: You are the assignee for the bug. -

Re: Tomcat 7 code policy (was: Re: svn commit: r1345848)

2012-06-04 Thread Konstantin Kolinko
2012/6/5 Konstantin Kolinko : >> >> For that reason, I'd like us to be more conscious about our commits on v7 >> and start looking at v7 as bug fixes and stabilization as the primary >> drivers for commits. > > Stabilization usually means that we stop fixing bugs in "stable" > version besides eas

Re: svn commit: r1345580 - in /tomcat/trunk/java/org/apache/catalina/deploy: LocalStrings.properties NamingResources.java

2012-06-04 Thread Konstantin Kolinko
2012/6/4 Mark Thomas : > On 03/06/2012 23:58, Mark Thomas wrote: > >> Konstantin Kolinko wrote: > >>> Does something guarantee that there is always common type among >>> injection targets? >>> >>> Can there be two disjoint interfaces A and B, which are both >>> implemented by a resource, so assign

[Bug 52723] An incomplete fix for the resource leak bugs in StandardManager.java

2012-06-04 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=52723 --- Comment #6 from Konstantin Kolinko --- (In reply to comment #5) 1. BufferedOutputStream does not deserve closing, because it is in memory only. No native resources are leaking. - ObjectOutputStream would never need to be closed. If an

[Bug 53359] New: Request for or as element inside

2012-06-04 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=53359 Priority: P2 Bug ID: 53359 Assignee: dev@tomcat.apache.org Summary: Request for or as element inside Severity: enhancement Classification: Unclassified

Re: svn commit: r1341370 - in /tomcat/tc7.0.x/trunk: java/org/apache/catalina/startup/ContextConfig.java webapps/docs/changelog.xml

2012-06-04 Thread Konstantin Kolinko
2012/5/28 Keiichi Fujino : > Thanks for the review. > I fixed it. > > I implemented the calculation method of host's default config path to > Host(StanderdHost). > just like a Host#getAppBaseFile(). > This fix is applied only to trunk. > > If there is a different implementation idea, feel free to r

[GUMP@vmgump]: Project tomcat-tc7.0.x-test (in module tomcat-7.0.x) failed

2012-06-04 Thread Bill Barker
To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at gene...@gump.apache.org. Project tomcat-tc7.0.x-test has an issue affecting its community integration. This

[GUMP@vmgump]: Project tomcat-trunk-test (in module tomcat-trunk) failed

2012-06-04 Thread Bill Barker
To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at gene...@gump.apache.org. Project tomcat-trunk-test has an issue affecting its community integration. This i