svn commit: r1198640 - /tomcat/trunk/java/org/apache/tomcat/util/http/Parameters.java

2011-11-07 Thread kkolinko
Author: kkolinko Date: Mon Nov 7 08:25:02 2011 New Revision: 1198640 URL: http://svn.apache.org/viewvc?rev=1198640&view=rev Log: Restore handleQueryParameters() call that was lost in r1189882 This is not covered by our tests. Modified: tomcat/trunk/java/org/apache/tomcat/util/http/Parameters

svn commit: r1198641 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/tomcat/util/http/Parameters.java

2011-11-07 Thread kkolinko
Author: kkolinko Date: Mon Nov 7 08:26:42 2011 New Revision: 1198641 URL: http://svn.apache.org/viewvc?rev=1198641&view=rev Log: Merged revision 1198640 from tomcat/trunk: Restore handleQueryParameters() call that was lost in r1189882 Modified: tomcat/tc7.0.x/trunk/ (props changed) tom

svn commit: r1198649 - /tomcat/tc6.0.x/trunk/STATUS.txt

2011-11-07 Thread kkolinko
Author: kkolinko Date: Mon Nov 7 08:30:06 2011 New Revision: 1198649 URL: http://svn.apache.org/viewvc?rev=1198649&view=rev Log: Add note Modified: tomcat/tc6.0.x/trunk/STATUS.txt Modified: tomcat/tc6.0.x/trunk/STATUS.txt URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?re

Re: svn commit: r1198640 - /tomcat/trunk/java/org/apache/tomcat/util/http/Parameters.java

2011-11-07 Thread Konstantin Kolinko
2011/11/7 : > Author: kkolinko > Date: Mon Nov  7 08:25:02 2011 > New Revision: 1198640 > > URL: http://svn.apache.org/viewvc?rev=1198640&view=rev > Log: > Restore handleQueryParameters() call that was lost in r1189882 > This is not covered by our tests. > > Modified: >    tomcat/trunk/java/org/ap

Unsubscribe From Mailing List

2011-11-07 Thread joshua . morris1
How do I unsubscribe

Re: Unsubscribe From Mailing List

2011-11-07 Thread Konstantin Kolinko
2011/11/7 joshua.morris1 : > How do I unsubscribe > > http://www.apache.org/foundation/mailinglists.html Send a short plain text e-mail to the unsubscription address mentioned here: http://tomcat.apache.org/lists.html You will receive a confirmation e-mail. You should reply to it to confirm unsu

svn commit: r1198677 - /tomcat/trunk/java/org/apache/catalina/Globals.java

2011-11-07 Thread kkolinko
Author: kkolinko Date: Mon Nov 7 09:42:55 2011 New Revision: 1198677 URL: http://svn.apache.org/viewvc?rev=1198677&view=rev Log: Add constants for the request attribute names used by Comet and Sendfile support. Modified: tomcat/trunk/java/org/apache/catalina/Globals.java Modified: tomcat/t

svn commit: r1198696 - in /tomcat/trunk/java/org/apache: catalina/Globals.java catalina/connector/Request.java catalina/filters/FailedRequestFilter.java tomcat/util/http/Parameters.java

2011-11-07 Thread kkolinko
Author: kkolinko Date: Mon Nov 7 10:46:14 2011 New Revision: 1198696 URL: http://svn.apache.org/viewvc?rev=1198696&view=rev Log: Introduce new request attribute to be used to mark request if there was a failure during parameter parsing, and a Filter that triggers parameter parsing and rejects re

svn commit: r1198707 - in /tomcat/trunk/java/org/apache/catalina: connector/Request.java filters/FailedRequestFilter.java

2011-11-07 Thread kkolinko
Author: kkolinko Date: Mon Nov 7 11:30:51 2011 New Revision: 1198707 URL: http://svn.apache.org/viewvc?rev=1198707&view=rev Log: Followup to r1198696: - Fix bug in Request#parseParameters(): Forgot to flag the main use case of parsing POST parameters as successful. - Update comment in FailedReque

FailedRequestFilter

2011-11-07 Thread Konstantin Kolinko
Hi! In trunk I committed a new feature: request attribute that is set if there were problems during parameter parsing and FailedRequestFilter - filter that rejects requests if that request attribute is set. I would like this to be ported to TC7 and earlier versions up to 5.5, but will wait a whil

Re: Redeploy on context.xml changes (Was: Tagging 7.0.23)

2011-11-07 Thread Konstantin Kolinko
2011/11/6 Konstantin Kolinko : > 2011/11/6 Mark Thomas : >> >> I'm in two minds whether to apply this patch before or after the 7.0.23 >> tag. There are clearly issues here that need fixing but the patch is >> quite invasive. I'm leaning towards tagging after the patch is applied. >> Thoughts? >> >

Re: FailedRequestFilter

2011-11-07 Thread Konstantin Kolinko
2011/11/7 Konstantin Kolinko : > Hi! > > In trunk I committed a new feature: request attribute that is set if > there were problems during parameter parsing and FailedRequestFilter - > filter that rejects requests if that request attribute is set. > > I would like this to be ported to TC7 and earli

Problem deploying WAR with manager app in trunk

2011-11-07 Thread Konstantin Kolinko
Hi! trunk@1198734, JDK 6u29, WinXP Using a zipped copy of examples webapp, named "examples3.war" Logs use org.apache.juli.OneLineFormatter The FailedContext patch is not applied. (Deleted all /classes and all jars and recompiled - problem reproducible). Steps to reproduce: 1. Login to the manag

svn commit: r1198740 - /tomcat/maven-plugin/trunk/common-tomcat-maven-plugin/src/main/java/org/apache/tomcat/maven/common/run/DefaultClassLoaderEntriesCalculator.java

2011-11-07 Thread olamy
Author: olamy Date: Mon Nov 7 14:06:26 2011 New Revision: 1198740 URL: http://svn.apache.org/viewvc?rev=1198740&view=rev Log: [MTOMCAT-100] support war overlay to add war external dependencies in tomcat run avoid duplicate jars in the webappclassloader: can cause issues with struts2 Modified:

[jira] [Commented] (MTOMCAT-100) support war overlay to add war external dependencies in tomcat run

2011-11-07 Thread Hudson (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/MTOMCAT-100?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13145512#comment-13145512 ] Hudson commented on MTOMCAT-100: Integrated in TomcatMavenPlugin #62 (See [https://build

DO NOT REPLY [Bug 52148] New: Missing jars in catalina-tasks.xml

2011-11-07 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=52148 Bug #: 52148 Summary: Missing jars in catalina-tasks.xml Product: Tomcat 7 Version: 7.0.22 Platform: PC OS/Version: Linux Status: NEW Severity: minor

DO NOT REPLY [Bug 52148] Missing jars in catalina-tasks.xml

2011-11-07 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=52148 --- Comment #1 from Volker Krebs 2011-11-07 15:10:58 UTC --- It's like Bug 51621 -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee f

Re: svn commit: r1198696 - in /tomcat/trunk/java/org/apache: catalina/Globals.java catalina/connector/Request.java catalina/filters/FailedRequestFilter.java tomcat/util/http/Parameters.java

2011-11-07 Thread Rainer Jung
Hi Konstantin, On 07.11.2011 02:46, kkoli...@apache.org wrote: > Author: kkolinko > Date: Mon Nov 7 10:46:14 2011 > New Revision: 1198696 > > URL: http://svn.apache.org/viewvc?rev=1198696&view=rev > Log: > Introduce new request attribute to be used to mark request if there was a > failure durin

DO NOT REPLY [Bug 51653] ServletRequestListener.requestDestroyed is called before request leaves a webapp

2011-11-07 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=51653 --- Comment #8 from Eitan Suez 2011-11-07 17:31:41 UTC --- (In reply to comment #7) > Did you just pick a bug at random and add your comments? > no. > Please join the Tomcat Users mailing list and ask for help there - Bugzilla is > not a

Re: svn commit: r1198696 - in /tomcat/trunk/java/org/apache: catalina/Globals.java catalina/connector/Request.java catalina/filters/FailedRequestFilter.java tomcat/util/http/Parameters.java

2011-11-07 Thread Konstantin Kolinko
2011/11/7 Rainer Jung : > Hi Konstantin, > > On 07.11.2011 02:46, kkoli...@apache.org wrote: >> Author: kkolinko >> Date: Mon Nov  7 10:46:14 2011 >> New Revision: 1198696 >> >> URL: http://svn.apache.org/viewvc?rev=1198696&view=rev >> Log: >> Introduce new request attribute to be used to mark requ

svn commit: r1199122 - in /tomcat/tc6.0.x/trunk: STATUS.txt java/org/apache/catalina/filters/CsrfPreventionFilter.java java/org/apache/catalina/filters/FilterBase.java webapps/docs/changelog.xml

2011-11-07 Thread kkolinko
Author: kkolinko Date: Tue Nov 8 06:37:57 2011 New Revision: 1199122 URL: http://svn.apache.org/viewvc?rev=1199122&view=rev Log: Make configuration issue for CsrfPreventionFilter result in the failure of the filter rather than just a warning message. Modified: tomcat/tc6.0.x/trunk/STATUS.txt

svn commit: r1199139 - in /tomcat/tc6.0.x/trunk: STATUS.txt java/org/apache/catalina/valves/LocalStrings.properties java/org/apache/catalina/valves/RequestFilterValve.java webapps/docs/changelog.xml

2011-11-07 Thread kkolinko
Author: kkolinko Date: Tue Nov 8 07:43:58 2011 New Revision: 1199139 URL: http://svn.apache.org/viewvc?rev=1199139&view=rev Log: Make configuration issue for RemoteAddrValve, RemoteHostValve result in the failure of the valve rather than just a warning message. Ensure changes to the configuration

svn commit: r1199142 - /tomcat/tc5.5.x/trunk/STATUS.txt

2011-11-07 Thread kkolinko
Author: kkolinko Date: Tue Nov 8 07:51:38 2011 New Revision: 1199142 URL: http://svn.apache.org/viewvc?rev=1199142&view=rev Log: Remove veto because the patch was updated, add note Modified: tomcat/tc5.5.x/trunk/STATUS.txt Modified: tomcat/tc5.5.x/trunk/STATUS.txt URL: http://svn.apache.or