Author: kkolinko
Date: Tue Jul 5 07:10:31 2011
New Revision: 1142904
URL: http://svn.apache.org/viewvc?rev=1142904&view=rev
Log:
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=51473
Fix concatenation of values in SecurityConfig.setSecurityProperty()
when the value provided by JRE is null.
Author: kkolinko
Date: Tue Jul 5 07:13:07 2011
New Revision: 1142906
URL: http://svn.apache.org/viewvc?rev=1142906&view=rev
Log:
proposal
Modified:
tomcat/tc5.5.x/trunk/STATUS.txt
tomcat/tc6.0.x/trunk/STATUS.txt
Modified: tomcat/tc5.5.x/trunk/STATUS.txt
URL:
http://svn.apache.org/viewv
https://issues.apache.org/bugzilla/show_bug.cgi?id=51473
Konstantin Kolinko changed:
What|Removed |Added
Component|Catalina|Catalina
Version|7
Author: kkolinko
Date: Tue Jul 5 08:31:52 2011
New Revision: 1142923
URL: http://svn.apache.org/viewvc?rev=1142923&view=rev
Log:
Further improvements to the Windows installer
1. Install into "**/Tomcat7.0_servicename" when service name differs from
default,
but install into "**/Tomcat7.0" if the
Author: kkolinko
Date: Tue Jul 5 08:36:04 2011
New Revision: 1142925
URL: http://svn.apache.org/viewvc?rev=1142925&view=rev
Log:
add recent commit to installer enhancements backport proposal
Modified:
tomcat/tc5.5.x/trunk/STATUS.txt
tomcat/tc6.0.x/trunk/STATUS.txt
Modified: tomcat/tc5.5
2011/7/3 Konstantin Kolinko :
> 2011/7/3 Mark Thomas :
>
> 1) "Windows Service Name" field does not restrict you from putting
> anything there.
>(...)
>
> 2) Tomcat 7 now by default installs into
> "%ProgramFiles%\Apache Software Foundation\Tomcat 7.0\Tomcat7".
>(...)
> BTW, an alternative could be
Author: kkolinko
Date: Tue Jul 5 08:58:19 2011
New Revision: 1142930
URL: http://svn.apache.org/viewvc?rev=1142930&view=rev
Log:
propose backport of fix for BZ 51324
Modified:
tomcat/tc5.5.x/trunk/STATUS.txt
tomcat/tc6.0.x/trunk/STATUS.txt
Modified: tomcat/tc5.5.x/trunk/STATUS.txt
URL:
https://issues.apache.org/bugzilla/show_bug.cgi?id=51324
--- Comment #4 from Konstantin Kolinko 2011-07-05
08:59:07 UTC ---
Proposed for backport to 6.0 and 5.5.
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: --
https://issues.apache.org/bugzilla/show_bug.cgi?id=51475
Bug #: 51475
Summary: GzipInterceptor#decompress is not completly
implemented
Product: Tomcat 6
Version: 6.0.29
Platform: PC
OS/Version: Linux
St
https://issues.apache.org/bugzilla/show_bug.cgi?id=51475
Christian Stöber changed:
What|Removed |Added
CC||cstoe...@amaris.de
--
Configur
Author: markt
Date: Tue Jul 5 10:03:06 2011
New Revision: 1142953
URL: http://svn.apache.org/viewvc?rev=1142953&view=rev
Log:
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=51472
Correctly test modifiers when resolving bean methods with the BeanELResolver.
Patch provided by Friedhelm Kueh
Author: markt
Date: Tue Jul 5 10:04:44 2011
New Revision: 1142955
URL: http://svn.apache.org/viewvc?rev=1142955&view=rev
Log:
Proposal
Modified:
tomcat/tc6.0.x/trunk/STATUS.txt
Modified: tomcat/tc6.0.x/trunk/STATUS.txt
URL:
http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=1
https://issues.apache.org/bugzilla/show_bug.cgi?id=51472
Mark Thomas changed:
What|Removed |Added
Component|Servlet & JSP API |Jasper
Version|7.0.16
Author: rjung
Date: Tue Jul 5 10:08:00 2011
New Revision: 1142959
URL: http://svn.apache.org/viewvc?rev=1142959&view=rev
Log:
Fix response.encodeURL() for the special case of
an absolute URL with no path segment (http://name).
Modified:
tomcat/trunk/java/org/apache/catalina/connector/Respons
Author: markt
Date: Tue Jul 5 10:12:53 2011
New Revision: 1142962
URL: http://svn.apache.org/viewvc?rev=1142962&view=rev
Log:
Votes, withdraw proposal
Modified:
tomcat/tc6.0.x/trunk/STATUS.txt
Modified: tomcat/tc6.0.x/trunk/STATUS.txt
URL:
http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/
On 29.06.2011 13:55, Konstantin Kolinko wrote:
> 2011/6/29 Rainer Jung :
>> Motivated by
>>
>> https://issues.apache.org/jira/browse/WICKET-3841
>>
>> I tested response.encodeURL("http://localhost:8080";) and I get
>> http://localhost:8080;jsessionid=... (cookies off).
>>
>> Note that there is no s
2011/7/5 :
> Author: markt
> Date: Tue Jul 5 10:03:06 2011
> New Revision: 1142953
>
> URL: http://svn.apache.org/viewvc?rev=1142953&view=rev
> Log:
> Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=51472
> Correctly test modifiers when resolving bean methods with the BeanELResolver.
> Pat
https://issues.apache.org/bugzilla/show_bug.cgi?id=51475
--- Comment #1 from Mark Thomas 2011-07-05 10:29:53 UTC ---
There are a number of issues with the patch as currently proposed.
- It uses tabs rather than spaces
- In includes whitespace changes that add noise
- Tests should be provided as J
On 05/07/2011 11:21, Konstantin Kolinko wrote:
> 2011/7/5 :
>> Author: markt
>> Date: Tue Jul 5 10:03:06 2011
>> New Revision: 1142953
>>
>> URL: http://svn.apache.org/viewvc?rev=1142953&view=rev
>> Log:
>> Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=51472
>> Correctly test modifiers w
Author: markt
Date: Tue Jul 5 10:42:15 2011
New Revision: 1142972
URL: http://svn.apache.org/viewvc?rev=1142972&view=rev
Log:
Revert r1142953. The analysis was incorrect.
Modified:
tomcat/trunk/java/javax/el/BeanELResolver.java
tomcat/trunk/webapps/docs/changelog.xml
Modified: tomcat/tr
Author: markt
Date: Tue Jul 5 10:42:41 2011
New Revision: 1142974
URL: http://svn.apache.org/viewvc?rev=1142974&view=rev
Log:
Withdraw patch
Modified:
tomcat/tc6.0.x/trunk/STATUS.txt
Modified: tomcat/tc6.0.x/trunk/STATUS.txt
URL:
http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt
https://issues.apache.org/bugzilla/show_bug.cgi?id=51472
Mark Thomas changed:
What|Removed |Added
Status|NEW |RESOLVED
Resolution|
Author: markt
Date: Tue Jul 5 11:36:41 2011
New Revision: 1142996
URL: http://svn.apache.org/viewvc?rev=1142996&view=rev
Log:
Limit exclusion to 'old' tests so tests added to o.a.catalina.tribes will
execute
Modified:
tomcat/trunk/build.xml
Modified: tomcat/trunk/build.xml
URL:
http://svn
https://issues.apache.org/bugzilla/show_bug.cgi?id=51472
--- Comment #3 from friedhelm.ku...@cms-it-services.de 2011-07-05 11:38:50 UTC
---
Sorry for my proposal, in case it is truely not correct.
However, I was not able to get the follwing bean working:
class xyz {
public getAbc(){
...
Author: markt
Date: Tue Jul 5 12:06:04 2011
New Revision: 1143016
URL: http://svn.apache.org/viewvc?rev=1143016&view=rev
Log:
Move working JUnit tests to align with package of class being tested.
Added:
tomcat/trunk/test/org/apache/catalina/tribes/group/
tomcat/trunk/test/org/apache/cat
https://issues.apache.org/bugzilla/show_bug.cgi?id=51475
--- Comment #2 from Christian Stöber 2011-07-05 12:08:55
UTC ---
Created attachment 27256
--> https://issues.apache.org/bugzilla/attachment.cgi?id=27256
Patch file for GzipInterceptor, TestGzipInterceptor and TribesTestSuite
Okay. I've
Author: markt
Date: Tue Jul 5 12:21:37 2011
New Revision: 1143019
URL: http://svn.apache.org/viewvc?rev=1143019&view=rev
Log:
Remove ununsed methods.
Convert from using main() to a unit test
Use valid test data
Modified:
tomcat/trunk/test/org/apache/catalina/tribes/io/TestXByteBuffer.java
M
Author: markt
Date: Tue Jul 5 12:22:03 2011
New Revision: 1143020
URL: http://svn.apache.org/viewvc?rev=1143020&view=rev
Log:
Remove main method
Modified:
tomcat/trunk/test/org/apache/catalina/tribes/io/TestXByteBuffer.java
Modified: tomcat/trunk/test/org/apache/catalina/tribes/io/TestXByte
Author: markt
Date: Tue Jul 5 12:25:38 2011
New Revision: 1143022
URL: http://svn.apache.org/viewvc?rev=1143022&view=rev
Log:
Based on current usage within Tomcat, message length of 0 should result in null.
Populate the test for this and ensure the test passes.
Modified:
tomcat/trunk/java/or
Author: markt
Date: Tue Jul 5 12:26:09 2011
New Revision: 1143023
URL: http://svn.apache.org/viewvc?rev=1143023&view=rev
Log:
Remove unused code
Modified:
tomcat/trunk/test/org/apache/catalina/tribes/membership/TestMemberImplSerialization.java
Modified:
tomcat/trunk/test/org/apache/catali
Author: markt
Date: Tue Jul 5 12:28:50 2011
New Revision: 1143025
URL: http://svn.apache.org/viewvc?rev=1143025&view=rev
Log:
Update changelog
Modified:
tomcat/trunk/webapps/docs/changelog.xml
Modified: tomcat/trunk/webapps/docs/changelog.xml
URL:
http://svn.apache.org/viewvc/tomcat/trunk/
https://issues.apache.org/bugzilla/show_bug.cgi?id=51468
--- Comment #6 from Christopher Schultz
2011-07-05 14:45:04 UTC ---
A few questions:
1. Why a Valve and not a Filter?
2. Why not use urlrewrite like everyone else?
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?t
Author: markt
Date: Tue Jul 5 16:21:51 2011
New Revision: 1143126
URL: http://svn.apache.org/viewvc?rev=1143126&view=rev
Log:
Prevent test failures on Linux
Modified:
tomcat/trunk/test/org/apache/catalina/tribes/group/TestGroupChannelMemberArrival.java
Modified:
tomcat/trunk/test/org/apac
Author: markt
Date: Tue Jul 5 16:32:28 2011
New Revision: 1143130
URL: http://svn.apache.org/viewvc?rev=1143130&view=rev
Log:
Extract test to a test case
Added:
tomcat/trunk/test/org/apache/catalina/tribes/group/interceptors/TestGzipInterceptor.java
(with props)
Modified:
tomcat/tru
Author: markt
Date: Tue Jul 5 16:45:38 2011
New Revision: 1143134
URL: http://svn.apache.org/viewvc?rev=1143134&view=rev
Log:
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=51475
Handle messages larger than the buffer size. Expand test cases to cover this.
Based on a patch by Christian St
Author: markt
Date: Tue Jul 5 16:47:02 2011
New Revision: 1143136
URL: http://svn.apache.org/viewvc?rev=1143136&view=rev
Log:
Propose patch
Modified:
tomcat/tc6.0.x/trunk/STATUS.txt
Modified: tomcat/tc6.0.x/trunk/STATUS.txt
URL:
http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?
https://issues.apache.org/bugzilla/show_bug.cgi?id=51475
--- Comment #3 from Mark Thomas 2011-07-05 16:48:34 UTC ---
Thanks for the updated patch. There are still some unnecessary changes in that
patch that distract from the changes that fix the problem. Also, new files need
to include a license
https://issues.apache.org/bugzilla/show_bug.cgi?id=51477
Bug #: 51477
Summary: Fix for 51073 Breaks SSLv3+TLSv1 Protocol Support in
APR Connector
Product: Tomcat 7
Version: unspecified
Platform: PC
OS/Version: Linu
https://issues.apache.org/bugzilla/show_bug.cgi?id=51477
Marvin Addison changed:
What|Removed |Added
Version|unspecified |7.0.16
--- Comment #1 from Marvin
2011/7/5 :
> Author: markt
> Date: Tue Jul 5 16:45:38 2011
> New Revision: 1143134
>
> URL: http://svn.apache.org/viewvc?rev=1143134&view=rev
> Log:
> Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=51475
> Handle messages larger than the buffer size. Expand test cases to cover this.
> Bas
On 05/07/2011 18:23, Konstantin Kolinko wrote:
> 2011/7/5 :
>> Author: markt
>> Date: Tue Jul 5 16:45:38 2011
>> New Revision: 1143134
>>
>> URL: http://svn.apache.org/viewvc?rev=1143134&view=rev
>> Log:
>> Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=51475
>> Handle messages larger tha
Author: markt
Date: Tue Jul 5 17:28:44 2011
New Revision: 1143150
URL: http://svn.apache.org/viewvc?rev=1143150&view=rev
Log:
Review comments
Modified:
tomcat/trunk/java/org/apache/catalina/tribes/group/interceptors/GzipInterceptor.java
Modified:
tomcat/trunk/java/org/apache/catalina/trib
https://issues.apache.org/bugzilla/show_bug.cgi?id=51477
Rainer Jung changed:
What|Removed |Added
Status|NEW |RESOLVED
Resolution|
https://issues.apache.org/bugzilla/show_bug.cgi?id=51478
Bug #: 51478
Summary: mod_jk-1.2.31-httpd-2.2.x.so 32bit binaries not
available for RHEL 32bit OS
Product: Tomcat Connectors
Version: 1.2.31
Platform: Other
https://issues.apache.org/bugzilla/show_bug.cgi?id=51478
Sambhram changed:
What|Removed |Added
CC||samb...@amazon.com
--
Configure bugmai
https://issues.apache.org/bugzilla/show_bug.cgi?id=51478
Mark Thomas changed:
What|Removed |Added
Status|NEW |RESOLVED
Resolution|
https://issues.apache.org/bugzilla/show_bug.cgi?id=51478
--- Comment #2 from Sambhram 2011-07-05 17:52:29 UTC ---
How do I build it from source?
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assi
https://issues.apache.org/bugzilla/show_bug.cgi?id=51478
--- Comment #3 from Mladen Turk 2011-07-05 17:53:36 UTC ---
We produce source code. Binaries are for user convenience.
Because there are so many os/os-version/cpu combination we will provide
only Windows binaries starting from 1.2.32
--
C
https://issues.apache.org/bugzilla/show_bug.cgi?id=51477
--- Comment #3 from Konstantin Kolinko 2011-07-05
17:55:18 UTC ---
According to the source code, before bug 51073 was fixed (r1094089 or
r1124211), the "SSLv3+TLSv1" value just worked as a synonym to "all".
What happens with ssl2 connecti
https://issues.apache.org/bugzilla/show_bug.cgi?id=51477
--- Comment #4 from Rainer Jung 2011-07-05 18:15:52
UTC ---
But I *think* OpenSSL does not support it:
http://www.openssl.org/docs/ssl/SSL_CTX_new.html
It looks like you have to do what I already posted here: choose "all" for the
protoco
https://issues.apache.org/bugzilla/show_bug.cgi?id=51477
--- Comment #5 from Marvin Addison 2011-07-05
18:19:26 UTC ---
"SSLv3+TLSv1" value just worked as a synonym to "all"
Appears this is correct based on my testing. Setting SSLProtocol="all" in both
7.0.8 and 7.0.16 produced exactly the sam
https://issues.apache.org/bugzilla/show_bug.cgi?id=51478
Sambhram changed:
What|Removed |Added
Status|RESOLVED|REOPENED
Resolution|INVALID
https://issues.apache.org/bugzilla/show_bug.cgi?id=51477
--- Comment #6 from Marvin Addison 2011-07-05
18:31:40 UTC ---
I verified the following mod_ssl directives provide equivalent behavior (no
SSLv2):
SSLProtocol +SSLv3 +TLSv1
SSLCipherSuite HIGH:MEDIUM
--
Configure bugmail: https://issues
https://issues.apache.org/bugzilla/show_bug.cgi?id=51478
Chuck Caldarale changed:
What|Removed |Added
Priority|P2 |P5
Status|REOPENED
https://issues.apache.org/bugzilla/show_bug.cgi?id=51477
Rainer Jung changed:
What|Removed |Added
Status|RESOLVED|REOPENED
Resolution|INVALID
https://issues.apache.org/bugzilla/show_bug.cgi?id=51477
Rainer Jung changed:
What|Removed |Added
Summary|Fix for 51073 Breaks|Support all protocol
https://issues.apache.org/bugzilla/show_bug.cgi?id=51477
--- Comment #8 from Rainer Jung 2011-07-05 19:29:12
UTC ---
Created attachment 27260
--> https://issues.apache.org/bugzilla/attachment.cgi?id=27260
Support for arbitrary protocol combinations
The combinations SSLv2+TLSv1 and SSLv3+TLSv1
https://issues.apache.org/bugzilla/show_bug.cgi?id=51477
Rainer Jung changed:
What|Removed |Added
Keywords||PatchAvailable
--
Configure bugmail
https://issues.apache.org/bugzilla/show_bug.cgi?id=51477
--- Comment #9 from Marvin Addison 2011-07-05
19:49:48 UTC ---
I've reviewed the patch and it appears that it doesn't do the work of removing
protocols via SSL_CTX_set_options() as you mentioned. At this point it appears
all supported str
Author: markt
Date: Tue Jul 5 19:53:53 2011
New Revision: 1143188
URL: http://svn.apache.org/viewvc?rev=1143188&view=rev
Log:
Javadoc fixes
Modified:
tomcat/trunk/java/org/apache/coyote/ajp/AjpNioProtocol.java
tomcat/trunk/java/org/apache/coyote/http11/Http11NioProtocol.java
Modified: t
https://issues.apache.org/bugzilla/show_bug.cgi?id=51477
--- Comment #10 from Marvin Addison 2011-07-05
19:58:09 UTC ---
I dug a little further and found that the requisite SSL_CTX_set_options() calls
are already in sslcontext.c. I'll test the patch and report back.
--
Configure bugmail: http
Author: markt
Date: Tue Jul 5 20:33:28 2011
New Revision: 1143197
URL: http://svn.apache.org/viewvc?rev=1143197&view=rev
Log:
Not just this test failing. Need a better solution. Revert r1143126.
Modified:
tomcat/trunk/test/org/apache/catalina/tribes/group/TestGroupChannelMemberArrival.java
On 05/07/2011 21:33, ma...@apache.org wrote:
> Author: markt
> Date: Tue Jul 5 20:33:28 2011
> New Revision: 1143197
>
> URL: http://svn.apache.org/viewvc?rev=1143197&view=rev
> Log:
> Not just this test failing. Need a better solution. Revert r1143126.
There is something odd going on with these
https://issues.apache.org/bugzilla/show_bug.cgi?id=51468
--- Comment #7 from Sergey Ushakov 2011-07-05 20:54:22 UTC
---
(In reply to comment #6)
Well, there is nothing wrong about UrlRewriteFilter except it is a filter :)
It looks perfect and mature, but it is good for webapp-level tasks rathe
On 05/07/2011 21:38, Mark Thomas wrote:
> On 05/07/2011 21:33, ma...@apache.org wrote:
>> Author: markt
>> Date: Tue Jul 5 20:33:28 2011
>> New Revision: 1143197
>>
>> URL: http://svn.apache.org/viewvc?rev=1143197&view=rev
>> Log:
>> Not just this test failing. Need a better solution. Revert r1143
https://issues.apache.org/bugzilla/show_bug.cgi?id=50570
Christopher Schultz changed:
What|Removed |Added
Keywords||PatchAvailable
--
Configure
https://issues.apache.org/bugzilla/show_bug.cgi?id=51468
--- Comment #8 from Christopher Schultz
2011-07-05 21:50:20 UTC ---
(In reply to comment #7)
> Well, there is nothing wrong about UrlRewriteFilter except it is a filter :)
> It looks perfect and mature, but it is good for webapp-level tas
https://issues.apache.org/bugzilla/show_bug.cgi?id=51468
--- Comment #9 from Mark Thomas 2011-07-05 21:54:52 UTC ---
(In reply to comment #8)
> Tomcat 7 can use Filters at the container level. Configure them just as you
> configure Valves, except that you use instead of .
Where did that come fr
https://issues.apache.org/bugzilla/show_bug.cgi?id=50570
--- Comment #18 from Konstantin Kolinko 2011-07-05
21:57:06 UTC ---
(In reply to comment #16)
Regarding attachment 27225 (Java patch) I have two comments:
1) Code formatting.
We usually have "{" on the same line as previous statement (li
https://issues.apache.org/bugzilla/show_bug.cgi?id=51468
--- Comment #10 from Christopher Schultz
2011-07-05 22:33:53 UTC ---
(In reply to comment #9)
> (In reply to comment #8)
> > Tomcat 7 can use Filters at the container level. Configure them just as you
> > configure Valves, except that you
https://issues.apache.org/bugzilla/show_bug.cgi?id=50570
--- Comment #19 from Christopher Schultz
2011-07-05 22:54:15 UTC ---
Thanks for the comments. Very helpful!
(In reply to comment #18)
> (In reply to comment #16)
>
> Regarding attachment 27225 [details] (Java patch) I have two comments:
On 05/07/2011 22:04, Mark Thomas wrote:
> On 05/07/2011 21:38, Mark Thomas wrote:
>> On 05/07/2011 21:33, ma...@apache.org wrote:
>>> Author: markt
>>> Date: Tue Jul 5 20:33:28 2011
>>> New Revision: 1143197
>>>
>>> URL: http://svn.apache.org/viewvc?rev=1143197&view=rev
>>> Log:
>>> Not just this
https://issues.apache.org/bugzilla/show_bug.cgi?id=51468
--- Comment #11 from Sergey Ushakov 2011-07-06 04:41:47
UTC ---
(In reply to comment #9)
> I am struggling to see the benefit of this Valve compared to the urlrewrite,
> particularly given the features that urlrewrite has compared to this
1. JavaDoc for the method has to be updated. It still says that the
name is quoted.
2. If I understand correctly, the name _is_ used directly, in
AbstractConnectionHandler.register():
... ",worker=" + getProtocol().getName() + ",name=" ...
and MBeanUtils.destroyMBean(Connector,Service)
worker =
Author: kkolinko
Revision: 1136028
Modified property: svn:log
Modified: svn:log at Wed Jul 6 06:07:56 2011
--
--- svn:log (original)
+++ svn:log Wed Jul 6 06:07:56 2011
@@ -0,0 +1,2 @@
+Fix https://issues.apache.org/bugz
75 matches
Mail list logo
