Re: SpnegoAuthenticator feedback

2011-04-21 Thread Mark Thomas
On 20/04/2011 21:00, Filip Hanik - Dev Lists wrote: > Here are some thoughts on the implementation Thanks for the feedback. > 1. |com.sun.security.jgss.initiate is not needed > This definition is not needed in jaas.conf. Tomcat is not a client in > this case, it's a server accepting tickets. > th

DO NOT REPLY [Bug 51099] New: SPNEGO loginConfigName does not work

2011-04-21 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=51099 Summary: SPNEGO loginConfigName does not work Product: Tomcat 7 Version: trunk Platform: All OS/Version: All Status: NEW Severity: normal Priority: P2

svn commit: r1095677 - in /tomcat/trunk/java/org/apache: catalina/users/MemoryUserDatabase.java tomcat/util/digester/AbstractObjectCreationFactory.java tomcat/util/digester/AbstractRulesImpl.java

2011-04-21 Thread markt
Author: markt Date: Thu Apr 21 12:25:31 2011 New Revision: 1095677 URL: http://svn.apache.org/viewvc?rev=1095677&view=rev Log: Fix some unused code warnings Removed: tomcat/trunk/java/org/apache/tomcat/util/digester/AbstractRulesImpl.java Modified: tomcat/trunk/java/org/apache/catalina/us

svn commit: r1095681 - /tomcat/trunk/webapps/docs/config/http.xml

2011-04-21 Thread markt
Author: markt Date: Thu Apr 21 12:37:21 2011 New Revision: 1095681 URL: http://svn.apache.org/viewvc?rev=1095681&view=rev Log: Fix typo Modified: tomcat/trunk/webapps/docs/config/http.xml Modified: tomcat/trunk/webapps/docs/config/http.xml URL: http://svn.apache.org/viewvc/tomcat/trunk/weba

svn commit: r1095682 - /tomcat/trunk/webapps/docs/config/ajp.xml

2011-04-21 Thread markt
Author: markt Date: Thu Apr 21 12:37:44 2011 New Revision: 1095682 URL: http://svn.apache.org/viewvc?rev=1095682&view=rev Log: bindOnInit is supported for AJP too. Modified: tomcat/trunk/webapps/docs/config/ajp.xml Modified: tomcat/trunk/webapps/docs/config/ajp.xml URL: http://svn.apache.or

Re: bindOnInit and maxConnections for AJP connectors

2011-04-21 Thread Mark Thomas
On 05/04/2011 09:51, Tim Whittington wrote: > In the AJP standard implementation docs, the following are not > mentioned, although they're properties of AbstractEndpoint and > probably should work: > - bindOnInit > - maxConnections > Am I right in assuming these should be possible in the AJP connec

svn commit: r1095684 - /tomcat/trunk/java/org/apache/jasper/compiler/DefaultErrorHandler.java

2011-04-21 Thread markt
Author: markt Date: Thu Apr 21 12:43:08 2011 New Revision: 1095684 URL: http://svn.apache.org/viewvc?rev=1095684&view=rev Log: Fix some Findbugs warnings Modified: tomcat/trunk/java/org/apache/jasper/compiler/DefaultErrorHandler.java Modified: tomcat/trunk/java/org/apache/jasper/compiler/Def

svn commit: r1095686 - in /tomcat/trunk/java/org/apache/jasper: compiler/DefaultErrorHandler.java resources/LocalStrings.properties

2011-04-21 Thread markt
Author: markt Date: Thu Apr 21 12:50:40 2011 New Revision: 1095686 URL: http://svn.apache.org/viewvc?rev=1095686&view=rev Log: i18n for r1090763 Modified: tomcat/trunk/java/org/apache/jasper/compiler/DefaultErrorHandler.java tomcat/trunk/java/org/apache/jasper/resources/LocalStrings.prope

Re: svn commit: r1090763 - in /tomcat/trunk: java/org/apache/jasper/compiler/DefaultErrorHandler.java webapps/docs/changelog.xml

2011-04-21 Thread Mark Thomas
On 10/04/2011 16:06, Konstantin Kolinko wrote: > 2011/4/10 : >> Author: markt >> Date: Sun Apr 10 10:33:30 2011 >> New Revision: 1090763 >> >> URL: http://svn.apache.org/viewvc?rev=1090763&view=rev >> Log: >> Improve error reporting by labeling line/column numbers > > This contradicts with i18n o

Re: svn commit: r1094069 - in /tomcat/trunk: java/org/apache/catalina/ java/org/apache/catalina/ha/session/ java/org/apache/catalina/manager/ java/org/apache/catalina/session/ webapps/docs/

2011-04-21 Thread Mark Thomas
On 19/04/2011 16:27, Filip Hanik - Dev Lists wrote: > > > On 4/18/2011 4:39 AM, Mark Thomas wrote: >> On 18/04/2011 10:13, Remy Maucherat wrote: >>> On Sat, 2011-04-16 at 22:25 +, ma...@apache.org wrote: Author: markt Date: Sat Apr 16 22:25:28 2011 New Revision: 1094069 >>

svn commit: r1095711 - in /tomcat/trunk/webapps/docs/config: ajp.xml http.xml

2011-04-21 Thread markt
Author: markt Date: Thu Apr 21 13:52:39 2011 New Revision: 1095711 URL: http://svn.apache.org/viewvc?rev=1095711&view=rev Log: Move the maxConnections description to the correct part of the HTTP doc. Add it to the AJP doc. Modified: tomcat/trunk/webapps/docs/config/ajp.xml tomcat/trunk/w

svn commit: r1095712 - /tomcat/trunk/webapps/docs/config/http.xml

2011-04-21 Thread markt
Author: markt Date: Thu Apr 21 13:54:17 2011 New Revision: 1095712 URL: http://svn.apache.org/viewvc?rev=1095712&view=rev Log: Update summary for maxConnections Modified: tomcat/trunk/webapps/docs/config/http.xml Modified: tomcat/trunk/webapps/docs/config/http.xml URL: http://svn.apache.org

Re: SpnegoAuthenticator feedback

2011-04-21 Thread Filip Hanik - Dev Lists
On 4/21/2011 3:09 AM, Mark Thomas wrote: On 20/04/2011 21:00, Filip Hanik - Dev Lists wrote: Here are some thoughts on the implementation Thanks for the feedback. 1. |com.sun.security.jgss.initiate is not needed This definition is not needed in jaas.conf. Tomcat is not a client in this case,

DO NOT REPLY [Bug 50642] keepAliveProtection doesn't work

2011-04-21 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=50642 --- Comment #8 from Dennis Homann 2011-04-21 14:10:05 EDT --- The issue is still present in 6.0.32. In more than 50% of my attempts, the KeepAliveThread is not cleared correctly. Debugging and profiling showed that in these cases, the Thre

svn commit: r1095794 - in /tomcat/trunk: java/org/apache/coyote/http11/Http11Processor.java webapps/docs/changelog.xml

2011-04-21 Thread markt
Author: markt Date: Thu Apr 21 19:02:46 2011 New Revision: 1095794 URL: http://svn.apache.org/viewvc?rev=1095794&view=rev Log: Fix TODO - take account of time waiting for a thread when calculating timeouts. Modified: tomcat/trunk/java/org/apache/coyote/http11/Http11Processor.java tomcat/t

Re: bindOnInit and maxConnections for AJP connectors

2011-04-21 Thread Mark Thomas
On 06/04/2011 22:51, Tim Whittington wrote: > On Wed, Apr 6, 2011 at 11:16 PM, Mark Thomas wrote: >> On 05/04/2011 10:50, Tim Whittington wrote: >>> Is what's actually going on more like: >>> >>> APR: use maxConnections == pollerSize (smallest will limit, but if >>> pollerSize < maxConnections the

Re: svn commit: r1095794 - in /tomcat/trunk: java/org/apache/coyote/http11/Http11Processor.java webapps/docs/changelog.xml

2011-04-21 Thread Filip Hanik - Dev Lists
On 4/21/2011 1:02 PM, ma...@apache.org wrote: +int firstReadTimeout; +if (queueTime>= standardTimeout) { +// Queued for longer than timeout but there might be +// data so use shortest possible timeout +