svn commit: r1095332 - /tomcat/trunk/conf/catalina.properties

2011-04-20 Thread markt
Author: markt Date: Wed Apr 20 09:13:07 2011 New Revision: 1095332 URL: http://svn.apache.org/viewvc?rev=1095332&view=rev Log: Add some more JARs to skip (spotted via logging in unit tests) Modified: tomcat/trunk/conf/catalina.properties Modified: tomcat/trunk/conf/catalina.properties URL:

svn commit: r1095333 - /tomcat/trunk/test/org/apache/catalina/startup/TomcatBaseTest.java

2011-04-20 Thread markt
Author: markt Date: Wed Apr 20 09:15:07 2011 New Revision: 1095333 URL: http://svn.apache.org/viewvc?rev=1095333&view=rev Log: Set jarsToSkip when running unit tests a) for speed and b) to reduce noise in the logs Modified: tomcat/trunk/test/org/apache/catalina/startup/TomcatBaseTest.java M

svn commit: r1095336 - /tomcat/trunk/test/org/apache/catalina/startup/TomcatBaseTest.java

2011-04-20 Thread markt
Author: markt Date: Wed Apr 20 09:25:09 2011 New Revision: 1095336 URL: http://svn.apache.org/viewvc?rev=1095336&view=rev Log: Move the unit test JARs to the end. Add a couple of JARs when running via the command line rather than Eclipse Modified: tomcat/trunk/test/org/apache/catalina/startup

DO NOT REPLY [Bug 51088] New: ArrayIndexOutOfBoundsException from org.apache.el.parser.JJTELParserState

2011-04-20 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=51088 Summary: ArrayIndexOutOfBoundsException from org.apache.el.parser.JJTELParserState Product: Tomcat 6 Version: 6.0.32 Platform: All Status: NEW Severity: nor

DO NOT REPLY [Bug 51088] ArrayIndexOutOfBoundsException from org.apache.el.parser.JJTELParserState

2011-04-20 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=51088 Michael Heinen changed: What|Removed |Added CC||mhn4...@googlemail.com OS

svn commit: r1095367 - in /tomcat/trunk: java/org/apache/catalina/startup/ java/org/apache/jasper/compiler/ java/org/apache/tomcat/util/scan/ webapps/docs/

2011-04-20 Thread markt
Author: markt Date: Wed Apr 20 11:28:53 2011 New Revision: 1095367 URL: http://svn.apache.org/viewvc?rev=1095367&view=rev Log: Switch JAR scanning to use JarInputStream rather JarFile for significant startup performance improvements Added: tomcat/trunk/java/org/apache/tomcat/util/scan/NonClo

Re: svn commit: r1095367 - in /tomcat/trunk: java/org/apache/catalina/startup/ java/org/apache/jasper/compiler/ java/org/apache/tomcat/util/scan/ webapps/docs/

2011-04-20 Thread Konstantin Kolinko
2011/4/20 : > Author: markt > Date: Wed Apr 20 11:28:53 2011 > New Revision: 1095367 > > URL: http://svn.apache.org/viewvc?rev=1095367&view=rev > Log: > Switch JAR scanning to use JarInputStream rather JarFile for significant > startup performance improvements > > +       > +        While scann

Re: svn commit: r1095367 - in /tomcat/trunk: java/org/apache/catalina/startup/ java/org/apache/jasper/compiler/ java/org/apache/tomcat/util/scan/ webapps/docs/

2011-04-20 Thread Mark Thomas
On 20/04/2011 16:51, Konstantin Kolinko wrote: > 2011/4/20 : >> Author: markt >> Date: Wed Apr 20 11:28:53 2011 >> New Revision: 1095367 >> >> URL: http://svn.apache.org/viewvc?rev=1095367&view=rev >> Log: >> Switch JAR scanning to use JarInputStream rather JarFile for significant >> startup perf

Re: svn commit: r1095367 - in /tomcat/trunk: java/org/apache/catalina/startup/ java/org/apache/jasper/compiler/ java/org/apache/tomcat/util/scan/ webapps/docs/

2011-04-20 Thread Konstantin Kolinko
2011/4/20 Mark Thomas : >>> +            // JarURLConnection#getJarFile() creates temporary copies of >>> the JAR >>> +            // if the underlying resource is not a file URL. That can be >>> slow so >> >> What URLs are there? Why aren't they file ones? > > Resources obtained via the context

Re: svn commit: r1095367 - in /tomcat/trunk: java/org/apache/catalina/startup/ java/org/apache/jasper/compiler/ java/org/apache/tomcat/util/scan/ webapps/docs/

2011-04-20 Thread Mark Thomas
On 20/04/2011 17:02, Konstantin Kolinko wrote: > 2011/4/20 Mark Thomas : +// JarURLConnection#getJarFile() creates temporary copies of the JAR +// if the underlying resource is not a file URL. That can be slow so >>> >>> What URLs are there? Why aren't

svn commit: r1095449 - /tomcat/trunk/java/org/apache/catalina/startup/ContextConfig.java

2011-04-20 Thread markt
Author: markt Date: Wed Apr 20 16:19:59 2011 New Revision: 1095449 URL: http://svn.apache.org/viewvc?rev=1095449&view=rev Log: Fix infinite loop in r1095367 Modified: tomcat/trunk/java/org/apache/catalina/startup/ContextConfig.java Modified: tomcat/trunk/java/org/apache/catalina/startup/Cont

Re: svn commit: r1095367 - in /tomcat/trunk: java/org/apache/catalina/startup/ java/org/apache/jasper/compiler/ java/org/apache/tomcat/util/scan/ webapps/docs/

2011-04-20 Thread Filip Hanik - Dev Lists
On 4/20/2011 10:07 AM, Mark Thomas wrote: The new code is better than the old. You are welcome to try and improve it further although I don't think there is much more scope for improvement given the performance figures I am seeing. My suggestion here would be to: 1. When a JAR file has been sca

Re: svn commit: r1095367 - in /tomcat/trunk: java/org/apache/catalina/startup/ java/org/apache/jasper/compiler/ java/org/apache/tomcat/util/scan/ webapps/docs/

2011-04-20 Thread Mark Thomas
On 20/04/2011 17:33, Filip Hanik - Dev Lists wrote: > On 4/20/2011 10:07 AM, Mark Thomas wrote: >> The new code is better than the old. You are welcome to try and improve >> it further although I don't think there is much more scope for >> improvement given the performance figures I am seeing. > My

DO NOT REPLY [Bug 51095] New: NPE in AprEndpoint.java

2011-04-20 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=51095 Summary: NPE in AprEndpoint.java Product: Tomcat 7 Version: trunk Platform: PC Status: NEW Severity: normal Priority: P2 Component: Catalina Assigned

Re: svn commit: r1095367 - in /tomcat/trunk: java/org/apache/catalina/startup/ java/org/apache/jasper/compiler/ java/org/apache/tomcat/util/scan/ webapps/docs/

2011-04-20 Thread sebb
On 20 April 2011 17:42, Mark Thomas wrote: > On 20/04/2011 17:33, Filip Hanik - Dev Lists wrote: >> On 4/20/2011 10:07 AM, Mark Thomas wrote: >>> The new code is better than the old. You are welcome to try and improve >>> it further although I don't think there is much more scope for >>> improveme

SpnegoAuthenticator feedback

2011-04-20 Thread Filip Hanik - Dev Lists
Here are some thoughts on the implementation 1. |com.sun.security.jgss.initiate is not needed This definition is not needed in jaas.conf. Tomcat is not a client in this case, it's a server accepting tickets. the .initiate is only for clients that request a Kerberos ticket from the KDC. The examp