svn commit: r1073289 - /tomcat/trunk/java/org/apache/catalina/realm/JNDIRealm.java

2011-02-22 Thread markt
Author: markt Date: Tue Feb 22 10:46:02 2011 New Revision: 1073289 URL: http://svn.apache.org/viewvc?rev=1073289&view=rev Log: Refactoring to remove duplicate code Modified: tomcat/trunk/java/org/apache/catalina/realm/JNDIRealm.java Modified: tomcat/trunk/java/org/apache/catalina/realm/JNDIR

svn commit: r1073296 - in /tomcat/trunk: java/org/apache/catalina/realm/JNDIRealm.java webapps/docs/changelog.xml webapps/docs/config/realm.xml

2011-02-22 Thread markt
Author: markt Date: Tue Feb 22 11:08:42 2011 New Revision: 1073296 URL: http://svn.apache.org/viewvc?rev=1073296&view=rev Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=19444 Add an option to the JNDI realm to allow role searches to be performed by the authenticated user. Modified:

DO NOT REPLY [Bug 19444] JNDI Authentication roles must be anonymous accessible

2011-02-22 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=19444 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED Resolution|

svn commit: r1073301 - in /tomcat/trunk: java/org/apache/catalina/realm/JNDIRealm.java webapps/docs/changelog.xml webapps/docs/config/realm.xml

2011-02-22 Thread markt
Author: markt Date: Tue Feb 22 11:48:09 2011 New Revision: 1073301 URL: http://svn.apache.org/viewvc?rev=1073301&view=rev Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=21669 Add the ability to specify the roleBase for the JNDI Realm as relative to the users DN. Based on a patch by A

DO NOT REPLY [Bug 21669] JNDIRealm roleBase pattern enahncement

2011-02-22 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=21669 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED Resolution|

svn commit: r1073320 - /tomcat/trunk/java/org/apache/jasper/runtime/PageContextImpl.java

2011-02-22 Thread markt
Author: markt Date: Tue Feb 22 12:55:56 2011 New Revision: 1073320 URL: http://svn.apache.org/viewvc?rev=1073320&view=rev Log: Remove unused code, fix FindBugs warning Modified: tomcat/trunk/java/org/apache/jasper/runtime/PageContextImpl.java Modified: tomcat/trunk/java/org/apache/jasper/run

DO NOT REPLY [Bug 22755] say which variable is at fault! ("Cannot compare null variable to value true")

2011-02-22 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=22755 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED Resolution|

svn commit: r1073393 - in /tomcat/trunk/java/org/apache/jasper: compiler/Compiler.java resources/LocalStrings.properties

2011-02-22 Thread markt
Author: markt Date: Tue Feb 22 16:38:39 2011 New Revision: 1073393 URL: http://svn.apache.org/viewvc?rev=1073393&view=rev Log: Test before generating debug log messages Fix FindBugs issues for File.delete() return value Modified: tomcat/trunk/java/org/apache/jasper/compiler/Compiler.java

DO NOT REPLY [Bug 24739] Control of secure flag when establishing sessions through https using cookies

2011-02-22 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=24739 --- Comment #4 from Andrew Mottaz 2011-02-22 11:58:55 EST --- How can you say there are no valid use cases? Virtually EVERY ecommerce site on the internet supports this behavior. Amazon.com, Apple.com, Dell.com. Basically - whether a ses

DO NOT REPLY [Bug 24739] Control of secure flag when establishing sessions through https using cookies

2011-02-22 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=24739 --- Comment #5 from Andrew Mottaz 2011-02-22 11:59:24 EST --- How can you say there are no valid use cases? Virtually EVERY ecommerce site on the internet supports this behavior. Amazon.com, Apple.com, Dell.com. Basically - whether a ses

DO NOT REPLY [Bug 24739] Control of secure flag when establishing sessions through https using cookies

2011-02-22 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=24739 --- Comment #6 from Mark Thomas 2011-02-22 12:46:02 EST --- (In reply to comment #5) > How can you say there are no valid use cases? Virtually EVERY ecommerce site > on the internet supports this behavior. No they don't. At least the secu

DO NOT REPLY [Bug 24739] Control of secure flag when establishing sessions through https using cookies

2011-02-22 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=24739 --- Comment #7 from Andrew Mottaz 2011-02-22 13:04:11 EST --- You actually made my point SOME of the cookies are not secure. My point is not that you should never have secure session cookies. It's that sometimes you don't want them secure

Re: Reaching ulimit values for open files can generate huge log files

2011-02-22 Thread Filip Hanik - Dev Lists
Wouldn't you build this into the logging framework, instead of one specific component? best Filip On 02/21/2011 08:21 AM, Mark Thomas wrote: The ASF Sonar installation managed to generate 46GB of identical log messages [1] today in the 8 hours it took to notice it was down. While better monit

Re: Reaching ulimit values for open files can generate huge log files

2011-02-22 Thread Mark Thomas
On 22/02/2011 19:34, Filip Hanik - Dev Lists wrote: > Wouldn't you build this into the logging framework, instead of one > specific component? You could, if you can find an efficient way to spot duplicate log messages and then differentiate correctly between when you want the duplicates and when y

Re: Connection draining when upload to large

2011-02-22 Thread Christopher Schultz
All, On 2/17/2011 5:41 AM, Mark Thomas wrote: > On 17/02/2011 10:30, Rainer Jung wrote: >> On 10.02.2011 18:44, Mark Thomas wrote: >> Any hints about where to add stuff to the docs? Are people fine with >> making it controllable via the request attribute? > > I'm not particularly comfortable with

DO NOT REPLY [Bug 23406] Jasper should use file size as well as date for recompile check

2011-02-22 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=23406 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED Resolution|

Re: Reaching ulimit values for open files can generate huge log files

2011-02-22 Thread Filip Hanik - Dev Lists
On 02/22/2011 12:59 PM, Mark Thomas wrote: On 22/02/2011 19:34, Filip Hanik - Dev Lists wrote: Wouldn't you build this into the logging framework, instead of one specific component? You could, if you can find an efficient way to spot duplicate log messages and then differentiate corre

Re: Reaching ulimit values for open files can generate huge log files

2011-02-22 Thread Christopher Schultz
Mark, On 2/21/2011 10:21 AM, Mark Thomas wrote: > The ASF Sonar installation managed to generate 46GB of identical log > messages [1] today in the 8 hours it took to notice it was down. Ugh. Yeah, that sucks. Hitting the ulimit doesn't necessarily mean disaster and the process could still recove

Re: Reaching ulimit values for open files can generate huge log files

2011-02-22 Thread Christopher Schultz
Mark, On 2/21/2011 10:21 AM, Mark Thomas wrote: > The ASF Sonar installation managed to generate 46GB of identical log > messages [1] today in the 8 hours it took to notice it was down. I've not really looked at how Tomcat does its logging, but do we have an opportunity to do what, say, syslogd d

DO NOT REPLY [Bug 23745] "jsp.error.unterminated.tag" received when doing struts tags - improve error messages for misbuilt tags!

2011-02-22 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=23745 Mark Thomas changed: What|Removed |Added Status|REOPENED|RESOLVED Resolution|

DO NOT REPLY [Bug 23841] More specific error message to "org.apache.jasper.JasperException: Exception thrown by getter for property ..."

2011-02-22 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=23841 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED Resolution|

DO NOT REPLY [Bug 24650] name class of bean when throwing java.lang.NoSuchMethodException

2011-02-22 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=24650 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED Resolution|

DO NOT REPLY [Bug 24772] say where in the .jsp file it happens: "Cannot find bean xyz in scope null"

2011-02-22 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=24772 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED Resolution|

DO NOT REPLY [Bug 24773] say which scope is null in "Cannot find bean xyz in scope null" request/session/application/... ?

2011-02-22 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=24773 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED Resolution|

DO NOT REPLY [Bug 24772] say where in the .jsp file it happens: "Cannot find bean xyz in scope null"

2011-02-22 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=24772 --- Comment #2 from Mark Thomas 2011-02-22 16:58:57 EST --- *** Bug 24773 has been marked as a duplicate of this bug. *** -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail

svn commit: r1073531 - in /tomcat/trunk/modules/jdbc-pool: java/org/apache/tomcat/jdbc/pool/ConnectionPool.java test/org/apache/tomcat/jdbc/test/Bug50805.java

2011-02-22 Thread fhanik
Author: fhanik Date: Tue Feb 22 22:42:44 2011 New Revision: 1073531 URL: http://svn.apache.org/viewvc?rev=1073531&view=rev Log: https://issues.apache.org/bugzilla/show_bug.cgi?id=50805 Make sure we only call borrowConnection once per connection per checkout Added: tomcat/trunk/modules/jdbc-

svn commit: r1073532 - /tomcat/trunk/modules/jdbc-pool/doc/changelog.xml

2011-02-22 Thread fhanik
Author: fhanik Date: Tue Feb 22 22:45:43 2011 New Revision: 1073532 URL: http://svn.apache.org/viewvc?rev=1073532&view=rev Log: doco update bug 50805 Modified: tomcat/trunk/modules/jdbc-pool/doc/changelog.xml Modified: tomcat/trunk/modules/jdbc-pool/doc/changelog.xml URL: http://svn.apache.

DO NOT REPLY [Bug 50805] Leak & Performance issue of getConnectionAsync()

2011-02-22 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=50805 Filip Hanik changed: What|Removed |Added Status|NEEDINFO|RESOLVED Resolution|

DO NOT REPLY [Bug 50805] Leak & Performance issue of getConnectionAsync()

2011-02-22 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=50805 --- Comment #4 from Eiji Takahashi 2011-02-22 21:07:29 EST --- Sorry for not replying sooner. The performance issue was solved by the latest revision. Many thanks! -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?t