Re: [VOTE] Release build 6.0.31

2011-01-27 Thread Rainer Jung
On 24.01.2011 22:51, jean-frederic clere wrote: The candidates binaries are available here: http://people.apache.org/~jfclere/tomcat-6/v6.0.31/ According to the release process, the 6.0.31 build corresponding to the tag TOMCAT_6_0_31 is: [ ] Broken [ ] Alpha [ ] Beta [X] Stable - MD5 OK - si

Re: [VOTE] Release build 6.0.31

2011-01-27 Thread Konstantin Kolinko
2011/1/25 jean-frederic clere : > The candidates binaries are available here: > http://people.apache.org/~jfclere/tomcat-6/v6.0.31/ > > According to the release process, the 6.0.31 build corresponding to the > tag TOMCAT_6_0_31 is: > [x] Beta That is because of issue observed with Nio connector.

DO NOT REPLY [Bug 50648] RpcChannel improvements

2011-01-27 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=50648 --- Comment #3 from Olivier Costet 2011-01-27 06:17:20 EST --- @Mark Sorry about that. I'll file seperate entries and will try to match the style. (In reply to comment #2) > 2. > What type of exceptions have you seen here? > Reply faile

DO NOT REPLY [Bug 50667] New: Tribes | RpcChannel | Add a callback for cases when an error occured sending a reply to an RP call

2011-01-27 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=50667 Summary: Tribes | RpcChannel | Add a callback for cases when an error occured sending a reply to an RP call Product: Tomcat 7 Version: 7.0.6 Platform: All OS/Version: All

DO NOT REPLY [Bug 50667] Tribes | RpcChannel | Add a callback for cases when an error occured sending a reply to an RP call

2011-01-27 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=50667 --- Comment #1 from Olivier Costet 2011-01-27 06:57:27 EST --- Reproducing comments from https://issues.apache.org/bugzilla/show_bug.cgi?id=50648: Filip Hanik wrote: > 2. > What type of exceptions have you seen here? > Reply failed callb

DO NOT REPLY [Bug 50670] New: Tribes | RpcChannel | Add option to specify external class loaders to support custom message classes

2011-01-27 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=50670 Summary: Tribes | RpcChannel | Add option to specify external class loaders to support custom message classes Product: Tomcat 7 Version: 7.0.6 Platform: All OS/Version: A

DO NOT REPLY [Bug 50670] Tribes | RpcChannel | Add option to specify external class loaders to support custom message classes

2011-01-27 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=50670 --- Comment #1 from Olivier Costet 2011-01-27 08:46:47 EST --- Reproducing comments from https://issues.apache.org/bugzilla/show_bug.cgi?id=50648: Filip Hanik wrote: > 3. > The external loaders IMHO don't belong here. > For the applicatio

DO NOT REPLY [Bug 50670] Tribes | RpcChannel | Add option to specify external class loaders to support custom message classes

2011-01-27 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=50670 --- Comment #2 from Olivier Costet 2011-01-27 08:47:54 EST --- Created an attachment (id=26560) --> (https://issues.apache.org/bugzilla/attachment.cgi?id=26560) svn diff -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs

DO NOT REPLY [Bug 50667] Tribes | RpcChannel | Add a callback for cases when an error occured sending a reply to an RP call

2011-01-27 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=50667 --- Comment #2 from Olivier Costet 2011-01-27 08:49:08 EST --- Created an attachment (id=26561) --> (https://issues.apache.org/bugzilla/attachment.cgi?id=26561) svn diff CAVEAT: this proposal modifies the RpcCallback interface. RpcCallba

DO NOT REPLY [Bug 50648] RpcChannel improvements

2011-01-27 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=50648 --- Comment #4 from Olivier Costet 2011-01-27 08:50:53 EST --- Filed separe enhancement requests: https://issues.apache.org/bugzilla/show_bug.cgi?id=50667 (replyFailed) https://issues.apache.org/bugzilla/show_bug.cgi?id=50670 (class loader

DO NOT REPLY [Bug 50642] keepAliveProtection doesn't work

2011-01-27 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=50642 --- Comment #2 from Mark Thomas 2011-01-27 08:41:35 EST --- Looking at the KeepAliveCache more closely, the currently solution is the wrong approach. Because the thread only exists for as long as it is needed and is re-created as necessary

Re: [VOTE] Release build 6.0.31

2011-01-27 Thread jean-frederic clere
On 01/27/2011 10:30 AM, Konstantin Kolinko wrote: 2011/1/25 jean-frederic clere: The candidates binaries are available here: http://people.apache.org/~jfclere/tomcat-6/v6.0.31/ According to the release process, the 6.0.31 build corresponding to the tag TOMCAT_6_0_31 is: [x] Beta That is be

DO NOT REPLY [Bug 50673] New: Error when stopping Tomcat using services.msc

2011-01-27 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=50673 Summary: Error when stopping Tomcat using services.msc Product: Tomcat 7 Version: 7.0.6 Platform: PC Status: NEW Severity: normal Priority: P2 Component: Pac

DO NOT REPLY [Bug 50674] New: Some maven pom improvments

2011-01-27 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=50674 Summary: Some maven pom improvments Product: Taglibs Version: unspecified Platform: All OS/Version: All Status: NEW Severity: normal Priority: P2 Com

DO NOT REPLY [Bug 50674] Some maven pom improvments

2011-01-27 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=50674 --- Comment #1 from olamy 2011-01-27 11:06:34 EST --- Created an attachment (id=26562) --> (https://issues.apache.org/bugzilla/attachment.cgi?id=26562) taglibs parent patch -- Configure bugmail: https://issues.apache.org/bugzilla/userpre

DO NOT REPLY [Bug 50674] Some maven pom improvments

2011-01-27 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=50674 --- Comment #2 from olamy 2011-01-27 11:07:10 EST --- Created an attachment (id=26563) --> (https://issues.apache.org/bugzilla/attachment.cgi?id=26563) taglibs standard patch -- Configure bugmail: https://issues.apache.org/bugzilla/userp

DO NOT REPLY [Bug 50673] Error when stopping Tomcat using services.msc

2011-01-27 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=50673 Konstantin Kolinko changed: What|Removed |Added OS/Version||All --- Comment #1 from Konst

DO NOT REPLY [Bug 50651] NPE in InternalNioOutputBuffer.recycle

2011-01-27 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=50651 --- Comment #10 from Filip Hanik 2011-01-27 11:24:16 EST --- (In reply to comment #9) > Created an attachment (id=26557) --> (https://issues.apache.org/bugzilla/attachment.cgi?id=26557) [details] > 2011-01-27_tc6_50651_CoyoteAdapter.patch

DO NOT REPLY [Bug 50667] Tribes | RpcChannel | Add a callback for cases when an error occured sending a reply to an RP call

2011-01-27 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=50667 Filip Hanik changed: What|Removed |Added Status|NEW |NEEDINFO --- Comment #3 from Filip H

svn commit: r1064187 - /tomcat/tc6.0.x/trunk/STATUS.txt

2011-01-27 Thread fhanik
Author: fhanik Date: Thu Jan 27 16:38:08 2011 New Revision: 1064187 URL: http://svn.apache.org/viewvc?rev=1064187&view=rev Log: votes Modified: tomcat/tc6.0.x/trunk/STATUS.txt Modified: tomcat/tc6.0.x/trunk/STATUS.txt URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=106

DO NOT REPLY [Bug 50642] keepAliveProtection doesn't work

2011-01-27 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=50642 Mark Thomas changed: What|Removed |Added Status|NEW |NEEDINFO --- Comment #3 from Mark Th

svn commit: r1064189 - /tomcat/tc6.0.x/trunk/STATUS.txt

2011-01-27 Thread markt
Author: markt Date: Thu Jan 27 16:44:32 2011 New Revision: 1064189 URL: http://svn.apache.org/viewvc?rev=1064189&view=rev Log: Vote Modified: tomcat/tc6.0.x/trunk/STATUS.txt Modified: tomcat/tc6.0.x/trunk/STATUS.txt URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=10641

Regarding c:forEach and memory usage

2011-01-27 Thread Christopher Schultz
All, Today's (duplicate) bug report about held references in JSTL tags has me thinking. What is the resistance to "fixing" the problem of object retention in these tags? JSP 1.8.2 says that all page-scoped objects are released after the response is written or the request is forwarded to another h

Re: Regarding c:forEach and memory usage

2011-01-27 Thread Mark Thomas
On 27/01/2011 16:54, Christopher Schultz wrote: > I'd love to hear some comments. It is a simple trade-off. Enable pooling, use more memory, have less GC vs Disable pooling, use less memory, have more GC The memory/GC required will vary depending on which tags are used and how they are used. I t

Re: [VOTE] Release Tomcat 5.5.32 Build

2011-01-27 Thread Filip Hanik - Dev Lists
On 01/22/2011 11:01 AM, Jim Jagielski wrote: [X] Stable - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

DO NOT REPLY [Bug 50640] Keystore in AbstractEndpoint doesn't have to be a file

2011-01-27 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=50640 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED Resolution|

DO NOT REPLY [Bug 50627] Bug in Tomcat Comet. Event CometEvent.EventType.END is not fired when connection closed.‏

2011-01-27 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=50627 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED Resolution|

DO NOT REPLY [Bug 50642] keepAliveProtection doesn't work

2011-01-27 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=50642 --- Comment #4 from Christopher Schultz 2011-01-27 12:43:04 EST --- Created an attachment (id=26564) --> (https://issues.apache.org/bugzilla/attachment.cgi?id=26564) Servlet that should trigger this thread to be created It's ugly, but it

DO NOT REPLY [Bug 50673] Error when stopping Tomcat using services.msc

2011-01-27 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=50673 Konstantin Kolinko changed: What|Removed |Added Status|NEW |RESOLVED Resolution|

DO NOT REPLY [Bug 50667] Tribes | RpcChannel | Add a callback for cases when an error occured sending a reply to an RP call

2011-01-27 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=50667 --- Comment #4 from Olivier Costet 2011-01-27 12:55:27 EST --- (In reply to comment #3) > I still don't understand this enhancement. What is the possibly use case for > implementing replyFailed. > The callback method replyFailed would get

DO NOT REPLY [Bug 50667] Tribes | RpcChannel | Add a callback for cases when an error occured sending a reply to an RP call

2011-01-27 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=50667 Olivier Costet changed: What|Removed |Added Status|NEEDINFO|NEW -- Configure bugmail: https:

Re: Regarding c:forEach and memory usage

2011-01-27 Thread Kris Schneider
On Thu, Jan 27, 2011 at 11:54 AM, Christopher Schultz wrote: > ... > I'd love to hear some comments. Some additional background: https://issues.apache.org/bugzilla/show_bug.cgi?id=33934 I haven't looked at the patch, so I'm not sure exactly how that got solved... -- Kris Schneider ---

DO NOT REPLY [Bug 50642] keepAliveProtection doesn't work

2011-01-27 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=50642 --- Comment #5 from Konstantin Kolinko 2011-01-27 13:22:23 EST --- Created an attachment (id=26566) --> (https://issues.apache.org/bugzilla/attachment.cgi?id=26566) Alternative implementation of the servlet Alternative implementation of

DO NOT REPLY [Bug 50642] keepAliveProtection doesn't work

2011-01-27 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=50642 Konstantin Kolinko changed: What|Removed |Added Status|NEEDINFO|NEW -- Configure bugmail: ht

svn commit: r1064252 - in /tomcat/tc6.0.x/trunk: STATUS.txt java/org/apache/catalina/connector/CoyoteAdapter.java java/org/apache/coyote/http11/InternalNioOutputBuffer.java webapps/docs/changelog.xml

2011-01-27 Thread kkolinko
Author: kkolinko Date: Thu Jan 27 18:43:18 2011 New Revision: 1064252 URL: http://svn.apache.org/viewvc?rev=1064252&view=rev Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=50651 Fix NPE in InternalNioOutputBuffer.recycle(). - Do not throw NPE when recycle() is called more than once. -

DO NOT REPLY [Bug 50651] NPE in InternalNioOutputBuffer.recycle

2011-01-27 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=50651 Konstantin Kolinko changed: What|Removed |Added Status|NEW |RESOLVED Resolution|

svn commit: r1064254 - in /tomcat/tc6.0.x/trunk: ./ STATUS.txt java/org/apache/catalina/ha/session/DeltaManager.java webapps/docs/changelog.xml

2011-01-27 Thread kkolinko
Author: kkolinko Date: Thu Jan 27 18:58:55 2011 New Revision: 1064254 URL: http://svn.apache.org/viewvc?rev=1064254&view=rev Log: Followup to r1061433 Be consistent with locks on sessionCreationTiming, sessionExpirationTiming in DeltaManager.resetStatistics(): use the same lock as elsewhere. Modi

svn commit: r1064257 - in /tomcat/tc6.0.x/trunk: ./ java/org/apache/catalina/core/ webapps/docs/

2011-01-27 Thread kkolinko
Author: kkolinko Date: Thu Jan 27 19:06:19 2011 New Revision: 1064257 URL: http://svn.apache.org/viewvc?rev=1064257&view=rev Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=48822 Include context name in reload and stop log statements. Based on the patch by Marc Guillemot. Modified:

DO NOT REPLY [Bug 48822] Include contest name in reload and stop log statements

2011-01-27 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=48822 Konstantin Kolinko changed: What|Removed |Added Status|NEW |RESOLVED Resolution|

DO NOT REPLY [Bug 50650] Connector#setProperty(String, String) does not set explicit property values

2011-01-27 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=50650 Konstantin Kolinko changed: What|Removed |Added Status|REOPENED|RESOLVED Resolution|

DO NOT REPLY [Bug 50496] AccessLogValve not logging size correctly for %B with enabled compression

2011-01-27 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=50496 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED Resolution|

svn commit: r1064275 - /tomcat/trunk/webapps/docs/jasper-howto.xml

2011-01-27 Thread markt
Author: markt Date: Thu Jan 27 19:43:23 2011 New Revision: 1064275 URL: http://svn.apache.org/viewvc?rev=1064275&view=rev Log: Typo Modified: tomcat/trunk/webapps/docs/jasper-howto.xml Modified: tomcat/trunk/webapps/docs/jasper-howto.xml URL: http://svn.apache.org/viewvc/tomcat/trunk/webapp

DO NOT REPLY [Bug 50631] InternalNioInputBuffer should honor maxHttpHeadSize

2011-01-27 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=50631 Konstantin Kolinko changed: What|Removed |Added OS/Version||All --- Comment #1 from Konst

Re: [VOTE] Release build 6.0.31

2011-01-27 Thread Konstantin Kolinko
2011/1/27 jean-frederic clere : > On 01/27/2011 10:30 AM, Konstantin Kolinko wrote: >> >> 2011/1/25 jean-frederic clere: >>> >>> The candidates binaries are available here: >>> http://people.apache.org/~jfclere/tomcat-6/v6.0.31/ >>> >>> According to the release process, the 6.0.31 build correspondi

DO NOT REPLY [Bug 50664] connectUsingDriver should use thread context classloader to load driver

2011-01-27 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=50664 balusc changed: What|Removed |Added Status|NEW |RESOLVED Resolution|

[Tomcat Wiki] Update of "PoweredBy" by andy smith

2011-01-27 Thread Apache Wiki
Dear Wiki user, You have subscribed to a wiki page or wiki category on "Tomcat Wiki" for change notification. The "PoweredBy" page has been changed by andy smith. http://wiki.apache.org/tomcat/PoweredBy?action=diff&rev1=304&rev2=305 -- === Dere

DO NOT REPLY [Bug 50664] connectUsingDriver should use thread context classloader to load driver

2011-01-27 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=50664 --- Comment #2 from Christopher Schultz 2011-01-27 16:44:21 EST --- I am in favor of using the context's WebappClassLoader when configuring a JNDI DataSource defined in context.xml. -- Configure bugmail: https://issues.apache.org/bugzill

DO NOT REPLY [Bug 50667] Tribes | RpcChannel | Add a callback for cases when an error occured sending a reply to an RP call

2011-01-27 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=50667 --- Comment #5 from Filip Hanik 2011-01-27 16:49:01 EST --- Hi Olivier, yes, I see the use case. I do have a different suggestion for the solution, as there is a significant change. I'm attaching a patch with the summary of 1. Not breaki

DO NOT REPLY [Bug 50667] Tribes | RpcChannel | Add a callback for cases when an error occured sending a reply to an RP call

2011-01-27 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=50667 --- Comment #6 from Filip Hanik 2011-01-27 16:50:07 EST --- Created an attachment (id=26567) --> (https://issues.apache.org/bugzilla/attachment.cgi?id=26567) Patch to include replyFailed functionality -- Configure bugmail: https://issues

DO NOT REPLY [Bug 50664] connectUsingDriver should use thread context classloader to load driver

2011-01-27 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=50664 --- Comment #3 from Filip Hanik 2011-01-27 17:08:04 EST --- (In reply to comment #2) > I am in favor of using the context's WebappClassLoader when configuring a JNDI > DataSource defined in context.xml. Yes, but this can cause problems whe

DO NOT REPLY [Bug 50664] connectUsingDriver should use thread context classloader to load driver

2011-01-27 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=50664 --- Comment #4 from Konstantin Kolinko 2011-01-27 17:14:01 EST --- (In reply to comment #2) > I am in favor of using the context's WebappClassLoader when configuring a JNDI > DataSource defined in context.xml. Note, that context.xml is be

Re: [VOTE] Release Tomcat 5.5.32 Build

2011-01-27 Thread Konstantin Kolinko
2011/1/22 Jim Jagielski : > [x] Stable Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

DO NOT REPLY [Bug 50677] New: Allow system property variables in catalina.properties

2011-01-27 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=50677 Summary: Allow system property variables in catalina.properties Product: Tomcat 7 Version: trunk Platform: All OS/Version: All Status: NEW Severity: enhancement

DO NOT REPLY [Bug 50677] Allow system property variables in catalina.properties

2011-01-27 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=50677 --- Comment #1 from Jim Riggs 2011-01-27 20:56:03 EST --- Created an attachment (id=26568) --> (https://issues.apache.org/bugzilla/attachment.cgi?id=26568) Proposal A Substitute on retrieval. -- Configure bugmail: https://issues.apache.

DO NOT REPLY [Bug 50677] Allow system property variables in catalina.properties

2011-01-27 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=50677 --- Comment #2 from Jim Riggs 2011-01-27 20:56:37 EST --- Created an attachment (id=26569) --> (https://issues.apache.org/bugzilla/attachment.cgi?id=26569) Proposal B Substitute on initialization. -- Configure bugmail: https://issues.ap

Re: Regarding c:forEach and memory usage

2011-01-27 Thread Jeremy Boynes
It also interacts with tag reinitialization as described here: https://issues.apache.org/bugzilla/show_bug.cgi?id=49589 in that we hang on to the value when the tag is in the pool only to clear it when we use it. I think there are other optimizations that could be done to forEach but have

Re: Regarding c:forEach and memory usage

2011-01-27 Thread Jeremy Boynes
On Jan 27, 2011, at 10:14 AM, Kris Schneider wrote: > On Thu, Jan 27, 2011 at 11:54 AM, Christopher Schultz > wrote: >> ... >> I'd love to hear some comments. > > Some additional background: > https://issues.apache.org/bugzilla/show_bug.cgi?id=33934 > > I haven't looked at the patch, so I'm not