Re: svn commit: r1051539 - /tomcat/trunk/java/org/apache/tomcat/util/threads/CounterLatch.java

2010-12-28 Thread sebb
On 22 December 2010 16:04, Filip Hanik - Dev Lists wrote: > On 12/21/2010 7:29 PM, sebb wrote: >> >>> -    private long signal; >>> +    private volatile long signal; >> >> It would be cheaper to make it final as it's only ever set in the ctor >> and is immutable. > > nothing cheaper, volatile are

Re: svn commit: r1051539 - /tomcat/trunk/java/org/apache/tomcat/util/threads/CounterLatch.java

2010-12-28 Thread Filip Hanik - Dev Lists
On 12/28/2010 5:02 PM, sebb wrote: On 22 December 2010 16:04, Filip Hanik - Dev Lists wrote: On 12/21/2010 7:29 PM, sebb wrote: -private long signal; +private volatile long signal; It would be cheaper to make it final as it's only ever set in the ctor and is immutable. nothing chea

DO NOT REPLY [Bug 50526] New: Clarify that JavaMail Session JNDI resource factory can accept any configuration attribute from JavaMail

2010-12-28 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=50526 Summary: Clarify that JavaMail Session JNDI resource factory can accept any configuration attribute from JavaMail Product: Tomcat 7 Version: unspecified Platform: PC