svn commit: r1044255 - /tomcat/trunk/java/org/apache/catalina/servlets/DefaultServlet.java

2010-12-10 Thread markt
Author: markt Date: Fri Dec 10 09:47:05 2010 New Revision: 1044255 URL: http://svn.apache.org/viewvc?rev=1044255&view=rev Log: Fix FindBugs / unused code warnings Modified: tomcat/trunk/java/org/apache/catalina/servlets/DefaultServlet.java Modified: tomcat/trunk/java/org/apache/catalina/serv

svn commit: r1044264 - /tomcat/trunk/java/org/apache/catalina/servlets/LocalStrings.properties

2010-12-10 Thread markt
Author: markt Date: Fri Dec 10 10:06:44 2010 New Revision: 1044264 URL: http://svn.apache.org/viewvc?rev=1044264&view=rev Log: Missed file in r1044255 Modified: tomcat/trunk/java/org/apache/catalina/servlets/LocalStrings.properties Modified: tomcat/trunk/java/org/apache/catalina/servlets/Loc

svn commit: r1044266 - in /tomcat/trunk: java/org/apache/catalina/servlets/DefaultServlet.java webapps/docs/changelog.xml

2010-12-10 Thread markt
Author: markt Date: Fri Dec 10 10:11:38 2010 New Revision: 1044266 URL: http://svn.apache.org/viewvc?rev=1044266&view=rev Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=50413 Ensure 304s are not returned when using static files as error pages Modified: tomcat/trunk/java/org/apach

DO NOT REPLY [Bug 50413] Tomcat returns 304 instead of 404 response for static custom 404 error file

2010-12-10 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=50413 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED Resolution|

DO NOT REPLY [Bug 50451] New: Apache Server Dont Start

2010-12-10 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=50451 Summary: Apache Server Dont Start Product: Tomcat 6 Version: 6.0.20 Platform: PC Status: NEW Severity: major Priority: P2 Component: Catalina Assigne

DO NOT REPLY [Bug 50451] Apache Server Dont Start

2010-12-10 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=50451 King changed: What|Removed |Added CC||vaghela_shreya...@yahoo.com OS/Vers

DO NOT REPLY [Bug 50451] Apache Server Dont Start

2010-12-10 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=50451 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED Resolution|

DO NOT REPLY [Bug 50452] New: java.net.SocketTimeoutException: Exception filling buffer with data from underlying input stream: not an EAGAIN status, so perhaps disconnected client?

2010-12-10 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=50452 Summary: java.net.SocketTimeoutException: Exception filling buffer with data from underlying input stream: not an EAGAIN status, so perhaps disconnected client? Product: Tomcat 5

svn commit: r1044359 - in /tomcat/trunk: java/org/apache/catalina/ java/org/apache/catalina/manager/ java/org/apache/catalina/session/ webapps/docs/

2010-12-10 Thread markt
Author: markt Date: Fri Dec 10 13:54:16 2010 New Revision: 1044359 URL: http://svn.apache.org/viewvc?rev=1044359&view=rev Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=50448 Regression caused by http://svn.apache.org/viewvc?view=revision&revision=1036281 Modified: tomcat/trunk/j

DO NOT REPLY [Bug 50448] StandardSession.expire causes IllegalStateException: getCreationTime: Session already invalidated

2010-12-10 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=50448 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED Resolution|

DO NOT REPLY [Bug 50452] java.net.SocketTimeoutException: Exception filling buffer with data from underlying input stream: not an EAGAIN status, so perhaps disconnected client?

2010-12-10 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=50452 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED Resolution|

DO NOT REPLY [Bug 50351] javax.naming.NamingException: No set method found for property: singleton

2010-12-10 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=50351 --- Comment #9 from Christophe Thiébaud 2010-12-10 09:03:24 EST --- I confirm the patch works for me as well. thanks Christophe -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving th

DO NOT REPLY [Bug 50453] New: Multiple X-Forwarded-For headers not handled by RemoteIP valve

2010-12-10 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=50453 Summary: Multiple X-Forwarded-For headers not handled by RemoteIP valve Product: Tomcat 6 Version: 6.0.29 Platform: PC OS/Version: Linux Status: NEW

DO NOT REPLY [Bug 50453] Multiple X-Forwarded-For headers not handled by RemoteIP valve

2010-12-10 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=50453 brett.dellegra...@intact-is.com changed: What|Removed |Added CC||brett.dellegra...@

DO NOT REPLY [Bug 50453] Multiple X-Forwarded-For headers not handled by RemoteIP valve

2010-12-10 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=50453 --- Comment #1 from Jim Riggs 2010-12-10 09:39:04 EST --- This is due to RemoteIpValve's use of request.getHeader() rather than the enumeration from request.getHeaders(). I'll try to whip up a patch... -- Configure bugmail: https://issue

DO NOT REPLY [Bug 50453] Multiple X-Forwarded-For headers not handled by RemoteIP valve

2010-12-10 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=50453 --- Comment #2 from Rainer Jung 2010-12-10 10:19:00 EST --- I think there is no given standard concerning whether the first or the last header is the "right" one (coming from the closest proxy). The same for a comma-separated multi-valued

DO NOT REPLY [Bug 50453] Multiple X-Forwarded-For headers not handled by RemoteIP valve

2010-12-10 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=50453 --- Comment #3 from Mark Thomas 2010-12-10 10:46:07 EST --- RFC2616 is clear on how headers should be combined so order is retained. In short ... X-Forwarded-For : A, B ... X-Forwarded-For : C ... X-Forwarded-For : D, E must be treated exa

DO NOT REPLY [Bug 50413] Tomcat returns 304 instead of 404 response for static custom 404 error file

2010-12-10 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=50413 --- Comment #3 from Konstantin Preißer 2010-12-10 10:57:33 EST --- (In reply to comment #2) > Thanks for the report. This has been fixed in 7.0.x and will be included in > 7.0.6 onwards. Thanks :) I would like to note that the same behav

DO NOT REPLY [Bug 50455] New: Jasper don't detects changes in jsp file if we load de jsp and after we modify the jsp in the same second

2010-12-10 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=50455 Summary: Jasper don't detects changes in jsp file if we load de jsp and after we modify the jsp in the same second Product: Tomcat 7 Version: 7.0.5 Platform: All OS/Versi

DO NOT REPLY [Bug 50455] Jasper don't detects changes in jsp file if we load de jsp and after we modify the jsp in the same second

2010-12-10 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=50455 --- Comment #1 from Alejandro Anadon 2010-12-10 13:22:51 EST --- (In reply to comment #0) > If we have a jsp file (not in a war file; just directly in the file system) > then we first call the jsp; then it is compiled and executed. > But i

DO NOT REPLY [Bug 50453] Multiple X-Forwarded-For headers not handled by RemoteIP valve

2010-12-10 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=50453 --- Comment #4 from Christopher Schultz 2010-12-10 14:40:29 EST --- So, should the RemoteIPValve/Filter should be looking at the first X-Forwarded-For (A) or the last X-Forwarded-For (E) address? It sounds like the reporter was expecting

DO NOT REPLY [Bug 50453] Multiple X-Forwarded-For headers not handled by RemoteIP valve

2010-12-10 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=50453 --- Comment #5 from William A. Rowe Jr. 2010-12-10 15:24:59 EST --- Rainer, the spec is absolutely clear about precidence, the last (rightmost) value is added by the nearest adjacent proxy to the server agent. Ergo, the first (leftmost) v

DO NOT REPLY [Bug 50453] Multiple X-Forwarded-For headers not handled by RemoteIP valve

2010-12-10 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=50453 --- Comment #6 from Jim Riggs 2010-12-10 16:48:05 EST --- (In reply to comment #4) > So, should the RemoteIPValve/Filter should be looking at the first > X-Forwarded-For (A) or the last X-Forwarded-For (E) address? Chris - It should be lo