DO NOT REPLY [Bug 50363] New: Chunked encoding is applied 304 responses with no bodies

2010-11-29 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=50363 Summary: Chunked encoding is applied 304 responses with no bodies Product: Tomcat Connectors Version: 1.2.30 Platform: PC Status: NEW Severity: normal

svn commit: r1040059 - /tomcat/jk/trunk/native/iis/jk_isapi_plugin.c

2010-11-29 Thread timw
Author: timw Date: Mon Nov 29 10:42:15 2010 New Revision: 1040059 URL: http://svn.apache.org/viewvc?rev=1040059&view=rev Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=50363 Handle 204, 205 and 304 responses with empty message bodies correctly (by not chunk encoding the body). Modif

DO NOT REPLY [Bug 50363] Chunked encoding is applied 304 responses with no bodies

2010-11-29 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=50363 Tim Whittington changed: What|Removed |Added Status|NEW |RESOLVED Resolution|

svn commit: r1040061 - /tomcat/jk/trunk/xdocs/miscellaneous/changelog.xml

2010-11-29 Thread timw
Author: timw Date: Mon Nov 29 10:47:46 2010 New Revision: 1040061 URL: http://svn.apache.org/viewvc?rev=1040061&view=rev Log: Changelog for https://issues.apache.org/bugzilla/show_bug.cgi?id=50363 Modified: tomcat/jk/trunk/xdocs/miscellaneous/changelog.xml Modified: tomcat/jk/trunk/xdocs/mis

Re: svn commit: r1036595 - in /tomcat/trunk: java/org/apache/catalina/ java/org/apache/catalina/ha/session/ java/org/apache/catalina/session/ test/org/apache/catalina/session/

2010-11-29 Thread Tim Funk
I checked the svn history of why MD5 (hashing was used) and the picture is incomplete. (unless someone asks craig since I think he was the author) But it appears like this ... Tomcat 3.X use Math.random() and some misc crap to generate its session id. It had a comment (paraphrased), "not secure

Re: svn commit: r1036595 - in /tomcat/trunk: java/org/apache/catalina/ java/org/apache/catalina/ha/session/ java/org/apache/catalina/session/ test/org/apache/catalina/session/

2010-11-29 Thread Mladen Turk
On 11/25/2010 05:33 PM, Mark Thomas wrote: How about this as an approach to reduce the complexity: 1. Remove the MD5 code (optional) 2. Default to /dev/urandom then SecureRandom. Don't fall back to Random. 3. Provide a class that implements Random that reads data from a file 4. If randomFile is

Re: svn commit: r1036595 - in /tomcat/trunk: java/org/apache/catalina/ java/org/apache/catalina/ha/session/ java/org/apache/catalina/session/ test/org/apache/catalina/session/

2010-11-29 Thread Tim Funk
Sorry for the additional noise ... my svn emails are in a different folder from dev emails. I just noticed ... svn commit: r1039882 - /tomcat/trunk/java/org/apache/catalina/session/ManagerBase.java -Tim On 11/29/2010 7:40 AM, Tim Funk wrote: I checked the svn history of why MD5 (hashing was

svn commit: r1040111 - in /tomcat/trunk: java/org/apache/catalina/startup/Embedded.java webapps/docs/changelog.xml

2010-11-29 Thread markt
Author: markt Date: Mon Nov 29 13:41:07 2010 New Revision: 1040111 URL: http://svn.apache.org/viewvc?rev=1040111&view=rev Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=50358 Set correct state when stopping Modified: tomcat/trunk/java/org/apache/catalina/startup/Embedded.java

DO NOT REPLY [Bug 50358] Embedded.stopInternal sets state to STARTING, should be STOPPING

2010-11-29 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=50358 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED Resolution|

DO NOT REPLY [Bug 50360] Server socket still bound after Embedded.stop is invoked

2010-11-29 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=50360 --- Comment #2 from Mark Thomas 2010-11-29 08:47:21 EST --- Connector components can be started and stopped multiple times and setting MUST_DESTROY will break that. Therefore, the patch can't be used in its current form. The Connectors and

Re: svn commit: r1036595 - in /tomcat/trunk: java/org/apache/catalina/ java/org/apache/catalina/ha/session/ java/org/apache/catalina/session/ test/org/apache/catalina/session/

2010-11-29 Thread Mark Thomas
On 29/11/2010 13:41, Tim Funk wrote: > Sorry for the additional noise ... my svn emails are in a different > folder from dev emails. I just noticed ... Good to see we were thinking along the same lines. I still want to get to the bottom of the really poor performance on my Mac. Before I do that, I

DO NOT REPLY [Bug 50351] javax.naming.NamingException: No set method found for property: singleton

2010-11-29 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=50351 --- Comment #4 from Mark Thomas 2010-11-29 08:57:15 EST --- I think I have a patch for this. If I attach a binary patch to this bug along with instructions on how to test it would you be able to test the patch to see it it fixes the issue?

svn commit: r1040157 - in /tomcat/trunk: java/org/apache/naming/factory/BeanFactory.java webapps/docs/changelog.xml

2010-11-29 Thread markt
Author: markt Date: Mon Nov 29 15:39:50 2010 New Revision: 1040157 URL: http://svn.apache.org/viewvc?rev=1040157&view=rev Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=50351 Fix the regression that broke BeanFactory resources caused by the previous fix for 50159 Modified: tomca

svn commit: r1040158 - in /tomcat/trunk/test/org/apache/naming/resources: TestNamingContext.java TesterObject.java

2010-11-29 Thread markt
Author: markt Date: Mon Nov 29 15:40:11 2010 New Revision: 1040158 URL: http://svn.apache.org/viewvc?rev=1040158&view=rev Log: Add a test case for https://issues.apache.org/bugzilla/show_bug.cgi?id=50351 Modified: tomcat/trunk/test/org/apache/naming/resources/TestNamingContext.java tomcat

DO NOT REPLY [Bug 50351] javax.naming.NamingException: No set method found for property: singleton

2010-11-29 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=50351 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED Resolution|

svn commit: r1040161 - /tomcat/trunk/java/org/apache/coyote/AsyncStateMachine.java

2010-11-29 Thread markt
Author: markt Date: Mon Nov 29 15:46:13 2010 New Revision: 1040161 URL: http://svn.apache.org/viewvc?rev=1040161&view=rev Log: Correct method name in log message Modified: tomcat/trunk/java/org/apache/coyote/AsyncStateMachine.java Modified: tomcat/trunk/java/org/apache/coyote/AsyncStateMachi

Re: svn commit: r1036595 - in /tomcat/trunk: java/org/apache/catalina/ java/org/apache/catalina/ha/session/ java/org/apache/catalina/session/ test/org/apache/catalina/session/

2010-11-29 Thread Konstantin Kolinko
2010/11/29 Mark Thomas : > Good to see we were thinking along the same lines. I still want to get > to the bottom of the really poor performance on my Mac. Looking at documentation for SecureRandom() constructor, it uses whatever implementation that it finds first. So, configuration of JRE might

Re: svn commit: r1036595 - in /tomcat/trunk: java/org/apache/catalina/ java/org/apache/catalina/ha/session/ java/org/apache/catalina/session/ test/org/apache/catalina/session/

2010-11-29 Thread Mark Thomas
On 29/11/2010 15:52, Konstantin Kolinko wrote: > 2010/11/29 Mark Thomas : >> Good to see we were thinking along the same lines. I still want to get >> to the bottom of the really poor performance on my Mac. > > Looking at documentation for SecureRandom() constructor, it uses > whatever implementa

Re: svn commit: r1040161 - /tomcat/trunk/java/org/apache/coyote/AsyncStateMachine.java

2010-11-29 Thread Konstantin Kolinko
2010/11/29 : > Author: markt > Date: Mon Nov 29 15:46:13 2010 > New Revision: 1040161 > > URL: http://svn.apache.org/viewvc?rev=1040161&view=rev > Log: > Correct method name in log message > > Modified: >    tomcat/trunk/java/org/apache/coyote/AsyncStateMachine.java > > Modified: tomcat/trunk/java

svn commit: r1040189 - in /tomcat/trunk: java/org/apache/coyote/AsyncStateMachine.java webapps/docs/changelog.xml

2010-11-29 Thread markt
Author: markt Date: Mon Nov 29 16:58:05 2010 New Revision: 1040189 URL: http://svn.apache.org/viewvc?rev=1040189&view=rev Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=50352 Ensure that AsyncListener.onComplete() is fired when AsyncContext.complete() is called. Modified: tomcat

svn commit: r1040190 - /tomcat/trunk/test/org/apache/catalina/core/TestAsyncContextImpl.java

2010-11-29 Thread markt
Author: markt Date: Mon Nov 29 16:58:31 2010 New Revision: 1040190 URL: http://svn.apache.org/viewvc?rev=1040190&view=rev Log: Test case for https://issues.apache.org/bugzilla/show_bug.cgi?id=50352 Modified: tomcat/trunk/test/org/apache/catalina/core/TestAsyncContextImpl.java Modified: tomca

DO NOT REPLY [Bug 50352] AsyncListener.onComplete is not called after AsyncContext.complete() is called

2010-11-29 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=50352 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED Resolution|

DO NOT REPLY [Bug 50339] mod_jk parsing error if workers.properties contains whitespaces

2010-11-29 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=50339 --- Comment #2 from Rainer Jung 2010-11-29 12:07:58 EST --- Can you please try the following patch: Index: common/jk_map.c === --- common/jk_map.c (revision 1032021) +++

DO NOT REPLY [Bug 50353] Calling asyncContext.getResponse() returns null after async timeout

2010-11-29 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=50353 Mark Thomas changed: What|Removed |Added Severity|normal |enhancement --- Comment #2 from Mark

svn commit: r1040196 - /tomcat/trunk/java/org/apache/coyote/AsyncStateMachine.java

2010-11-29 Thread markt
Author: markt Date: Mon Nov 29 17:23:55 2010 New Revision: 1040196 URL: http://svn.apache.org/viewvc?rev=1040196&view=rev Log: Correct method names in log messages Modified: tomcat/trunk/java/org/apache/coyote/AsyncStateMachine.java Modified: tomcat/trunk/java/org/apache/coyote/AsyncStateMac

Re: svn commit: r1040161 - /tomcat/trunk/java/org/apache/coyote/AsyncStateMachine.java

2010-11-29 Thread Mark Thomas
On 29/11/2010 15:57, Konstantin Kolinko wrote: > 2010/11/29 : >> Author: markt >> Date: Mon Nov 29 15:46:13 2010 >> New Revision: 1040161 >> >> URL: http://svn.apache.org/viewvc?rev=1040161&view=rev > Searching for "asyncStateMachine.invalidAsyncState" in that file, > there are more errors like

svn commit: r1040198 - /tomcat/trunk/test/webapp-3.0/WEB-INF/tags/bug49297.tag

2010-11-29 Thread rjung
Author: rjung Date: Mon Nov 29 17:31:18 2010 New Revision: 1040198 URL: http://svn.apache.org/viewvc?rev=1040198&view=rev Log: Set svn properties. Modified: tomcat/trunk/test/webapp-3.0/WEB-INF/tags/bug49297.tag (contents, props changed) Modified: tomcat/trunk/test/webapp-3.0/WEB-INF/tags

svn commit: r1040199 - /tomcat/trunk/build.xml

2010-11-29 Thread rjung
Author: rjung Date: Mon Nov 29 17:32:21 2010 New Revision: 1040199 URL: http://svn.apache.org/viewvc?rev=1040199&view=rev Log: Add css to text file list. Modified: tomcat/trunk/build.xml Modified: tomcat/trunk/build.xml URL: http://svn.apache.org/viewvc/tomcat/trunk/build.xml?rev=1040199&r1

Re: DO NOT REPLY [Bug 50339] mod_jk parsing error if workers.properties contains whitespaces

2010-11-29 Thread Mladen Turk
On 11/29/2010 06:08 PM, bugzi...@apache.org wrote: https://issues.apache.org/bugzilla/show_bug.cgi?id=50339 -strcpy(s,&s[i]); +for (off = i; '\0' != s[i]; i++); { +s[i - off] = s[i]; +} +s[i - off] = s[i]; memmove ;) It would mean HPUX has a crappy st

DO NOT REPLY [Bug 50370] New: issue Tomcat is down or refused connection. No response has been sent to the client (yet)

2010-11-29 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=50370 Summary: issue Tomcat is down or refused connection. No response has been sent to the client (yet) Product: Tomcat Connectors Version: 1.2.30 Platform: HP OS/Version: Lin

DO NOT REPLY [Bug 50370] issue Tomcat is down or refused connection. No response has been sent to the client (yet)

2010-11-29 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=50370 Thomas changed: What|Removed |Added Priority|P2 |P4 CC|

Re: [VOTE] Release Apache Tomcat 7.0.5

2010-11-29 Thread Rainer Jung
On 24.11.2010 19:52, Mark Thomas wrote: The proposed Apache Tomcat 7.0.5 release is now available for voting. It can be obtained from: http://people.apache.org/~markt/dev/tomcat-7/v7.0.5/ The svn tag is: http://svn.apache.org/repos/asf/tomcat/tc7.0.x/tags/TOMCAT_7_0_5/ As with previous votes, I

DO NOT REPLY [Bug 50370] issue Tomcat is down or refused connection. No response has been sent to the client (yet)

2010-11-29 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=50370 Rainer Jung changed: What|Removed |Added Status|NEW |RESOLVED Resolution|

Re: [VOTE] Release Apache Tomcat 7.0.5

2010-11-29 Thread Tim Whittington
I've only been able to do limited testing, but let's keep the 7 releases ticking over. tim On Thu, Nov 25, 2010 at 7:52 AM, Mark Thomas wrote: > The proposed Apache Tomcat 7.0.5 release is now available for voting. > > It can be obtained from: > http://people.apache.org/~markt/dev/tomcat-7/v7.0.

DO NOT REPLY [Bug 50363] Chunked encoding is applied to 304 responses with no bodies

2010-11-29 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=50363 Tim Whittington changed: What|Removed |Added Summary|Chunked encoding is applied |Chunked encoding is applied

DO NOT REPLY [Bug 49511] IIS 7.5 incorrect logging: pfc->pFilterContext is per-connection not per-request

2010-11-29 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=49511 Tim Whittington changed: What|Removed |Added Status|NEEDINFO|RESOLVED Resolution|

DO NOT REPLY [Bug 41170] single crlf in header termination crashes app.

2010-11-29 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=41170 Tim Whittington changed: What|Removed |Added Status|NEEDINFO|RESOLVED Resolution|

DO NOT REPLY [Bug 46263] Tomcat reloading of context does not update context path

2010-11-29 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=46263 --- Comment #3 from Joe Kislo 2010-11-29 15:07:33 EST --- I can confirm my patch still works on Tomcat 6.0.29 -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: -

DO NOT REPLY [Bug 46264] Shutting down tomcat with large number of contexts is slow

2010-11-29 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=46264 --- Comment #3 from Joe Kislo 2010-11-29 15:14:59 EST --- I can confirm my patch still works on Tomcat 6.0.29 -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: -

DO NOT REPLY [Bug 50351] javax.naming.NamingException: No set method found for property: singleton

2010-11-29 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=50351 --- Comment #6 from Flávio Henrique 2010-11-29 17:26:30 EST --- Sure, I will try to do my best, but I am a regular user, not a specialized one. (In reply to comment #4) > I think I have a patch for this. If I attach a binary patch to thi

DO NOT REPLY [Bug 46264] Shutting down tomcat with large number of contexts is slow

2010-11-29 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=46264 --- Comment #4 from Pid 2010-11-30 01:41:00 EST --- (In reply to comment #3) > I can confirm my patch still works on Tomcat 6.0.29 Would the java.util.concurrency package not provide a more elegant way of solving this problem? -- Configu