Author: markt
Date: Wed Oct 13 11:10:30 2010
New Revision: 1022068
URL: http://svn.apache.org/viewvc?rev=1022068&view=rev
Log:
Better fix for https://issues.apache.org/bugzilla/show_bug.cgi?id=49922
Revert my approach and go with patch suggested by heyoulin.
Extend test cases
Modified:
tomcat
https://issues.apache.org/bugzilla/show_bug.cgi?id=50084
Summary: catalina.sh fix in #49728 breaks PID handling again
Product: Tomcat 6
Version: unspecified
Platform: PC
Status: NEW
Severity: normal
Priority: P2
Co
https://issues.apache.org/bugzilla/show_bug.cgi?id=50084
r...@symentis.com changed:
What|Removed |Added
CC||r...@symentis.com
OS/Ve
https://issues.apache.org/bugzilla/show_bug.cgi?id=50084
--- Comment #1 from Konstantin Kolinko 2010-10-13
08:42:26 EDT ---
What is your suggestion how to deal with it?
I might think about truncating the stale PID file instead of deleting it.
To truncate a file one might redirect empty output
https://issues.apache.org/bugzilla/show_bug.cgi?id=50084
--- Comment #2 from r...@symentis.com 2010-10-13 08:48:16 EDT ---
In my opinion, thats not necessary.
I will add a patch to this ticket with my workaround to the problem.
Basically, when an empty pid file exists, its' just filled by catalin
https://issues.apache.org/bugzilla/show_bug.cgi?id=50084
--- Comment #3 from r...@symentis.com 2010-10-13 08:56:37 EDT ---
Created an attachment (id=26167)
--> (https://issues.apache.org/bugzilla/attachment.cgi?id=26167)
Patch to fix existing, empty pid file handling
Note: echo $! > "$CATALINA_P
https://issues.apache.org/bugzilla/show_bug.cgi?id=50072
--- Comment #2 from p...@creactive.cz 2010-10-13 09:09:24 EDT ---
Created an attachment (id=26168)
--> (https://issues.apache.org/bugzilla/attachment.cgi?id=26168)
tcpdump log - nio connector
--
Configure bugmail: https://issues.apache.or
https://issues.apache.org/bugzilla/show_bug.cgi?id=50072
--- Comment #3 from p...@creactive.cz 2010-10-13 09:09:59 EDT ---
Created an attachment (id=26169)
--> (https://issues.apache.org/bugzilla/attachment.cgi?id=26169)
tcpdump log - bio connector
--
Configure bugmail: https://issues.apache.or
https://issues.apache.org/bugzilla/show_bug.cgi?id=50072
p...@creactive.cz changed:
What|Removed |Added
Status|NEEDINFO|NEW
--- Comment #4 from p...@cr
https://issues.apache.org/bugzilla/show_bug.cgi?id=50087
Summary: When metadata-complete="false" throw illegal
JVM_CONSTANT_Class name
Product: Tomcat 7
Version: trunk
Platform: PC
OS/Version: All
Status: NEW
Author: kkolinko
Date: Wed Oct 13 13:43:03 2010
New Revision: 1022098
URL: http://svn.apache.org/viewvc?rev=1022098&view=rev
Log:
vote
Modified:
tomcat/tc5.5.x/trunk/STATUS.txt
Modified: tomcat/tc5.5.x/trunk/STATUS.txt
URL:
http://svn.apache.org/viewvc/tomcat/tc5.5.x/trunk/STATUS.txt?rev=10
https://issues.apache.org/bugzilla/show_bug.cgi?id=50087
--- Comment #1 from Konstantin Kolinko 2010-10-13
09:49:47 EDT ---
What is your JRE version?
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are th
Author: kkolinko
Date: Wed Oct 13 14:03:23 2010
New Revision: 1022109
URL: http://svn.apache.org/viewvc?rev=1022109&view=rev
Log:
Revert r964780 that was a fix for
https://issues.apache.org/bugzilla/show_bug.cgi?id=49428
See Re:r964780 thread on dev@ or TC 6.0 STATUS file.
Modified:
tomcat/t
Author: markt
Date: Wed Oct 13 14:22:10 2010
New Revision: 1022114
URL: http://svn.apache.org/viewvc?rev=1022114&view=rev
Log:
Withdraw patch
Modified:
tomcat/tc6.0.x/trunk/STATUS.txt
Modified: tomcat/tc6.0.x/trunk/STATUS.txt
URL:
http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt
https://issues.apache.org/bugzilla/show_bug.cgi?id=49428
--- Comment #10 from Mark Thomas 2010-10-13 10:23:56 EDT ---
Patch has been withdrawn for 6.0.x and reverted for 7.0.x
See http://tomcat.markmail.org/thread/u5i5blwrsxf2h3zv for reasoning.
--
Configure bugmail: https://issues.apache.org/
Author: markt
Date: Wed Oct 13 14:41:57 2010
New Revision: 1022117
URL: http://svn.apache.org/viewvc?rev=1022117&view=rev
Log:
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=49987
Thread safety issue with population of servlet context initialisation
parameters.
Back-port wasn't completely
https://issues.apache.org/bugzilla/show_bug.cgi?id=49987
Mark Thomas changed:
What|Removed |Added
Status|NEW |RESOLVED
Resolution|
Author: kkolinko
Date: Wed Oct 13 14:55:27 2010
New Revision: 1022120
URL: http://svn.apache.org/viewvc?rev=1022120&view=rev
Log:
Re-implement the fix for
https://issues.apache.org/bugzilla/show_bug.cgi?id=49428
Modified:
tomcat/trunk/java/org/apache/catalina/servlets/WebdavServlet.java
Modi
Author: markt
Date: Wed Oct 13 14:55:42 2010
New Revision: 1022121
URL: http://svn.apache.org/viewvc?rev=1022121&view=rev
Log:
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=49986
Thread safety for JSP reload.
Patch by timw
Modified:
tomcat/tc6.0.x/trunk/ (props changed)
tomcat/
https://issues.apache.org/bugzilla/show_bug.cgi?id=49986
Mark Thomas changed:
What|Removed |Added
Status|NEW |RESOLVED
Resolution|
Author: markt
Date: Wed Oct 13 15:02:32 2010
New Revision: 1022125
URL: http://svn.apache.org/viewvc?rev=1022125&view=rev
Log:
Typo
Modified:
tomcat/trunk/webapps/docs/changelog.xml
Modified: tomcat/trunk/webapps/docs/changelog.xml
URL:
http://svn.apache.org/viewvc/tomcat/trunk/webapps/docs
https://issues.apache.org/bugzilla/show_bug.cgi?id=50087
--- Comment #2 from heyoulin 2010-10-13 11:04:51 EDT ---
I try jdk1.6.0_21 and jrmc-4.0.1-1.6.0 both throw this exception. Only
groovy-all-1.7.2 and not test on other groovy version. But this worked fine
before until i use latest build.
--
Author: markt
Date: Wed Oct 13 15:06:26 2010
New Revision: 1022128
URL: http://svn.apache.org/viewvc?rev=1022128&view=rev
Log:
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=49972
Potential thread safety issues in FastHttpDateFormat
Modified:
tomcat/tc6.0.x/trunk/ (props changed)
https://issues.apache.org/bugzilla/show_bug.cgi?id=49972
Mark Thomas changed:
What|Removed |Added
Status|NEW |RESOLVED
Resolution|
Author: markt
Date: Wed Oct 13 15:16:35 2010
New Revision: 1022134
URL: http://svn.apache.org/viewvc?rev=1022134&view=rev
Log:
Avoid unnecessary cast
Modified:
tomcat/trunk/java/org/apache/catalina/core/StandardContext.java
Modified: tomcat/trunk/java/org/apache/catalina/core/StandardContext
Author: markt
Date: Wed Oct 13 15:23:17 2010
New Revision: 1022136
URL: http://svn.apache.org/viewvc?rev=1022136&view=rev
Log:
Proposal
Modified:
tomcat/tc6.0.x/trunk/STATUS.txt
Modified: tomcat/tc6.0.x/trunk/STATUS.txt
URL:
http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=1
Author: markt
Date: Wed Oct 13 15:23:33 2010
New Revision: 1022137
URL: http://svn.apache.org/viewvc?rev=1022137&view=rev
Log:
Proposal
Modified:
tomcat/tc5.5.x/trunk/STATUS.txt
Modified: tomcat/tc5.5.x/trunk/STATUS.txt
URL:
http://svn.apache.org/viewvc/tomcat/tc5.5.x/trunk/STATUS.txt?rev=1
Author: kkolinko
Date: Wed Oct 13 15:30:39 2010
New Revision: 1022143
URL: http://svn.apache.org/viewvc?rev=1022143&view=rev
Log:
Add changelog entry for r1022120
Modified:
tomcat/trunk/webapps/docs/changelog.xml
Modified: tomcat/trunk/webapps/docs/changelog.xml
URL:
http://svn.apache.org/v
Author: kkolinko
Date: Wed Oct 13 15:33:12 2010
New Revision: 1022144
URL: http://svn.apache.org/viewvc?rev=1022144&view=rev
Log:
proposal
Modified:
tomcat/tc6.0.x/trunk/STATUS.txt
Modified: tomcat/tc6.0.x/trunk/STATUS.txt
URL:
http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?re
https://issues.apache.org/bugzilla/show_bug.cgi?id=49428
--- Comment #11 from Konstantin Kolinko 2010-10-13
11:37:54 EDT ---
I reimplemented the fix in trunk in r1022120 and it will be in 7.0.4.
Proposed it for 6.0.x.
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=e
Author: kkolinko
Date: Wed Oct 13 15:45:09 2010
New Revision: 1022148
URL: http://svn.apache.org/viewvc?rev=1022148&view=rev
Log:
vote
Modified:
tomcat/tc5.5.x/trunk/STATUS.txt
tomcat/tc6.0.x/trunk/STATUS.txt
Modified: tomcat/tc5.5.x/trunk/STATUS.txt
URL:
http://svn.apache.org/viewvc/to
2010/10/6 :
> Author: markt
> Date: Wed Oct 6 18:03:03 2010
> New Revision: 1005192
>
> URL: http://svn.apache.org/viewvc?rev=1005192&view=rev
> Log:
> Proposal
>
> Modified:
> tomcat/tc6.0.x/trunk/STATUS.txt
>
> +
> +* Fix path parameter handling. Currently the following URL fails with a 404:
On 13/10/2010 16:57, Konstantin Kolinko wrote:
> 2010/10/6 :
>> Author: markt
>> Date: Wed Oct 6 18:03:03 2010
>> New Revision: 1005192
>>
>> URL: http://svn.apache.org/viewvc?rev=1005192&view=rev
>> Log:
>> Proposal
>>
>> Modified:
>>tomcat/tc6.0.x/trunk/STATUS.txt
>>
>> +
>> +* Fix path par
Author: kkolinko
Date: Wed Oct 13 16:18:48 2010
New Revision: 1022171
URL: http://svn.apache.org/viewvc?rev=1022171&view=rev
Log:
vote and proposal
Modified:
tomcat/tc6.0.x/trunk/STATUS.txt
Modified: tomcat/tc6.0.x/trunk/STATUS.txt
URL:
http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STAT
2010/10/13 Mark Thomas :
> I'm not against switching from a pair to a triple for this but a) I'm
> not sure many (any?) folks are using path parameters apart from for
> session IDs
I will think more on it and do some testing, what of our APIs are exposing them,
but just from reading RFC 3986 ch.3.
Hi,
One user asked to put commons-daemon-1.0.3 to the
Maven repository
I know everything is explained here:
http://www.apache.org/dev/publishing-maven-artifacts.html
However, never did that, so would appreciate if
someone familiar could to push the released jar's.
Thanks
--
^TM
-
Huh, wrong Apache tribe (I was sending that to the commons dev list).
Sorry for the noise.
One user asked to put commons-daemon-1.0.3 to the
Maven repository
Cheers
--
^TM
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apa
Author: rjung
Date: Wed Oct 13 18:53:17 2010
New Revision: 1022236
URL: http://svn.apache.org/viewvc?rev=1022236&view=rev
Log:
Vote.
Modified:
tomcat/tc6.0.x/trunk/STATUS.txt
Modified: tomcat/tc6.0.x/trunk/STATUS.txt
URL:
http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=1022
Author: rjung
Date: Wed Oct 13 18:53:30 2010
New Revision: 1022237
URL: http://svn.apache.org/viewvc?rev=1022237&view=rev
Log:
Vote.
Modified:
tomcat/tc5.5.x/trunk/STATUS.txt
Modified: tomcat/tc5.5.x/trunk/STATUS.txt
URL:
http://svn.apache.org/viewvc/tomcat/tc5.5.x/trunk/STATUS.txt?rev=1022
On 13 October 2010 15:41, wrote:
> Author: markt
> Date: Wed Oct 13 14:41:57 2010
> New Revision: 1022117
>
> URL: http://svn.apache.org/viewvc?rev=1022117&view=rev
> Log:
> Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=49987
> Thread safety issue with population of servlet context initi
Author: markt
Date: Wed Oct 13 21:16:33 2010
New Revision: 1022293
URL: http://svn.apache.org/viewvc?rev=1022293&view=rev
Log:
Fix reading the request line via NIO for slow clients (such as me typing via
telnet). Need to treat each section of the request line (text or space) as a
separate phase.
Author: markt
Date: Wed Oct 13 21:19:17 2010
New Revision: 1022294
URL: http://svn.apache.org/viewvc?rev=1022294&view=rev
Log:
Update change-log
Modified:
tomcat/trunk/webapps/docs/changelog.xml
Modified: tomcat/trunk/webapps/docs/changelog.xml
URL:
http://svn.apache.org/viewvc/tomcat/trunk
Author: markt
Date: Wed Oct 13 21:54:28 2010
New Revision: 1022303
URL: http://svn.apache.org/viewvc?rev=1022303&view=rev
Log:
Better clean-up.
Modified:
tomcat/trunk/java/org/apache/coyote/http11/Http11NioProtocol.java
Modified: tomcat/trunk/java/org/apache/coyote/http11/Http11NioProtocol.j
Author: markt
Date: Wed Oct 13 21:57:46 2010
New Revision: 1022304
URL: http://svn.apache.org/viewvc?rev=1022304&view=rev
Log:
Testing in 6.0.x confirmed this is the same issue.
Modified:
tomcat/trunk/webapps/docs/changelog.xml
Modified: tomcat/trunk/webapps/docs/changelog.xml
URL:
http://s
https://issues.apache.org/bugzilla/show_bug.cgi?id=50072
--- Comment #5 from Mark Thomas 2010-10-13 17:59:19 EDT ---
Created an attachment (id=26173)
--> (https://issues.apache.org/bugzilla/attachment.cgi?id=26173)
Proposed patch
--
Configure bugmail: https://issues.apache.org/bugzilla/userpre
Author: markt
Date: Wed Oct 13 22:02:13 2010
New Revision: 1022306
URL: http://svn.apache.org/viewvc?rev=1022306&view=rev
Log:
Proposal
Modified:
tomcat/tc6.0.x/trunk/STATUS.txt
Modified: tomcat/tc6.0.x/trunk/STATUS.txt
URL:
http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=1
https://issues.apache.org/bugzilla/show_bug.cgi?id=50072
--- Comment #6 from Mark Thomas 2010-10-13 18:02:49 EDT ---
Thanks for the additional traces and analysis. The analysis is particularly
helpful. I tracked the problem down to a long standing issue in the NIO
connector where request lines se
Author: markt
Date: Wed Oct 13 22:03:42 2010
New Revision: 1022307
URL: http://svn.apache.org/viewvc?rev=1022307&view=rev
Log:
Fix warnings
Modified:
tomcat/trunk/java/org/apache/catalina/servlets/WebdavServlet.java
Modified: tomcat/trunk/java/org/apache/catalina/servlets/WebdavServlet.java
Author: markt
Date: Wed Oct 13 22:08:49 2010
New Revision: 1022310
URL: http://svn.apache.org/viewvc?rev=1022310&view=rev
Log:
Vote
Modified:
tomcat/tc6.0.x/trunk/STATUS.txt
Modified: tomcat/tc6.0.x/trunk/STATUS.txt
URL:
http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=10223
Author: kkolinko
Date: Wed Oct 13 22:41:45 2010
New Revision: 1022315
URL: http://svn.apache.org/viewvc?rev=1022315&view=rev
Log:
Followup to r1022117
Remove unused import.
CTR
Modified:
tomcat/tc6.0.x/trunk/java/org/apache/catalina/core/ApplicationContext.java
Modified:
tomcat/tc6.0.x/trun
2010/10/13 :
> Author: markt
> Date: Wed Oct 13 14:41:57 2010
> New Revision: 1022117
>
> URL: http://svn.apache.org/viewvc?rev=1022117&view=rev
> Log:
> Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=49987
> Thread safety issue with population of servlet context initialisation
> paramete
Author: kkolinko
Date: Wed Oct 13 23:25:47 2010
New Revision: 1022323
URL: http://svn.apache.org/viewvc?rev=1022323&view=rev
Log:
Followup to r1022303
I think that releasing the socket should be done before passing it away to a
poller.
Modified:
tomcat/trunk/java/org/apache/coyote/http11/Htt
Hi!
Looking at the Http11NioProtocol.Http11ConnectionHandler.release(NioChannel
socket) method in Http11NioProtocol.java, it looks for me that like
that method does in all other places before any call to
"recycledProcessors.offer(result);" there should be
- a call to connections.remove(socket)
Author: kkolinko
Date: Thu Oct 14 00:23:57 2010
New Revision: 1022328
URL: http://svn.apache.org/viewvc?rev=1022328&view=rev
Log:
vote
Modified:
tomcat/tc6.0.x/trunk/STATUS.txt
Modified: tomcat/tc6.0.x/trunk/STATUS.txt
URL:
http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=10
On 14 October 2010 00:05, Konstantin Kolinko wrote:
> 2010/10/13 :
>> Author: markt
>> Date: Wed Oct 13 14:41:57 2010
>> New Revision: 1022117
>>
>> URL: http://svn.apache.org/viewvc?rev=1022117&view=rev
>> Log:
>> Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=49987
>> Thread safety issu
Dear Wiki user,
You have subscribed to a wiki page or wiki category on "Tomcat Wiki" for change
notification.
The "TomcatAtApacheConNA2010" page has been changed by JeanFredericClere.
http://wiki.apache.org/tomcat/TomcatAtApacheConNA2010?action=diff&rev1=1&rev2=2
---
Dear Wiki user,
You have subscribed to a wiki page or wiki category on "Tomcat Wiki" for change
notification.
The "TomcatAtApacheConNA2010" page has been changed by JeanFredericClere.
http://wiki.apache.org/tomcat/TomcatAtApacheConNA2010?action=diff&rev1=2&rev2=3
---
Author: jfclere
Date: Thu Oct 14 06:10:39 2010
New Revision: 1022385
URL: http://svn.apache.org/viewvc?rev=1022385&view=rev
Log:
Add the meetup entry.
Modified:
tomcat/site/trunk/docs/index.html
tomcat/site/trunk/xdocs/index.xml
Modified: tomcat/site/trunk/docs/index.html
URL:
http://sv
2010/10/14 sebb :
> On 14 October 2010 00:05, Konstantin Kolinko wrote:
>> Re: sebb:
>> 2010/10/13 sebb :
- private Map parameters = null;
+ private Map parameters =
+ new ConcurrentHashMap();
>>>
>>> This should be final, surely?
>>>
>>
>> There are a lot of non-final
59 matches
Mail list logo
