DO NOT REPLY [Bug 49985] Lazy initialization without any synchronization - data race in AstInteger, AstFloatingPoint, AstString

2010-10-01 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=49985 Sergey Vorobyev changed: What|Removed |Added Status|RESOLVED|REOPENED Resolution|INVA

DO NOT REPLY [Bug 49667] JdbcLeakPrevention class can register unregistered JCBC Driver

2010-10-01 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=49667 Arjen Knibbe changed: What|Removed |Added Status|RESOLVED|REOPENED Resolution|WORKSFO

svn commit: r1003461 - in /tomcat/trunk: java/org/apache/coyote/http11/filters/ChunkedInputFilter.java test/org/apache/coyote/http11/filters/ test/org/apache/coyote/http11/filters/TestChunkedInputFilt

2010-10-01 Thread markt
Author: markt Date: Fri Oct 1 10:21:58 2010 New Revision: 1003461 URL: http://svn.apache.org/viewvc?rev=1003461&view=rev Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=49860 Add support for trailing headers Added: tomcat/trunk/test/org/apache/coyote/http11/filters/ tomcat/t

DO NOT REPLY [Bug 50035] New: StandardContext.getDocBase() returns incorrect values after the context with antiResourceLocking="true" failed to start

2010-10-01 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=50035 Summary: StandardContext.getDocBase() returns incorrect values after the context with antiResourceLocking="true" failed to start Product: Tomcat 6 Version: 6.0.26

DO NOT REPLY [Bug 50035] StandardContext.getDocBase() returns incorrect values after the context with antiResourceLocking="true" failed to start

2010-10-01 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=50035 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED Resolution|

svn commit: r1003468 - /tomcat/tc6.0.x/trunk/STATUS.txt

2010-10-01 Thread markt
Author: markt Date: Fri Oct 1 10:36:53 2010 New Revision: 1003468 URL: http://svn.apache.org/viewvc?rev=1003468&view=rev Log: Proposal Modified: tomcat/tc6.0.x/trunk/STATUS.txt Modified: tomcat/tc6.0.x/trunk/STATUS.txt URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=1

DO NOT REPLY [Bug 49667] JdbcLeakPrevention class can register unregistered JCBC Driver

2010-10-01 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=49667 --- Comment #6 from Mark Thomas 2010-10-01 06:47:44 EDT --- Thanks for the sample apps. I can now reproduce this. Looking at a fix now... -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are rec

svn commit: r1003481 - in /tomcat/trunk: java/org/apache/catalina/loader/JdbcLeakPrevention.java webapps/docs/changelog.xml

2010-10-01 Thread markt
Author: markt Date: Fri Oct 1 11:10:51 2010 New Revision: 1003481 URL: http://svn.apache.org/viewvc?rev=1003481&view=rev Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=49667 Ensure JDBC leak prevention code doesn't trigger the very memory leak it is meant to be fixing. Modified:

svn commit: r1003483 - /tomcat/tc6.0.x/trunk/STATUS.txt

2010-10-01 Thread markt
Author: markt Date: Fri Oct 1 11:13:02 2010 New Revision: 1003483 URL: http://svn.apache.org/viewvc?rev=1003483&view=rev Log: Proposal Modified: tomcat/tc6.0.x/trunk/STATUS.txt Modified: tomcat/tc6.0.x/trunk/STATUS.txt URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=1

DO NOT REPLY [Bug 49667] JdbcLeakPrevention class can register unregistered JCBC Driver

2010-10-01 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=49667 Mark Thomas changed: What|Removed |Added Component|Catalina|Catalina Version|7.0.0

svn commit: r1003485 - /tomcat/trunk/java/org/apache/catalina/mbeans/JmxRemoteLifecycleListener.java

2010-10-01 Thread markt
Author: markt Date: Fri Oct 1 11:15:56 2010 New Revision: 1003485 URL: http://svn.apache.org/viewvc?rev=1003485&view=rev Log: Fix Eclipse warnings Modified: tomcat/trunk/java/org/apache/catalina/mbeans/JmxRemoteLifecycleListener.java Modified: tomcat/trunk/java/org/apache/catalina/mbeans/J

DO NOT REPLY [Bug 49667] JdbcLeakPrevention class can register unregistered JCBC Driver

2010-10-01 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=49667 --- Comment #8 from Arjen Knibbe 2010-10-01 07:16:52 EDT --- That was a quick fix Thomas! Thanks a lot. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: ---

svn commit: r1003488 - in /tomcat/trunk: java/org/apache/catalina/mbeans/JmxRemoteLifecycleListener.java webapps/docs/changelog.xml

2010-10-01 Thread markt
Author: markt Date: Fri Oct 1 11:37:05 2010 New Revision: 1003488 URL: http://svn.apache.org/viewvc?rev=1003488&view=rev Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=49861 Don't use commas when logging RMI port values Modified: tomcat/trunk/java/org/apache/catalina/mbeans/JmxR

svn commit: r1003489 - /tomcat/tc6.0.x/trunk/STATUS.txt

2010-10-01 Thread markt
Author: markt Date: Fri Oct 1 11:38:25 2010 New Revision: 1003489 URL: http://svn.apache.org/viewvc?rev=1003489&view=rev Log: Proposal Modified: tomcat/tc6.0.x/trunk/STATUS.txt Modified: tomcat/tc6.0.x/trunk/STATUS.txt URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=1

DO NOT REPLY [Bug 49861] Log format of RMI ports can be improved, remove ","

2010-10-01 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=49861 --- Comment #1 from Mark Thomas 2010-10-01 07:38:22 EDT --- Fixed in trunk and will be included in 7.0.3 onwards. Proposed for 6.0.x -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receivi

DO NOT REPLY [Bug 49985] Lazy initialization without any synchronization - data race in AstInteger, AstFloatingPoint, AstString

2010-10-01 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=49985 --- Comment #3 from Sebb 2010-10-01 07:56:05 EDT --- AIUI making "number" volatile would prevent the re-ordering that can result in the object reference being set up before construction is complete. Yes? -- Configure bugmail: https://issu

DO NOT REPLY [Bug 49985] Lazy initialization without any synchronization - data race in AstInteger, AstFloatingPoint, AstString

2010-10-01 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=49985 --- Comment #4 from Sergey Vorobyev 2010-10-01 08:07:19 EDT --- (In reply to comment #3) > AIUI making "number" volatile would prevent the re-ordering that can result in > the object reference being set up before construction is complete.

DO NOT REPLY [Bug 49985] Lazy initialization without any synchronization - data race in AstInteger, AstFloatingPoint, AstString

2010-10-01 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=49985 --- Comment #5 from Mark Thomas 2010-10-01 08:15:36 EDT --- I've yet to be convinced that there is an real issue here. I don't see any multi-threaded code paths into instances of those classes. If we change anything (on the basis there mig

DO NOT REPLY [Bug 49985] Lazy initialization without any synchronization - data race in AstInteger, AstFloatingPoint, AstString

2010-10-01 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=49985 --- Comment #6 from Sergey Vorobyev 2010-10-01 08:28:06 EDT --- Lock at this stack-traces to see how this method can be on invoked from a number of threads: (I'm using dacapo tomcat benchmark) AstInteger: Thread 22 #0 org/apache/

DO NOT REPLY [Bug 49985] Lazy initialization without any synchronization - data race in AstInteger, AstFloatingPoint, AstString

2010-10-01 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=49985 --- Comment #7 from Chuck Caldarale 2010-10-01 09:25:13 EDT --- (In reply to comment #6) > Lock at this stack-traces to see how this method can be on invoked from a > number of threads: But is each thread in the pair using the same instan

DO NOT REPLY [Bug 49985] Lazy initialization without any synchronization - data race in AstInteger, AstFloatingPoint, AstString

2010-10-01 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=49985 --- Comment #8 from Sergey Vorobyev 2010-10-01 09:34:45 EDT --- (In reply to comment #7) > (In reply to comment #6) > > Lock at this stack-traces to see how this method can be on invoked from a > > number of threads: > > But is each threa

DO NOT REPLY [Bug 50037] New: Tomcat embedded is not using Juli as logging system

2010-10-01 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=50037 Summary: Tomcat embedded is not using Juli as logging system Product: Tomcat 7 Version: unspecified Platform: PC Status: NEW Severity: normal Priority: P2 Co

DO NOT REPLY [Bug 49985] Lazy initialization without any synchronization - data race in AstInteger, AstFloatingPoint, AstString

2010-10-01 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=49985 --- Comment #9 from Remy Maucherat 2010-10-01 09:51:41 EDT --- Really a pity some attention has been paid to the drones during Tomcat 7 development, I knew it would just attract more of them :) -- Configure bugmail: https://issues.apache.

Re: svn commit: r1002359 - /tomcat/trunk/bin/catalina.sh

2010-10-01 Thread Rainer Jung
Sorry, shell scripting once more, recent changes break the script on Solaris. Details below. On 28.09.2010 23:20, ma...@apache.org wrote: Author: markt Date: Tue Sep 28 21:20:06 2010 New Revision: 1002359 URL: http://svn.apache.org/viewvc?rev=1002359&view=rev Log: Respond to mturk's review. Ma

DO NOT REPLY [Bug 49890] Nio Selector issue on linux platform

2010-10-01 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=49890 --- Comment #1 from Mark Thomas 2010-10-01 10:25:01 EDT --- I've just spent a couple of hours hammering a Linux box with JMeter and have been unable to reproduce this. From reading the various links it looks like the latest JVM + latest Lin

DO NOT REPLY [Bug 50037] Tomcat embedded is not using Juli as logging system

2010-10-01 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=50037 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED Resolution|

DO NOT REPLY [Bug 50037] Tomcat embedded is not using Juli as logging system

2010-10-01 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=50037 --- Comment #2 from David Calavera 2010-10-01 10:33:09 EDT --- Sorry I meant util.logging the methods silence and setSilent use it. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receivi

svn commit: r1003548 - /tomcat/trunk/java/org/apache/tomcat/util/net/NioEndpoint.java

2010-10-01 Thread markt
Author: markt Date: Fri Oct 1 14:36:31 2010 New Revision: 1003548 URL: http://svn.apache.org/viewvc?rev=1003548&view=rev Log: getKeyCount() didn't do anything due to local variable definition Modified: tomcat/trunk/java/org/apache/tomcat/util/net/NioEndpoint.java Modified: tomcat/trunk/java

DO NOT REPLY [Bug 50037] Tomcat embedded is not using Juli as logging system

2010-10-01 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=50037 --- Comment #3 from Chuck Caldarale 2010-10-01 10:50:13 EDT --- (In reply to comment #0) > Tomcat.java class uses commons logging directly rather than using Juli. This > causes you have to use two logging configurations. > > Could you ple

svn commit: r1003550 - in /tomcat/trunk: java/org/apache/tomcat/util/net/NioEndpoint.java java/org/apache/tomcat/util/net/res/LocalStrings.properties webapps/docs/changelog.xml

2010-10-01 Thread markt
Author: markt Date: Fri Oct 1 14:54:53 2010 New Revision: 1003550 URL: http://svn.apache.org/viewvc?rev=1003550&view=rev Log: https://issues.apache.org/bugzilla/show_bug.cgi?id=49890 Detect when the JVM bug occurs and log an error asking for more information. Modified: tomcat/trunk/java/org/

svn commit: r1003552 - /tomcat/trunk/java/org/apache/tomcat/util/net/NioEndpoint.java

2010-10-01 Thread markt
Author: markt Date: Fri Oct 1 14:58:43 2010 New Revision: 1003552 URL: http://svn.apache.org/viewvc?rev=1003552&view=rev Log: Add a TODO Modified: tomcat/trunk/java/org/apache/tomcat/util/net/NioEndpoint.java Modified: tomcat/trunk/java/org/apache/tomcat/util/net/NioEndpoint.java URL: http

DO NOT REPLY [Bug 49890] Nio Selector issue on linux platform

2010-10-01 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=49890 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED Resolution|

svn commit: r1003556 - /tomcat/trunk/bin/catalina.sh

2010-10-01 Thread markt
Author: markt Date: Fri Oct 1 15:08:23 2010 New Revision: 1003556 URL: http://svn.apache.org/viewvc?rev=1003556&view=rev Log: -e doesn't exist on Solaris Modified: tomcat/trunk/bin/catalina.sh Modified: tomcat/trunk/bin/catalina.sh URL: http://svn.apache.org/viewvc/tomcat/trunk/bin/catalin

svn commit: r1003557 - /tomcat/tc6.0.x/trunk/STATUS.txt

2010-10-01 Thread markt
Author: markt Date: Fri Oct 1 15:09:25 2010 New Revision: 1003557 URL: http://svn.apache.org/viewvc?rev=1003557&view=rev Log: Proposal Modified: tomcat/tc6.0.x/trunk/STATUS.txt Modified: tomcat/tc6.0.x/trunk/STATUS.txt URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=1

svn commit: r1003572 - in /tomcat/trunk/java/org/apache/catalina/tribes: group/interceptors/MessageDispatch15Interceptor.java util/TcclThreadFactory.java

2010-10-01 Thread markt
Author: markt Date: Fri Oct 1 16:32:31 2010 New Revision: 1003572 URL: http://svn.apache.org/viewvc?rev=1003572&view=rev Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=49905 Prevent memory leak when using aysnc session replication Added: tomcat/trunk/java/org/apache/catalina/tri

svn commit: r1003573 - /tomcat/tc6.0.x/trunk/STATUS.txt

2010-10-01 Thread markt
Author: markt Date: Fri Oct 1 16:33:22 2010 New Revision: 1003573 URL: http://svn.apache.org/viewvc?rev=1003573&view=rev Log: Proposal Modified: tomcat/tc6.0.x/trunk/STATUS.txt Modified: tomcat/tc6.0.x/trunk/STATUS.txt URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=1

svn commit: r1003574 - /tomcat/trunk/webapps/docs/changelog.xml

2010-10-01 Thread markt
Author: markt Date: Fri Oct 1 16:34:37 2010 New Revision: 1003574 URL: http://svn.apache.org/viewvc?rev=1003574&view=rev Log: Update changelog Modified: tomcat/trunk/webapps/docs/changelog.xml Modified: tomcat/trunk/webapps/docs/changelog.xml URL: http://svn.apache.org/viewvc/tomcat/trunk/

DO NOT REPLY [Bug 49905] In cluster, when using DeltaManager memory leak can occur

2010-10-01 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=49905 --- Comment #1 from Mark Thomas 2010-10-01 12:35:02 EDT --- This has been fixed in trunk and will be included 7.0.3 onwards. I have proposed the same fix for 6.0.x. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?t

svn commit: r1003581 - in /tomcat/trunk: java/org/apache/catalina/core/StandardServer.java webapps/docs/changelog.xml

2010-10-01 Thread markt
Author: markt Date: Fri Oct 1 16:49:29 2010 New Revision: 1003581 URL: http://svn.apache.org/viewvc?rev=1003581&view=rev Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=49915 Make error more obvious, particularly when accessed via JConsole, if StandardServer.storeConfig() is called w

svn commit: r1003582 - /tomcat/tc6.0.x/trunk/STATUS.txt

2010-10-01 Thread markt
Author: markt Date: Fri Oct 1 16:50:28 2010 New Revision: 1003582 URL: http://svn.apache.org/viewvc?rev=1003582&view=rev Log: Proposal Modified: tomcat/tc6.0.x/trunk/STATUS.txt Modified: tomcat/tc6.0.x/trunk/STATUS.txt URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=1

DO NOT REPLY [Bug 49915] [Patch] o.a.c.c.StandardServer swallows error on storeConfig.

2010-10-01 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=49915 --- Comment #1 from Mark Thomas 2010-10-01 12:50:59 EDT --- Patch? What patch? :) Fixed in trunk and will be included in 7.0.3 onwards. Also proposed for 6.0.x -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=e

svn commit: r1003589 - in /tomcat/trunk: java/org/apache/catalina/ java/org/apache/catalina/core/ java/org/apache/catalina/deploy/ java/org/apache/catalina/startup/ java/org/apache/jasper/servlet/ web

2010-10-01 Thread markt
Author: markt Date: Fri Oct 1 17:29:03 2010 New Revision: 1003589 URL: http://svn.apache.org/viewvc?rev=1003589&view=rev Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=49916 Switch to using an initialisation parameter to pass JSP file information from Catalina to Jasper. This simpli

DO NOT REPLY [Bug 49916] use an init-param for jspFile on explicit jsp servlets

2010-10-01 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=49916 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED Resolution|

MBeans and credentials

2010-10-01 Thread Rainer Jung
Should we remove the following attributes from the respective mbeans? - "shutdown" from "Catalina:type=Server" - "keyPass" from "Catalina:type=ProtocolHandler,port=8080" - "password" from "User" - "connectionPassword" from "JDBCRealm" - "password" for a DataSource (?) Or at least allow to drop t

DO NOT REPLY [Bug 49915] [Patch] o.a.c.c.StandardServer swallows error on storeConfig.

2010-10-01 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=49915 Wesley changed: What|Removed |Added Platform|PC |All OS/Version|Windows Vista