On 24/07/2010 04:05, Bill Barker wrote:
I'm -1 (vote, not veto) on having validate be a dependency for
compile. Historically, Tomcat has been very lenient about what is
required just to build the project, and I can't see the reason to
force checkstyle just to be able to build. Mostly my concern i
Author: markt
Date: Sat Jul 24 08:37:48 2010
New Revision: 978826
URL: http://svn.apache.org/viewvc?rev=978826&view=rev
Log:
Update to require Ant 1.8.x+ to take advantage of the new property expansion
for if/unless and then use it control if the validate code is executed.
Modified:
tomcat/t
Modified: tomcat/trunk/java/org/apache/catalina/tribes/util/ExecutorFactory.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/tribes/util/ExecutorFactory.java?rev=978840&r1=978839&r2=978840&view=diff
===
Author: markt
Date: Sat Jul 24 11:10:48 2010
New Revision: 978847
URL: http://svn.apache.org/viewvc?rev=978847&view=rev
Log:
Check the tests too.
Modified:
tomcat/trunk/build.xml
Modified: tomcat/trunk/build.xml
URL:
http://svn.apache.org/viewvc/tomcat/trunk/build.xml?rev=978847&r1=978846&r
Author: markt
Date: Sat Jul 24 12:25:40 2010
New Revision: 978862
URL: http://svn.apache.org/viewvc?rev=978862&view=rev
Log:
Ignore config for checkstyle Eclipse plugin
Modified:
tomcat/trunk/ (props changed)
Propchange: tomcat/trunk/
---
Modified: tomcat/trunk/java/org/apache/jasper/xmlparser/XMLEncodingDetector.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/jasper/xmlparser/XMLEncodingDetector.java?rev=978865&r1=978864&r2=978865&view=diff
===
Author: markt
Date: Sun Jul 25 00:12:02 2010
New Revision: 978952
URL: http://svn.apache.org/viewvc?rev=978952&view=rev
Log:
Add additional tests known to pass - list provided by Marc Guillemot.
Modified:
tomcat/trunk/checkstyle.xml
Modified: tomcat/trunk/checkstyle.xml
URL:
http://svn.apac
