Re: svn commit: r962531 [2/2] - in /tomcat/jk/trunk: native/apache-1.3/ native/apache-2.0/ native/iis/ native/iis/pcre/ native/jni/ native/netscape/ native/nt_service/ xdocs/miscellaneous/

2010-07-10 Thread Rainer Jung
On 09.07.2010 17:14, Mladen Turk wrote: On 07/09/2010 03:56 PM, rj...@apache.org wrote: Modified: tomcat/jk/trunk/xdocs/miscellaneous/changelog.xml URL: http://svn.apache.org/viewvc/tomcat/jk/trunk/xdocs/miscellaneous/changelog.xml?rev=962531&r1=962530&r2=962531&view=diff =

svn commit: r962825 [2/2] - in /tomcat/jk/trunk: native/apache-1.3/ native/apache-2.0/ native/iis/ native/iis/pcre/ native/jni/ native/netscape/ native/nt_service/ xdocs/miscellaneous/

2010-07-10 Thread rjung
Modified: tomcat/jk/trunk/native/jni/jni_connect.dsp URL: http://svn.apache.org/viewvc/tomcat/jk/trunk/native/jni/jni_connect.dsp?rev=962825&r1=962824&r2=962825&view=diff == --- tomcat/jk/trunk/native/jni/jni_connect.dsp (

DO NOT REPLY [Bug 48891] Missing EOL-style settings in tomcat/jk/trunk

2010-07-10 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=48891 Rainer Jung changed: What|Removed |Added Status|RESOLVED|REOPENED Resolution|FIXED

svn commit: r962855 - /tomcat/tc5.5.x/trunk/container/webapps/docs/changelog.xml

2010-07-10 Thread kkolinko
Author: kkolinko Date: Sat Jul 10 15:05:58 2010 New Revision: 962855 URL: http://svn.apache.org/viewvc?rev=962855&view=rev Log: Add release date Modified: tomcat/tc5.5.x/trunk/container/webapps/docs/changelog.xml Modified: tomcat/tc5.5.x/trunk/container/webapps/docs/changelog.xml URL: http:

svn commit: r962856 - /tomcat/tc6.0.x/trunk/webapps/docs/changelog.xml

2010-07-10 Thread kkolinko
Author: kkolinko Date: Sat Jul 10 15:08:09 2010 New Revision: 962856 URL: http://svn.apache.org/viewvc?rev=962856&view=rev Log: Add release date Modified: tomcat/tc6.0.x/trunk/webapps/docs/changelog.xml Modified: tomcat/tc6.0.x/trunk/webapps/docs/changelog.xml URL: http://svn.apache.org/vie

svn commit: r962857 - /tomcat/trunk/webapps/docs/changelog.xml

2010-07-10 Thread kkolinko
Author: kkolinko Date: Sat Jul 10 15:12:24 2010 New Revision: 962857 URL: http://svn.apache.org/viewvc?rev=962857&view=rev Log: Add release date Modified: tomcat/trunk/webapps/docs/changelog.xml Modified: tomcat/trunk/webapps/docs/changelog.xml URL: http://svn.apache.org/viewvc/tomcat/trunk

Re: svn commit: r962531 [2/2] - in /tomcat/jk/trunk: native/apache-1.3/ native/apache-2.0/ native/iis/ native/iis/pcre/ native/jni/ native/netscape/ native/nt_service/ xdocs/miscellaneous/

2010-07-10 Thread Mladen Turk
On 07/10/2010 01:56 PM, Rainer Jung wrote: On 09.07.2010 17:14, Mladen Turk wrote: Nevertheless I needed to do conversions a coupe of times myself and was always annoyed. Yes partially because I had the tarball at hand not the zip, partially because my Cgwin subversion used non-Windows line ends

svn commit: r962864 - /tomcat/trunk/webapps/docs/logging.xml

2010-07-10 Thread markt
Author: markt Date: Sat Jul 10 16:05:52 2010 New Revision: 962864 URL: http://svn.apache.org/viewvc?rev=962864&view=rev Log: Align docs with reality Modified: tomcat/trunk/webapps/docs/logging.xml Modified: tomcat/trunk/webapps/docs/logging.xml URL: http://svn.apache.org/viewvc/tomcat/trunk

svn commit: r962865 - in /tomcat/trunk: java/org/apache/catalina/filters/CsrfPreventionFilter.java webapps/docs/changelog.xml

2010-07-10 Thread markt
Author: markt Date: Sat Jul 10 16:10:33 2010 New Revision: 962865 URL: http://svn.apache.org/viewvc?rev=962865&view=rev Log: Improve CSRF protection filter by using SecureRandom rather than Random Modified: tomcat/trunk/java/org/apache/catalina/filters/CsrfPreventionFilter.java tomcat/tru

svn commit: r962871 - /tomcat/trunk/test/org/apache/coyote/http11/TestAbstractHttp11Processor.java

2010-07-10 Thread markt
Author: markt Date: Sat Jul 10 16:14:42 2010 New Revision: 962871 URL: http://svn.apache.org/viewvc?rev=962871&view=rev Log: Add CVE-2010-2227 test case Added: tomcat/trunk/test/org/apache/coyote/http11/TestAbstractHttp11Processor.java (with props) Added: tomcat/trunk/test/org/apache/coy

svn commit: r962872 - /tomcat/trunk/java/org/apache/catalina/filters/CsrfPreventionFilter.java

2010-07-10 Thread markt
Author: markt Date: Sat Jul 10 16:19:26 2010 New Revision: 962872 URL: http://svn.apache.org/viewvc?rev=962872&view=rev Log: Align implementation with docs. nonceCacheSize should be configurable Modified: tomcat/trunk/java/org/apache/catalina/filters/CsrfPreventionFilter.java Modified: tomc

svn commit: r962881 - in /tomcat/trunk: java/org/apache/catalina/filters/CsrfPreventionFilter.java java/org/apache/catalina/filters/LocalStrings.properties webapps/docs/changelog.xml webapps/docs/conf

2010-07-10 Thread markt
Author: markt Date: Sat Jul 10 16:41:59 2010 New Revision: 962881 URL: http://svn.apache.org/viewvc?rev=962881&view=rev Log: Make the random source used for nonces user configurable Modified: tomcat/trunk/java/org/apache/catalina/filters/CsrfPreventionFilter.java tomcat/trunk/java/org/apa

svn commit: r962883 - /tomcat/tc6.0.x/trunk/STATUS.txt

2010-07-10 Thread markt
Author: markt Date: Sat Jul 10 16:43:16 2010 New Revision: 962883 URL: http://svn.apache.org/viewvc?rev=962883&view=rev Log: Update proposal. Remove pero's vote due to size of changes Modified: tomcat/tc6.0.x/trunk/STATUS.txt Modified: tomcat/tc6.0.x/trunk/STATUS.txt URL: http://svn.apache.

DO NOT REPLY [Bug 49570] The CompressionFilter example should support HTTP proxies to cache gzipped content better by sending Vary: Accept-Encoding header

2010-07-10 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=49570 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED Resolution|

svn commit: r962889 - in /tomcat/trunk/webapps: docs/changelog.xml examples/WEB-INF/classes/compressionFilters/CompressionResponseStream.java

2010-07-10 Thread markt
Author: markt Date: Sat Jul 10 17:20:41 2010 New Revision: 962889 URL: http://svn.apache.org/viewvc?rev=962889&view=rev Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=49570 When using the example compression filter, set the Vary header on compressed responses Modified: tomcat/tr

Re: svn commit: r962881 - in /tomcat/trunk: java/org/apache/catalina/filters/CsrfPreventionFilter.java java/org/apache/catalina/filters/LocalStrings.properties webapps/docs/changelog.xml webapps/doc

2010-07-10 Thread Konstantin Kolinko
2010/7/10 : > Author: markt > Date: Sat Jul 10 16:41:59 2010 > New Revision: 962881 > > --- tomcat/trunk/webapps/docs/config/filter.xml (original) > +++ tomcat/trunk/webapps/docs/config/filter.xml Sat Jul 10 16:41:59 2010 > @@ -135,6 +135,12 @@ >         value of 5 will be used. >       > > +  

Re: svn commit: r962881 - in /tomcat/trunk: java/org/apache/catalina/filters/CsrfPreventionFilter.java java/org/apache/catalina/filters/LocalStrings.properties webapps/docs/changelog.xml webapps/doc

2010-07-10 Thread Mark Thomas
On 10/07/2010 19:31, Konstantin Kolinko wrote: > 2010/7/10 : >> Author: markt >> Date: Sat Jul 10 16:41:59 2010 >> New Revision: 962881 >> > >> --- tomcat/trunk/webapps/docs/config/filter.xml (original) >> +++ tomcat/trunk/webapps/docs/config/filter.xml Sat Jul 10 16:41:59 2010 >> @@ -135,6 +135,

svn commit: r962900 - /tomcat/trunk/webapps/docs/config/filter.xml

2010-07-10 Thread markt
Author: markt Date: Sat Jul 10 18:33:14 2010 New Revision: 962900 URL: http://svn.apache.org/viewvc?rev=962900&view=rev Log: Typo Modified: tomcat/trunk/webapps/docs/config/filter.xml Modified: tomcat/trunk/webapps/docs/config/filter.xml URL: http://svn.apache.org/viewvc/tomcat/trunk/webapp

svn commit: r962901 - /tomcat/tc6.0.x/trunk/STATUS.txt

2010-07-10 Thread markt
Author: markt Date: Sat Jul 10 18:37:23 2010 New Revision: 962901 URL: http://svn.apache.org/viewvc?rev=962901&view=rev Log: Add fix for typo Modified: tomcat/tc6.0.x/trunk/STATUS.txt Modified: tomcat/tc6.0.x/trunk/STATUS.txt URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt

DO NOT REPLY [Bug 48861] Files without AL headers

2010-07-10 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=48861 --- Comment #2 from dbz 2010-07-10 16:42:07 EDT --- Created an attachment (id=25747) --> (https://issues.apache.org/bugzilla/attachment.cgi?id=25747) A patch which add the AL header to several classes of the tomcat-lite module This patch

Re: [ANN] Apache Tomcat 5.5.30 released

2010-07-10 Thread Konstantin Kolinko
2010/7/10 Jim Jagielski : > The Apache Tomcat Team announces the immediate availability of Apache > Tomcat 5.5.30 stable. > It seems that this announcement was not sent to the following list: annou...@apache.org Archive: http://mail-archives.apache.org/mod_mbox/www-announce/201007.mbox/browser

svn commit: r962917 - in /tomcat/trunk: java/org/apache/catalina/filters/ test/org/apache/catalina/filters/ webapps/docs/ webapps/docs/config/

2010-07-10 Thread markt
Author: markt Date: Sat Jul 10 21:13:23 2010 New Revision: 962917 URL: http://svn.apache.org/viewvc?rev=962917&view=rev Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=49478 Add support for user specified character sets to the AddDefaultCharsetFilter. Based on a patch by Felix Schumac

DO NOT REPLY [Bug 49478] Add encoding parameter to AddDefaultCharSetFilter

2010-07-10 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=49478 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED Resolution|

svn commit: r962919 - /tomcat/trunk/java/org/apache/tomcat/util/res/StringManager.java

2010-07-10 Thread markt
Author: markt Date: Sat Jul 10 21:22:12 2010 New Revision: 962919 URL: http://svn.apache.org/viewvc?rev=962919&view=rev Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=49442 Trivial code clean-up. No functional change. Based on a patch provided by Sebb. Modified: tomcat/trunk/java

DO NOT REPLY [Bug 49567] when starting a new thread from a startAsync Runnable, an infinite amount of doPosts is generated

2010-07-10 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=49567 --- Comment #1 from Mark Thomas 2010-07-10 17:26:55 EDT --- Looks like you attached the wrong test case to this report. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail b

DO NOT REPLY [Bug 49442] Make StringManager fields final

2010-07-10 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=49442 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED Resolution|

svn commit: r962921 - /tomcat/trunk/test/org/apache/catalina/tribes/demos/EchoRpcTest.java

2010-07-10 Thread markt
Author: markt Date: Sat Jul 10 21:33:16 2010 New Revision: 962921 URL: http://svn.apache.org/viewvc?rev=962921&view=rev Log: Trivial cleanup no functional change Modified: tomcat/trunk/test/org/apache/catalina/tribes/demos/EchoRpcTest.java Modified: tomcat/trunk/test/org/apache/catalina/trib

svn commit: r962922 - in /tomcat/trunk/java/javax/mail: Authenticator.java PasswordAuthentication.java Session.java internet/InternetAddress.java internet/MimeMessage.java internet/MimePart.java inter

2010-07-10 Thread markt
Author: markt Date: Sat Jul 10 21:39:58 2010 New Revision: 962922 URL: http://svn.apache.org/viewvc?rev=962922&view=rev Log: javax.mail is a dummy implementation - mark it as such to stop Eclipse complaining about empty methods and unused parameters Modified: tomcat/trunk/java/javax/mail/Aut

svn commit: r962923 - in /tomcat/trunk/java/javax/annotation: PostConstruct.java PreDestroy.java security/DenyAll.java security/PermitAll.java

2010-07-10 Thread markt
Author: markt Date: Sat Jul 10 21:43:02 2010 New Revision: 962923 URL: http://svn.apache.org/viewvc?rev=962923&view=rev Log: Eclipse warnings for annotations Modified: tomcat/trunk/java/javax/annotation/PostConstruct.java tomcat/trunk/java/javax/annotation/PreDestroy.java tomcat/trunk

DO NOT REPLY [Bug 49268] Use checkstyle to enforce common code style

2010-07-10 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=49268 --- Comment #2 from Konstantin Kolinko 2010-07-10 20:23:02 EDT --- Thank you for the effort. I won't comment on the project policies - that is to be discussed and decided on d...@. Several comments on the patch itself: 1) Checkstyle vers

Re: [VOTE] Add Checkstyle ruleset and make code cleanups!

2010-07-10 Thread Konstantin Kolinko
Adjusted the thread subject. Was: Vote: Add Checkstyle roleset and make code cleanups! 2010/7/8 Peter Roßbach : > Hi, > > after the discussion about code style > (http://tomcat.markmail.org/thread/2c7lkzmpcuxqpgjj), I think that we must > vote for this fix: > > https://issues.apache.org/bugzilla/

Re: svn commit: r961948 - in /tomcat/trunk: java/org/apache/jasper/compiler/ELFunctionMapper.java webapps/docs/changelog.xml

2010-07-10 Thread Konstantin Kolinko
2010/7/9 : > Author: markt > Date: Thu Jul  8 21:29:12 2010 > New Revision: 961948 > > URL: http://svn.apache.org/viewvc?rev=961948&view=rev > Log: > Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=49555 > Correctly handle tag libraries that use functions defined in static inner > classes

Re: [g...@vmgump]: Project tomcat-taglibs-standard (in module tomcat-taglibs) failed

2010-07-10 Thread Stefan Bodewig
On 2010-07-09, Jeremy Boynes wrote: > The cactifywar goal is attached to package so that may not help. I've > reattached it to pre-integration-test as that seems more logical > (assuming it runs before jetty run-war). At least it has fixed Gump - both for the package and install goals. Neither of

DO NOT REPLY [Bug 27717] very slow in JSTL 1.1

2010-07-10 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=27717 --- Comment #19 from Jeremy Boynes 2010-07-11 01:18:30 EDT --- Created an attachment (id=25749) --> (https://issues.apache.org/bugzilla/attachment.cgi?id=25749) Update ExprSupport to use JAXP -- Configure bugmail: https://issues.apache.

DO NOT REPLY [Bug 27717] very slow in JSTL 1.1

2010-07-10 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=27717 --- Comment #20 from Jeremy Boynes 2010-07-11 01:19:20 EDT --- Created an attachment (id=25750) --> (https://issues.apache.org/bugzilla/attachment.cgi?id=25750) Supporting variable resolver -- Configure bugmail: https://issues.apache.or

DO NOT REPLY [Bug 27717] very slow in JSTL 1.1

2010-07-10 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=27717 Jeremy Boynes changed: What|Removed |Added Attachment #25749|application/octet-stream|text/plain mime type|

Re: [taglibs] XPath support

2010-07-10 Thread Jeremy Boynes
I've added two attachments to bug 27717 https://issues.apache.org/bugzilla/show_bug.cgi?id=27717 that show ExprSupport updated to use the JAXP XPath API to precompile expressions and an implementation of an XPathVariableResolver that handles the JSTL variable resolution scheme. There are ver

DO NOT REPLY [Bug 27717] very slow in JSTL 1.1

2010-07-10 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=27717 Jeremy Boynes changed: What|Removed |Added Attachment #25750|application/octet-stream|text/plain mime type|