I work on a patch to remove them and add JavaDoc.
What do you think of adding JSR-303 javax.validation annotations like NotNull?
Those are part of JavaEE 6 so are guaranteed to be available there but would
require a dependency for a JavaEE5 environment. My thought would be not to use
them yet.
ma...@apache.org wrote:
Author: markt
Date: Fri Jul 2 21:13:25 2010
New Revision: 960104
URL: http://svn.apache.org/viewvc?rev=960104&view=rev
Log:
A few more FindBugs issues
> ...
why don't you integrate checkstyle (and FindBugs) in the build? It's the
only safe way to ensure quality and to
https://issues.apache.org/bugzilla/show_bug.cgi?id=49528
--- Comment #5 from Pieter Libin 2010-07-05 03:55:31 EDT ---
(In reply to comment #1)
> Please could you confirm that the test case is provided under the terms of
> section 5 of the Apache License, v2 and that you have the right to provide
https://issues.apache.org/bugzilla/show_bug.cgi?id=49528
--- Comment #6 from Pieter Libin 2010-07-05 03:56:31 EDT ---
(In reply to comment #4)
> I have reverted the original fix and applied a new fix that fixes the issue
> described here and still passes the Servlet TCK.
Thanks for the quick fix
https://issues.apache.org/bugzilla/show_bug.cgi?id=47692
--- Comment #5 from ganggaroo 2010-07-05 04:03:29 EDT ---
Hi , I am a newbee on AIX...I found this article after hard googling.
I think my trouble is somewhat related so I want to hear your advices..
I want apache-tomcat server on AIX 6.1
On 05/07/2010 09:27, Marc Guillemot wrote:
ma...@apache.org wrote:
Author: markt
Date: Fri Jul 2 21:13:25 2010
New Revision: 960104
URL: http://svn.apache.org/viewvc?rev=960104&view=rev
Log:
A few more FindBugs issues
> ...
why don't you integrate checkstyle (and FindBugs) in the build?
Th
https://issues.apache.org/bugzilla/show_bug.cgi?id=47692
--- Comment #6 from Rainer Jung 2010-07-05 06:19:34
EDT ---
(In reply to comment #5)
> Hi , I am a newbee on AIX...I found this article after hard googling.
> I think my trouble is somewhat related so I want to hear your advices..
> I want
https://issues.apache.org/bugzilla/show_bug.cgi?id=49550
Summary: [PATCH] Response class fix isSpace (deprecated) =>
isWhiteSpace
Product: Tomcat 7
Version: 7.0.0
Platform: PC
OS/Version: Windows XP
Status: NEW
https://issues.apache.org/bugzilla/show_bug.cgi?id=49551
Summary: When setting absolute path to default context.xml, in
ContextConfig.contextConfig() it cannot be found
Product: Tomcat 6
Version: 6.0.26
Platform: PC
OS/Version:
https://issues.apache.org/bugzilla/show_bug.cgi?id=49550
Mark Thomas changed:
What|Removed |Added
Status|NEW |RESOLVED
Resolution|
https://issues.apache.org/bugzilla/show_bug.cgi?id=49550
Sebb changed:
What|Removed |Added
Status|RESOLVED|REOPENED
Resolution|INVALID
https://issues.apache.org/bugzilla/show_bug.cgi?id=49550
Sebb changed:
What|Removed |Added
Attachment #25703|0 |1
is obsolete|
https://issues.apache.org/bugzilla/show_bug.cgi?id=49528
Pieter Libin changed:
What|Removed |Added
Status|RESOLVED|REOPENED
Resolution|FIXED
https://issues.apache.org/bugzilla/show_bug.cgi?id=49428
--- Comment #3 from Panagiotis Astithas 2010-07-05 11:13:54 EDT
---
(In reply to comment #2)
> Please run the litmus test suite with your patch. Whilst the current
> implementation has some failures (and patches for those would be welcome
https://issues.apache.org/bugzilla/show_bug.cgi?id=49428
--- Comment #4 from Mark Thomas 2010-07-05 12:27:53 EDT ---
The additional failures were in the lock tests. Test 6 failed first and that
triggered multiple additional failures.
--
Configure bugmail: https://issues.apache.org/bugzilla/user
https://issues.apache.org/bugzilla/show_bug.cgi?id=49528
--- Comment #8 from Mark Thomas 2010-07-05 12:48:17 EDT ---
Yep. The test only looked at the correctness of the return values present, it
didn't check all the expected return values were present. I have fixed the test
case and am looking at
To whom it may engage...
This is an automated request, but not an unsolicited one. For
more information please visit http://gump.apache.org/nagged.html,
and/or contact the folk at gene...@gump.apache.org.
Project tomcat-taglibs-standard has an issue affecting its community
integration.
https://issues.apache.org/bugzilla/show_bug.cgi?id=49554
Summary: Clean up Functions
Product: Taglibs
Version: 1.2.0
Platform: PC
Status: NEW
Severity: enhancement
Priority: P2
Component: Standard Taglib
As
https://issues.apache.org/bugzilla/show_bug.cgi?id=49554
--- Comment #1 from Jeremy Boynes 2010-07-05 16:01:53 EDT
---
Created an attachment (id=25711)
--> (https://issues.apache.org/bugzilla/attachment.cgi?id=25711)
Patch to clean up Functions
pom.xml also includes changes from attachment 256
Author: markt
Date: Mon Jul 5 20:51:21 2010
New Revision: 960692
URL: http://svn.apache.org/viewvc?rev=960692&view=rev
Log:
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=49528
Previous fix was incomplete. Improve test case and fix
TCK and test cases pass with this patch
Modified:
to
https://issues.apache.org/bugzilla/show_bug.cgi?id=49528
Mark Thomas changed:
What|Removed |Added
Status|REOPENED|RESOLVED
Resolution|
Author: markt
Date: Mon Jul 5 20:58:23 2010
New Revision: 960698
URL: http://svn.apache.org/viewvc?rev=960698&view=rev
Log:
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=49550
Trivial code clean up
Modified:
tomcat/trunk/java/org/apache/catalina/connector/Response.java
tomcat/tr
https://issues.apache.org/bugzilla/show_bug.cgi?id=49550
Mark Thomas changed:
What|Removed |Added
Status|REOPENED|RESOLVED
Resolution|
Author: markt
Date: Mon Jul 5 21:07:32 2010
New Revision: 960701
URL: http://svn.apache.org/viewvc?rev=960701&view=rev
Log:
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=49551
Allow default context.xml file to be specified using an absolute path.
Modified:
tomcat/trunk/java/org/apac
Author: markt
Date: Mon Jul 5 21:09:25 2010
New Revision: 960702
URL: http://svn.apache.org/viewvc?rev=960702&view=rev
Log:
Proposal
Modified:
tomcat/tc6.0.x/trunk/STATUS.txt
Modified: tomcat/tc6.0.x/trunk/STATUS.txt
URL:
http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=960
https://issues.apache.org/bugzilla/show_bug.cgi?id=49551
--- Comment #1 from Mark Thomas 2010-07-05 17:10:22 EDT ---
Thanks for the bug report. I have fixed in this in 7.0.x (it will be in 7.0.1
onwards) and proposed the fix for 6.0.x.
--
Configure bugmail: https://issues.apache.org/bugzilla/us
https://issues.apache.org/bugzilla/show_bug.cgi?id=49528
--- Comment #10 from Pieter Libin 2010-07-05 17:15:08 EDT ---
(In reply to comment #9)
> Sorry about that. Fixed in trunk. Will be in 7.0.1 onwards.
Thanks a lot for the quick response!
I'll retest from the trunk tomorrow morning.
--
Co
Author: markt
Date: Mon Jul 5 21:44:29 2010
New Revision: 960711
URL: http://svn.apache.org/viewvc?rev=960711&view=rev
Log:
Test case for https://issues.apache.org/bugzilla/show_bug.cgi?id=49217
Added:
tomcat/trunk/test/org/apache/el/parser/TesterBeanA.java (with props)
Modified:
tomca
Author: markt
Date: Mon Jul 5 21:45:26 2010
New Revision: 960712
URL: http://svn.apache.org/viewvc?rev=960712&view=rev
Log:
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=49217
Prevent use of Java keywords in identifiers
Added:
tomcat/trunk/java/org/apache/el/util/Validation.java (
Author: markt
Date: Mon Jul 5 21:46:31 2010
New Revision: 960713
URL: http://svn.apache.org/viewvc?rev=960713&view=rev
Log:
Proposal
Modified:
tomcat/tc6.0.x/trunk/STATUS.txt
Modified: tomcat/tc6.0.x/trunk/STATUS.txt
URL:
http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=960
https://issues.apache.org/bugzilla/show_bug.cgi?id=49217
--- Comment #2 from Mark Thomas 2010-07-05 17:47:39 EDT ---
Thanks for the report. This has been fixed in 7.0.x and will be in 7.0.1
onwards. It has also been proposed for 6.0.x
--
Configure bugmail: https://issues.apache.org/bugzilla/use
https://issues.apache.org/bugzilla/show_bug.cgi?id=28756
Mark Thomas changed:
What|Removed |Added
Status|NEW |RESOLVED
Resolution|
https://issues.apache.org/bugzilla/show_bug.cgi?id=25738
Mark Thomas changed:
What|Removed |Added
Status|NEW |RESOLVED
Resolution|
https://issues.apache.org/bugzilla/show_bug.cgi?id=49555
Summary: Custom Taglibs should support all parameters
Product: Tomcat 7
Version: unspecified
Platform: PC
OS/Version: Linux
Status: NEW
Severity: blocker
Prio
https://issues.apache.org/bugzilla/show_bug.cgi?id=49555
--- Comment #1 from james_cal...@yahoo.com 2010-07-05 18:30:00 EDT ---
I have an architecture that uses static inner classes. After about an hour of
trial and error and internet searches, I discovered that I can not use a Static
inner class
https://issues.apache.org/bugzilla/show_bug.cgi?id=49556
Summary: the proc.create function used args as env to get the
element count,
Product: Tomcat Native
Version: 1.1.19
Platform: PC
OS/Version: Windows XP
Status
https://issues.apache.org/bugzilla/show_bug.cgi?id=49557
Summary: index erro in the loop to get the env info in the
proc.create function
Product: Tomcat Native
Version: 1.1.19
Platform: PC
OS/Version: Windows XP
Sta
https://issues.apache.org/bugzilla/show_bug.cgi?id=49555
--- Comment #2 from Mark Thomas 2010-07-06 01:28:32 EDT ---
It is likely to be Tomcat 6 that is being used rather than Tomcat 7 but any fix
in Tomcat 7 will get back-ported to Tomcat 6 so lets not worry too much about
that.
I think I under
Author: bayard
Date: Tue Jul 6 06:32:09 2010
New Revision: 960812
URL: http://svn.apache.org/viewvc?rev=960812&view=rev
Log:
Adding pom changes from #49548. Hook the new TestSetSupport file up directly,
and ensure the jar includes the .properties file. Patch from Jeremy Boynes
Modified:
tom
https://issues.apache.org/bugzilla/show_bug.cgi?id=49548
Henri Yandell changed:
What|Removed |Added
OS/Version||All
--- Comment #2 from Henri Yand
Author: bayard
Date: Tue Jul 6 06:46:55 2010
New Revision: 960814
URL: http://svn.apache.org/viewvc?rev=960814&view=rev
Log:
Patch from Jeremy Boynes (#49554):
"The implementation of Functions has checks for null parameters that are
redundant given coercion required by the Engine. As discussed
Author: bayard
Date: Tue Jul 6 06:52:21 2010
New Revision: 960817
URL: http://svn.apache.org/viewvc?rev=960817&view=rev
Log:
Applying Jeremy Boynes' refactoring of SetSupport per #49548
"Patch primarily refactors the large "if" clause that sets
the result into smaller methods. It also clears up
https://issues.apache.org/bugzilla/show_bug.cgi?id=49548
Henri Yandell changed:
What|Removed |Added
Status|NEW |NEEDINFO
--- Comment #3 from Henri
https://issues.apache.org/bugzilla/show_bug.cgi?id=49554
Henri Yandell changed:
What|Removed |Added
Status|NEW |RESOLVED
Resolution|
44 matches
Mail list logo
