svn commit: r943032 - /tomcat/trunk/modules/jdbc-pool/java/org/apache/tomcat/jdbc/pool/PoolProperties.java

2010-05-11 Thread markt
Author: markt Date: Tue May 11 08:01:52 2010 New Revision: 943032 URL: http://svn.apache.org/viewvc?rev=943032&view=rev Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=49269 Set maxIdle to maxActive by default to prevent warning on start when maxIdle > maxActive Patch provided by Matt

DO NOT REPLY [Bug 49269] Shouldn't see maxIdle > maxActive message with default props

2010-05-11 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=49269 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED Resolution|

svn commit: r943065 - /tomcat/trunk/java/org/apache/catalina/startup/ContextConfig.java

2010-05-11 Thread markt
Author: markt Date: Tue May 11 09:46:42 2010 New Revision: 943065 URL: http://svn.apache.org/viewvc?rev=943065&view=rev Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=49240 If a class can't be loaded, don't scan HandlesTypes for it Also handle NoClassDefFoundError Patch provided by pi

DO NOT REPLY [Bug 49240] Error thrown during detection of ServletContainerInitializer's

2010-05-11 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=49240 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED Resolution|

svn commit: r943073 - in /tomcat/trunk/java/org/apache/catalina: connector/LocalStrings.properties connector/MapperListener.java core/mbeans-descriptors.xml

2010-05-11 Thread markt
Author: markt Date: Tue May 11 10:18:55 2010 New Revision: 943073 URL: http://svn.apache.org/viewvc?rev=943073&view=rev Log: ContainerListener != LifecycleListener. Use the correct one. Modified: tomcat/trunk/java/org/apache/catalina/connector/LocalStrings.properties tomcat/trunk/java/org

Re: CSRF prevention filter and Tomcat 5/6

2010-05-11 Thread Tim Funk
+1 to E -Tim On 5/10/2010 11:47 AM, Mark Thomas wrote: On 10/05/2010 13:25, Konstantin Kolinko wrote: Thoughts? It is possible to combine A+C: E. Use a different name for the new role that allows access to GUI interface only, "manager-gui", as well as new "manager-script", "manager-jmx", "

svn commit: r943081 - in /tomcat/trunk/java/org/apache/catalina/connector: LocalStrings.properties MapperListener.java

2010-05-11 Thread markt
Author: markt Date: Tue May 11 11:06:02 2010 New Revision: 943081 URL: http://svn.apache.org/viewvc?rev=943081&view=rev Log: No need to remove LifecycleListeners from destroyed components Modified: tomcat/trunk/java/org/apache/catalina/connector/LocalStrings.properties tomcat/trunk/java/o

DO NOT REPLY [Bug 47237] Put a hard limit on Http11NioProcessor objects

2010-05-11 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=47237 William Leung changed: What|Removed |Added Status|RESOLVED|REOPENED Resolution|FIXED

DO NOT REPLY [Bug 47237] Put a hard limit on Http11NioProcessor objects

2010-05-11 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=47237 William Leung changed: What|Removed |Added CC||l...@21cn.com -- Configure bugmai

Re: svn commit: r943081 - in /tomcat/trunk/java/org/apache/catalina/connector: LocalStrings.properties MapperListener.java

2010-05-11 Thread Konstantin Kolinko
2010/5/11 : > Author: markt > Date: Tue May 11 11:06:02 2010 > New Revision: 943081 > > URL: http://svn.apache.org/viewvc?rev=943081&view=rev > Log: > No need to remove LifecycleListeners from destroyed components > > Modified: >    tomcat/trunk/java/org/apache/catalina/connector/LocalStrings.prop

svn commit: r943110 - in /tomcat/trunk/java/org/apache/catalina/connector: LocalStrings.properties MapperListener.java

2010-05-11 Thread markt
Author: markt Date: Tue May 11 13:01:50 2010 New Revision: 943110 URL: http://svn.apache.org/viewvc?rev=943110&view=rev Log: Fix typos Modified: tomcat/trunk/java/org/apache/catalina/connector/LocalStrings.properties tomcat/trunk/java/org/apache/catalina/connector/MapperListener.java Mod

svn commit: r943112 - /tomcat/trunk/java/org/apache/catalina/core/ContainerBase.java

2010-05-11 Thread markt
Author: markt Date: Tue May 11 13:09:43 2010 New Revision: 943112 URL: http://svn.apache.org/viewvc?rev=943112&view=rev Log: NPE protection Modified: tomcat/trunk/java/org/apache/catalina/core/ContainerBase.java Modified: tomcat/trunk/java/org/apache/catalina/core/ContainerBase.java URL: ht

svn commit: r943151 - /tomcat/trunk/java/org/apache/catalina/startup/ContextConfig.java

2010-05-11 Thread markt
Author: markt Date: Tue May 11 15:48:36 2010 New Revision: 943151 URL: http://svn.apache.org/viewvc?rev=943151&view=rev Log: https://issues.apache.org/bugzilla/show_bug.cgi?id=49235 Fix handlesTypes with annotations. The annotated class should be reported, not the annotation class. Modified:

DO NOT REPLY [Bug 49235] ServletContainerInitializer onStartup(Set> classSet is not expect class

2010-05-11 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=49235 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED Resolution|

svn commit: r943155 - in /tomcat/trunk/java/org/apache/jasper: compiler/Validator.java tagplugins/jstl/Util.java

2010-05-11 Thread markt
Author: markt Date: Tue May 11 15:53:10 2010 New Revision: 943155 URL: http://svn.apache.org/viewvc?rev=943155&view=rev Log: https://issues.apache.org/bugzilla/show_bug.cgi?id=49228 Use English Locale since other Locale's may give add results Modified: tomcat/trunk/java/org/apache/jasper/comp

DO NOT REPLY [Bug 49228] toLowerCase()/toUpperCase() may not work OK in all Locales

2010-05-11 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=49228 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED Resolution|

DO NOT REPLY [Bug 47237] Put a hard limit on Http11NioProcessor objects

2010-05-11 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=47237 Filip Hanik changed: What|Removed |Added Status|REOPENED|RESOLVED Resolution|

WebappClassLoader.clearReferences removes root Java Logger handlers

2010-05-11 Thread Ruslan Gainutdinov
Hello! I am using apache-tomcat-6.0.26 with Tanuki Wrapper. In this particular setup, Juli is not used (no -Djava.util.logging.manager=org.apache.juli.ClassLoaderLogManager) and java.util.logging.LogManager returns standard Java SE instance. org.apache.catalina.loader.WebappClassLoader.clearRefe

DO NOT REPLY [Bug 49224] NullPointerException in PooledConnection when username or password are null

2010-05-11 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=49224 --- Comment #4 from Matt Passell 2010-05-11 13:07:05 EDT --- Created an attachment (id=25427) --> (https://issues.apache.org/bugzilla/attachment.cgi?id=25427) only set username and password if the values are not null Looking at how the d

Re: WebappClassLoader.clearReferences removes root Java Logger handlers

2010-05-11 Thread Mark Thomas
On 11/05/2010 18:52, Ruslan Gainutdinov wrote: Hello! I am using apache-tomcat-6.0.26 with Tanuki Wrapper. In this particular setup, Juli is not used (no -Djava.util.logging.manager=org.apache.juli.ClassLoaderLogManager) and java.util.logging.LogManager returns standard Java SE instance. This

svn commit: r943250 - in /tomcat/trunk/java/org/apache/coyote/http11: Http11AprProcessor.java Http11NioProcessor.java Http11Processor.java

2010-05-11 Thread markt
Author: markt Date: Tue May 11 19:51:45 2010 New Revision: 943250 URL: http://svn.apache.org/viewvc?rev=943250&view=rev Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=49227 Ensure case conversion behaves as expected Patch provided by sebb Modified: tomcat/trunk/java/org/apache/co

DO NOT REPLY [Bug 49227] toLowerCase()/toUpperCase() may not work OK in all Locales

2010-05-11 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=49227 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED Resolution|

svn commit: r943260 - in /tomcat/trunk: java/org/apache/catalina/core/ java/org/apache/catalina/deploy/ java/org/apache/catalina/manager/ java/org/apache/catalina/manager/util/ java/org/apache/catalin

2010-05-11 Thread markt
Author: markt Date: Tue May 11 20:05:15 2010 New Revision: 943260 URL: http://svn.apache.org/viewvc?rev=943260&view=rev Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=49226 Ensure case conversion behaves as expected Patch provided by sebb Modified: tomcat/trunk/java/org/apache/ca

DO NOT REPLY [Bug 49226] toLowerCase()/toUpperCase() may not work OK in all Locales

2010-05-11 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=49226 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED Resolution|

svn commit: r943290 - in /tomcat/trunk/webapps/manager: 401.jsp WEB-INF/web.xml

2010-05-11 Thread markt
Author: markt Date: Tue May 11 21:02:19 2010 New Revision: 943290 URL: http://svn.apache.org/viewvc?rev=943290&view=rev Log: Change role name for Manager GUI access to manager-gui to align with planned changes to Tomcat 5/6 Modified: tomcat/trunk/webapps/manager/401.jsp tomcat/trunk/weba