svn commit: r940183 - /tomcat/trunk/test/org/apache/catalina/startup/ParamFilter.java

2010-05-02 Thread pero
Author: pero Date: Sun May 2 09:40:46 2010 New Revision: 940183 URL: http://svn.apache.org/viewvc?rev=940183&view=rev Log: Add License Header Modified: tomcat/trunk/test/org/apache/catalina/startup/ParamFilter.java Modified: tomcat/trunk/test/org/apache/catalina/startup/ParamFilter.java URL

svn commit: r940184 - /tomcat/trunk/test/org/apache/catalina/startup/ParamFilter.java

2010-05-02 Thread pero
Author: pero Date: Sun May 2 09:44:01 2010 New Revision: 940184 URL: http://svn.apache.org/viewvc?rev=940184&view=rev Log: Revert... Editor seams display problem... Sorry! Modified: tomcat/trunk/test/org/apache/catalina/startup/ParamFilter.java Modified: tomcat/trunk/test/org/apache/catalin

svn commit: r940189 - /tomcat/trunk/java/org/apache/coyote/http11/Http11AprProcessor.java

2010-05-02 Thread jfclere
Author: jfclere Date: Sun May 2 10:02:56 2010 New Revision: 940189 URL: http://svn.apache.org/viewvc?rev=940189&view=rev Log: try to fix async for APR. Modified: tomcat/trunk/java/org/apache/coyote/http11/Http11AprProcessor.java Modified: tomcat/trunk/java/org/apache/coyote/http11/Http11Apr

Re: [VOTE] Release Tomcat 7.0.0 based on Tomcat 7.0.0 RC1

2010-05-02 Thread Mark Thomas
On 01/05/2010 22:08, Kevan Miller wrote: > On May 1, 2010, at 7:25 AM, Mark Thomas wrote: >> Thanks for the review. My bad. I saw we are using EPL for the JDT >> compiler and assumed we'd be fine for this to. I'll see what I can do to >> work around it or get the license changed. > > No problem. T

svn commit: r940236 - /tomcat/trunk/java/org/apache/catalina/core/ContainerBase.java

2010-05-02 Thread markt
Author: markt Date: Sun May 2 14:25:42 2010 New Revision: 940236 URL: http://svn.apache.org/viewvc?rev=940236&view=rev Log: Clean-up post init/destroy lifecycle refactoring By default, remove children on destroy, not stop Modified: tomcat/trunk/java/org/apache/catalina/core/ContainerBase.jav

svn commit: r940237 - /tomcat/trunk/java/org/apache/catalina/loader/WebappLoader.java

2010-05-02 Thread markt
Author: markt Date: Sun May 2 14:26:34 2010 New Revision: 940237 URL: http://svn.apache.org/viewvc?rev=940237&view=rev Log: Clean-up post init/destroy lifecycle refactoring Allow Loader objects to be restarted Modified: tomcat/trunk/java/org/apache/catalina/loader/WebappLoader.java Modified

svn commit: r940238 - /tomcat/trunk/java/org/apache/catalina/session/StandardManager.java

2010-05-02 Thread markt
Author: markt Date: Sun May 2 14:26:54 2010 New Revision: 940238 URL: http://svn.apache.org/viewvc?rev=940238&view=rev Log: Clean-up post init/destroy lifecycle refactoring Allow Manager objects to be restarted Modified: tomcat/trunk/java/org/apache/catalina/session/StandardManager.java Mod

svn commit: r940271 - in /tomcat/trunk/java/org/apache/catalina: LifecycleMBeanRegistration.java util/LifecycleBase.java util/LocalStrings.properties

2010-05-02 Thread markt
Author: markt Date: Sun May 2 17:34:33 2010 New Revision: 940271 URL: http://svn.apache.org/viewvc?rev=940271&view=rev Log: Add MBean registration and de-registration to LifecycleBase The new interface will need to be added to each component to get this to work. Added: tomcat/trunk/java/org/

svn commit: r940272 - /tomcat/trunk/java/org/apache/tomcat/util/buf/StringCache.java

2010-05-02 Thread markt
Author: markt Date: Sun May 2 17:35:10 2010 New Revision: 940272 URL: http://svn.apache.org/viewvc?rev=940272&view=rev Log: Line lengths. No functional change. Modified: tomcat/trunk/java/org/apache/tomcat/util/buf/StringCache.java Modified: tomcat/trunk/java/org/apache/tomcat/util/buf/Stri

svn commit: r940273 - in /tomcat/trunk: java/org/apache/catalina/ java/org/apache/catalina/core/ test/org/apache/catalina/mbeans/

2010-05-02 Thread markt
Author: markt Date: Sun May 2 17:36:38 2010 New Revision: 940273 URL: http://svn.apache.org/viewvc?rev=940273&view=rev Log: Add new interface to StandardServer to enable MBean (de)registration on init/destroy Added: tomcat/trunk/test/org/apache/catalina/mbeans/ tomcat/trunk/test/org/apa

buildbot failure in ASF Buildbot on tomcat-trunk

2010-05-02 Thread buildbot
The Buildbot has detected a new failure of tomcat-trunk on ASF Buildbot. Full details are available at: http://ci.apache.org/builders/tomcat-trunk/builds/384 Buildbot URL: http://ci.apache.org/ Buildslave for this Build: bb-vm_ubuntu Build Reason: Build Source Stamp: [branch tomcat/trunk] 9402

svn commit: r940275 - /tomcat/trunk/java/org/apache/catalina/core/StandardServer.java

2010-05-02 Thread markt
Author: markt Date: Sun May 2 17:47:31 2010 New Revision: 940275 URL: http://svn.apache.org/viewvc?rev=940275&view=rev Log: Remove invalid auto-generated import. Modified: tomcat/trunk/java/org/apache/catalina/core/StandardServer.java Modified: tomcat/trunk/java/org/apache/catalina/core/Sta

buildbot success in ASF Buildbot on tomcat-trunk

2010-05-02 Thread buildbot
The Buildbot has detected a restored build of tomcat-trunk on ASF Buildbot. Full details are available at: http://ci.apache.org/builders/tomcat-trunk/builds/385 Buildbot URL: http://ci.apache.org/ Buildslave for this Build: bb-vm_ubuntu Build Reason: Build Source Stamp: [branch tomcat/trunk] 9

svn commit: r940278 - /tomcat/trunk/test/org/apache/catalina/mbeans/RegistrationTest.java

2010-05-02 Thread markt
Author: markt Date: Sun May 2 17:58:28 2010 New Revision: 940278 URL: http://svn.apache.org/viewvc?rev=940278&view=rev Log: Align test with expected behaviour (currently fails). Will fix in following commits. Modified: tomcat/trunk/test/org/apache/catalina/mbeans/RegistrationTest.java Modi

svn commit: r940281 - /tomcat/trunk/java/org/apache/catalina/startup/Tomcat.java

2010-05-02 Thread markt
Author: markt Date: Sun May 2 18:01:58 2010 New Revision: 940281 URL: http://svn.apache.org/viewvc?rev=940281&view=rev Log: Add init() and destroy() support Modified: tomcat/trunk/java/org/apache/catalina/startup/Tomcat.java Modified: tomcat/trunk/java/org/apache/catalina/startup/Tomcat.jav

svn commit: r940282 - /tomcat/trunk/test/org/apache/catalina/mbeans/RegistrationTest.java

2010-05-02 Thread markt
Author: markt Date: Sun May 2 18:02:34 2010 New Revision: 940282 URL: http://svn.apache.org/viewvc?rev=940282&view=rev Log: Add call to destroy() that should unregister all the MBeans Modified: tomcat/trunk/test/org/apache/catalina/mbeans/RegistrationTest.java Modified: tomcat/trunk/test/or

svn commit: r940283 - /tomcat/trunk/test/org/apache/catalina/mbeans/RegistrationTest.java

2010-05-02 Thread markt
Author: markt Date: Sun May 2 18:10:12 2010 New Revision: 940283 URL: http://svn.apache.org/viewvc?rev=940283&view=rev Log: No longer need ServerLifecycleListener Modified: tomcat/trunk/test/org/apache/catalina/mbeans/RegistrationTest.java Modified: tomcat/trunk/test/org/apache/catalina/mbe

svn commit: r940284 - /tomcat/trunk/java/org/apache/catalina/core/StandardServer.java

2010-05-02 Thread markt
Author: markt Date: Sun May 2 18:13:34 2010 New Revision: 940284 URL: http://svn.apache.org/viewvc?rev=940284&view=rev Log: Register the MBeanFactory Make sure all the objects registered are unregistered Modified: tomcat/trunk/java/org/apache/catalina/core/StandardServer.java Modified: tomc

svn commit: r940292 - /tomcat/trunk/java/org/apache/catalina/core/StandardServer.java

2010-05-02 Thread markt
Author: markt Date: Sun May 2 18:31:41 2010 New Revision: 940292 URL: http://svn.apache.org/viewvc?rev=940292&view=rev Log: Make sure Server calls destroy() on subordinate Services Modified: tomcat/trunk/java/org/apache/catalina/core/StandardServer.java Modified: tomcat/trunk/java/org/apach

svn commit: r940298 - in /tomcat/trunk/java/org/apache/catalina/core: LocalStrings.properties StandardService.java

2010-05-02 Thread markt
Author: markt Date: Sun May 2 18:47:56 2010 New Revision: 940298 URL: http://svn.apache.org/viewvc?rev=940298&view=rev Log: Add LifecycleMBeanRegistration Align init() and destroy() Executors and Connectors need to handle their own (de)registration Modified: tomcat/trunk/java/org/apache/cata

svn commit: r940304 - in /tomcat/trunk/java/org/apache/catalina/util: LifecycleBase.java LocalStrings.properties

2010-05-02 Thread markt
Author: markt Date: Sun May 2 19:05:07 2010 New Revision: 940304 URL: http://svn.apache.org/viewvc?rev=940304&view=rev Log: Just log multiple calls to destroy rather than throwing an Exception. Modified: tomcat/trunk/java/org/apache/catalina/util/LifecycleBase.java tomcat/trunk/java/org/

svn commit: r940305 - in /tomcat/trunk/java/org/apache/catalina: LifecycleMBeanRegistration.java core/LocalStrings.properties core/StandardEngine.java core/StandardServer.java core/StandardService.jav

2010-05-02 Thread markt
Author: markt Date: Sun May 2 19:10:40 2010 New Revision: 940305 URL: http://svn.apache.org/viewvc?rev=940305&view=rev Log: Add a setDomain() method to LifecycleMBeanRegistration since not all components (eg Exectutor) retain a reference to their parent. Implement this new method where required.

svn commit: r940306 - /tomcat/trunk/test/org/apache/catalina/mbeans/RegistrationTest.java

2010-05-02 Thread markt
Author: markt Date: Sun May 2 19:13:34 2010 New Revision: 940306 URL: http://svn.apache.org/viewvc?rev=940306&view=rev Log: Increase the threshold to try and catch if MBean registration breaks and MBeans don't get registered. Modified: tomcat/trunk/test/org/apache/catalina/mbeans/Registrati

svn commit: r940307 - /tomcat/trunk/java/org/apache/catalina/connector/Connector.java

2010-05-02 Thread markt
Author: markt Date: Sun May 2 19:17:52 2010 New Revision: 940307 URL: http://svn.apache.org/viewvc?rev=940307&view=rev Log: Clean-up prior to MBean changes Modified: tomcat/trunk/java/org/apache/catalina/connector/Connector.java Modified: tomcat/trunk/java/org/apache/catalina/connector/Conn

Re: svn commit: r940189 - /tomcat/trunk/java/org/apache/coyote/http11/Http11AprProcessor.java

2010-05-02 Thread Filip Hanik - Dev Lists
On 05/02/2010 04:02 AM, jfcl...@apache.org wrote: -// endpoint.processSocket(this.socket, SocketStatus.STOP); +try { +asyncDispatch(SocketStatus.STOP); // What to do with return code ? What you want to do here, is let the Endpoint know that

svn commit: r940338 - in /tomcat/trunk/java/org/apache/catalina: connector/Connector.java connector/CoyoteAdapter.java core/StandardService.java startup/Embedded.java

2010-05-02 Thread markt
Author: markt Date: Sun May 2 23:47:51 2010 New Revision: 940338 URL: http://svn.apache.org/viewvc?rev=940338&view=rev Log: Simplify the connector. Keep a reference to just the Service rather than the Service and the Engine. Modified: tomcat/trunk/java/org/apache/catalina/connector/Connecto

DO NOT REPLY [Bug 49234] JMX Descriptor Modifications

2010-05-02 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=49234 chamith buddhika changed: What|Removed |Added Attachment #25378|0 |1 is obsolete|

DO NOT REPLY [Bug 49234] JMX Descriptor Modifications

2010-05-02 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=49234 --- Comment #3 from chamith buddhika 2010-05-03 02:26:58 EDT --- Created an attachment (id=25390) --> (https://issues.apache.org/bugzilla/attachment.cgi?id=25390) catalina.connector-descriptor Package: org.apache.catalina.connector This