DO NOT REPLY [Bug 47437] New: better exception message for shutdown

2009-06-27 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=47437 Summary: better exception message for shutdown Product: Tomcat 6 Version: 6.0.20 Platform: PC OS/Version: Windows Vista Status: NEW Severity: enhancement Prio

Re: svn commit: r788214 - /tomcat/current/tc5.5.x/STATUS.txt

2009-06-27 Thread Konstantin Kolinko
Mark Thomas wrote: >Konstantin Kolinko wrote: >> 2. struct.currentDateString is calculated in two different places >> I propose to encapsulate that code into AccessDateStruct >> >> 3. Invocation of getDate() in invoke() (the only place where getDate() >> is called): >> I think that getDate() also c

DO NOT REPLY [Bug 47439] New: PooledConnection.connect() fails to check for null connection

2009-06-27 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=47439 Summary: PooledConnection.connect() fails to check for null connection Product: Tomcat 6 Version: unspecified Platform: PC OS/Version: Windows XP Status: NEW

DO NOT REPLY [Bug 47440] New: Remove DB-specific SQL statements from test cases (SELECT 1)

2009-06-27 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=47440 Summary: Remove DB-specific SQL statements from test cases (SELECT 1) Product: Tomcat 6 Version: unspecified Platform: PC OS/Version: Windows XP Status: NEW

DO NOT REPLY [Bug 47440] Remove DB-specific SQL statements from test cases (SELECT 1)

2009-06-27 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=47440 --- Comment #1 from Sebb 2009-06-27 05:19:01 PST --- Created an attachment (id=23890) --> (https://issues.apache.org/bugzilla/attachment.cgi?id=23890) Remove setValidattionQuery() calls -- Configure bugmail: https://issues.apache.or

DO NOT REPLY [Bug 47440] Remove DB-specific SQL statements from test cases (SELECT 1)

2009-06-27 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=47440 --- Comment #2 from Sebb 2009-06-27 05:19:46 PST --- Created an attachment (id=23891) --> (https://issues.apache.org/bugzilla/attachment.cgi?id=23891) Use validationQuery instead of "SELECT 1" -- Configure bugmail: https://issues.ap

Re: svn commit: r788214 - /tomcat/current/tc5.5.x/STATUS.txt

2009-06-27 Thread Xie Xiaodong
But how could ThreadLocal be shared among all AccessLogValve instances on the same server? After all, each thread access ThreadLocal has its own. Another point, based on the java doc of ThreadLocal, maybe "private ThreadLocal currentDateStruct" should be declared as static? 2009/6/27 Konstantin

Re: svn commit: r788214 - /tomcat/current/tc5.5.x/STATUS.txt

2009-06-27 Thread sebb
On 27/06/2009, Xie Xiaodong wrote: > But how could ThreadLocal be shared among all AccessLogValve instances on > the same server? After all, each thread access ThreadLocal has its own. > > Another point, based on the java doc of ThreadLocal, maybe "private > ThreadLocal currentDateStruct" shoul

Re: svn commit: r788214 - /tomcat/current/tc5.5.x/STATUS.txt

2009-06-27 Thread Xie Xiaodong
Yes, you're right. Both static and final. :) 2009/6/27 sebb > On 27/06/2009, Xie Xiaodong wrote: > > But how could ThreadLocal be shared among all AccessLogValve instances on > > the same server? After all, each thread access ThreadLocal has its own. > > > > Another point, based on the java d

DO NOT REPLY [Bug 47439] PooledConnection.connect() fails to check for null connection

2009-06-27 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=47439 Filip Hanik changed: What|Removed |Added Status|NEW |RESOLVED Resolution|

DO NOT REPLY [Bug 47439] PooledConnection.connect() fails to check for null connection

2009-06-27 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=47439 Sebb changed: What|Removed |Added Status|RESOLVED|REOPENED Resolution|INVALID

DO NOT REPLY [Bug 47439] PooledConnection.connect() fails to check for null connection

2009-06-27 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=47439 --- Comment #3 from Sebb 2009-06-27 13:03:46 PST --- Here's the result of using a "jdbc:oracle:" URL with the Derby JDBC client: Testcase: testException(org.apache.tomcat.jdbc.test.TestException): Caused an ERROR null java.sql.SQLE

DO NOT REPLY [Bug 47439] PooledConnection.connect() fails to check for null connection

2009-06-27 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=47439 Filip Hanik changed: What|Removed |Added Status|REOPENED|RESOLVED Resolution|

DO NOT REPLY [Bug 47439] PooledConnection.connect() fails to check for null connection

2009-06-27 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=47439 Sebb changed: What|Removed |Added Status|RESOLVED|REOPENED Resolution|INVALID