svn commit: r718561 - /tomcat/container/tags/tc4.1.x/TOMCAT_4_1_39/

2008-11-18 Thread markt
Author: markt Date: Tue Nov 18 03:35:06 2008 New Revision: 718561 URL: http://svn.apache.org/viewvc?rev=718561&view=rev Log: Tagging 4.1.39 Added: tomcat/container/tags/tc4.1.x/TOMCAT_4_1_39/ - copied from r718560, tomcat/container/branches/tc4.1.x/ ---

svn commit: r718562 - /tomcat/connectors/tags/tc4.1.x/TOMCAT_4_1_39/

2008-11-18 Thread markt
Author: markt Date: Tue Nov 18 03:35:19 2008 New Revision: 718562 URL: http://svn.apache.org/viewvc?rev=718562&view=rev Log: Tagging 4.1.39 Added: tomcat/connectors/tags/tc4.1.x/TOMCAT_4_1_39/ - copied from r718561, tomcat/connectors/trunk/

svn commit: r718563 - /tomcat/jasper/tags/tc4.1.x/TOMCAT_4_1_39/

2008-11-18 Thread markt
Author: markt Date: Tue Nov 18 03:35:32 2008 New Revision: 718563 URL: http://svn.apache.org/viewvc?rev=718563&view=rev Log: Tagging 4.1.39 Added: tomcat/jasper/tags/tc4.1.x/TOMCAT_4_1_39/ - copied from r718562, tomcat/jasper/branches/tc4.1.x/ -

svn commit: r718564 - /tomcat/servletapi/tags/servlet2.3-jsp1.2-tc4.x/TOMCAT_4_1_39/

2008-11-18 Thread markt
Author: markt Date: Tue Nov 18 03:35:45 2008 New Revision: 718564 URL: http://svn.apache.org/viewvc?rev=718564&view=rev Log: Tagging 4.1.39 Added: tomcat/servletapi/tags/servlet2.3-jsp1.2-tc4.x/TOMCAT_4_1_39/ - copied from r718563, tomcat/servletapi/branches/servlet2.3-jsp1.2-tc4.x/ -

Re: svn commit: r718474 - in /tomcat/trunk/java/org/apache/tomcat/util/net: NioEndpoint.java SecureNioChannel.java

2008-11-18 Thread Konstantin Kolinko
It would a bit better to use java.lang.StringBuilder instead of StringBuffer here for code that runs on 1.5+ JVMs. also, in theory, this toString() code may throw an NPE, though it looks like it would not occur in practice. Just in case if it matters. Best regards, Konstantin Kolinko 2008/11/18

Re: [RESULT] [VOTE] Releasing Apache Tomcat Native 1.1.16

2008-11-18 Thread sebb
I happened to spot the following in ssl.c: static int jbs_gets(BIO *b, char *out, int outl) ... int l = (int)strlen(J2S(o)); if (l < outl) { strcpy(out, J2S(o)); ret = outl; } ... return ret; It looks a bit odd to me - I would have expected it to return l rather than outl. However, I've

Re: [RESULT] [VOTE] Releasing Apache Tomcat Native 1.1.16

2008-11-18 Thread Mladen Turk
sebb wrote: I happened to spot the following in ssl.c: static int jbs_gets(BIO *b, char *out, int outl) ... int l = (int)strlen(J2S(o)); if (l < outl) { strcpy(out, J2S(o)); ret = outl; } ... return ret; It looks a bit odd to me - I would have expected it to return l rather than outl.

Re: [RESULT] [VOTE] Releasing Apache Tomcat Native 1.1.16

2008-11-18 Thread sebb
On 18/11/2008, Mladen Turk <[EMAIL PROTECTED]> wrote: > sebb wrote: > > > I happened to spot the following in ssl.c: > > > > static int jbs_gets(BIO *b, char *out, int outl) > > ... > > int l = (int)strlen(J2S(o)); > > if (l < outl) { > >strcpy(out, J2S(o)); > >ret = outl; > > } > > ... > >

Re: [RESULT] [VOTE] Releasing Apache Tomcat Native 1.1.16

2008-11-18 Thread jean-frederic clere
Mladen Turk wrote: sebb wrote: I happened to spot the following in ssl.c: static int jbs_gets(BIO *b, char *out, int outl) ... int l = (int)strlen(J2S(o)); if (l < outl) { strcpy(out, J2S(o)); ret = outl; } ... return ret; It looks a bit odd to me - I would have expected it to return l

DO NOT REPLY [Bug 46232] New: Can't override XML parser implementation using endorsed mechanism

2008-11-18 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=46232 Summary: Can't override XML parser implementation using endorsed mechanism Product: Tomcat 6 Version: 6.0.18 Platform: Sun OS/Version: Solaris Status: NEW

DO NOT REPLY [Bug 46234] New: Can't Bind Address

2008-11-18 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=46234 Summary: Can't Bind Address Product: Tomcat 6 Version: 6.0.16 Platform: PC OS/Version: FreeBSD Status: NEW Severity: blocker Priority: P1 Component:

svn commit: r718766 - in /tomcat/trunk/java/org/apache/tomcat/util: digester/ http/ http/fileupload/ http/mapper/ log/ threads/

2008-11-18 Thread markt
Author: markt Date: Tue Nov 18 15:29:05 2008 New Revision: 718766 URL: http://svn.apache.org/viewvc?rev=718766&view=rev Log: Remaining generics changes in o.a.tomcat.util No nasty surprises. Should be no functional impact. Modified: tomcat/trunk/java/org/apache/tomcat/util/digester/AbstractRu

svn commit: r718796 - /tomcat/trunk/java/org/apache/catalina/startup/Catalina.java

2008-11-18 Thread markt
Author: markt Date: Tue Nov 18 15:36:34 2008 New Revision: 718796 URL: http://svn.apache.org/viewvc?rev=718796&view=rev Log: Knock-on generics changes from digester commit Modified: tomcat/trunk/java/org/apache/catalina/startup/Catalina.java Modified: tomcat/trunk/java/org/apache/catalina/st

svn commit: r718819 - in /tomcat/trunk/java/org/apache: catalina/connector/ tomcat/util/ tomcat/util/buf/ tomcat/util/digester/ tomcat/util/http/ tomcat/util/modeler/ tomcat/util/modeler/modules/ tomc

2008-11-18 Thread markt
Author: markt Date: Tue Nov 18 16:39:04 2008 New Revision: 718819 URL: http://svn.apache.org/viewvc?rev=718819&view=rev Log: Remove deprecated methods. (In a few places public methods become private) In the few places they are used, replace the call to the deprecated method with an appropriate al

DO NOT REPLY [Bug 46234] Can't Bind Address

2008-11-18 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=46234 Mark Thomas <[EMAIL PROTECTED]> changed: What|Removed |Added Status|NEW |RESOLVED

svn commit: r718821 - /tomcat/trunk/java/org/apache/tomcat/util/modeler/Registry.java

2008-11-18 Thread markt
Author: markt Date: Tue Nov 18 16:43:15 2008 New Revision: 718821 URL: http://svn.apache.org/viewvc?rev=718821&view=rev Log: Remove deprecation. Generics changes removed the issue. Modified: tomcat/trunk/java/org/apache/tomcat/util/modeler/Registry.java Modified: tomcat/trunk/java/org/apache

svn commit: r718824 - /tomcat/trunk/java/org/apache/tomcat/util/net/SecureNioChannel.java

2008-11-18 Thread fhanik
Author: fhanik Date: Tue Nov 18 16:44:57 2008 New Revision: 718824 URL: http://svn.apache.org/viewvc?rev=718824&view=rev Log: remove debug stuff that should not be there Modified: tomcat/trunk/java/org/apache/tomcat/util/net/SecureNioChannel.java Modified: tomcat/trunk/java/org/apache/tomcat