svn commit: r702376 - in /tomcat/connectors/trunk/jk/native/common: jk_ajp_common.c jk_lb_worker.c

2008-10-07 Thread mturk
Author: mturk Date: Tue Oct 7 01:01:27 2008 New Revision: 702376 URL: http://svn.apache.org/viewvc?rev=702376&view=rev Log: Move get_endpoint retries to the get_endpoint function Modified: tomcat/connectors/trunk/jk/native/common/jk_ajp_common.c tomcat/connectors/trunk/jk/native/common/j

svn commit: r702378 - /tomcat/connectors/trunk/jk/native/common/jk_lb_worker.h

2008-10-07 Thread mturk
Author: mturk Date: Tue Oct 7 01:04:34 2008 New Revision: 702378 URL: http://svn.apache.org/viewvc?rev=702378&view=rev Log: Remove obsolete defines Modified: tomcat/connectors/trunk/jk/native/common/jk_lb_worker.h Modified: tomcat/connectors/trunk/jk/native/common/jk_lb_worker.h URL: http:

svn commit: r702387 - in /tomcat/connectors/trunk/jk: native/common/jk_ajp_common.c native/common/jk_util.c native/common/jk_util.h xdocs/miscellaneous/changelog.xml xdocs/reference/workers.xml

2008-10-07 Thread mturk
Author: mturk Date: Tue Oct 7 01:42:30 2008 New Revision: 702387 URL: http://svn.apache.org/viewvc?rev=702387&view=rev Log: Add connection_acquire_timeout directive. It helps diferentiating the timeout for obtaining cache endpoint and retry on the obtained worker connection Modified: tomcat

Re: UTF-8 POST request results in corrupted data

2008-10-07 Thread Tim Funk
If you take that form and post it - how does the server know that the content is UTF-8? (Answer: it doesn't) The HTML directives tell the browser to encode everything into UTF-8 on the way to the web server. But there is nothing that tells the webserver explicitly what the charset is of the in

DO NOT REPLY [Bug 45774] jspDestroy called after deployment, the second jspInit follows

2008-10-07 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=45774 Brian Burch <[EMAIL PROTECTED]> changed: What|Removed |Added CC||[EMAIL PROTECTED]

svn commit: r702391 - /tomcat/connectors/trunk/jk/xdocs/reference/workers.xml

2008-10-07 Thread mturk
Author: mturk Date: Tue Oct 7 01:51:31 2008 New Revision: 702391 URL: http://svn.apache.org/viewvc?rev=702391&view=rev Log: Document the new usage for lb retries Modified: tomcat/connectors/trunk/jk/xdocs/reference/workers.xml Modified: tomcat/connectors/trunk/jk/xdocs/reference/workers.xml

DO NOT REPLY [Bug 45774] jspDestroy called after deployment, the second jspInit follows

2008-10-07 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=45774 --- Comment #3 from Mark Thomas <[EMAIL PROTECTED]> 2008-10-07 07:47:51 PST --- Thanks for the additional testing - it explains why I couldn't reproduce it. I'll take another look at what is going on. If you need to create long-lived r

svn commit: r702429 - /tomcat/connectors/trunk/jk/native/apache-2.0/mod_jk.c

2008-10-07 Thread mturk
Author: mturk Date: Tue Oct 7 03:33:08 2008 New Revision: 702429 URL: http://svn.apache.org/viewvc?rev=702429&view=rev Log: Do a simple thread_join for a detached watchdog thread Modified: tomcat/connectors/trunk/jk/native/apache-2.0/mod_jk.c Modified: tomcat/connectors/trunk/jk/native/apac

Re: UTF-8 POST request results in corrupted data

2008-10-07 Thread Mark Thomas
Andre-John Mas wrote: > Thanks for the answer on this point. Reading section 3.7.1 of RFC 2616 > indicates that request can specify a character other than the default. > For this reason the following should technically be legal: > > enctype="application/x-www-form-urlencoded; charset=utf-8" > acc

svn commit: r702431 - in /tomcat/connectors/trunk/jk: native/apache-2.0/mod_jk.c xdocs/reference/apache.xml

2008-10-07 Thread mturk
Author: mturk Date: Tue Oct 7 03:56:27 2008 New Revision: 702431 URL: http://svn.apache.org/viewvc?rev=702431&view=rev Log: Allow JkStripSession to have optional session path identifier different then default ;jsessionid Modified: tomcat/connectors/trunk/jk/native/apache-2.0/mod_jk.c to

DO NOT REPLY [Bug 45774] jspDestroy called after deployment, the second jspInit follows

2008-10-07 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=45774 Brian Burch <[EMAIL PROTECTED]> changed: What|Removed |Added Status|RESOLVED|REOPENED

Spec clarification and bug 45451

2008-10-07 Thread Mark Thomas
All, I received clarification from the EG today. In summary, the question was which of the following is correct: 1: 2: A strict reading of the EBNF grammar in the JSP spec suggested that 1 was correct. The TCK expected 2. The EG have confirmed that the TCK is correct. I am still following up

svn commit: r702531 - /tomcat/connectors/trunk/jk/native/common/jk_msg_buff.c

2008-10-07 Thread mturk
Author: mturk Date: Tue Oct 7 09:18:36 2008 New Revision: 702531 URL: http://svn.apache.org/viewvc?rev=702531&view=rev Log: Get rid of invalid sting message parsing. We should mark the entire message as invalid. At least we presume in ajp_common that get_bytes can return NULL in overflow case

svn commit: r702532 - /tomcat/connectors/trunk/jk/native/common/jk_ajp_common.h

2008-10-07 Thread mturk
Author: mturk Date: Tue Oct 7 09:20:40 2008 New Revision: 702532 URL: http://svn.apache.org/viewvc?rev=702532&view=rev Log: Add missing struct member for cache_acquire_timeout Modified: tomcat/connectors/trunk/jk/native/common/jk_ajp_common.h Modified: tomcat/connectors/trunk/jk/native/comm

Re: Spec clarification and bug 45451

2008-10-07 Thread Remy Maucherat
On Tue, 2008-10-07 at 16:51 +0100, Mark Thomas wrote: > I will start work on getting the necessary changes implemented in trunk and > then propose patches for 6.0.x. Changes may also be required for 5.5.x Ok. The change to the Parser made it that EL was no longer unescaped. So if I understand corr

Re: Spec clarification and bug 45451

2008-10-07 Thread Mark Thomas
Remy Maucherat wrote: > On Tue, 2008-10-07 at 16:51 +0100, Mark Thomas wrote: >> I will start work on getting the necessary changes implemented in trunk and >> then propose patches for 6.0.x. Changes may also be required for 5.5.x > > Ok. The change to the Parser made it that EL was no longer unes

svn commit: r702540 - in /tomcat/connectors/trunk/jk: native/common/jk_ajp_common.c xdocs/miscellaneous/changelog.xml

2008-10-07 Thread mturk
Author: mturk Date: Tue Oct 7 09:44:44 2008 New Revision: 702540 URL: http://svn.apache.org/viewvc?rev=702540&view=rev Log: Send an empty initial POST message if client failed in a middle of request Modified: tomcat/connectors/trunk/jk/native/common/jk_ajp_common.c tomcat/connectors/trun

svn commit: r702585 - /tomcat/tc6.0.x/trunk/STATUS.txt

2008-10-07 Thread markt
Author: markt Date: Tue Oct 7 12:08:07 2008 New Revision: 702585 URL: http://svn.apache.org/viewvc?rev=702585&view=rev Log: Pull the current patch for bug 45451. Modified: tomcat/tc6.0.x/trunk/STATUS.txt Modified: tomcat/tc6.0.x/trunk/STATUS.txt URL: http://svn.apache.org/viewvc/tomcat/tc6

svn commit: r702587 - /tomcat/trunk/java/org/apache/jasper/compiler/Parser.java

2008-10-07 Thread markt
Author: markt Date: Tue Oct 7 12:10:51 2008 New Revision: 702587 URL: http://svn.apache.org/viewvc?rev=702587&view=rev Log: EG confirmed that attribute values should be fully escaped, including any EL. Note this does not fix bug 45451. Modified: tomcat/trunk/java/org/apache/jasper/compiler/

Re: svn commit: r702587 - /tomcat/trunk/java/org/apache/jasper/compiler/Parser.java

2008-10-07 Thread sebb
On 07/10/2008, [EMAIL PROTECTED] <[EMAIL PROTECTED]> wrote: > Author: markt > Date: Tue Oct 7 12:10:51 2008 > New Revision: 702587 > > URL: http://svn.apache.org/viewvc?rev=702587&view=rev > Log: > EG confirmed that attribute values should be fully escaped, including any > EL. Note this does

Re: svn commit: r702587 - /tomcat/trunk/java/org/apache/jasper/compiler/Parser.java

2008-10-07 Thread Mark Thomas
sebb wrote: > The sentence: > > \ " and ' are always unescaped regardless of if they are or outside of > an EL expression. > > seems a bit odd to me - at least one word is missing. > > Might be better as: > > " and ' are always unescaped regardless of whether they are inside or > outside an EL

svn commit: r702595 - /tomcat/trunk/java/org/apache/jasper/compiler/Parser.java

2008-10-07 Thread markt
Author: markt Date: Tue Oct 7 12:26:30 2008 New Revision: 702595 URL: http://svn.apache.org/viewvc?rev=702595&view=rev Log: Fix comment typo Modified: tomcat/trunk/java/org/apache/jasper/compiler/Parser.java Modified: tomcat/trunk/java/org/apache/jasper/compiler/Parser.java URL: http://svn

svn commit: r702628 - in /tomcat/trunk: java/org/apache/el/lang/ELSupport.java test/org/apache/el/lang/TestELSupport.java

2008-10-07 Thread markt
Author: markt Date: Tue Oct 7 13:48:45 2008 New Revision: 702628 URL: http://svn.apache.org/viewvc?rev=702628&view=rev Log: Revert patch - it caused a regression. Correct patch to follow. Modified: tomcat/trunk/java/org/apache/el/lang/ELSupport.java tomcat/trunk/test/org/apache/el/lang/T

DO NOT REPLY [Bug 43656] ELSupport.coerceToType modifies BigDecimal Values

2008-10-07 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=43656 --- Comment #11 from Mark Thomas <[EMAIL PROTECTED]> 2008-10-07 13:53:18 PST --- (In reply to comment #8) > Another possible risk is the number.doubleValue() in the BigDecimal if clause. > This behaves different to the coerceToType Met

svn commit: r702632 - in /tomcat/trunk: java/org/apache/el/lang/ELSupport.java test/org/apache/el/lang/TestELSupport.java

2008-10-07 Thread markt
Author: markt Date: Tue Oct 7 13:54:47 2008 New Revision: 702632 URL: http://svn.apache.org/viewvc?rev=702632&view=rev Log: Better fix for 45636 Modified: tomcat/trunk/java/org/apache/el/lang/ELSupport.java tomcat/trunk/test/org/apache/el/lang/TestELSupport.java Modified: tomcat/trunk/j

svn commit: r702634 - /tomcat/tc6.0.x/trunk/STATUS.txt

2008-10-07 Thread markt
Author: markt Date: Tue Oct 7 13:56:18 2008 New Revision: 702634 URL: http://svn.apache.org/viewvc?rev=702634&view=rev Log: Provide the right link Modified: tomcat/tc6.0.x/trunk/STATUS.txt Modified: tomcat/tc6.0.x/trunk/STATUS.txt URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STAT

DO NOT REPLY [Bug 43656] ELSupport.coerceToType modifies BigDecimal Values

2008-10-07 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=43656 --- Comment #12 from Nils Eckert <[EMAIL PROTECTED]> 2008-10-07 14:13:04 PST --- public final static Object coerceToType(final Object obj, final Class type) throws IllegalArgumentException { if (type == null ||

DO NOT REPLY [Bug 45963] New: WebappClassLoader.loadClass() throws NoClassDefFoundError from system.loadClass()

2008-10-07 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=45963 Summary: WebappClassLoader.loadClass() throws NoClassDefFoundError from system.loadClass() Product: Tomcat 6 Version: 6.0.18 Platform: PC OS/Version: SunOS St

svn commit: r702676 - /tomcat/trunk/java/org/apache/coyote/http11/Http11Processor.java

2008-10-07 Thread fhanik
Author: fhanik Date: Tue Oct 7 18:03:02 2008 New Revision: 702676 URL: http://svn.apache.org/viewvc?rev=702676&view=rev Log: properly cleanup socket object, since we have the ability to chache Http11Processor objects the processor must remove its reference to the socket, since sockets contain b

svn commit: r702677 - /tomcat/tc6.0.x/trunk/STATUS.txt

2008-10-07 Thread fhanik
Author: fhanik Date: Tue Oct 7 18:08:07 2008 New Revision: 702677 URL: http://svn.apache.org/viewvc?rev=702677&view=rev Log: deref socket proposal Modified: tomcat/tc6.0.x/trunk/STATUS.txt Modified: tomcat/tc6.0.x/trunk/STATUS.txt URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STAT

Re: svn commit: r702160 - /tomcat/connectors/trunk/jk/native/common/jk_shm.c

2008-10-07 Thread Rainer Jung
[EMAIL PROTECTED] schrieb: > Author: mturk > Date: Mon Oct 6 07:28:20 2008 > New Revision: 702160 > > URL: http://svn.apache.org/viewvc?rev=702160&view=rev > Log: > Implement global shared memory lock for IIS. With IIS 6+ we don't have a > single process any more I was talking to someone having

Re: svn commit: r702160 - /tomcat/connectors/trunk/jk/native/common/jk_shm.c

2008-10-07 Thread Rainer Jung
[EMAIL PROTECTED] schrieb: > Author: mturk > Date: Mon Oct 6 07:28:20 2008 > New Revision: 702160 > > URL: http://svn.apache.org/viewvc?rev=702160&view=rev > Log: > Implement global shared memory lock for IIS. With IIS 6+ we don't have a > single process any more I also noticed, that the new fe

svn commit: r702732 - /tomcat/connectors/trunk/jk/native/apache-2.0/mod_jk.c

2008-10-07 Thread mturk
Author: mturk Date: Tue Oct 7 23:38:11 2008 New Revision: 702732 URL: http://svn.apache.org/viewvc?rev=702732&view=rev Log: Fix simple thread join. Thread can be closed before even initialized Modified: tomcat/connectors/trunk/jk/native/apache-2.0/mod_jk.c Modified: tomcat/connectors/trunk/

Re: svn commit: r702160 - /tomcat/connectors/trunk/jk/native/common/jk_shm.c

2008-10-07 Thread Mladen Turk
Rainer Jung wrote: [EMAIL PROTECTED] schrieb: Author: mturk Date: Mon Oct 6 07:28:20 2008 New Revision: 702160 URL: http://svn.apache.org/viewvc?rev=702160&view=rev Log: Implement global shared memory lock for IIS. With IIS 6+ we don't have a single process any more I also noticed, that the