svn commit: r699210 - /tomcat/connectors/trunk/jk/native/common/jk_uri_worker_map.c

2008-09-26 Thread rjung
Author: rjung Date: Fri Sep 26 01:11:43 2008 New Revision: 699210 URL: http://svn.apache.org/viewvc?rev=699210&view=rev Log: Fix wrong log message in unreleased extension feature. Modified: tomcat/connectors/trunk/jk/native/common/jk_uri_worker_map.c Modified: tomcat/connectors/trunk/jk/nati

DO NOT REPLY [Bug 45872] warning message for fail_on_status extension is incorrect

2008-09-26 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=45872 Rainer Jung <[EMAIL PROTECTED]> changed: What|Removed |Added Status|NEW |RESOLVED

svn commit: r699234 - /tomcat/tc6.0.x/trunk/java/org/apache/jasper/compiler/Parser.java

2008-09-26 Thread markt
Author: markt Date: Fri Sep 26 02:08:29 2008 New Revision: 699234 URL: http://svn.apache.org/viewvc?rev=699234&view=rev Log: Restore import that is still required (EL patches were applied out of order) Modified: tomcat/tc6.0.x/trunk/java/org/apache/jasper/compiler/Parser.java Modified: tomca

svn commit: r699236 - in /tomcat/tc6.0.x/trunk: STATUS.txt java/org/apache/el/lang/ELSupport.java

2008-09-26 Thread rjung
Author: rjung Date: Fri Sep 26 02:11:17 2008 New Revision: 699236 URL: http://svn.apache.org/viewvc?rev=699236&view=rev Log: Backport r649637: "Remove unused code" in ELSupport.java. Modified: tomcat/tc6.0.x/trunk/STATUS.txt tomcat/tc6.0.x/trunk/java/org/apache/el/lang/ELSupport.java Mod

svn commit: r699258 - in /tomcat/tc6.0.x/trunk: ./ STATUS.txt conf/logging.properties

2008-09-26 Thread markt
Author: markt Date: Fri Sep 26 03:33:55 2008 New Revision: 699258 URL: http://svn.apache.org/viewvc?rev=699258&view=rev Log: Remove the admin app from the logging configuration Modified: tomcat/tc6.0.x/trunk/ (props changed) tomcat/tc6.0.x/trunk/STATUS.txt tomcat/tc6.0.x/trunk/conf/

svn commit: r699260 - in /tomcat/tc6.0.x/trunk: ./ STATUS.txt res/tomcat.nsi webapps/docs/changelog.xml

2008-09-26 Thread markt
Author: markt Date: Fri Sep 26 03:39:42 2008 New Revision: 699260 URL: http://svn.apache.org/viewvc?rev=699260&view=rev Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=45852 Add special handing to the Windows installer for a charset that doesn't follow the standard naming convention.

DO NOT REPLY [Bug 45852] conf/tomcat-users.xml has invalid encoding "cp932".

2008-09-26 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=45852 Mark Thomas <[EMAIL PROTECTED]> changed: What|Removed |Added Status|ASSIGNED|RESOLVED

svn commit: r699287 - in /tomcat/trunk: java/org/apache/catalina/core/ java/org/apache/naming/resources/ webapps/docs/config/

2008-09-26 Thread markt
Author: markt Date: Fri Sep 26 04:56:42 2008 New Revision: 699287 URL: http://svn.apache.org/viewvc?rev=699287&view=rev Log: Allow the maximum allowed size of a resource that is cached to be configured. The default of cacheMaxSize/20 gave too high a value for large caches. Modified: tomcat/t

svn commit: r699296 - in /tomcat/trunk/java/org/apache/catalina/ha/deploy: FarmWarDeployer.java WarWatcher.java

2008-09-26 Thread markt
Author: markt Date: Fri Sep 26 05:20:03 2008 New Revision: 699296 URL: http://svn.apache.org/viewvc?rev=699296&view=rev Log: Code clean up in o.a.c.h.deploy No functional change Modified: tomcat/trunk/java/org/apache/catalina/ha/deploy/FarmWarDeployer.java tomcat/trunk/java/org/apache/cat

DO NOT REPLY [Bug 45285] RESOURCES DECLARED IN PARENT CLASSES ARE NOT INJECTED

2008-09-26 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=45285 Firstname Lastname <[EMAIL PROTECTED]> changed: What|Removed |Added Status|RESOLVED|REOPENED

svn commit: r699427 - in /tomcat/trunk/java/org/apache/catalina/ha/deploy: FarmWarDeployer.java FileMessageFactory.java

2008-09-26 Thread markt
Author: markt Date: Fri Sep 26 10:37:34 2008 New Revision: 699427 URL: http://svn.apache.org/viewvc?rev=699427&view=rev Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=45851 Correct NPE when cluster is defined at engine level Ensure that only 1 thread writes the replicated WAR to disk

DO NOT REPLY [Bug 45851] FarmWarDeployer fails to properly unpack copied war on target node

2008-09-26 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=45851 --- Comment #2 from Mark Thomas <[EMAIL PROTECTED]> 2008-09-26 10:38:56 PST --- I've fixed the issues issues I could see in the FarmWarDeployer. Any additional testing much appreciated. I will propose the fix for inclusion in 6.0.x.

DO NOT REPLY [Bug 45851] FarmWarDeployer fails to properly unpack copied war on target node

2008-09-26 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=45851 --- Comment #3 from Paul McGurn <[EMAIL PROTECTED]> 2008-09-26 10:45:04 PST --- I can definitely test that more. If this ends up in the next point release, I'll upgrade my development environment and test. -- Configure bugmail: http

DO NOT REPLY [Bug 45285] RESOURCES DECLARED IN PARENT CLASSES ARE NOT INJECTED

2008-09-26 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=45285 --- Comment #5 from Mark Thomas <[EMAIL PROTECTED]> 2008-09-26 11:06:26 PST --- Sorry - my bad. The fixed missed the preDestroy and postContruct methods. I'll get that fixed. -- Configure bugmail: https://issues.apache.org/bugzilla/u

svn commit: r699443 - /tomcat/tc6.0.x/trunk/STATUS.txt

2008-09-26 Thread markt
Author: markt Date: Fri Sep 26 11:17:46 2008 New Revision: 699443 URL: http://svn.apache.org/viewvc?rev=699443&view=rev Log: Proposals Modified: tomcat/tc6.0.x/trunk/STATUS.txt Modified: tomcat/tc6.0.x/trunk/STATUS.txt URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=69

Findbugs results when run against Tomcat6

2008-09-26 Thread sebb
Just out of curiosity, I ran Findbugs 1.3.5 on Tomcat 6.0.18. The default settings generated some 1400 warnings about possible bugs. Quite a few of them look serious - assuming that the code which contains them is being used. For example, there are quite a few public static fields which are not

svn commit: r699523 - in /tomcat/trunk: java/org/apache/catalina/mbeans/ webapps/docs/config/

2008-09-26 Thread markt
Author: markt Date: Fri Sep 26 15:20:51 2008 New Revision: 699523 URL: http://svn.apache.org/viewvc?rev=699523&view=rev Log: Add a new listener that enables the JMX ports to be fixed. This makes using jconsole etc through a firewall / SSH tunnel etc. a lot easier. As a bonus, the config docs inc

DO NOT REPLY [Bug 45403] Tomcat does not reload application

2008-09-26 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=45403 Mark Thomas <[EMAIL PROTECTED]> changed: What|Removed |Added Attachment #22478|0 |1 is obso

Re: Findbugs results when run against Tomcat6

2008-09-26 Thread Jim Manico
Findbugs does a real bad job of findings real security bugs - I would recommend running the codebase against Fortify + include the new Cigital rulepack. Or take a look at the results of the Fortify Open Source Analysis project https://opensource.fortify.com/teamserver/welcome.fhtml - Jim Jus

Re: Findbugs results when run against Tomcat6

2008-09-26 Thread Jonathan Holloway
You can also set this up to run as part of the Gump build and get the warnings/errors etc... recorded as part of a standard build. Jon. 2008/9/26 sebb <[EMAIL PROTECTED]> > Just out of curiosity, I ran Findbugs 1.3.5 on Tomcat 6.0.18. The > default settings generated some 1400 warnings about po

svn commit: r699569 - in /tomcat/connectors/trunk/jk: native/iis/jk_isapi_plugin.c xdocs/miscellaneous/changelog.xml

2008-09-26 Thread mturk
Author: mturk Date: Fri Sep 26 23:41:56 2008 New Revision: 699569 URL: http://svn.apache.org/viewvc?rev=699569&view=rev Log: Add INSTANCE_ID to the unique shared memory name Modified: tomcat/connectors/trunk/jk/native/iis/jk_isapi_plugin.c tomcat/connectors/trunk/jk/xdocs/miscellaneous/ch