Re: svn commit: r646605 - /tomcat/tc6.0.x/trunk/STATUS.txt

2008-04-10 Thread Mark Thomas
[EMAIL PROTECTED] wrote: * Clean up type checking code. Patch provided by Konstantin Kolinko. http://svn.apache.org/viewvc?rev=646571&view=rev +1: markt + -0: remm (44766: the first patch http://svn.apache.org/viewvc?rev=646106&view=rev is not mentioned ?) Oversight on my part. I'll do

svn commit: r646667 - /tomcat/tc6.0.x/trunk/STATUS.txt

2008-04-10 Thread markt
Author: markt Date: Thu Apr 10 00:23:03 2008 New Revision: 646667 URL: http://svn.apache.org/viewvc?rev=646667&view=rev Log: Add missing proposal. Modified: tomcat/tc6.0.x/trunk/STATUS.txt Modified: tomcat/tc6.0.x/trunk/STATUS.txt URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATU

svn commit: r646719 - /tomcat/tc6.0.x/trunk/STATUS.txt

2008-04-10 Thread remm
Author: remm Date: Thu Apr 10 02:48:51 2008 New Revision: 646719 URL: http://svn.apache.org/viewvc?rev=646719&view=rev Log: - Votes. Modified: tomcat/tc6.0.x/trunk/STATUS.txt Modified: tomcat/tc6.0.x/trunk/STATUS.txt URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=6467

DO NOT REPLY [Bug 44494] Requests greater than 8k being truncated.

2008-04-10 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=44494 --- Comment #34 from Rainer Jung <[EMAIL PROTECTED]> 2008-04-10 01:59:00 PST --- I tested recent trunk and also 6.x with the latest STATUS file patches for this issue applied. When we change maxHttpHeaderSize from the default to somet

Re: svn commit: r646571 - in /tomcat/trunk/java/org/apache/el: lang/ELArithmetic.java lang/ELSupport.java parser/AstNegative.java

2008-04-10 Thread Remy Maucherat
On Wed, 2008-04-09 at 22:29 +, [EMAIL PROTECTED] wrote: > Author: markt > Date: Wed Apr 9 15:29:28 2008 > New Revision: 646571 > > URL: http://svn.apache.org/viewvc?rev=646571&view=rev > Log: > Clean up type checking code. Patch provided by Konstantin Kolinko. > > Modified: > tomcat/trun

DO NOT REPLY [Bug 44797] New: url-pattern not working as expected.

2008-04-10 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=44797 Summary: url-pattern not working as expected. Product: Tomcat 5 Version: 5.5.26 Platform: PC OS/Version: Linux Status: NEW Severity: normal Priority: P2

svn commit: r646816 - /tomcat/tc6.0.x/trunk/STATUS.txt

2008-04-10 Thread fhanik
Author: fhanik Date: Thu Apr 10 07:24:33 2008 New Revision: 646816 URL: http://svn.apache.org/viewvc?rev=646816&view=rev Log: votes Modified: tomcat/tc6.0.x/trunk/STATUS.txt Modified: tomcat/tc6.0.x/trunk/STATUS.txt URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=64681

DO NOT REPLY [Bug 44494] Requests greater than 8k being truncated.

2008-04-10 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=44494 Ruediger Pluem <[EMAIL PROTECTED]> changed: What|Removed |Added CC||[EMAIL PROTECT

DO NOT REPLY [Bug 44494] Requests greater than 8k being truncated.

2008-04-10 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=44494 --- Comment #35 from Remy Maucherat <[EMAIL PROTECTED]> 2008-04-10 08:05:13 PST --- You've got to be able to reproduce this using the test webapp provided in this report (the line length is configurable, and there's a readLine test). I

DO NOT REPLY [Bug 44494] Requests greater than 8k being truncated.

2008-04-10 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=44494 --- Comment #36 from Rainer Jung <[EMAIL PROTECTED]> 2008-04-10 08:15:03 PST --- I'll try that. For the sake of completeness, here's the exception stack: java.io.IOException at org.apache.catalina.connector.InputBuffer.reset(

DO NOT REPLY [Bug 44494] Requests greater than 8k being truncated.

2008-04-10 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=44494 --- Comment #37 from Rainer Jung <[EMAIL PROTECTED]> 2008-04-10 08:24:21 PST --- Using the war and maxHttpHeaderSize="16384" I did the following test case: Characters size: 17000___ Use MultiByte Character: ( ) yes (

DO NOT REPLY [Bug 44797] url-pattern not working as expected.

2008-04-10 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=44797 Mark Thomas <[EMAIL PROTECTED]> changed: What|Removed |Added Status|NEW |RESOLVED

svn commit: r646889 - /tomcat/trunk/java/org/apache/jasper/runtime/PageContextImpl.java

2008-04-10 Thread markt
Author: markt Date: Thu Apr 10 10:29:23 2008 New Revision: 646889 URL: http://svn.apache.org/viewvc?rev=646889&view=rev Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=44408 Avoid bottleneck by calling the synchronized method only once. Patch provided by Robert Andersson. Modified:

svn commit: r646891 - /tomcat/tc6.0.x/trunk/STATUS.txt

2008-04-10 Thread markt
Author: markt Date: Thu Apr 10 10:32:23 2008 New Revision: 646891 URL: http://svn.apache.org/viewvc?rev=646891&view=rev Log: Propose patch Modified: tomcat/tc6.0.x/trunk/STATUS.txt Modified: tomcat/tc6.0.x/trunk/STATUS.txt URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?re

DO NOT REPLY [Bug 44408] EL-expression evaluation slow due to synchronization caused by JspFactory. getDefaultFactory

2008-04-10 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=44408 --- Comment #2 from Mark Thomas <[EMAIL PROTECTED]> 2008-04-10 10:30:09 PST --- This has been fixed in trunk and proposed for 6.0.x. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are rec

Re: svn commit: r646571 - in /tomcat/trunk/java/org/apache/el: lang/ELArithmetic.java lang/ELSupport.java parser/AstNegative.java

2008-04-10 Thread Mark Thomas
Remy Maucherat wrote: On Wed, 2008-04-09 at 22:29 +, [EMAIL PROTECTED] wrote: Author: markt Date: Wed Apr 9 15:29:28 2008 New Revision: 646571 URL: http://svn.apache.org/viewvc?rev=646571&view=rev Log: Clean up type checking code. Patch provided by Konstantin Kolinko. Modified: tomcat

DO NOT REPLY [Bug 44494] Requests greater than 8k being truncated.

2008-04-10 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=44494 --- Comment #38 from Rainer Jung <[EMAIL PROTECTED]> 2008-04-10 11:25:43 PST --- Since most people are deeper in the code than I, here's what i get if I instrument o.a.c.connector.InputBuffer with a couple of log statements and post th

DO NOT REPLY [Bug 44494] Requests greater than 8k being truncated.

2008-04-10 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=44494 --- Comment #39 from Rainer Jung <[EMAIL PROTECTED]> 2008-04-10 11:41:32 PST --- And the stack in realWriteChars is: at org.apache.catalina.connector.InputBuffer.realWriteChars(InputBuffer. java:335) at org.apache.tomc

DO NOT REPLY [Bug 44801] New: getPathInfo() and getRequestURI() handle %3B incorrectly

2008-04-10 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=44801 Summary: getPathInfo() and getRequestURI() handle %3B incorrectly Product: Tomcat 6 Version: 6.0.16 Platform: PC OS/Version: Windows XP Status: NEW Severity: normal

DO NOT REPLY [Bug 44801] getPathInfo() and getRequestURI() handle %3B incorrectly

2008-04-10 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=44801 Mark Thomas <[EMAIL PROTECTED]> changed: What|Removed |Added Status|NEW |RESOLVED

DO NOT REPLY [Bug 44801] getPathInfo() and getRequestURI() handle %3B incorrectly

2008-04-10 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=44801 --- Comment #2 from Jess Holle <[EMAIL PROTECTED]> 2008-04-10 13:32:45 PST --- Sorry to have jumped the gun on this. As per the user's group thread, it would seem that this is an issue only with Apache. Is there any reasonable way I c

svn commit: r646980 - in /tomcat/trunk/java/org/apache/catalina/ssi: ExpressionParseTree.java SSIExternalResolver.java SSIMediator.java SSIPrintenv.java SSIProcessor.java SSIServletExternalResolver.ja

2008-04-10 Thread markt
Author: markt Date: Thu Apr 10 14:51:57 2008 New Revision: 646980 URL: http://svn.apache.org/viewvc?rev=646980&view=rev Log: Java 5 clean up. No functional change. Modified: tomcat/trunk/java/org/apache/catalina/ssi/ExpressionParseTree.java tomcat/trunk/java/org/apache/catalina/ssi/SSIExt

DO NOT REPLY [Bug 44494] Requests greater than 8k being truncated.

2008-04-10 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=44494 --- Comment #40 from Filip Hanik <[EMAIL PROTECTED]> 2008-04-10 14:56:29 PST --- I think I might have found the problem, I've been unable to reproduce the error using the NIO/APR (APR below) connector with setting I reproduce t

DO NOT REPLY [Bug 41538] Unable to run Tomcat as a Windows service under JDK 1.6

2008-04-10 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=41538 --- Comment #23 from Carlos <[EMAIL PROTECTED]> 2008-04-10 14:59:01 PST --- Hi, In my case, I tried: *adding C:\j2sdk1.4.2_17\bin to the PATH environmental variable *copying the mscvr71.dll file to C:\WINDOWS\system32 directory *Addin

DO NOT REPLY [Bug 44494] Requests greater than 8k being truncated.

2008-04-10 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=44494 --- Comment #41 from Rainer Jung <[EMAIL PROTECTED]> 2008-04-10 15:15:06 PST --- Hi Filip, I didn't yet read your comment, because we both worked in parallel (mid-air collission). I'm posting my finding nevertheless, so we can look fo

DO NOT REPLY [Bug 44494] Requests greater than 8k being truncated.

2008-04-10 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=44494 --- Comment #42 from Filip Hanik <[EMAIL PROTECTED]> 2008-04-10 15:20:00 PST --- If we don't want the simple fix of growing the CharChunk, (since CharChunk will always be <=maxHttpHeaderSize, a character is at least one byte) then the

DO NOT REPLY [Bug 44494] Requests greater than 8k being truncated.

2008-04-10 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=44494 --- Comment #43 from Filip Hanik <[EMAIL PROTECTED]> 2008-04-10 15:21:07 PST --- hi Rainer, both patches do the exact same thing, one explicit one implicit, I'd vote +1 for either or Filip -- Configure bugmail: https://issues.apach

DO NOT REPLY [Bug 44494] Requests greater than 8k being truncated.

2008-04-10 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=44494 --- Comment #44 from Rainer Jung <[EMAIL PROTECTED]> 2008-04-10 15:29:58 PST --- Next mid-air, BZ is obviously not IM :) When I use the test war, the garbage test still seems to fail, even with default maxHttpHeaderSize. The behaviour

JNDIRealm connection pooling

2008-04-10 Thread Brandon DuRette
While trying to track down an issue with logins taking a very long time, I just discovered in the 5.5.26 source code/Javadoc for JNDIRealm (likewise in the 6.0 documentation) that there's a big bold TODO to support connection pooling in the JNDIRealm. I think this may be part of the login problem

DO NOT REPLY [Bug 44804] New: JVM Crash: SIGSEGV Java HotSpot(TM) Server VM (1.6.0_03-b05 mixed mode)

2008-04-10 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=44804 Summary: JVM Crash: SIGSEGV Java HotSpot(TM) Server VM (1.6.0_03- b05 mixed mode) Product: Tomcat 5 Version: 5.5.23 Platform: Sun URL: internal OS/Version:

Re: svn commit: r646571 - in /tomcat/trunk/java/org/apache/el: lang/ELArithmetic.java lang/ELSupport.java parser/AstNegative.java

2008-04-10 Thread Remy Maucherat
On Thu, 2008-04-10 at 19:01 +0100, Mark Thomas wrote: > Remy Maucherat wrote: > > On Wed, 2008-04-09 at 22:29 +, [EMAIL PROTECTED] wrote: > >> Author: markt > >> Date: Wed Apr 9 15:29:28 2008 > >> New Revision: 646571 > >> > >> URL: http://svn.apache.org/viewvc?rev=646571&view=rev > >> Log: >

DO NOT REPLY [Bug 44494] Requests greater than 8k being truncated.

2008-04-10 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=44494 --- Comment #45 from Suzuki Yuichiro <[EMAIL PROTECTED]> 2008-04-10 21:26:03 PST --- Hi, The behavior of the test case with default values is as follows. 1. It posts 8192 multibytes characters. 2. The posted data is read up to 4096

svn commit: r647056 - /tomcat/connectors/trunk/jk/native/common/jk_ajp_common.c

2008-04-10 Thread mturk
Author: mturk Date: Thu Apr 10 22:51:52 2008 New Revision: 647056 URL: http://svn.apache.org/viewvc?rev=647056&view=rev Log: Don't log ajp_connection_tcp_get_message failure as ERROR. This can be part of normal operation caused by cping/cpong. We are later logging that either as INFO in handle_c

DO NOT REPLY [Bug 44804] JVM Crash: SIGSEGV Java HotSpot(TM) Server VM (1.6 .0_03-b05 mixed mode)

2008-04-10 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=44804 Mark Thomas <[EMAIL PROTECTED]> changed: What|Removed |Added Severity|blocker |major