DO NOT REPLY [Bug 44620] infinit loop in nio connector code

2008-03-21 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=44620 --- Comment #5 from tangy <[EMAIL PROTECTED]> 2008-03-21 00:02:24 PST --- Sorry for that I do not express it clearly(We made some mistake in it). Since our application will cause the following problem: 2008-3-21 14:54:12 org.apache.cat

DO NOT REPLY [Bug 44620] infinit loop in nio connector code

2008-03-21 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=44620 --- Comment #6 from tangy <[EMAIL PROTECTED]> 2008-03-21 00:04:36 PST --- sorry for typed mistake: we changed the server.xml and set maxHttpHeaderSize="1024" , should be we changed the server.xml and set maxHttpHeaderSize="10240

Cookies are broken in 6.0.16?

2008-03-21 Thread Olivier Jaquemet
Hi all, This is a follow up to thread "Cookies are broken in 6.0.16?" http://marc.info/?t=12025394451&r=2&w=2 Before submitting a bug report on the matter exposed below I wanted to open a discussion with Tomcat developpers about it. Summary of the above thread : - Problem : If a webapp is

Re: Cookies are broken in 6.0.16?

2008-03-21 Thread Mark Thomas
Olivier Jaquemet wrote: So my questions are : - What could be done in Tomcat to fix this ? This has been discussed extensively on the dev list and there is a patch proposed. See the archives for details. - Is the security problem real if it is why do other application server vendors do not h

Re: Cookies are broken in 6.0.16?

2008-03-21 Thread Olivier Jaquemet
Thank you for your answer Mark. Accept my apologies for bothering you with already fixed issues. I had not found the appropriate discussions in the archive. Olivier Mark Thomas wrote: Olivier Jaquemet wrote: So my questions are : - What could be done in Tomcat to fix this ? This has been dis

Re: renaming jar files

2008-03-21 Thread Filip Hanik - Dev Lists
Costin Manolache wrote: What's the current status of commons-logging versus juli/logging ? Do we still need the dep ? in 5.5 we still support commoons logging, in 6.0, no more unless you build the adapter from the extras package Speaking of deps - I'm completely confused by tomcat-dbcp.jar -

DO NOT REPLY [Bug 44494] Requests greater than 8k being truncated.

2008-03-21 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=44494 --- Comment #17 from Filip Hanik <[EMAIL PROTECTED]> 2008-03-21 08:48:11 PST --- (In reply to comment #15) > Remy and Filip, thank you for immediate checks. > > Yes, the logic is same in all of them. > > (In reply to comment #11, #1

Re: Cookies are broken in 6.0.16?

2008-03-21 Thread Olivier Jaquemet
One last question Mark... The tc6.6.x trunk has the patch and it works fine, but not yet the tc5.5.x. Is it planned for the next 5.5.x release ? Olivier Jaquemet wrote: Thank you for your answer Mark. Accept my apologies for bothering you with already fixed issues. I had not found the appropria

Re: Cookies are broken in 6.0.16?

2008-03-21 Thread Filip Hanik - Dev Lists
even the 6.0.x needs one more patch in order to be backwards compatible Filip Olivier Jaquemet wrote: One last question Mark... The tc6.6.x trunk has the patch and it works fine, but not yet the tc5.5.x. Is it planned for the next 5.5.x release ? Olivier Jaquemet wrote: Thank you for your a

Re: svn commit: r639046 - /tomcat/tc6.0.x/trunk/STATUS.txt

2008-03-21 Thread Filip Hanik - Dev Lists
Remy Maucherat wrote: On Wed, 2008-03-19 at 18:17 -0600, Filip Hanik - Dev Lists wrote: Remy Maucherat wrote: On Wed, 2008-03-19 at 22:43 +, [EMAIL PROTECTED] wrote: +1 : remm, markt - -1 : fhanik - I tried this patch, and it doesn't work, it hangs. I also saw the bu

DO NOT REPLY [Bug 44494] Requests greater than 8k being truncated.

2008-03-21 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=44494 --- Comment #18 from Filip Hanik <[EMAIL PROTECTED]> 2008-03-21 10:24:06 PST --- I posted to the dev lists about this, basically, one can just take advantage of java.io.BufferedReader to do the caching public void doFilter(Servlet

Re: svn commit: r639046 - /tomcat/tc6.0.x/trunk/STATUS.txt

2008-03-21 Thread Remy Maucherat
On Fri, 2008-03-21 at 11:25 -0600, Filip Hanik - Dev Lists wrote: > what this filter does, is it relies on the already implemented > BufferedReader, no need to reinvent the wheel. > The java.io.BufferedReader, already has this logic implemented, and it > works, so CoyoteReader, will only be treat

DO NOT REPLY [Bug 44494] Requests greater than 8k being truncated.

2008-03-21 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=44494 Remy Maucherat <[EMAIL PROTECTED]> changed: What|Removed |Added Status|ASSIGNED|NEEDINFO -

svn commit: r639771 - /tomcat/trunk/conf/web.xml

2008-03-21 Thread markt
Author: markt Date: Fri Mar 21 12:29:35 2008 New Revision: 639771 URL: http://svn.apache.org/viewvc?rev=639771&view=rev Log: No longer need to rename jars for CGI or SSI. Modified: tomcat/trunk/conf/web.xml Modified: tomcat/trunk/conf/web.xml URL: http://svn.apache.org/viewvc/tomcat/trunk/c

svn commit: r639772 - /tomcat/tc6.0.x/trunk/STATUS.txt

2008-03-21 Thread markt
Author: markt Date: Fri Mar 21 12:32:03 2008 New Revision: 639772 URL: http://svn.apache.org/viewvc?rev=639772&view=rev Log: Propose another patch Modified: tomcat/tc6.0.x/trunk/STATUS.txt Modified: tomcat/tc6.0.x/trunk/STATUS.txt URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATU

Re: svn commit: r639046 - /tomcat/tc6.0.x/trunk/STATUS.txt

2008-03-21 Thread Filip Hanik - Dev Lists
Remy Maucherat wrote: On Fri, 2008-03-21 at 11:25 -0600, Filip Hanik - Dev Lists wrote: what this filter does, is it relies on the already implemented BufferedReader, no need to reinvent the wheel. The java.io.BufferedReader, already has this logic implemented, and it works, so CoyoteReader,

Re: svn commit: r639046 - /tomcat/tc6.0.x/trunk/STATUS.txt

2008-03-21 Thread Remy Maucherat
On Fri, 2008-03-21 at 14:29 -0600, Filip Hanik - Dev Lists wrote: > I'd prefer to move forward with just the truncation fix so that we can > move towards a release. > > Any other efforts can be postponed at this time. If the mark/reset bug > in fact exists, there is an easy work around, and that

svn commit: r639842 - /tomcat/trunk/webapps/docs/jndi-datasource-examples-howto.xml

2008-03-21 Thread markt
Author: markt Date: Fri Mar 21 14:08:36 2008 New Revision: 639842 URL: http://svn.apache.org/viewvc?rev=639842&view=rev Log: maxActive setting for unlimited changed in commons-pool > 1.2 Modified: tomcat/trunk/webapps/docs/jndi-datasource-examples-howto.xml Modified: tomcat/trunk/webapps/doc

svn commit: r639844 - /tomcat/tc6.0.x/trunk/STATUS.txt

2008-03-21 Thread markt
Author: markt Date: Fri Mar 21 14:11:19 2008 New Revision: 639844 URL: http://svn.apache.org/viewvc?rev=639844&view=rev Log: Propose doc fix Modified: tomcat/tc6.0.x/trunk/STATUS.txt Modified: tomcat/tc6.0.x/trunk/STATUS.txt URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?

svn commit: r639845 - /tomcat/current/tc5.5.x/STATUS.txt

2008-03-21 Thread markt
Author: markt Date: Fri Mar 21 14:11:35 2008 New Revision: 639845 URL: http://svn.apache.org/viewvc?rev=639845&view=rev Log: Propose doc fix Modified: tomcat/current/tc5.5.x/STATUS.txt Modified: tomcat/current/tc5.5.x/STATUS.txt URL: http://svn.apache.org/viewvc/tomcat/current/tc5.5.x/STATU

svn commit: r639846 - /tomcat/current/tc4.1.x/STATUS.txt

2008-03-21 Thread markt
Author: markt Date: Fri Mar 21 14:11:46 2008 New Revision: 639846 URL: http://svn.apache.org/viewvc?rev=639846&view=rev Log: Propose doc fix Modified: tomcat/current/tc4.1.x/STATUS.txt Modified: tomcat/current/tc4.1.x/STATUS.txt URL: http://svn.apache.org/viewvc/tomcat/current/tc4.1.x/STATU

Re: svn commit: r639046 - /tomcat/tc6.0.x/trunk/STATUS.txt

2008-03-21 Thread Filip Hanik - Dev Lists
Remy Maucherat wrote: On Fri, 2008-03-21 at 14:29 -0600, Filip Hanik - Dev Lists wrote: I'd prefer to move forward with just the truncation fix so that we can move towards a release. Any other efforts can be postponed at this time. If the mark/reset bug in fact exists, there is an easy wor

Re: svn commit: r639046 - /tomcat/tc6.0.x/trunk/STATUS.txt

2008-03-21 Thread Remy Maucherat
On Fri, 2008-03-21 at 15:19 -0600, Filip Hanik - Dev Lists wrote: > Remy Maucherat wrote: > regression, the fact that you can't read more than 8k when using > ServletRequest.getReader I proposed a patch for that. If it doesn't fix it with the patch I proposed applied, I would need some test cases

Re: svn commit: r639046 - /tomcat/tc6.0.x/trunk/STATUS.txt

2008-03-21 Thread Mark Thomas
Remy Maucherat wrote: On Fri, 2008-03-21 at 15:19 -0600, Filip Hanik - Dev Lists wrote: Remy Maucherat wrote: regression, the fact that you can't read more than 8k when using ServletRequest.getReader I proposed a patch for that. If it doesn't fix it with the patch I proposed applied, I would

Re: svn commit: r639046 - /tomcat/tc6.0.x/trunk/STATUS.txt

2008-03-21 Thread Filip Hanik - Dev Lists
Remy Maucherat wrote: On Fri, 2008-03-21 at 15:19 -0600, Filip Hanik - Dev Lists wrote: Remy Maucherat wrote: regression, the fact that you can't read more than 8k when using ServletRequest.getReader I proposed a patch for that. If it doesn't fix it with the patch I proposed applied,

svn commit: r639891 - in /tomcat/tc6.0.x/trunk: STATUS.txt java/org/apache/catalina/connector/InputBuffer.java webapps/docs/changelog.xml

2008-03-21 Thread remm
Author: remm Date: Fri Mar 21 15:22:56 2008 New Revision: 639891 URL: http://svn.apache.org/viewvc?rev=639891&view=rev Log: - 44494: patch for 8KB character input. - Votes. Modified: tomcat/tc6.0.x/trunk/STATUS.txt tomcat/tc6.0.x/trunk/java/org/apache/catalina/connector/InputBuffer.java

Re: svn commit: r639046 - /tomcat/tc6.0.x/trunk/STATUS.txt

2008-03-21 Thread Remy Maucherat
On Fri, 2008-03-21 at 21:44 +, Mark Thomas wrote: > The cookies patch is short and you haven't voted yet so if you > could find the time to review the cookies patch we could get to agreed > fixes for both issues quite quickly. I did get lost somewhere between the new new patch and the new ne

svn commit: r639909 - in /tomcat/tc6.0.x/trunk: STATUS.txt java/org/apache/tomcat/util/http/ServerCookie.java

2008-03-21 Thread fhanik
Author: fhanik Date: Fri Mar 21 16:29:17 2008 New Revision: 639909 URL: http://svn.apache.org/viewvc?rev=639909&view=rev Log: only make version switch on cookie value Modified: tomcat/tc6.0.x/trunk/STATUS.txt tomcat/tc6.0.x/trunk/java/org/apache/tomcat/util/http/ServerCookie.java Modifie

svn commit: r639910 - /tomcat/tc6.0.x/trunk/STATUS.txt

2008-03-21 Thread fhanik
Author: fhanik Date: Fri Mar 21 16:30:48 2008 New Revision: 639910 URL: http://svn.apache.org/viewvc?rev=639910&view=rev Log: votes Modified: tomcat/tc6.0.x/trunk/STATUS.txt Modified: tomcat/tc6.0.x/trunk/STATUS.txt URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=63991

svn commit: r639919 - /tomcat/tc6.0.x/trunk/STATUS.txt

2008-03-21 Thread markt
Author: markt Date: Fri Mar 21 16:49:17 2008 New Revision: 639919 URL: http://svn.apache.org/viewvc?rev=639919&view=rev Log: Must remember to vote for my own proposals. Modified: tomcat/tc6.0.x/trunk/STATUS.txt Modified: tomcat/tc6.0.x/trunk/STATUS.txt URL: http://svn.apache.org/viewvc/tomc

svn commit: r639920 - in /tomcat/tc6.0.x/trunk: STATUS.txt webapps/ROOT/admin/

2008-03-21 Thread markt
Author: markt Date: Fri Mar 21 16:50:39 2008 New Revision: 639920 URL: http://svn.apache.org/viewvc?rev=639920&view=rev Log: Remove reference to admin application. Removed: tomcat/tc6.0.x/trunk/webapps/ROOT/admin/ Modified: tomcat/tc6.0.x/trunk/STATUS.txt Modified: tomcat/tc6.0.x/trunk/S