svn commit: r479939 - /tomcat/connectors/trunk/jk/native/common/jk_status.c

2006-11-28 Thread pero
Author: pero Date: Tue Nov 28 00:12:13 2006 New Revision: 479939 URL: http://svn.apache.org/viewvc?view=rev&rev=479939 Log: Fix correct table formating at 'Edit worker dialog' Modified: tomcat/connectors/trunk/jk/native/common/jk_status.c Modified: tomcat/connectors/trunk/jk/native/common/jk

svn commit: r479953 - /tomcat/tc6.0.x/trunk/webapps/docs/apr.xml

2006-11-28 Thread mturk
Author: mturk Date: Tue Nov 28 00:51:21 2006 New Revision: 479953 URL: http://svn.apache.org/viewvc?view=rev&rev=479953 Log: Fix example AprSLL. We have a new param SSLEnabled. Modified: tomcat/tc6.0.x/trunk/webapps/docs/apr.xml Modified: tomcat/tc6.0.x/trunk/webapps/docs/apr.xml URL: http:

Tomcat web site admin problems.

2006-11-28 Thread Mladen Turk
Remy, Can you change the permissions for the files in /x1/www/tomcat.apache.org/tomcat-6.0-doc-v6.0.2 from 0644 to 0664? Add group write permission, so other can modify the docs. I know, it's a version related, but we should not create a new tag if there is error in the docs thought. Regards, M

svn commit: r479961 - /tomcat/connectors/trunk/jk/native/common/jk_status.c

2006-11-28 Thread rjung
Author: rjung Date: Tue Nov 28 01:33:48 2006 New Revision: 479961 URL: http://svn.apache.org/viewvc?view=rev&rev=479961 Log: Fix compiler warnings. Modified: tomcat/connectors/trunk/jk/native/common/jk_status.c Modified: tomcat/connectors/trunk/jk/native/common/jk_status.c URL: http://svn.a

svn commit: r479963 - /tomcat/connectors/trunk/jk/native/common/jk_status.c

2006-11-28 Thread rjung
Author: rjung Date: Tue Nov 28 01:44:04 2006 New Revision: 479963 URL: http://svn.apache.org/viewvc?view=rev&rev=479963 Log: Adding "back" links to the form views (edit) of the status worker. Modified: tomcat/connectors/trunk/jk/native/common/jk_status.c Modified: tomcat/connectors/trunk/jk/

DO NOT REPLY [Bug 41016] - tomcat 5.5 multiple contexts using same realm bug

2006-11-28 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT . ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bu

svn commit: r479965 - /tomcat/connectors/trunk/jni/native/src/ssl.c

2006-11-28 Thread mturk
Author: mturk Date: Tue Nov 28 01:47:42 2006 New Revision: 479965 URL: http://svn.apache.org/viewvc?view=rev&rev=479965 Log: The AprLifecycleListener depend on the SSL.initialize throwing exception. Make sure exception is thrown together with error code returned. Modified: tomcat/connectors/t

svn commit: r479966 - /tomcat/connectors/trunk/jni/native/src/sslnetwork.c

2006-11-28 Thread mturk
Author: mturk Date: Tue Nov 28 01:48:30 2006 New Revision: 479966 URL: http://svn.apache.org/viewvc?view=rev&rev=479966 Log: Add missing stub for SSLSocket.handskake if the OpenSSL was not compiled in. Modified: tomcat/connectors/trunk/jni/native/src/sslnetwork.c Modified: tomcat/connectors/

svn commit: r479969 - /tomcat/connectors/trunk/jk/native/common/jk_status.c

2006-11-28 Thread rjung
Author: rjung Date: Tue Nov 28 01:56:10 2006 New Revision: 479969 URL: http://svn.apache.org/viewvc?view=rev&rev=479969 Log: Add easier to detect result message to the end of status worker output. Should help with automation. Modified: tomcat/connectors/trunk/jk/native/common/jk_status.c Mod

svn commit: r479995 - /tomcat/tc6.0.x/trunk/java/org/apache/catalina/core/AprLifecycleListener.java

2006-11-28 Thread mturk
Author: mturk Date: Tue Nov 28 03:21:38 2006 New Revision: 479995 URL: http://svn.apache.org/viewvc?view=rev&rev=479995 Log: Refactor AprLifecycleListener by putting the logic into separate methods. 1. Do not call terminate in case initialize failed 2. Call terminate if version is below required.

svn commit: r480000 - /tomcat/tc6.0.x/trunk/java/org/apache/catalina/connector/Connector.java

2006-11-28 Thread mturk
Author: mturk Date: Tue Nov 28 03:31:04 2006 New Revision: 48 URL: http://svn.apache.org/viewvc?view=rev&rev=48 Log: Avoid initializing APR for each connector. Also test the minimum version required. Modified: tomcat/tc6.0.x/trunk/java/org/apache/catalina/connector/Connector.java Mod

[TC6] Minimum coding style

2006-11-28 Thread Mladen Turk
Hi, Just committed two files, and again I've bumped upon the coding style. Although it seems we are quite good relating to the tabs, the trailing spaces are a real mess in some files. There are lots of files where we have if (...) { followed with the one or more spaces. Also there are lots empty

Re: [TC6] Minimum coding style

2006-11-28 Thread Remy Maucherat
Mladen Turk wrote: Hi, Just committed two files, and again I've bumped upon the coding style. Although it seems we are quite good relating to the tabs, the trailing spaces are a real mess in some files. There are lots of files where we have if (...) { followed with the one or more spaces. Also t

Re: [TC6] Minimum coding style

2006-11-28 Thread Mladen Turk
Remy Maucherat wrote: Mladen Turk wrote: Comments? -1. This will screw up diffs, and these really irrelevant things will be added back very quickly. Tabs is one thing since it can be hard to work with, but this is simply ridiculous. Right, but at least the empty lines with spaces are very

Re: [TC6] Minimum coding style

2006-11-28 Thread Remy Maucherat
Mladen Turk wrote: Also, I love the Filip style (sorry if that doesn't originates from you): for example, MessageDispatchInterceptor: }//end if }//sync }//end if Now, that is what I call ridiculous. Nice comment :( And what if he likes it and it makes his programming easier ? -

Re: [TC6] Minimum coding style

2006-11-28 Thread Filip Hanik - Dev Lists
Mladen Turk wrote: Remy Maucherat wrote: Mladen Turk wrote: Comments? -1. This will screw up diffs, and these really irrelevant things will be added back very quickly. Tabs is one thing since it can be hard to work with, but this is simply ridiculous. Right, but at least the empty lines

Re: [TC6] Minimum coding style

2006-11-28 Thread Mladen Turk
Remy Maucherat wrote: -1 for enforcing any coding style (except tabs, since it can make code unreadable very easily). You must be joking, right? Regards, Mladen. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional

Re: [TC6] Minimum coding style

2006-11-28 Thread Jim Jagielski
On Nov 28, 2006, at 9:36 AM, Mladen Turk wrote: Remy Maucherat wrote: -1 for enforcing any coding style (except tabs, since it can make code unreadable very easily). You must be joking, right? One hopes... - To unsub

Re: [TC6] Minimum coding style

2006-11-28 Thread Tim Funk
+1 trailing spaces always annoy me and text editors can easily be configured to strip them out. An alternative is to change the email diffs to diff ignoring whitespace changes. Then lines can have all the trailing spaces they want and we won't see those diffs. -Tim Mladen Turk wrote: Hi,

DO NOT REPLY [Bug 37869] - Cannot obtain client certificate with SSL / client certificate authentication using APR components

2006-11-28 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT . ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bu

Re: [TC6] Minimum coding style

2006-11-28 Thread Remy Maucherat
Jim Jagielski wrote: On Nov 28, 2006, at 9:36 AM, Mladen Turk wrote: Remy Maucherat wrote: -1 for enforcing any coding style (except tabs, since it can make code unreadable very easily). You must be joking, right? One hopes... Why ? Because arbitrary rules only create tensions ? It's

Re: [TC6] Minimum coding style

2006-11-28 Thread Jim Jagielski
On Nov 28, 2006, at 10:44 AM, Remy Maucherat wrote: Jim Jagielski wrote: On Nov 28, 2006, at 9:36 AM, Mladen Turk wrote: Remy Maucherat wrote: -1 for enforcing any coding style (except tabs, since it can make code unreadable very easily). You must be joking, right? One hopes... Why

Re: [TC6] Minimum coding style

2006-11-28 Thread Remy Maucherat
Jim Jagielski wrote: I'm a firm believer in the One True Tab, but I lost that battle lng ago :) Yes, I used to push for one coding style a long time ago, but it's not going to happen (I figured it was better to collaborate with Costin rather than keep the "clean" - ahem - coding style and

Re: [TC6] Minimum coding style

2006-11-28 Thread Henri Gomez
I remember the cold days of the 'Tab brigade' :) 2006/11/28, Remy Maucherat <[EMAIL PROTECTED]>: Jim Jagielski wrote: > I'm a firm believer in the One True Tab, but I lost that > battle lng ago :) Yes, I used to push for one coding style a long time ago, but it's not going to happen (I figu

DO NOT REPLY [Bug 37869] - Cannot obtain client certificate with SSL / client certificate authentication using APR components

2006-11-28 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT . ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bu

Re: DO NOT REPLY [Bug 39120] - Create semantics for "path" attribute in embedded context.xml

2006-11-28 Thread Kris Nuttycombe
Hi, Mark, Thanks for your reply. Perhaps I should be stating the problem in terms of how I would like to be able to deploy a web application and what was possible under 5.0 instead of in terms of the problems I have encountered. Here is what I would like to do: I have a warfile, myapp-1.3.5.war

DO NOT REPLY [Bug 41057] New: - Tomcat leaks memory on every request

2006-11-28 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT . ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bu

DO NOT REPLY [Bug 41057] - Tomcat leaks memory on every request

2006-11-28 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT . ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bu

DO NOT REPLY [Bug 41051] - Keystore alias shouldn't be case sensitive

2006-11-28 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT . ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bu

DO NOT REPLY [Bug 40668] - MailSessionFactory is missing in Tomcat 5.5.20

2006-11-28 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT . ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bu

DO NOT REPLY [Bug 41059] New: - WebAppClassLoader clearReferences code break running threads

2006-11-28 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT . ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bu

Re: [TC6] Minimum coding style

2006-11-28 Thread Mladen Turk
Henri Gomez wrote: I remember the cold days of the 'Tab brigade' :) Right. Anyhow, the point of my post was 'minimal', and removing the trailing spaces. It seems that the trailing spaces are very important, so fine with me. Cheers, Mladen. --

DO NOT REPLY [Bug 41051] - Keystore alias shouldn't be case sensitive

2006-11-28 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT . ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bu

DO NOT REPLY [Bug 41051] - Keystore alias shouldn't be case sensitive

2006-11-28 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT . ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bu

Re: [TC6] Minimum coding style

2006-11-28 Thread Rainer Jung
>From a very personal view I'm tempted to share Mladens dislike of trailing spaces. If I try to express, why I don't like them, then it all comes back to diffs. Trailing spaces increase the potential of diff lines with no functional differences. Nevertheless one wastes time to check very carefully

Re: [TC6] Minimum coding style

2006-11-28 Thread Darryl Miles
Just in case people didn't know, diff does have a number of options to modify white space behavior, such that you can check in a massive whitespace cleanup patch but still view a clean diff which ignores blank lines, crlf/lf and leading/trailing whitespace, etc... So really its not that bad. Wi

Re: [TC6] Minimum coding style

2006-11-28 Thread Kris Nuttycombe
Darryl Miles wrote: Just in case people didn't know, diff does have a number of options to modify white space behavior, such that you can check in a massive whitespace cleanup patch but still view a clean diff which ignores blank lines, crlf/lf and leading/trailing whitespace, etc... So really i

DO NOT REPLY [Bug 41057] - Tomcat leaks memory on every request

2006-11-28 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT . ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bu

DO NOT REPLY [Bug 41059] - WebAppClassLoader clearReferences code break running threads

2006-11-28 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT . ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bu

DO NOT REPLY [Bug 41059] - WebAppClassLoader clearReferences code break running threads

2006-11-28 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT . ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bu

DO NOT REPLY [Bug 41057] - Tomcat leaks memory on every request

2006-11-28 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT . ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bu

svn commit: r480302 - /tomcat/tc6.0.x/trunk/java/org/apache/tomcat/util/buf/StringCache.java

2006-11-28 Thread remm
Author: remm Date: Tue Nov 28 16:30:07 2006 New Revision: 480302 URL: http://svn.apache.org/viewvc?view=rev&rev=480302 Log: - 41057: Caching large strings uses too much memory and is a bit pointless, so add an upper bound to the String length. Modified: tomcat/tc6.0.x/trunk/java/org/apache/t

DO NOT REPLY [Bug 41034] - Classloader leak caused by request recycle

2006-11-28 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT . ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bu

DO NOT REPLY [Bug 40809] - Tomcat 5.5.20 fails to load ServletContextListener in tld!

2006-11-28 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT . ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bu

svn commit: r480346 - /tomcat/tc6.0.x/trunk/java/org/apache/catalina/startup/TldConfig.java

2006-11-28 Thread remm
Author: remm Date: Tue Nov 28 18:39:45 2006 New Revision: 480346 URL: http://svn.apache.org/viewvc?view=rev&rev=480346 Log: - Update JAR list for no-tld-scan. Modified: tomcat/tc6.0.x/trunk/java/org/apache/catalina/startup/TldConfig.java Modified: tomcat/tc6.0.x/trunk/java/org/apache/catalin

DO NOT REPLY [Bug 41051] - Keystore alias shouldn't be case sensitive

2006-11-28 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT . ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bu

DO NOT REPLY [Bug 41051] - Keystore alias shouldn't be case sensitive

2006-11-28 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT . ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bu

DO NOT REPLY [Bug 41051] - Keystore alias shouldn't be case sensitive

2006-11-28 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT . ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bu

DO NOT REPLY [Bug 41051] - Keystore alias shouldn't be case sensitive

2006-11-28 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT . ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bu

DO NOT REPLY [Bug 41051] - Keystore alias shouldn't be case sensitive

2006-11-28 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT . ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bu

adding communication between mod_jk and servlet code

2006-11-28 Thread Chris Lamprecht
Hi all, I previously submitted the lb 'busyness' patch for mod_jk, and it has worked well for us. Now we need some additional functionality from mod_jk and I'd like to get feedback here first before I start patching. I'd prefer to implement something that is generally useful to others, and submi

DO NOT REPLY [Bug 41051] - Keystore alias shouldn't be case sensitive

2006-11-28 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT . ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bu