Re: new access log valve implementation

2007-01-06 Thread Remy Maucherat
Peter Rossbach wrote: Good news, please, open a bug report with the a AccessLogValve patch. It looks good enough to me right now. Now there's the question of potentially replacing the other access log valves, since it provides a superset of the functionality (the other valves - except the E

Re: new access log valve implementation

2007-01-06 Thread Peter Rossbach
Good news, please, open a bug report with the a AccessLogValve patch. Thanks Peter Am 06.01.2007 um 09:00 schrieb Takayuki Kaneko: Hi, I modified AccessLogValve in about five points. 1) use buffering like FastCommonAccessLogValve 2) generate the date character string on each 1000ms like Fa

Re: new access log valve implementation

2007-01-06 Thread Takayuki Kaneko
Hi, I modified AccessLogValve in about five points. 1) use buffering like FastCommonAccessLogValve 2) generate the date character string on each 1000ms like FastCommonAccessLogValve 3) move the parsing pattern into the initail phase, it was executed on each requst 4) manage "common" and "combine

Re: new access log valve implementation

2007-01-05 Thread Remy Maucherat
Takayuki Kaneko wrote: So, I made the new one. Not bad, the pattern processing is very cheap (that's the only addition, basically), so it's the same performance as the fast valve. I like it. Rémy - To unsubscribe, e-mail:

Re: new access log valve implementation

2007-01-05 Thread Yoav Shapira
Hi, On 1/5/07, Robert McKay <[EMAIL PROTECTED]> wrote: On 1/5/07, Takayuki Kaneko <[EMAIL PROTECTED]> wrote: > Hi Tomcat developers, > > I made 'FastAccessLogValve' that was modified and tuned based on AccessLogValve. > It can output any log element specified by the pattern string like > Access

Re: new access log valve implementation

2007-01-05 Thread Mladen Turk
Takayuki Kaneko wrote: Is this beneficial? I doubt. The same could be done by simply buffering the log and then flushing to the disk on overflow. Is it beneficial? No, its misleading, because you will never know if your log data is the correct one or there is something in the write buffer wai

Re: new access log valve implementation

2007-01-05 Thread Remy Maucherat
Robert McKay wrote: non-blocking write() ??? Ok, so you get to point out where a non blocking write is made in AccessLogValve. Personally, I think it would be wise to consider upgrading certain components of your system, starting with the OS and the JVM. Rémy

Re: new access log valve implementation

2007-01-05 Thread Robert McKay
On 1/5/07, Takayuki Kaneko <[EMAIL PROTECTED]> wrote: Hi Tomcat developers, I made 'FastAccessLogValve' that was modified and tuned based on AccessLogValve. It can output any log element specified by the pattern string like AccessLogValve. And it is as fast as FastCommonAccessLogValve. I made a