Re: Tomcat 7 & regex

2010-12-29 Thread Henri Yandell
May I suggest you emit a warning to the logs when comma is used in the regexp for a few versions? Hen On Fri, Dec 24, 2010 at 10:34 AM, Mark Thomas wrote: > There are a number of configuration properties defined as "comma > separated regular expressions". As someone pointed out at at ApacheCon >

Re: Tomcat 7 & regex

2010-12-27 Thread Rainer Jung
On 27.12.2010 21:22, Christopher Schultz wrote: So the plan would be to have users convert values like this: 127\.0\.0\.1, 10\.10\.10\.1, 192\.168\.1\.[0-9]+ to this: (127\.0\.0\.1|10\.10\.10\.1|192\.168\.1\.[0-9]+) which is equivalent to 127\.0\.0\.1|10\.10\.10\.1|192\.168\.1\.[0-9]+ if w

Re: Tomcat 7 & regex

2010-12-27 Thread Christopher Schultz
Tim, On 12/25/2010 3:34 PM, Tim Funk wrote: > I am thinking from an admin point of view. While you can combine OR > conditionals in regex's - when you get something more complicated - you > may encounter a nasty nesting of () to get all the nested OR's correct. One can always use more, simpler |

Re: Tomcat 7 & regex

2010-12-27 Thread Christopher Schultz
Mark, On 12/24/2010 1:34 PM, Mark Thomas wrote: > There are a number of configuration properties defined as "comma > separated regular expressions". As someone pointed out at at ApacheCon > that is a little odd. It stops "," being used in an expression and is > inefficient. A comma can still be u

Re: Tomcat 7 & regex

2010-12-27 Thread Rainer Jung
On 25.12.2010 20:53, Mark Thomas wrote: On 25/12/2010 01:49, Tim Funk wrote: +0.5 - I wonder if in some cases - it may be preferable to use a property called split which lets the user define the separator which we can pass to String.split(). [Which OTOH may be more confusing (yet powerful) since

Re: Tomcat 7 & regex

2010-12-25 Thread Daniel Baktiar
+1 i like the approach toward standard regex. ones that use it most likely will be sysadmins, so they should at least know how to use regex in their tools like shell, awk, perl, python or powershell. it will be nice if the standard regex is in place. --- daniel baktiar http://savinggaia.tritiumapp

Re: Tomcat 7 & regex

2010-12-25 Thread Tim Funk
I am thinking from an admin point of view. While you can combine OR conditionals in regex's - when you get something more complicated - you may encounter a nasty nesting of () to get all the nested OR's correct. So while one COULD to it in a single regex - most mere mortals might not be able to

Re: Tomcat 7 & regex

2010-12-25 Thread Mark Thomas
On 25/12/2010 13:37, Konstantin Kolinko wrote: > 1) It it were configurable, in certain places it makes sense to use > space as a separator (e.g. in IP addresses). > -> any whitespace? -> \w+ and we end up with using a regex to split a > list of regexes. Yes, space could work but I'd rather stick

Re: Tomcat 7 & regex

2010-12-25 Thread Mark Thomas
On 25/12/2010 01:49, Tim Funk wrote: > +0.5 - I wonder if in some cases - it may be preferable to use a > property called split which lets the user define the separator which we > can pass to String.split(). [Which OTOH may be more confusing (yet > powerful) since the user is using a regex to split

Re: Tomcat 7 & regex

2010-12-25 Thread Konstantin Kolinko
1) It it were configurable, in certain places it makes sense to use space as a separator (e.g. in IP addresses). -> any whitespace? -> \w+ and we end up with using a regex to split a list of regexes. 2) It might make sense to require regex expressions to be surrounded by '/'. E.g. "/192\.168\.1\.

Re: Tomcat 7 & regex

2010-12-24 Thread Tim Funk
+0.5 - I wonder if in some cases - it may be preferable to use a property called split which lets the user define the separator which we can pass to String.split(). [Which OTOH may be more confusing (yet powerful) since the user is using a regex to split get a list of regex] -Tim On 12/24/201

Tomcat 7 & regex

2010-12-24 Thread Mark Thomas
There are a number of configuration properties defined as "comma separated regular expressions". As someone pointed out at at ApacheCon that is a little odd. It stops "," being used in an expression and is inefficient. Having just been bitten by this while setting up the new Jira instance, I inten