Re: State of affairs for mod_jk 1.2.20

2006-11-27 Thread Jim Jagielski
On Nov 24, 2006, at 3:06 PM, Mladen Turk wrote: Rainer Jung wrote: In my opinion the only change is: - old code: retries=2 means first try to close all conns and second try with new connection - new code: retries=2 means first try to close all conns and immediate new conn, second try a "

Re: State of affairs for mod_jk 1.2.20

2006-11-24 Thread Rainer Jung
OK, convinced. I'll change that tomorrow and add a respective note to the docs fpr ajp retries in relation to lb. Mladen Turk schrieb: > Rainer Jung wrote: >> >> In my opinion the only change is: >> >> - old code: retries=2 means first try to close all conns and second try >> with new connection >

Re: State of affairs for mod_jk 1.2.20

2006-11-24 Thread Mladen Turk
Rainer Jung wrote: In my opinion the only change is: - old code: retries=2 means first try to close all conns and second try with new connection - new code: retries=2 means first try to close all conns and immediate new conn, second try a "real" retry. Right, and that is the problem. With re

Re: State of affairs for mod_jk 1.2.20

2006-11-24 Thread Rainer Jung
Hi Mladen, I read our code as follows: in any case where a function in the while loop does produce an error, we close the connection afterwards: - if jk_is_socket_connected() fails, we do it explicitely via jk_close_socket() - if ajp_handle_cping_cpong() fails, we don't go into ajp_connection_t

Re: State of affairs for mod_jk 1.2.20

2006-11-24 Thread Rainer Jung
Hi Mladen, Mladen Turk schrieb: > Rainer Jung wrote: >> For those who want to test: I committed far the most part of what I >> planned to improve. > > Thanks Rainer, the patches you made are really great! > I think we'll have a best ever mod_jk. Thanks for the credits, I hope they work. > Howev

Re: State of affairs for mod_jk 1.2.20

2006-11-24 Thread Mladen Turk
Rainer Jung wrote: For those who want to test: I committed far the most part of what I planned to improve. Thanks Rainer, the patches you made are really great! I think we'll have a best ever mod_jk. However I still have doubts about you patch: > @@ -1219,8 +1219,8 @@ > jk_log(l,

State of affairs for mod_jk 1.2.20

2006-11-23 Thread Rainer Jung
For those who want to test: I committed far the most part of what I planned to improve. The rest of the things, I want to work on (depending on time) concerns only much smaller code areas: - checking consistency for logging/%R/NOTES concerning worker name versus jvmRoute - XML and txt mime ty