Re: RewriteMap parsing

Hi Felix Overall it looks good but I'd do two minor changes: 1. Only lookup providers once per context (ServiceLoader result being cached per parser instance) 2. Likely lazy load the parsing after context startup to ensure ioc can be used (spring web or cdi lookups) Hope it makes sense Le ven.

Re: RewriteMap parsing

Am 01.11.19 um 14:24 schrieb Romain Manni-Bucau: > > > Le ven. 1 nov. 2019 à 11:26, Felix Schumacher > > a écrit : > > > Am 01.11.19 um 11:11 schrieb Romain Manni-Bucau: >> Through the spi IMHO and if it can be ambiguous use an ordinal or >> p

Re: RewriteMap parsing

Le ven. 1 nov. 2019 à 11:26, Felix Schumacher < felix.schumac...@internetallee.de> a écrit : > > Am 01.11.19 um 11:11 schrieb Romain Manni-Bucau: > > Through the spi IMHO and if it can be ambiguous use an ordinal or priority > to let it be overriden maybe? > > Do we want users to be able to overwr

Re: RewriteMap parsing

Am 01.11.19 um 11:11 schrieb Romain Manni-Bucau: > Through the spi IMHO and if it can be ambiguous use an ordinal or > priority to let it be overriden maybe? Do we want users to be able to overwrite our functions? Is the "int:" namespace free for everyone? Should we break the context startup in

Re: RewriteMap parsing

Through the spi IMHO and if it can be ambiguous use an ordinal or priority to let it be overriden maybe? Le ven. 1 nov. 2019 à 10:46, Felix Schumacher < felix.schumac...@internetallee.de> a écrit : > > Am 28.10.19 um 23:06 schrieb Romain Manni-Bucau: > > +1 for quotes > > Can the "function" suppo

Re: RewriteMap parsing

Am 28.10.19 um 23:06 schrieb Romain Manni-Bucau: > +1 for quotes > > Can the "function" support be pluggable either with an explicit > registry or a SPI? Would be awesome to enrich it in "super tomcat" > instances (thinking to meecrowave, tomee and maybe spring boot). The function support is alre

Re: RewriteMap parsing

+1 for quotes Can the "function" support be pluggable either with an explicit registry or a SPI? Would be awesome to enrich it in "super tomcat" instances (thinking to meecrowave, tomee and maybe spring boot). Le lun. 28 oct. 2019 à 21:43, Mark Thomas a écrit : > > > On 27/10/2019 11:27, Felix

Re: RewriteMap parsing

On 27/10/2019 11:27, Felix Schumacher wrote: > Hi all, > > while looking at the RewriteMap configuration, I noticed, that parsing > of the RewriteMap directive is a bit minimal. Parameters are split at > whitespace (no quotes will be recognized) and only the first of the > optional parameters w

RewriteMap parsing

Hi all, while looking at the RewriteMap configuration, I noticed, that parsing of the RewriteMap directive is a bit minimal. Parameters are split at whitespace (no quotes will be recognized) and only the first of the optional parameters will be used. Should this be changed? If so, should we intro