Hi Mark,
Can you review the patches that i submitted?
Thanks,
Pravallika
Hi Mark and Justin,
I have updated my comments on top of yours. Can you help check them and
confirm so that i can provide the patch?
Thanks,
Pravallika(VIN)
On 09/04/2015 13:25, Pravallika Peddi wrote:
> Hi Mark,
>
>
>
> I can add the Boolean variable at ContextConfig class level so that all
> pluggability scans can access it and set the value accordingly.
That is too high. It needs to be per JAR.
> Almost all web-inf/lib/class scans are internall
Hi Mark,
I can add the Boolean variable at ContextConfig class level so that all
pluggability scans can access it and set the value accordingly.
Almost all web-inf/lib/class scans are internally calling
“processAnnotationsStream()” method of ContextConfig.java. So in this
method I can change th
On 08/04/2015 14:07, Pravallika Peddi wrote:
> Hi Mark,
>
> *Fix for Pluggability Scan in Tomcat 7.0: *
You have only addressed fragment scanning. You have not addressed the
other scans such as class scanning which are part of the pluggability
scanning process.
I agree adding a flag to track if
On 08/04/2015 11:20, Pravallika Peddi wrote:
> Hi Mark,
>
>
> Highlighted code is the Fix to add summary message to *Tomcat7.0*:
Patches should be in diff -u format and are best attached to bug reports.
Mark
>
>
> In org.apache.catalina.startup.TldConfig.java à
>
>
>
> a) Return a
Hi Mark,
*Fix for Pluggability Scan in Tomcat 7.0: *
1) Org.apache.catalina.startup.ContextConfig.java à
processJarsForWebFragments(WebXml
application)
FragmentJarScannerCallback callback =
*new* FragmentJarScannerCallback(parseRequired);
jarScanner.scan(co
Hi Mark,
Highlighted code is the Fix to add summary message to *Tomcat7.0*:
In org.apache.catalina.startup.TldConfig.java à
a) Return a Boolean variable from tldScanJar(JarURLConnection jarConn)
method which indicates tld found or not.
b) In TldJarScannerCallback inner class à ad
Hi Mark,
Currently there is no mechanism to skip the JARs from Pluggability scan in
Tomcat 8.0.
Below are the fix details that i propose for *tomcat 8* pluggability scan
problem:
1) Added below code in
org.apache.tomcat.util.descriptor.web.FragmentJarScannerCallBack.java à
On 26/03/2015 13:27, Pravallika Peddi wrote:
> 1) As mentioned in bug, in Tomcat7.0 catalina.properties file first 4
> default jars(except jdom.jar) are missing:
> commons-discovery-*.jar,commons-el-*.jar,commons-net-*.jar
>
> We can add them under
> “tomcat.util.scan.DefaultJarS
Hi Mark,
can you please review my previous mail and confirm whether i can proceed
with the fix or not?
Thanks,
Pravallika(VIN)
On Thu, Mar 26, 2015 at 6:57 PM, Pravallika Peddi
wrote:
> Hi Mark,
>
> Sorry, I was on long vacation due to which I could not respond immediately
> on bug: https://bz.
Hi Mark,
Sorry, I was on long vacation due to which I could not respond immediately
on bug: https://bz.apache.org/bugzilla/show_bug.cgi?id=56438
*Below are my further observations on Tomcat7.0 trunk:*
1) As mentioned in bug, in Tomcat7.0 catalina.properties file first 4
default jars(except
On 25/02/2015 11:46, Pravallika Peddi wrote:
> Hi Mark,
>
> More updates on bug 56438:
>
> I have downloaded all the jars mentioned in the issue
> except(Protomatter.jar, openspml2-toolkit.jar, ha-jdbc.jar, db2jcc4.jar,
> hazelcast.jar) and added import statements in my web application for these
Hi Mark,
More updates on bug 56438:
I have downloaded all the jars mentioned in the issue
except(Protomatter.jar, openspml2-toolkit.jar, ha-jdbc.jar, db2jcc4.jar,
hazelcast.jar) and added import statements in my web application for these
jars.
I have added couple of more log messages for my rese
Sure Mark. I am doing the research.
On Thu, Feb 19, 2015 at 3:11 PM, Mark Thomas wrote:
> On 19/02/2015 07:17, Pravallika Peddi wrote:
> > Hi Mark,
> > Below are my observations during my research on the bug:
> >
> > 1) I downloaded recent trunk and ran the ant command so that the
> > build/bin/
On 19/02/2015 07:17, Pravallika Peddi wrote:
> Hi Mark,
> Below are my observations during my research on the bug:
>
> 1) I downloaded recent trunk and ran the ant command so that the
> build/bin/lib folders are generated.
>
> 2) I created a simple web application and exported to WAR file which i
Hi Mark,
Below are my observations during my research on the bug:
1) I downloaded recent trunk and ran the ant command so that the
build/bin/lib folders are generated.
2) I created a simple web application and exported to WAR file which is of
3.4 MB size including 10 required jar files.
3) I ena
Sure Mark, I will try and let you know.
On Tue, Feb 17, 2015 at 4:20 PM, Mark Thomas wrote:
> On 17/02/2015 06:42, Pravallika Peddi wrote:
> > Hi Mark,
> > Its regarding the another bug that you shared to me:
> > https://bz.apache.org/bugzilla/show_bug.cgi?id=56438
> >
> > This bug involves mig
On 17/02/2015 06:42, Pravallika Peddi wrote:
> Hi Mark,
> Its regarding the another bug that you shared to me:
> https://bz.apache.org/bugzilla/show_bug.cgi?id=56438
>
> This bug involves migration from 5.5 to 7.0, and i am new to migration of
> Tomcat releases. Hence can you assign me some other
Hi Mark,
Its regarding the another bug that you shared to me:
https://bz.apache.org/bugzilla/show_bug.cgi?id=56438
This bug involves migration from 5.5 to 7.0, and i am new to migration of
Tomcat releases. Hence can you assign me some other issues which can handle
with code directly?
Or please l
20 matches
Mail list logo
