Re: Reaching ulimit values for open files can generate huge log files

2011-02-23 Thread Mark Thomas
On 23/02/2011 11:47, Tim Funk wrote: > Sorry - I meant to say - since the existing setSocketOptions() is in the > try/catch block as accept(). Is it possible for a network client to send > an ip packet to cause a failure and throw a SocketException while > internally tomcat is setting each of the s

Re: Reaching ulimit values for open files can generate huge log files

2011-02-23 Thread Tim Funk
Sorry - I meant to say - since the existing setSocketOptions() is in the try/catch block as accept(). Is it possible for a network client to send an ip packet to cause a failure and throw a SocketException while internally tomcat is setting each of the socket options? So the net effect is - the

Re: Reaching ulimit values for open files can generate huge log files

2011-02-23 Thread Mark Thomas
On 21/02/2011 17:33, Tim Funk wrote: > Do you want to limit the try/catch scope to just > serverSocketFactory.acceptSocket since setSocketOptions() can also throw > IOException? A couple of people have mentioned this and while the current code would be OK with a broader try/catch I like the idea o

Re: Reaching ulimit values for open files can generate huge log files

2011-02-22 Thread Christopher Schultz
Mark, On 2/21/2011 10:21 AM, Mark Thomas wrote: > The ASF Sonar installation managed to generate 46GB of identical log > messages [1] today in the 8 hours it took to notice it was down. I've not really looked at how Tomcat does its logging, but do we have an opportunity to do what, say, syslogd d

Re: Reaching ulimit values for open files can generate huge log files

2011-02-22 Thread Christopher Schultz
Mark, On 2/21/2011 10:21 AM, Mark Thomas wrote: > The ASF Sonar installation managed to generate 46GB of identical log > messages [1] today in the 8 hours it took to notice it was down. Ugh. Yeah, that sucks. Hitting the ulimit doesn't necessarily mean disaster and the process could still recove

Re: Reaching ulimit values for open files can generate huge log files

2011-02-22 Thread Filip Hanik - Dev Lists
On 02/22/2011 12:59 PM, Mark Thomas wrote: On 22/02/2011 19:34, Filip Hanik - Dev Lists wrote: Wouldn't you build this into the logging framework, instead of one specific component? You could, if you can find an efficient way to spot duplicate log messages and then differentiate corre

Re: Reaching ulimit values for open files can generate huge log files

2011-02-22 Thread Mark Thomas
On 22/02/2011 19:34, Filip Hanik - Dev Lists wrote: > Wouldn't you build this into the logging framework, instead of one > specific component? You could, if you can find an efficient way to spot duplicate log messages and then differentiate correctly between when you want the duplicates and when y

Re: Reaching ulimit values for open files can generate huge log files

2011-02-22 Thread Filip Hanik - Dev Lists
Wouldn't you build this into the logging framework, instead of one specific component? best Filip On 02/21/2011 08:21 AM, Mark Thomas wrote: The ASF Sonar installation managed to generate 46GB of identical log messages [1] today in the 8 hours it took to notice it was down. While better monit

Re: Reaching ulimit values for open files can generate huge log files

2011-02-21 Thread Tim Funk
Do you want to limit the try/catch scope to just serverSocketFactory.acceptSocket since setSocketOptions() can also throw IOException? Is there a case where a client can induce an exception while setSocketOptions() is processing? -Tim On 2/21/2011 10:21 AM, Mark Thomas wrote: The ASF Sona

Re: Reaching ulimit values for open files can generate huge log files

2011-02-21 Thread Konstantin Kolinko
2011/2/21 Mark Thomas : > The ASF Sonar installation managed to generate 46GB of identical log > messages [1] today in the 8 hours it took to notice it was down. > > While better monitoring would/should have identified the problem sooner, > it does demonstrate a problem with the acceptor threads in

Re: Reaching ulimit values for open files can generate huge log files

2011-02-21 Thread Ian Darwin
On 02/21/11 10:21, Mark Thomas wrote: > The ASF Sonar installation managed to generate 46GB of identical log > messages [1] today in the 8 hours it took to notice it was down. Continuing to drive down the cost of disk storage :-) > While better monitoring would/should have identified the problem

Reaching ulimit values for open files can generate huge log files

2011-02-21 Thread Mark Thomas
The ASF Sonar installation managed to generate 46GB of identical log messages [1] today in the 8 hours it took to notice it was down. While better monitoring would/should have identified the problem sooner, it does demonstrate a problem with the acceptor threads in all three endpoints. If there is