Re: svn commit: r804963 - /tomcat/trunk/bin/catalina.sh

2009-08-17 Thread sebb
On 17/08/2009, Mark Thomas wrote: > sebb wrote: > > On 17/08/2009, ma...@apache.org wrote: > > >> + else > >> +if [ $? -eq 0 ]; then > > > > Might be better to check $FORCE before sleeping? > > > On reflection, I don't think there is any need for a sleep here at all. > There is no PID

Re: svn commit: r804963 - /tomcat/trunk/bin/catalina.sh

2009-08-17 Thread Mark Thomas
sebb wrote: > On 17/08/2009, ma...@apache.org wrote: >> + else >> +if [ $? -eq 0 ]; then > > Might be better to check $FORCE before sleeping? On reflection, I don't think there is any need for a sleep here at all. There is no PID so force won't be able to do anything anyway. > Surely tha

Re: svn commit: r804963 - /tomcat/trunk/bin/catalina.sh

2009-08-17 Thread sebb
On 17/08/2009, ma...@apache.org wrote: > Author: markt > Date: Mon Aug 17 13:01:31 2009 > New Revision: 804963 > > URL: http://svn.apache.org/viewvc?rev=804963&view=rev > Log: > Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=47699\nBetter > handling of PID files > > Modified: >