On Fri, 2008-03-21 at 21:44 +, Mark Thomas wrote:
> The cookies patch is short and you haven't voted yet so if you
> could find the time to review the cookies patch we could get to agreed
> fixes for both issues quite quickly.
I did get lost somewhere between the new new patch and the new ne
Remy Maucherat wrote:
On Fri, 2008-03-21 at 15:19 -0600, Filip Hanik - Dev Lists wrote:
Remy Maucherat wrote:
regression, the fact that you can't read more than 8k when using
ServletRequest.getReader
I proposed a patch for that. If it doesn't fix it with the patch I
proposed applied,
Remy Maucherat wrote:
On Fri, 2008-03-21 at 15:19 -0600, Filip Hanik - Dev Lists wrote:
Remy Maucherat wrote:
regression, the fact that you can't read more than 8k when using
ServletRequest.getReader
I proposed a patch for that. If it doesn't fix it with the patch I
proposed applied, I would
On Fri, 2008-03-21 at 15:19 -0600, Filip Hanik - Dev Lists wrote:
> Remy Maucherat wrote:
> regression, the fact that you can't read more than 8k when using
> ServletRequest.getReader
I proposed a patch for that. If it doesn't fix it with the patch I
proposed applied, I would need some test cases
Remy Maucherat wrote:
On Fri, 2008-03-21 at 14:29 -0600, Filip Hanik - Dev Lists wrote:
I'd prefer to move forward with just the truncation fix so that we can
move towards a release.
Any other efforts can be postponed at this time. If the mark/reset bug
in fact exists, there is an easy wor
On Fri, 2008-03-21 at 14:29 -0600, Filip Hanik - Dev Lists wrote:
> I'd prefer to move forward with just the truncation fix so that we can
> move towards a release.
>
> Any other efforts can be postponed at this time. If the mark/reset bug
> in fact exists, there is an easy work around, and that
Remy Maucherat wrote:
On Fri, 2008-03-21 at 11:25 -0600, Filip Hanik - Dev Lists wrote:
what this filter does, is it relies on the already implemented
BufferedReader, no need to reinvent the wheel.
The java.io.BufferedReader, already has this logic implemented, and it
works, so CoyoteReader,
On Fri, 2008-03-21 at 11:25 -0600, Filip Hanik - Dev Lists wrote:
> what this filter does, is it relies on the already implemented
> BufferedReader, no need to reinvent the wheel.
> The java.io.BufferedReader, already has this logic implemented, and it
> works, so CoyoteReader, will only be treat
Remy Maucherat wrote:
On Wed, 2008-03-19 at 18:17 -0600, Filip Hanik - Dev Lists wrote:
Remy Maucherat wrote:
On Wed, 2008-03-19 at 22:43 +, [EMAIL PROTECTED] wrote:
+1 : remm, markt
- -1 : fhanik - I tried this patch, and it doesn't work, it hangs. I also saw
the bu
On Wed, 2008-03-19 at 18:17 -0600, Filip Hanik - Dev Lists wrote:
> Remy Maucherat wrote:
> > On Wed, 2008-03-19 at 22:43 +, [EMAIL PROTECTED] wrote:
> >
> >>+1 : remm, markt
> >> - -1 : fhanik - I tried this patch, and it doesn't work, it hangs. I also
> >> saw the bug report, informi
Remy Maucherat wrote:
On Wed, 2008-03-19 at 22:43 +, [EMAIL PROTECTED] wrote:
+1 : remm, markt
- -1 : fhanik - I tried this patch, and it doesn't work, it hangs. I also saw
the bug report, informing about further issues that are still valid
+ +1 : fhanik - I don't think we should su
On Wed, 2008-03-19 at 22:43 +, [EMAIL PROTECTED] wrote:
>+1 : remm, markt
> - -1 : fhanik - I tried this patch, and it doesn't work, it hangs. I also
> saw the bug report, informing about further issues that are still valid
> + +1 : fhanik - I don't think we should support mark/reset, we
12 matches
Mail list logo
