Filip Hanik - Dev Lists wrote:
> Mark Thomas wrote:
>> [EMAIL PROTECTED] wrote:
>>
>>> + -1: fhanik - lets not do e.printStackTrace, handle the error and
>>> log it correctly,
>>>
>>
>> Fair point. I'll fix that.
>>
>> also, have the diff only change lines that are actually changed. makes i
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/ha/session/SerializablePrincipal.java?r1=607596&r2=607595&pathrev=607596
Mark Thomas wrote:
[EMAIL PROTECTED] wrote:
+ -1: fhanik - lets not do e.printStackTrace, handle the error and log it
correctly,
Fair point.
Mark Thomas wrote:
[EMAIL PROTECTED] wrote:
+ -1: fhanik - lets not do e.printStackTrace, handle the error and log it
correctly,
Fair point. I'll fix that.
also, have the diff only change lines that are actually changed. makes it
easier to review
Which lines do you mean? The diff l
[EMAIL PROTECTED] wrote:
> + -1: fhanik - lets not do e.printStackTrace, handle the error and log it
> correctly,
Fair point. I'll fix that.
also, have the diff only change lines that are actually changed. makes it
easier to review
Which lines do you mean? The diff looks normal to me.
Mark
