Re: svn commit: r1137607 - /tomcat/trunk/bin/catalina.sh

2011-06-20 Thread Rainer Jung
On 20.06.2011 16:06, Mladen Turk wrote: > On 06/20/2011 03:53 PM, Rainer Jung wrote: >> On 20.06.2011 15:41, Mladen Turk wrote: >> >> In general all commands except those that start a Tomcat (and thus >> deploy webapps etc.) should not use that type of params. They should go >> into CATALINA_OPTS.

Re: svn commit: r1137607 - /tomcat/trunk/bin/catalina.sh

2011-06-20 Thread Filip Hanik - Dev Lists
On 6/20/2011 8:06 AM, Mladen Turk wrote: On 06/20/2011 03:53 PM, Rainer Jung wrote: On 20.06.2011 15:41, Mladen Turk wrote: In general all commands except those that start a Tomcat (and thus deploy webapps etc.) should not use that type of params. They should go into CATALINA_OPTS. Everything t

Re: svn commit: r1137607 - /tomcat/trunk/bin/catalina.sh

2011-06-20 Thread Mladen Turk
On 06/20/2011 03:28 PM, Mark Thomas wrote: On 20/06/2011 14:21, Mladen Turk wrote: Just don't see what was the problem with that option that would require it to go away. This wasn't discussed on the dev list so if I weren't tracking the svn commits it would be a big surprise on the next tomcat r

Re: svn commit: r1137607 - /tomcat/trunk/bin/catalina.sh

2011-06-20 Thread Mladen Turk
On 06/20/2011 03:53 PM, Rainer Jung wrote: On 20.06.2011 15:41, Mladen Turk wrote: In general all commands except those that start a Tomcat (and thus deploy webapps etc.) should not use that type of params. They should go into CATALINA_OPTS. Everything that you can use multiple times in parallel

Re: svn commit: r1137607 - /tomcat/trunk/bin/catalina.sh

2011-06-20 Thread Rainer Jung
On 20.06.2011 15:41, Mladen Turk wrote: > On 06/20/2011 03:28 PM, Mark Thomas wrote: >> On 20/06/2011 14:21, Mladen Turk wrote: >>> Just don't see what was the problem with that option that >>> would require it to go away. This wasn't discussed on the dev list >>> so if I weren't tracking the svn c

Re: svn commit: r1137607 - /tomcat/trunk/bin/catalina.sh

2011-06-20 Thread Konstantin Kolinko
2011/6/20 Mladen Turk : >> >> Look at the patch again. It only removes the option for configtest >> > > It depends what you have in CATALINA_OPTS. > If you have -d32/-d64 this won't get picked. > However still don't get it why it was removed? > > Funny, but I was actually trying to add $CATALINA_OP

Re: svn commit: r1137607 - /tomcat/trunk/bin/catalina.sh

2011-06-20 Thread Rainer Jung
On 20.06.2011 14:56, Mladen Turk wrote: > On 06/20/2011 02:37 PM, rj...@apache.org wrote: >> Author: rjung >> Date: Mon Jun 20 12:37:01 2011 >> New Revision: 1137607 >> >> URL: http://svn.apache.org/viewvc?rev=1137607&view=rev >> Log: >> Slight improvement of configtest handling in >> Unix shell sc

Re: svn commit: r1137607 - /tomcat/trunk/bin/catalina.sh

2011-06-20 Thread Mark Thomas
On 20/06/2011 14:21, Mladen Turk wrote: > Just don't see what was the problem with that option that > would require it to go away. This wasn't discussed on the dev list > so if I weren't tracking the svn commits it would be a big surprise on > the next tomcat release. Look at the patch again. It o

Re: svn commit: r1137607 - /tomcat/trunk/bin/catalina.sh

2011-06-20 Thread Mladen Turk
On 06/20/2011 03:16 PM, Rainer Jung wrote: On 20.06.2011 14:56, Mladen Turk wrote: On 06/20/2011 02:37 PM, rj...@apache.org wrote: Author: rjung Date: Mon Jun 20 12:37:01 2011 New Revision: 1137607 URL: http://svn.apache.org/viewvc?rev=1137607&view=rev Log: Slight improvement of configtest han

Re: svn commit: r1137607 - /tomcat/trunk/bin/catalina.sh

2011-06-20 Thread Rainer Jung
On 20.06.2011 14:56, Mladen Turk wrote: > On 06/20/2011 02:37 PM, rj...@apache.org wrote: >> Author: rjung >> Date: Mon Jun 20 12:37:01 2011 >> New Revision: 1137607 >> >> URL: http://svn.apache.org/viewvc?rev=1137607&view=rev >> Log: >> Slight improvement of configtest handling in >> Unix shell sc

Re: svn commit: r1137607 - /tomcat/trunk/bin/catalina.sh

2011-06-20 Thread Mladen Turk
On 06/20/2011 02:37 PM, rj...@apache.org wrote: Author: rjung Date: Mon Jun 20 12:37:01 2011 New Revision: 1137607 URL: http://svn.apache.org/viewvc?rev=1137607&view=rev Log: Slight improvement of configtest handling in Unix shell script: - add to usage - don't use CATALINA_OPTS (think memory s