Re: Tagging 7.0.23

2011-11-02 Thread markt
Konstantin Kolinko wrote: >2011/11/2 Mark Thomas : >> On 01/11/2011 22:39, Mark Thomas wrote: >> My first stab at a patch for this is at [1]. Comments welcome. >>http://people.apache.org/~markt/patches/2011-11-01-redeploy-trunk-v1.patch >Quick review - several typos: > >mbeans-descriptors.xml

Re: Tagging 7.0.23

2011-11-01 Thread Konstantin Kolinko
2011/11/2 Mark Thomas : > On 01/11/2011 22:39, Mark Thomas wrote: >> Changes to any context.xml have to trigger a redeploy else they won't >> take effect as no new Context object will be created. > > My first stab at a patch for this is at [1]. Comments welcome. > > The one thing I don't like is th

Re: Tagging 7.0.23

2011-11-01 Thread Mark Thomas
On 01/11/2011 22:39, Mark Thomas wrote: > Changes to any context.xml have to trigger a redeploy else they won't > take effect as no new Context object will be created. My first stab at a patch for this is at [1]. Comments welcome. The one thing I don't like is that a change to conf/context.xml th

Re: Tagging 7.0.23

2011-11-01 Thread Mark Thomas
On 01/11/2011 22:31, Konstantin Kolinko wrote: > 2011/11/2 Mark Thomas : >> On 01/11/2011 22:01, Konstantin Kolinko wrote: >>> 2011/11/2 Konstantin Kolinko : 2011/11/1 Mark Thomas : > My current thinking is to add redeployResoucre and reloadResource to > Context and deprecate watchedRe

Re: Tagging 7.0.23

2011-11-01 Thread Konstantin Kolinko
2011/11/2 Mark Thomas : > On 01/11/2011 22:01, Konstantin Kolinko wrote: >> 2011/11/2 Konstantin Kolinko : >>> 2011/11/1 Mark Thomas : My current thinking is to add redeployResoucre and reloadResource to Context and deprecate watchedResource, making it a synonym for reloadResource. T

Re: Tagging 7.0.23

2011-11-01 Thread Mark Thomas
On 01/11/2011 22:01, Konstantin Kolinko wrote: > 2011/11/2 Konstantin Kolinko : >> 2011/11/1 Mark Thomas : >>> My current thinking is to add redeployResoucre and reloadResource to >>> Context and deprecate watchedResource, making it a synonym for >>> reloadResource. Thoughts? (I haven't tested this

Re: Tagging 7.0.23

2011-11-01 Thread Konstantin Kolinko
2011/11/2 Konstantin Kolinko : > 2011/11/1 Mark Thomas : >> On 01/11/2011 14:16, Konstantin Kolinko wrote: >>> >>> 1) Re: http://svn.apache.org/viewvc?view=revision&revision=1195965 >> >>> Is it possible to throw a runtime exception from parseParameters() >>> when the limit is reached instead of dr

Re: Tagging 7.0.23

2011-11-01 Thread Konstantin Kolinko
2011/11/1 Mark Thomas : > On 01/11/2011 14:16, Konstantin Kolinko wrote: >> >> 1) Re: http://svn.apache.org/viewvc?view=revision&revision=1195965 > >> Is it possible to throw a runtime exception from parseParameters() >> when the limit is reached instead of dropping the parameters, or you >> think

Re: Tagging 7.0.23

2011-11-01 Thread Mark Thomas
On 01/11/2011 19:42, Mark Thomas wrote: > On 01/11/2011 14:16, Konstantin Kolinko wrote: >> 2) http://markmail.org/message/5k4urwimvvmeqees > > I'll see if I can get that fixed too. Hmm. The problem here is that the context.xml files are registered as resources that trigger reload rather than red

Re: Tagging 7.0.23

2011-11-01 Thread Mark Thomas
On 01/11/2011 14:16, Konstantin Kolinko wrote: > 2011/11/1 Mark Thomas : >> It is that time again. I plan to tag 7.0.23 later today once I have run >> the unit tests and the TCKs to check all is well. >> >> If you have anything you want to get into this release, now is the time >> to commit it. >

Re: Tagging 7.0.23

2011-11-01 Thread Konstantin Kolinko
2011/11/1 Mark Thomas : > It is that time again. I plan to tag 7.0.23 later today once I have run > the unit tests and the TCKs to check all is well. > > If you have anything you want to get into this release, now is the time > to commit it. 1) Re: http://svn.apache.org/viewvc?view=revision&revisi