Re: TC WebappClassLoaderBase bottleneck in filter()

2016-01-26 Thread Christopher Schultz
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 All, On 1/25/16 5:23 AM, Mark Thomas wrote: > On 25/01/2016 09:32, Rainer Jung wrote: >> Hi Konstantin, >> >> thanks for the feedback. More inline. >> >> Am 25.01.2016 um 03:51 schrieb Konstantin Kolinko: >>> 2016-01-23 15:17 GMT+03:00 Rainer Jung >

Re: TC WebappClassLoaderBase bottleneck in filter()

2016-01-25 Thread Rainer Jung
Am 25.01.2016 um 11:23 schrieb Mark Thomas: On 25/01/2016 09:32, Rainer Jung wrote: Hi Konstantin, thanks for the feedback. More inline. Am 25.01.2016 um 03:51 schrieb Konstantin Kolinko: 2016-01-23 15:17 GMT+03:00 Rainer Jung : I observed a bottleneck in WebappClassLoaderBase.filter() durin

Re: TC WebappClassLoaderBase bottleneck in filter()

2016-01-25 Thread Mark Thomas
On 25/01/2016 09:32, Rainer Jung wrote: > Hi Konstantin, > > thanks for the feedback. More inline. > > Am 25.01.2016 um 03:51 schrieb Konstantin Kolinko: >> 2016-01-23 15:17 GMT+03:00 Rainer Jung : >>> I observed a bottleneck in WebappClassLoaderBase.filter() during a >>> stress >>> test. The rea

Re: TC WebappClassLoaderBase bottleneck in filter()

2016-01-25 Thread Rainer Jung
Hi Konstantin, thanks for the feedback. More inline. Am 25.01.2016 um 03:51 schrieb Konstantin Kolinko: 2016-01-23 15:17 GMT+03:00 Rainer Jung : I observed a bottleneck in WebappClassLoaderBase.filter() during a stress test. The reason is, that the method is synchronized. It looks to me, that

Re: TC WebappClassLoaderBase bottleneck in filter()

2016-01-24 Thread Konstantin Kolinko
2016-01-23 15:17 GMT+03:00 Rainer Jung : > I observed a bottleneck in WebappClassLoaderBase.filter() during a stress > test. The reason is, that the method is synchronized. It looks to me, that > the reason for the synchronization is only the access to the non-thread safe > Matchers packageTriggers

Re: TC WebappClassLoaderBase bottleneck in filter()

2016-01-24 Thread Rainer Jung
Am 24.01.2016 um 19:50 schrieb Felix Schumacher: Am 23.01.2016 um 17:05 schrieb Rainer Jung: Am 23.01.2016 um 13:17 schrieb Rainer Jung: Since the calls to filter() are in a hot code path, I wonder whether using a more complex code instead of a single regexp could be better. The code should be

Re: TC WebappClassLoaderBase bottleneck in filter()

2016-01-24 Thread Felix Schumacher
Am 23.01.2016 um 17:05 schrieb Rainer Jung: Am 23.01.2016 um 13:17 schrieb Rainer Jung: Since the calls to filter() are in a hot code path, I wonder whether using a more complex code instead of a single regexp could be better. The code should be fast in the common case, which IMHO is the case wh

Re: TC WebappClassLoaderBase bottleneck in filter()

2016-01-23 Thread Rainer Jung
Am 23.01.2016 um 13:17 schrieb Rainer Jung: Since the calls to filter() are in a hot code path, I wonder whether using a more complex code instead of a single regexp could be better. The code should be fast in the common case, which IMHO is the case when the resource name neither starts with java